* Re: [edk2-devel] [PATCH RESEND v2 0/2] AMD CPU extended topology [not found] <17AB54C0527B447C.12800@groups.io> @ 2024-01-25 5:02 ` Abdul Lateef Attar via groups.io 2024-01-25 10:20 ` Ni, Ray 0 siblings, 1 reply; 7+ messages in thread From: Abdul Lateef Attar via groups.io @ 2024-01-25 5:02 UTC (permalink / raw) To: devel Cc: Michael D Kinney, Liming Gao, Zhiguang Liu, Ray Ni, Rahul Kumar, Gerd Hoffmann Gentle reminder, please review the patch series. On 18-01-2024 09:24, Abdul Lateef Attar via groups.io wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> > > Resending the patch with updated Cc list. > > PR: https://github.com/tianocore/edk2/pull/5269 > > V2: delta changes > - Added additional check apart from supported CPUID extneded number. > - removed EFIAPI > > Implements AMD extended toplogy. > Adds CPUID macro > update APIC library to use new exteded cpuid. > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Zhiguang Liu <zhiguang.liu@intel.com> > Cc: Ray Ni <ray.ni@intel.com> > Cc: Rahul Kumar <rahul1.kumar@intel.com> > Cc: Gerd Hoffmann <kraxel@redhat.com> > Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> > > Abdul Lateef Attar (2): > MdePkg: Adds AMD Extended CPU topology CPUID > UefiCpuPkg/BaseXApic[X2]ApicLib: Implements AMD extended cpu topology > > MdePkg/Include/Register/Amd/Cpuid.h | 23 +++- > .../Library/BaseXApicLib/BaseXApicLib.c | 126 +++++++++++++++++- > .../BaseXApicX2ApicLib/BaseXApicX2ApicLib.c | 126 +++++++++++++++++- > 3 files changed, 272 insertions(+), 3 deletions(-) > > -- > 2.34.1 > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114364): https://edk2.groups.io/g/devel/message/114364 Mute This Topic: https://groups.io/mt/103802341/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH RESEND v2 0/2] AMD CPU extended topology 2024-01-25 5:02 ` [edk2-devel] [PATCH RESEND v2 0/2] AMD CPU extended topology Abdul Lateef Attar via groups.io @ 2024-01-25 10:20 ` Ni, Ray 2024-01-25 16:21 ` Lendacky, Thomas via groups.io 0 siblings, 1 reply; 7+ messages in thread From: Ni, Ray @ 2024-01-25 10:20 UTC (permalink / raw) To: Attar, AbdulLateef (Abdul Lateef), devel@edk2.groups.io, Tom Lendacky Cc: Kinney, Michael D, Liming Gao, Liu, Zhiguang, Kumar, Rahul R, Gerd Hoffmann Acked-by: Ray Ni <ray.ni@intel.com> + Tom Thanks, Ray > -----Original Message----- > From: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com> > Sent: Thursday, January 25, 2024 1:02 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao > <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Ni, > Ray <ray.ni@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Gerd > Hoffmann <kraxel@redhat.com> > Subject: Re: [edk2-devel] [PATCH RESEND v2 0/2] AMD CPU extended > topology > > Gentle reminder, please review the patch series. > > On 18-01-2024 09:24, Abdul Lateef Attar via groups.io wrote: > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > > > > From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> > > > > Resending the patch with updated Cc list. > > > > PR: https://github.com/tianocore/edk2/pull/5269 > > > > V2: delta changes > > - Added additional check apart from supported CPUID extneded number. > > - removed EFIAPI > > > > Implements AMD extended toplogy. > > Adds CPUID macro > > update APIC library to use new exteded cpuid. > > > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > > Cc: Liming Gao <gaoliming@byosoft.com.cn> > > Cc: Zhiguang Liu <zhiguang.liu@intel.com> > > Cc: Ray Ni <ray.ni@intel.com> > > Cc: Rahul Kumar <rahul1.kumar@intel.com> > > Cc: Gerd Hoffmann <kraxel@redhat.com> > > Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> > > > > Abdul Lateef Attar (2): > > MdePkg: Adds AMD Extended CPU topology CPUID > > UefiCpuPkg/BaseXApic[X2]ApicLib: Implements AMD extended cpu > topology > > > > MdePkg/Include/Register/Amd/Cpuid.h | 23 +++- > > .../Library/BaseXApicLib/BaseXApicLib.c | 126 > +++++++++++++++++- > > .../BaseXApicX2ApicLib/BaseXApicX2ApicLib.c | 126 > +++++++++++++++++- > > 3 files changed, 272 insertions(+), 3 deletions(-) > > > > -- > > 2.34.1 > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114383): https://edk2.groups.io/g/devel/message/114383 Mute This Topic: https://groups.io/mt/103802341/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH RESEND v2 0/2] AMD CPU extended topology 2024-01-25 10:20 ` Ni, Ray @ 2024-01-25 16:21 ` Lendacky, Thomas via groups.io 2024-01-31 4:54 ` Abdul Lateef Attar via groups.io 0 siblings, 1 reply; 7+ messages in thread From: Lendacky, Thomas via groups.io @ 2024-01-25 16:21 UTC (permalink / raw) To: devel, ray.ni, Attar, AbdulLateef (Abdul Lateef) Cc: Kinney, Michael D, Liming Gao, Liu, Zhiguang, Kumar, Rahul R, Gerd Hoffmann On 1/25/24 04:20, Ni, Ray via groups.io wrote: > Acked-by: Ray Ni <ray.ni@intel.com> > > + Tom Looks good to me. Should AmdGetProcessorLocation2ByApicId() be STATIC? Not asking for this patch series, but there is a lot of duplicated code between the two APIC libraries. It would be nice if there was a way to have a common file where just a single copy of the duplicated code could live. Acked-by: Tom Lendacky <thomas.lendacky@amd.com> Thanks, Tom > > Thanks, > Ray >> -----Original Message----- >> From: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com> >> Sent: Thursday, January 25, 2024 1:02 PM >> To: devel@edk2.groups.io >> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao >> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Ni, >> Ray <ray.ni@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Gerd >> Hoffmann <kraxel@redhat.com> >> Subject: Re: [edk2-devel] [PATCH RESEND v2 0/2] AMD CPU extended >> topology >> >> Gentle reminder, please review the patch series. >> >> On 18-01-2024 09:24, Abdul Lateef Attar via groups.io wrote: >>> Caution: This message originated from an External Source. Use proper >> caution when opening attachments, clicking links, or responding. >>> >>> >>> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> >>> >>> Resending the patch with updated Cc list. >>> >>> PR: https://github.com/tianocore/edk2/pull/5269 >>> >>> V2: delta changes >>> - Added additional check apart from supported CPUID extneded number. >>> - removed EFIAPI >>> >>> Implements AMD extended toplogy. >>> Adds CPUID macro >>> update APIC library to use new exteded cpuid. >>> >>> Cc: Michael D Kinney <michael.d.kinney@intel.com> >>> Cc: Liming Gao <gaoliming@byosoft.com.cn> >>> Cc: Zhiguang Liu <zhiguang.liu@intel.com> >>> Cc: Ray Ni <ray.ni@intel.com> >>> Cc: Rahul Kumar <rahul1.kumar@intel.com> >>> Cc: Gerd Hoffmann <kraxel@redhat.com> >>> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> >>> >>> Abdul Lateef Attar (2): >>> MdePkg: Adds AMD Extended CPU topology CPUID >>> UefiCpuPkg/BaseXApic[X2]ApicLib: Implements AMD extended cpu >> topology >>> >>> MdePkg/Include/Register/Amd/Cpuid.h | 23 +++- >>> .../Library/BaseXApicLib/BaseXApicLib.c | 126 >> +++++++++++++++++- >>> .../BaseXApicX2ApicLib/BaseXApicX2ApicLib.c | 126 >> +++++++++++++++++- >>> 3 files changed, 272 insertions(+), 3 deletions(-) >>> >>> -- >>> 2.34.1 >>> >>> >>> >>> >>> >>> > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114430): https://edk2.groups.io/g/devel/message/114430 Mute This Topic: https://groups.io/mt/103802341/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH RESEND v2 0/2] AMD CPU extended topology 2024-01-25 16:21 ` Lendacky, Thomas via groups.io @ 2024-01-31 4:54 ` Abdul Lateef Attar via groups.io 2024-01-31 13:27 ` Laszlo Ersek 0 siblings, 1 reply; 7+ messages in thread From: Abdul Lateef Attar via groups.io @ 2024-01-31 4:54 UTC (permalink / raw) To: Tom Lendacky, devel, ray.ni Cc: Kinney, Michael D, Liming Gao, Liu, Zhiguang, Kumar, Rahul R, Gerd Hoffmann Hi All, Thanks for reviewing the patch, I had re-based the patch and added "Acked-by". Please take a look and merge the PR. https://github.com/tianocore/edk2/pull/5269 Thanks AbduL On 25-01-2024 21:51, Tom Lendacky wrote: > On 1/25/24 04:20, Ni, Ray via groups.io wrote: >> Acked-by: Ray Ni <ray.ni@intel.com> >> >> + Tom > > Looks good to me. Should AmdGetProcessorLocation2ByApicId() be STATIC? [Abdul] I think its okay to not have STATIC, as I can see other local functions also doesn't have STATIC prefix. > > Not asking for this patch series, but there is a lot of duplicated > code between the two APIC libraries. It would be nice if there was a > way to have a common file where just a single copy of the duplicated > code could live. [Abdul] Agree lot of duplicate code, we can combine BaseXApic and BaseXApicX2Apic library to single library and have separate INF file with shared source file. > > Acked-by: Tom Lendacky <thomas.lendacky@amd.com> > > Thanks, > Tom > >> >> Thanks, >> Ray >>> -----Original Message----- >>> From: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com> >>> Sent: Thursday, January 25, 2024 1:02 PM >>> To: devel@edk2.groups.io >>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liming Gao >>> <gaoliming@byosoft.com.cn>; Liu, Zhiguang <zhiguang.liu@intel.com>; Ni, >>> Ray <ray.ni@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Gerd >>> Hoffmann <kraxel@redhat.com> >>> Subject: Re: [edk2-devel] [PATCH RESEND v2 0/2] AMD CPU extended >>> topology >>> >>> Gentle reminder, please review the patch series. >>> >>> On 18-01-2024 09:24, Abdul Lateef Attar via groups.io wrote: >>>> Caution: This message originated from an External Source. Use proper >>> caution when opening attachments, clicking links, or responding. >>>> >>>> >>>> From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> >>>> >>>> Resending the patch with updated Cc list. >>>> >>>> PR: https://github.com/tianocore/edk2/pull/5269 >>>> >>>> V2: delta changes >>>> - Added additional check apart from supported CPUID extneded >>>> number. >>>> - removed EFIAPI >>>> >>>> Implements AMD extended toplogy. >>>> Adds CPUID macro >>>> update APIC library to use new exteded cpuid. >>>> >>>> Cc: Michael D Kinney <michael.d.kinney@intel.com> >>>> Cc: Liming Gao <gaoliming@byosoft.com.cn> >>>> Cc: Zhiguang Liu <zhiguang.liu@intel.com> >>>> Cc: Ray Ni <ray.ni@intel.com> >>>> Cc: Rahul Kumar <rahul1.kumar@intel.com> >>>> Cc: Gerd Hoffmann <kraxel@redhat.com> >>>> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> >>>> >>>> Abdul Lateef Attar (2): >>>> MdePkg: Adds AMD Extended CPU topology CPUID >>>> UefiCpuPkg/BaseXApic[X2]ApicLib: Implements AMD extended cpu >>> topology >>>> >>>> MdePkg/Include/Register/Amd/Cpuid.h | 23 +++- >>>> .../Library/BaseXApicLib/BaseXApicLib.c | 126 >>> +++++++++++++++++- >>>> .../BaseXApicX2ApicLib/BaseXApicX2ApicLib.c | 126 >>> +++++++++++++++++- >>>> 3 files changed, 272 insertions(+), 3 deletions(-) >>>> >>>> -- >>>> 2.34.1 >>>> >>>> >>>> >>>> >>>> >>>> >> >> >> >> >> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114856): https://edk2.groups.io/g/devel/message/114856 Mute This Topic: https://groups.io/mt/103802341/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH RESEND v2 0/2] AMD CPU extended topology 2024-01-31 4:54 ` Abdul Lateef Attar via groups.io @ 2024-01-31 13:27 ` Laszlo Ersek 0 siblings, 0 replies; 7+ messages in thread From: Laszlo Ersek @ 2024-01-31 13:27 UTC (permalink / raw) To: devel, AbdulLateef.Attar, Tom Lendacky, ray.ni Cc: Kinney, Michael D, Liming Gao, Liu, Zhiguang, Kumar, Rahul R, Gerd Hoffmann On 1/31/24 05:54, Abdul Lateef Attar via groups.io wrote: > Hi All, > > Thanks for reviewing the patch, I had re-based the patch and added > "Acked-by". > > Please take a look and merge the PR. > > https://github.com/tianocore/edk2/pull/5269 (repeating here too:) series merged via <https://github.com/tianocore/edk2/pull/5326>, commits 1 d14526372d6c MdePkg: Adds AMD Extended CPU topology CPUID 2 0e9b124f9c67 UefiCpuPkg/BaseXApic[X2]ApicLib: Implements AMD extended cpu topology -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114898): https://edk2.groups.io/g/devel/message/114898 Mute This Topic: https://groups.io/mt/103802341/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 7+ messages in thread
* [edk2-devel] [PATCH RESEND v2 0/2] AMD CPU extended topology @ 2024-01-18 3:54 Abdul Lateef Attar via groups.io 2024-01-31 13:27 ` Laszlo Ersek 0 siblings, 1 reply; 7+ messages in thread From: Abdul Lateef Attar via groups.io @ 2024-01-18 3:54 UTC (permalink / raw) To: devel Cc: Abdul Lateef Attar, Michael D Kinney, Liming Gao, Zhiguang Liu, Ray Ni, Rahul Kumar, Gerd Hoffmann From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> Resending the patch with updated Cc list. PR: https://github.com/tianocore/edk2/pull/5269 V2: delta changes - Added additional check apart from supported CPUID extneded number. - removed EFIAPI Implements AMD extended toplogy. Adds CPUID macro update APIC library to use new exteded cpuid. Cc: Michael D Kinney <michael.d.kinney@intel.com> Cc: Liming Gao <gaoliming@byosoft.com.cn> Cc: Zhiguang Liu <zhiguang.liu@intel.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Rahul Kumar <rahul1.kumar@intel.com> Cc: Gerd Hoffmann <kraxel@redhat.com> Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> Abdul Lateef Attar (2): MdePkg: Adds AMD Extended CPU topology CPUID UefiCpuPkg/BaseXApic[X2]ApicLib: Implements AMD extended cpu topology MdePkg/Include/Register/Amd/Cpuid.h | 23 +++- .../Library/BaseXApicLib/BaseXApicLib.c | 126 +++++++++++++++++- .../BaseXApicX2ApicLib/BaseXApicX2ApicLib.c | 126 +++++++++++++++++- 3 files changed, 272 insertions(+), 3 deletions(-) -- 2.34.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#113982): https://edk2.groups.io/g/devel/message/113982 Mute This Topic: https://groups.io/mt/103802341/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [PATCH RESEND v2 0/2] AMD CPU extended topology 2024-01-18 3:54 Abdul Lateef Attar via groups.io @ 2024-01-31 13:27 ` Laszlo Ersek 0 siblings, 0 replies; 7+ messages in thread From: Laszlo Ersek @ 2024-01-31 13:27 UTC (permalink / raw) To: devel, AbdulLateef.Attar Cc: Michael D Kinney, Liming Gao, Zhiguang Liu, Ray Ni, Rahul Kumar, Gerd Hoffmann On 1/18/24 04:54, Abdul Lateef Attar via groups.io wrote: > From: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> > > Resending the patch with updated Cc list. > > PR: https://github.com/tianocore/edk2/pull/5269 > > V2: delta changes > - Added additional check apart from supported CPUID extneded number. > - removed EFIAPI > > Implements AMD extended toplogy. > Adds CPUID macro > update APIC library to use new exteded cpuid. > > Cc: Michael D Kinney <michael.d.kinney@intel.com> > Cc: Liming Gao <gaoliming@byosoft.com.cn> > Cc: Zhiguang Liu <zhiguang.liu@intel.com> > Cc: Ray Ni <ray.ni@intel.com> > Cc: Rahul Kumar <rahul1.kumar@intel.com> > Cc: Gerd Hoffmann <kraxel@redhat.com> > Cc: Abdul Lateef Attar <AbdulLateef.Attar@amd.com> > > Abdul Lateef Attar (2): > MdePkg: Adds AMD Extended CPU topology CPUID > UefiCpuPkg/BaseXApic[X2]ApicLib: Implements AMD extended cpu topology > > MdePkg/Include/Register/Amd/Cpuid.h | 23 +++- > .../Library/BaseXApicLib/BaseXApicLib.c | 126 +++++++++++++++++- > .../BaseXApicX2ApicLib/BaseXApicX2ApicLib.c | 126 +++++++++++++++++- > 3 files changed, 272 insertions(+), 3 deletions(-) > series merged via <https://github.com/tianocore/edk2/pull/5326>, commits 1 d14526372d6c MdePkg: Adds AMD Extended CPU topology CPUID 2 0e9b124f9c67 UefiCpuPkg/BaseXApic[X2]ApicLib: Implements AMD extended cpu topology -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114897): https://edk2.groups.io/g/devel/message/114897 Mute This Topic: https://groups.io/mt/103802341/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-01-31 13:27 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <17AB54C0527B447C.12800@groups.io>
2024-01-25 5:02 ` [edk2-devel] [PATCH RESEND v2 0/2] AMD CPU extended topology Abdul Lateef Attar via groups.io
2024-01-25 10:20 ` Ni, Ray
2024-01-25 16:21 ` Lendacky, Thomas via groups.io
2024-01-31 4:54 ` Abdul Lateef Attar via groups.io
2024-01-31 13:27 ` Laszlo Ersek
2024-01-18 3:54 Abdul Lateef Attar via groups.io
2024-01-31 13:27 ` Laszlo Ersek
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox