From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id A8A3E940F8E for ; Mon, 13 May 2024 02:27:11 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=AFij9y9AvuJc6jplBlkmdXf+RCu8torExko+Ge79FuY=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1715567230; v=1; b=MgiAxQPvD6qEkjWL13i/CyrRvhnlG0ahMGwLUnQdJJbcOpXIbjO/GXgpCAYXqkW5Uy9FPHrn GCuaHxvKaD6KFVHwt8vL57sQe4OQFptzE+Nh88fkowSOHqCFMugPwOrwaNRZRbYkF+/PP876Kze Q7lZatmR38phrm97kXWt1aFYG/CrdBs+RjDtDQ2ALYXtC9fufpFPlMTtY/qt6chZ6e0tNaSHiMu mgAsVkwWSj4t6CLICzEntfMXNmTFOwL0LVDug26W9e5zPx/a598RjFE/8OGz94pEEoExvfuNJ8g kRsuMlKRueRz7/PShPRBRsi4FBu7mIOPK6Nq6+bgYvLMw== X-Received: by 127.0.0.2 with SMTP id P7eVYY7687511xIlvYO2Zn9p; Sun, 12 May 2024 19:27:10 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) by mx.groups.io with SMTP id smtpd.web11.51347.1715567229186833466 for ; Sun, 12 May 2024 19:27:09 -0700 X-CSE-ConnectionGUID: j6R0qI8FSL2sQ2Ccmr2J4w== X-CSE-MsgGUID: QpNpu439QH+gJ4LIzT2jqg== X-IronPort-AV: E=McAfee;i="6600,9927,11071"; a="22882768" X-IronPort-AV: E=Sophos;i="6.08,157,1712646000"; d="scan'208,217";a="22882768" X-Received: from orviesa001.jf.intel.com ([10.64.159.141]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2024 19:27:09 -0700 X-CSE-ConnectionGUID: rld4GPoFRwK/1vmV1iaKfA== X-CSE-MsgGUID: 0tnFKQbcT+GI2LRljHTj8g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,157,1712646000"; d="scan'208,217";a="67682194" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa001.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 12 May 2024 19:27:09 -0700 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 12 May 2024 19:27:08 -0700 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 12 May 2024 19:27:07 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 12 May 2024 19:27:07 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.172) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 12 May 2024 19:27:07 -0700 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by SJ2PR11MB8537.namprd11.prod.outlook.com (2603:10b6:a03:56f::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.55; Mon, 13 May 2024 02:27:05 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::41a4:c775:32e6:76a8]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::41a4:c775:32e6:76a8%4]) with mapi id 15.20.7544.052; Mon, 13 May 2024 02:27:05 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: Laszlo Ersek , "Kumar, Rahul R" , Gerd Hoffmann , "Wu, Jiaxin" Subject: Re: [edk2-devel] [PATCH 15/18] UefiCpuPkg:Remove code to handle APIC setting and Interrupt Thread-Topic: [PATCH 15/18] UefiCpuPkg:Remove code to handle APIC setting and Interrupt Thread-Index: AQHaosIoywyviTpTikOJNS/XEqQQArGUdHsx Date: Mon, 13 May 2024 02:27:05 +0000 Message-ID: References: <20240510100827.1903-1-dun.tan@intel.com> <20240510100827.1903-16-dun.tan@intel.com> In-Reply-To: <20240510100827.1903-16-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|SJ2PR11MB8537:EE_ x-ms-office365-filtering-correlation-id: 19e7abed-8a64-402c-4b0f-08dc72f42e54 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?KgwMjEQoRcaiPlo/3xgLRA2nArbSqpM2vM0v+ZUzBwmT3TaHng934aWCeS40?= =?us-ascii?Q?ImQHLCtmDAieZEF/nRTq0vx+B1nyVvwtzAxmv7lUdVci8tHjBw186BSWkb5L?= =?us-ascii?Q?uSGlp4P2xEPScO8jptDpT71CZgLNzEWp3Q9GMp6a39RdtoINF7JL7k+N27L5?= =?us-ascii?Q?Uaz28a5t4JPZ0D2lPNCnQmVEfOAeGtS0bcvtDaEwMJ+DEVrCe+nVbp2dGKkV?= =?us-ascii?Q?R0FSjZeUdZZpMcJHOgC6IrOtp9Rsqj8IQkooVxr8jJ10y+ROeWb+x/GRk9A1?= =?us-ascii?Q?baAAEUXASUD3oaDTttWzkmWONppLcMJv/kna5Da6hAMdls05X9ayKOWmgcWn?= =?us-ascii?Q?zLwIaOWiV0Z2SUPYkxiZCKZA2fssaIcv8qmYLEPFcEX3ojq+KKx/xwACDoLX?= =?us-ascii?Q?POENtyqFATrcWg8oGtLchg/PSjpK2OoyuaIyUPqYqr1vSGhEQh5VXdkcTLW1?= =?us-ascii?Q?hoW6VQzcdgEudXtJdv3jrmpUHjri3N1Omra7y+jlH3hJiINZe6lnpWU5+r4R?= =?us-ascii?Q?QSIBe2U3l7JsplAb8WJoHjSpRZsZO3ShL1vPYL2LOhj5k4AnvN/dTGMkx2QE?= =?us-ascii?Q?CxcFTTEJjIcOLXRqhUvxuKSxXxo/Szj1RfWbjMjlwD6VC7c5QyzbycKDhjv2?= =?us-ascii?Q?njLUyYqsGkRe0KC+Vc+o5JpgXxsmLcYplL7Z3FTSlKS7k3DrTOZ9qn1ivYBj?= =?us-ascii?Q?M8SoMA986sluu6lp4xYFhK9Av5sK9TyjaeEhWZF+H0/JxAGOcTsi9nrdlSb4?= =?us-ascii?Q?JAs2WfdtmaC2NRDOSAizJ+f0MBT2TaopxQ/vCdPnLfWvPPtOKEenrmNpD2R2?= =?us-ascii?Q?pHTgvn/RZWTemdN3zvBYesU1jGJ4sCtnBtbaJuF7btWllmXPOmTpVEV+3pk3?= =?us-ascii?Q?z3U/kJTHa31ziAFRuAxqbmXVV8KF5rGUIEt5cOkJcRsq3MKXTNWeNMJgECim?= =?us-ascii?Q?dAk8Y7RE12dPUS9fgJ4KVFNjAqMiHYPYnRvRcc+tRJXXNfuftoCSYPD2SUbQ?= =?us-ascii?Q?nGdWC6rFK/xgUf6z3uC/+r1bL+pnVEulfWPlWp5WaGe7ydKjxlEeCbtm07Ai?= =?us-ascii?Q?nqq/IllTWtM4/XrAZ7anYpmBQCyj4ogy1MJ65pk0h+qZIzuoqy/ZKws985E1?= =?us-ascii?Q?aDoscnE7TcBi6M4XILmUjqOU6J7ik/v36EbHfgyCgi+ryzhmH6KxsAhsplVx?= =?us-ascii?Q?3leUeHCL10dT67rZ9CTmr378KCbIH4kJIewtKgx6oFt6GS5SO7xU8K9fGycj?= =?us-ascii?Q?vll99HyxsPmniAXl2uigNjFSfhD2jJd+EhVUtmA3r8D7UaFYRQMv84E/6k6u?= =?us-ascii?Q?vHRc/qVYvbr/lWG/1IB7ym1I/XikRpZIVxBv86MHAy7XBg=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/Ma1NB6PuKSCR3PzfhMwmLL5rAPYyHhhrHt7cCyseTH1TzrQgWUZATmEGv5u?= =?us-ascii?Q?KO7+cE1UHIxtq0bMWFWBb3P1QD6Gvstoz966wZkwevfszLcxDGPskQqUAcuq?= =?us-ascii?Q?gSTkEXmEAnzcLOanT6rtDX6AypUoYHpaIDoih6lDRrUvUA7Q81fG9XQDRpuw?= =?us-ascii?Q?swen+qE1UyJivqk9/XLcjf1OTl8HNCFyb6tfgvwO31Qrsn0N0ZB/AT3FZ5Yc?= =?us-ascii?Q?+etfdMfXniR3Ip5BaOmEMaP5O1EUpBLXjOXpIr3U8CCDas5/yMGe3UYNqVPt?= =?us-ascii?Q?C8mSBHE4l3Dm3TywQ1jCUnLf1s+3os3U6Tvn3XBmguJbWerpXSXru5cAzGqk?= =?us-ascii?Q?IlNpFXE6+tb6Z2P+Rf8J4VNgS46S9TtnhMPrJyr73Zu8frdaJJQqkOCUL9ck?= =?us-ascii?Q?d45js+BdOYsMleAPKYIA/WVUma/sC0E4iuXzEz8rDjcp15wS01KaH28WW78f?= =?us-ascii?Q?TUTPS7VLZm71YHJU9Z+hTgj/QObrNVBirWg2vFydZQZzuZHqasz7S6mWfEC6?= =?us-ascii?Q?F+CxPgjyVigTH1HdbYKFG+MGAtW4LJWE385c7fBez8zHpTQB3D+ZHSLoV3FS?= =?us-ascii?Q?RChg4+N5sbjB8Cu6rMKq09z9j3F0ERb6TQ9uqaLnSSG0QigsvTj6w9SMSCoM?= =?us-ascii?Q?tDuAKv15+3pcyqie9svJEqMwMcVEimhQYMLB+59qjjAruHrH9nFqQaGtX+hT?= =?us-ascii?Q?o071PG8zQiZMjM0yIMcIBN9GiFwQFLuaCDzzW1j8ACJqwK6qjvPtSDNygqFo?= =?us-ascii?Q?TPTu5CKwQy/6FKzjNWJKKTl3+rLog2Ay2pK13IsF9wBMqcuqOs4l9/TMKj6m?= =?us-ascii?Q?WuNGiwcBynU4KjIhgqRRjj5AsMccRlQwMOKWvHng0dZJIhlermZl63QWDN7X?= =?us-ascii?Q?3Ma2k6JDkHW8cR+hvpOUyjeiMUEwu2UdG4MjaglmW3Vhig/k8PwE0+efX2xa?= =?us-ascii?Q?keoimHbwEO1s3bCG3yMLBCYDZz5eG6BM+CVG3V1rqQJ72rrDtbXYwBfE49Ie?= =?us-ascii?Q?HuZ+Krdy4xqei7mT9GFF0ddyosnhV59BltGrDQnhCplT4lAMGJ6kwdsRnN54?= =?us-ascii?Q?DzIlaMDCsxXCAVUwR0xZ7D9ERWuc1R20/JqzV9SYnvtAtlAC1AVOjtd93NkT?= =?us-ascii?Q?j97ZgXy/+bzByFYyQagvfadUHffzW5bldzZ12z4DJh+uTa4oKlDo9exoPvtE?= =?us-ascii?Q?bDAEsLOwVVf+ybDR7NtP2d6PIx1zF4n3sXeKo66ta6dGxcqUMEH5njdkltrN?= =?us-ascii?Q?v0EgKXivh1hllH9hKcwY2OLIjLx9oQIDLD1v1hU4V0IwDJXKmw1jzCkyhA24?= =?us-ascii?Q?uuk2eiK8038ynq9E23GeOtuzM1MsSeri1lo4hDE/VP6ofzN8cLKnKyOoGc4r?= =?us-ascii?Q?lj07l+Kwb3VB2xtprTr1ehX7i46ChnlyMBMBrQLjlzeY64Dk9A5N9DRU3Iam?= =?us-ascii?Q?rusrCzKKUgA6A582fIEft/M+7IaQ1DbHgVXBGX8LAFyn8mrNomMZRuiknPUY?= =?us-ascii?Q?9lenE9ahS7q8lDDFWvS7PNCalZD2MiiPt9MmQXnHzvSgLjagU0Q7uKXH54o2?= =?us-ascii?Q?DX2WG1DCl1qlTTi/dBc=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19e7abed-8a64-402c-4b0f-08dc72f42e54 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2024 02:27:05.4572 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TNHCnD/hAjaqb8QfKYHz3hLNDuI61Swf5G3rjZMr89FjIcbndOpfOXigCsjKKv3AtMeCWWcCuOcC+6mlW3LMLA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8537 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Sun, 12 May 2024 19:27:09 -0700 Resent-From: ray.ni@intel.com Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: uSyCWfwCBekjBSCRNb2eWuTbx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB8244F4D2AAC7F0BD8A64CAB58CE22MN6PR11MB8244namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=MgiAxQPv; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MN6PR11MB8244F4D2AAC7F0BD8A64CAB58CE22MN6PR11MB8244namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni Thanks, Ray ________________________________ From: Tan, Dun Sent: Friday, May 10, 2024 18:08 To: devel@edk2.groups.io Cc: Ni, Ray ; Laszlo Ersek ; Kumar, Ra= hul R ; Gerd Hoffmann ; Wu, Jia= xin Subject: [PATCH 15/18] UefiCpuPkg:Remove code to handle APIC setting and In= terrupt Remove ProgramVirtualWireMode()/DisableLvtInterrupts() since APs won't be waken by INIT-SIPI-SIPI in CpuS3.c any more. The two functions has been executed in MpInitLibInitialize() in PeiMplib. Signed-off-by: Dun Tan Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Jiaxin Wu --- UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c b/UefiCpuPkg/PiSmmCpuDxeSmm/= CpuS3.c index 9520451d92..65fe903fd3 100644 --- a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c @@ -105,11 +105,6 @@ InitializeCpuBeforeRebase ( IN BOOLEAN IsBsp ) { - ProgramVirtualWireMode (); - if (!IsBsp) { - DisableLvtInterrupts (); - } - // // Count down the number with lock mechanism. // -- 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118846): https://edk2.groups.io/g/devel/message/118846 Mute This Topic: https://groups.io/mt/106018141/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN6PR11MB8244F4D2AAC7F0BD8A64CAB58CE22MN6PR11MB8244namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Ray Ni <ray.ni@intel.com>

Thanks,
Ray
From: Tan, Dun <dun.tan@= intel.com>
Sent: Friday, May 10, 2024 18:08
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Ni, Ray <ray.ni@intel.com>; Laszlo Ersek <lersek@redhat= .com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Gerd Hoffmann <= ;kraxel@redhat.com>; Wu, Jiaxin <jiaxin.wu@intel.com>
Subject: [PATCH 15/18] UefiCpuPkg:Remove code to handle APIC setting= and Interrupt
 
Remove ProgramVirtualWireMode()/DisableLvtInterrup= ts()
since APs won't be waken by INIT-SIPI-SIPI in CpuS3.c
any more. The two functions has been executed in
MpInitLibInitialize() in PeiMplib.

Signed-off-by: Dun Tan <dun.tan@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
---
 UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c b/UefiCpuPkg/PiSmmCpuDxeSmm/= CpuS3.c
index 9520451d92..65fe903fd3 100644
--- a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c
+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c
@@ -105,11 +105,6 @@ InitializeCpuBeforeRebase (
   IN BOOLEAN  IsBsp
   )
 {
-  ProgramVirtualWireMode ();
-  if (!IsBsp) {
-    DisableLvtInterrupts ();
-  }
-
   //
   // Count down the number with lock mechanism.
   //
--
2.31.1.windows.1

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118846) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN6PR11MB8244F4D2AAC7F0BD8A64CAB58CE22MN6PR11MB8244namp_--