From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.10154.1679306673241939514 for ; Mon, 20 Mar 2023 03:04:33 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Dwgl+RP5; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679306673; x=1710842673; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=dL7GZjzgTHamrxp6BHk1KVfJNSuDYRUgwY0EA8XMLIc=; b=Dwgl+RP5a9aMO6zKqNWZmr8Yjbr7zsq+yI2YYmBKPklxQW/6Uah3gat0 nYeXd6xMiciYNHuI64wScTW4ofd6XCXQxde0yeTDY5jsabOB9XJ2pcWij k7WUKfV6ZBmK1EbJgYRH6BNfieDynV6mBL8eeNB1dQ1raxZPDSC+o9zp7 TukifC6VNYJuotnMm1TQRe8AEYwLkTmotZohjFDmujrBbGx9EJMlg5/FO +viB3G1SQjUFLk7vxtg0y+BhgQqz3JYx2dC4hTD9sNmzM7BHQ7Nf0Wa4N h+w9JrzHPZFLcqiTBmj5FeGGBoxn8UL7IyDeVkaXX5tirI1fA0s39Joxy g==; X-IronPort-AV: E=McAfee;i="6600,9927,10654"; a="403490916" X-IronPort-AV: E=Sophos;i="5.98,274,1673942400"; d="scan'208";a="403490916" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2023 03:04:26 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10654"; a="658292940" X-IronPort-AV: E=Sophos;i="5.98,274,1673942400"; d="scan'208";a="658292940" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga006.jf.intel.com with ESMTP; 20 Mar 2023 03:04:25 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 20 Mar 2023 03:04:25 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 20 Mar 2023 03:04:24 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Mon, 20 Mar 2023 03:04:24 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Mon, 20 Mar 2023 03:04:24 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lzjmshn4NJij5BgUieaIl4IXNt7hTFTugNfIBxaj9n/zYQk+RXRLNcPjrVWghrSbec7713C2XXg0Cyj7ZOabcNzRgOwq6DRCRdQQLP9wpscjtGl2jMcS4rC1SKpWnHR5Qayc/6yc7lC6AV6IVOzKsLfhMAID3gA1gJ7cG1EYru5x04GmMYohYcv5eCI4u713tBWeSVY/S6q61zMdaOijjjTBoZhEzK/PrQI6WUI5vUSQn43tX4SW4frHPvw42hflIybSxNgulC2hKPUUgOm/W/2dtLNAQSkgUaI5sehdAgLkTNJbkjPc0Kf5osjEYneiW8z/dMwSXJ92/hCQ4i+VvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EnntWV+jvOLxzug0nXhqzdL2yZ2QEzR1pmnNhc8jxtg=; b=R17Ju7ZLpZBLfinVDf52nUywGrahT5rf4CWblZOCtr67MxOEu9AqC55MDrZgm0wX7wf9weobZcvE5DjluBvr4r/gTN+kgDjhBQvS67RgB5BdRP9qIquIbnuIdM4y3POX94p56bWPVnczdU9ovhHheGsOl8u+vjUsrgUmowI5cSKWT6jFoYZE8fGobVtMBcaHfm4w1Zwf0EpiQZajrtbY7Hdp6actwwfl/7Q+RyzG35X+9pxATd5dZkSRSHcTMOas+NW1skMqUGYGlnIk9c+p6lgcBMy7LjbmORCvB5J9bPAVgpUBQyQDSTzs4rvSGSxj7aanS5bgx21LVPyEihGcQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by CO1PR11MB4884.namprd11.prod.outlook.com (2603:10b6:303:6c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Mon, 20 Mar 2023 10:04:22 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69%7]) with mapi id 15.20.6178.037; Mon, 20 Mar 2023 10:04:22 +0000 From: "Ni, Ray" To: Gerd Hoffmann , "devel@edk2.groups.io" CC: Oliver Steffen , "Kumar, Rahul R" , Pawel Polawski , "Dong, Eric" Subject: Re: [PATCH 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: fix error handling Thread-Topic: [PATCH 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: fix error handling Thread-Index: AQHZU060zcZQSpnCQka6qL3RInlFi68DgCAw Date: Mon, 20 Mar 2023 10:04:22 +0000 Message-ID: References: <20230310124849.831839-1-kraxel@redhat.com> <20230310124849.831839-3-kraxel@redhat.com> In-Reply-To: <20230310124849.831839-3-kraxel@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|CO1PR11MB4884:EE_ x-ms-office365-filtering-correlation-id: 2aebb71c-6a6b-4596-226d-08db292a7a9c x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: zPbetWJf6nGoeT0RxeAbeewovtQNLxza/Ls5vLenPdX1K+wcCCYlXuCx7pwWr1RK8v8B+b8WIDldJ5vmpTJh1EVRmzI4hQxntLTWgdqHr0oBn2qsTo0um+rL2CehKnccSqUTbRinWin60Qylnj3q+F9aTIebOP8tAyyoaoipEKTS8l/j5N8YpM7IXPGIpaoa2y7HktshF8DJpel9WfTK3pDYnM4oD7NKOX8gfcNwP7WlDlkGSubiCOAuq8ctGY2HYt8Wq3+GWZ0sQYsLgV+WD3eLPuk6z30XbHdbssIGgVyNcr9XNjWcWrx6fvGJDBCQaUFWn+5b9OU7z54w+SixHgP+4WQz8Mg76ckkXmePzzNXNgwIVpKWqzVBAc3xoV+CGJUBn+3kUBI9AULscVYKWjNm4vw5G3FNkfK8g7+oQhRU2zWQ6g89AxX1QV0GOqU8TSL/SoCLkHo47KEtwO7Ea/GzK66XmkPN6wEmOCWat/53V2YFoGVv1XBtRWPnTAfb74DF3SdO98uGK3u2TKRZ5vJqf0E1MO+Yw+JAH6c1xBApbihr5UrftTAG1QJDOjgTXGX8OX6siWJeZlKEHNopDl054Dw/WJR1bLcjy+8CAAHfVcAkB5ryojZHvS9kFbvZcHRwEPIu3S6eCD18OLWKCD6QuFxx9UaNVRFnciItoPrBJcJCJmOOh2dKyh3jzR3fs6OSjFlGl3fRdBAuiQAiXA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(6029001)(136003)(39860400002)(366004)(376002)(346002)(396003)(451199018)(83380400001)(478600001)(86362001)(122000001)(38070700005)(38100700002)(4326008)(82960400001)(41300700001)(8676002)(66446008)(66556008)(64756008)(55016003)(66946007)(76116006)(2906002)(52536014)(8936002)(66476007)(5660300002)(9686003)(33656002)(110136005)(71200400001)(26005)(107886003)(186003)(53546011)(6506007)(7696005)(54906003)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cfH7QJDGmh7RkrAlu0oHYuBR9ANCW0wx6hna+Cq9HMXgKxEqEAtGOLDflq5s?= =?us-ascii?Q?ngpiDKkh5f5JhQafuLetrmyBZRcZliKj5fiH72+2nBWoKBQHdaDTx1QTWoln?= =?us-ascii?Q?FAt7YHIK03vhvQrvY9JTo83aCXEGl0XK3ga4ooZHjYP1gRrx2jpcUpYxocl/?= =?us-ascii?Q?6rA8N+25DcL3jywsWGk19xfrRaVaGdmD80KstU1iEE88dF9Xm43VCKPTgFzM?= =?us-ascii?Q?oVQLL42pFRBX3ezmnAmB40p3McbfVfZ20OW01KnBXN+nCSLp2asbKxnVruY2?= =?us-ascii?Q?IcSfKTIS4b9Ue5A6zngV28Za/mu5Sbtf/L1ZfD2+ceyxOF17wzNeaFNQo3yu?= =?us-ascii?Q?4GvF646YQG5UuPKyzKjNG1XLoen5bRA7drV0R2k0vLax+hacc0DUAm4YGGUs?= =?us-ascii?Q?QpqpGCHQLFRSVCzRuEeXXZyQkrQHD9Njmi6YWN/pzGSwPIgtqUcgsKLrni3D?= =?us-ascii?Q?hfqnTbEoZewFFqHfC4efGbcGhst17I/fXoTSxi2l/1lhc6fgrBdNiVXSNuuv?= =?us-ascii?Q?ZL+P/LL3WBssRVKeaMJBlWh/srS+1ghUklTh0HeTs2XeDWETwo8BmMXS/hTz?= =?us-ascii?Q?IHhBehpzE0Za6we37W4g9O8Ere4nMXaorLCycFnoCEMT/ZOOLEbE2U92djJ1?= =?us-ascii?Q?yrPnYLaPpxD7XnhZySL6z1rf1P72NmYUVKEr1W+UNycg4EV7+KPORWwiV/B0?= =?us-ascii?Q?ynrIX7g/BmaSrr/vShBHDMcRgw1q8S5nnCB6dqSXhVyOdkNGKp1axYqzgIwg?= =?us-ascii?Q?9YTtAVbZJuq8c9sbWn6TRsLRS4OegMHatvZO3On8RQGsHk6DDUX5TMqtvxfE?= =?us-ascii?Q?Czif8IbOXxpqBWnOIwUIzZkaMEr5bjFtCN/R5Wr5h6NWMDyGFl+EcfRUC6RG?= =?us-ascii?Q?n4XB5vbF+nXQqdx4tTyjA2LKKacGZqeDLaJBGDbNU9FGXgA6NzfueHCng9iu?= =?us-ascii?Q?N1iKazoK3BNMUWDkheFxKF98dnvSYk46FqUXekcRKtbyussyvSB2HcI5H4sm?= =?us-ascii?Q?1f3TIlr16jEbGXgMBc2KrtgtxGxTuhO/XEVsszSpCRhX/HflTwPk0RE8st56?= =?us-ascii?Q?OyRP3rTVEpF7HLVG1Zb3ov5aMjY2Jv04fT3wx9BmBn3PMB4C8xdWjUmx7tRO?= =?us-ascii?Q?udsnWEmtda67SJ7MFAwyEwb+q8SuuJGwOAdF5UTbmfab+gO82RWxQFUUE2aa?= =?us-ascii?Q?Xblhu2QDEUk1uhE7NkDH5gfPI/m2+FJJxdLtwc4RoUkwYQpp31f9ShqzDbYK?= =?us-ascii?Q?0KcvzueATL8kf5F2ODb/nMO8J+JxpdRsojylYts62P3MZF+5xPE5rHIRyVin?= =?us-ascii?Q?64hPo5WcGZlZ0li+ECQUkppez3ZZBJqxeBQNRCkBlUBXWxMPtJAB1gND8jAe?= =?us-ascii?Q?4Wei/IqDyblRcQZrFlg/tpkalFApzQEpci4vw3JGix4Kt+J3/0jntj5IvMT5?= =?us-ascii?Q?6nmgTMnbVDAIujx60zxr7avNNRD/7TWhHE945Ad5BTWh2SGyu8KEbkiZPC5z?= =?us-ascii?Q?phuHwlDv0Sws4YPuZiQdj6bn6gYB/s+Cl4NYckb0iQrcEL+2p/aprIcQV2Zj?= =?us-ascii?Q?JTBihxgqu4nndSuU3dVXvRZWiAzakrp8H4t6TQ+u?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2aebb71c-6a6b-4596-226d-08db292a7a9c X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Mar 2023 10:04:22.5162 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vYh+mou4fXQj/WLCv+nlo4Tb+0JndI+iKn8VQ/aJc+V69AaxOpW8rQ9hn3cequ6ERirD5dX3n58IgjmBzTAc5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4884 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Gerd Hoffmann > Sent: Friday, March 10, 2023 8:49 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Oliver Steffen ; Ger= d > Hoffmann ; Kumar, Rahul R > ; Pawel Polawski ; > Dong, Eric > Subject: [PATCH 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: fix error handling >=20 > ASSERT() is not proper handling of allocation failures, it gets compiled > out on RELEASE builds. Print a message and enter dead loop instead. >=20 > Signed-off-by: Gerd Hoffmann > --- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > index 55a9f79da8eb..2e41df1f1074 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > @@ -879,6 +879,12 @@ PiCpuSmmEntry ( > // > BufferPages =3D EFI_SIZE_TO_PAGES (SIZE_32KB + TileSize * > (mMaxNumberOfCpus - 1)); > Buffer =3D AllocateAlignedCodePages (BufferPages, SIZE_4KB); > + if (!Buffer) { > + DEBUG ((DEBUG_ERROR, "Failed to allocate %d pages.\n", BufferPages= )); > + CpuDeadLoop (); > + return EFI_OUT_OF_RESOURCES; > + } > + > ASSERT (Buffer !=3D NULL); > DEBUG ((DEBUG_INFO, "New Allcoated SMRAM SaveState Buffer (0x%08x, > 0x%08x)\n", Buffer, EFI_PAGES_TO_SIZE (BufferPages))); > } > -- > 2.39.2