From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 09DF0AC0C55 for ; Mon, 11 Dec 2023 05:49:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=+MnaLNv3QdvjQ/kpA+cqlM9S3EZKTD2KNAvGdTGEIUQ=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702273765; v=1; b=h/SXcdm8ETb1RSqXYUt+2S8b8q5M5p06s0MBR4KBHWpcCgcaDWcyrKszEBUgQ0QTqqn/f6VN TBQaRi2Rt0NLTm9mcKcVqN2dvu9J9nOOHdqk/PuEXs4iRJymWlKGhmbSbzatKqH68LAhA2zC5HI a3Nbp7teoceWLNM2OtrFSLNk= X-Received: by 127.0.0.2 with SMTP id iP5EYY7687511xkG95GKZiN9; Sun, 10 Dec 2023 21:49:25 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mx.groups.io with SMTP id smtpd.web11.2293.1702273764791863772 for ; Sun, 10 Dec 2023 21:49:25 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10920"; a="1713379" X-IronPort-AV: E=Sophos;i="6.04,267,1695711600"; d="scan'208";a="1713379" X-Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2023 21:49:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10920"; a="776537421" X-IronPort-AV: E=Sophos;i="6.04,267,1695711600"; d="scan'208";a="776537421" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 10 Dec 2023 21:49:23 -0800 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 10 Dec 2023 21:49:23 -0800 X-Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 10 Dec 2023 21:49:22 -0800 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 10 Dec 2023 21:49:22 -0800 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 10 Dec 2023 21:49:20 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IqK4trPLjFJaQgkCXda4C61hDYyuOBuSCadFW9uYoZo4xIZpaDtvpFpeQre9bBMJwpnFXMucAqJv/n+4KeXADpUhrAFWdNBMGQxJoguRzw32SJbFMnKbtcnVB2HzeZUh33YlGNOqgslVlzEyraSuD5AyCE1tJD1o2fOWk7ZsGgQkgmpAwjgJtwvfRfFfbuGjR1CITyPfkjbe/bbz+uS9S2A+BVoPM+GxdnPcb597C8KgPybF/ZMxOFD9PbZtlxWGH/E9EtmPj4Z29p0Zj/cL1Og5WcFycWw5s44WFgrDQHJPDHJ9xT29Stojphv8G/7YnbYvD/YNdyezKwqHEd+zMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NewxNfOBdIYxtuF2VB3xMeXSqVHzR7ww2jHJMsvSQnU=; b=Avg20W0nJlNN4k6lhVIPSmSig8lXLmPHS3mvnjnhyVDQWAD47vlAb95oKCJsUnhgpXEO+ffYPss2uXxGTkoDX9U1uK1cqUR7cBmZpgHfvv/Ious1KYcxr+2VPHRsnsy8XhZaev6sW2sUCpoSzglmo/aN1QzhLfYdgIvuVUnVhX858x9RTWYCf67ktEX5tHOXbOSHdjM6JsNTmUunbl5Xjp8pYW4RewWe9f0JUgafj6suOCwJQDadPQQrs5yZQHhSIRqeikZO79zWek6PcNvad686UCg2t+FsaJwoDtOKM0NE8o9jpPyS1X78ixgPddDto9VrEH1iAu4G0uebOxT1Mw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by MW4PR11MB7104.namprd11.prod.outlook.com (2603:10b6:303:22b::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.32; Mon, 11 Dec 2023 05:49:17 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858%4]) with mapi id 15.20.7068.031; Mon, 11 Dec 2023 05:49:17 +0000 From: "Ni, Ray" To: Nhi Pham , "devel@edk2.groups.io" CC: Ard Biesheuvel , Sami Mujawar , Oliver Smith-Denny Subject: Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg/StandaloneMmHobLib: Remove HOB creation Thread-Topic: [PATCH v1 1/1] StandaloneMmPkg/StandaloneMmHobLib: Remove HOB creation Thread-Index: AQHaJ4GyWGdRTnRjdka2QBYXJi71x7CgLmwggANt5gA= Date: Mon, 11 Dec 2023 05:49:17 +0000 Message-ID: References: <20231205134757.14692-1-nhiphambka@gmail.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|MW4PR11MB7104:EE_ x-ms-office365-filtering-correlation-id: 0c850d3a-422f-4ae3-6c91-08dbfa0ce9d5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 9qD7sjer3IoRSNcnQINVPlThDxHlaamKTyH82QWsecCunB/D6qd7xm9bRAoELpF7H5hcdZ154bW03g+KDEJil9NuGBC8X3aL1GMM1HXJYR4QxTKiT1Zy3GZuLlb3YP7KoRjGTwWQecqnjskJItsjk59TuibytvVqvo9bxsxPFvz9fsC9+jx3XTTRPYx6cZ0meuFxK5y6VaqynOaaJhAIxHRPAqtRVVYM52uP9PvSh6LXTHA3QB8JOJ0PVNIu/RB1iLetW29l7XLxw933VGb+g/RELVt9t/w3Sm0v9Cy32h4PeEc5LVBAhxS5TkB8oFKdT131RvRw0uBZCj0yBP0uyCk7bWonjX/WfzZHUkfB68NDrz8FMJ/KEbZ13jAF+Sc030T7vvPhUAKpfV0snM0hWr3XbqczCy/iOzpjPwpSr6a0X3DbQOuo4uj99eBl/XEg7ufy6OJlI8fCN2xqw2kvXm4xwE2YCP/8fdolmbCmjJyGnAhFCLuOj7Fv5I3nmKEVJm6KT1qnwuXEhEaFmI8jiNAQCEw8fKwjpHNxBXurqEoMZJPgJGfL1WKEoXG/RdqrdxyN5DbnMOGCbdv6TJoulxAYFF4fvpjXCh3IGfRA3KA= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mp4KotgxmKHCs5xyzLi/sih4nNn33R7MbfyLuwjxwsD0thzGZtAlIx8zyQYU?= =?us-ascii?Q?3LVfZkX8dE3MK5whW9YhmhUhAxwWzulVu0OgK+5SbId5P7KePtEkcspSJ/0Y?= =?us-ascii?Q?JSSwFdzH0etCi936EsYAqyzN3CLV/cmgSdRKrOjbjoaPN6YKI9xi5E4rHLVY?= =?us-ascii?Q?ljDIlAuWPljsBJhwJaj0xZnfTALwXRwhNM8mnUrMBlGcx42lexjaokrT0Eoh?= =?us-ascii?Q?KY6PMUKnRlo7a5ptwlNmxWdflJ9BFcBtea8pbqSK4uK8QEr+UDG4k1huMDaA?= =?us-ascii?Q?Ad9punE5/BJ2q+3PRL9HddgLvoR85MbDQ8fOJX3fbZKNsGs8YsFdZs6ucxg0?= =?us-ascii?Q?n0vGkobUVdNF64sOPRJ2UUGkUACtr3k+tUiyVFQkxPJExAhYB7ziS3PNEWfc?= =?us-ascii?Q?qZefO54iejRbUJOVHmQMMmNqic3v6UX6RVA/E4C2hlziURDjMLsp1CCikvEM?= =?us-ascii?Q?kGly4Laq9gyPf9BldwylrcZDLlQ3CornmgMURVojUJJM5kkP6NOPle+TT19H?= =?us-ascii?Q?/VRpbFngOUwGvq0r6V5BuWmMW+O9jZSO4uYrjdG3XZpKuGrSSJ5CrTXxeOjS?= =?us-ascii?Q?3R9dg85wIWToq+Q0WqiZhEabPvkZw1qNmxZSXeJuTk9JwOMM7zPPGzdDu827?= =?us-ascii?Q?+W/nUeQOOu3w/PuHDvEREMGLCepXg8r4FBrX4fLGOD7JskLkC/+0xlgYIGku?= =?us-ascii?Q?j+AteYPABRW4xEd9BSdF5NoEpLTKuU2WiAvNLAImd18GuJbeX5MJEclsHO28?= =?us-ascii?Q?ZsWYlxqSy05PyDhqOmyFhzy24sC3XrtXY8OInNDEkcxgTINaPDiXurprtmnQ?= =?us-ascii?Q?tDUih2UHI5DyFW/ImUJ+1U2C5IxDWNKEgQacwaOJfGSN3es9FbWRp2n4VNGR?= =?us-ascii?Q?4sDvlaU6nc2rVyeIKvEZpqW33xzmlXoHsLVrr3E6Vez3RH21z4ybTt1+6ZGy?= =?us-ascii?Q?flWAiUHqp4gFw0WnlGH/Z98lfpqXK+51ASl0QzEJwmjOl1XmwOKaAqRltUAy?= =?us-ascii?Q?tJlqfpuyqr0H0pJCBRZ3AWOafgKXo8U1PATG9tbXJyxtZXb6hY9N56y8cIWW?= =?us-ascii?Q?w2tZVi5Rom9iz3gNWMuLf8cbLKXQ+eyQN8UOnei+Ad2V+n3KH4HspEwLjxPa?= =?us-ascii?Q?7Ke/tEJjFoT1Ja5GR0xgXCRV9GewrrmY9XOE5bqkGr5pMixYztvD6egO9u5a?= =?us-ascii?Q?zttzwmFGnXpbPv7rhs8pDb70E/bJvCwXJhWyb9XeAlDyHK99KtOU9Gb2Byvx?= =?us-ascii?Q?q8DTTs0J2uMk22Yl+Kz1NADZZsAO6b8Ogd4TMdCxw23fd52eir0xYrrT54w1?= =?us-ascii?Q?3OyZSWrHDJlTmqwpZVA+pBgrTTh3/0DgyTo257ZiuRg0z6ii0J8v0uomDT0w?= =?us-ascii?Q?44cpkTMkBIfRKnpXGOgpeuVWYM3kwHKEy6PNV6xL1a1E2jWAufplbaJrewAX?= =?us-ascii?Q?c9SXL+/NScqvtX9bKuQ646gh8NvNHQgWZOJQYp/CcXLTctn6bI51MFva/zrU?= =?us-ascii?Q?ikfM4lrlw0wV5D31ezhhc5T0HxDCibiL1JCj2D8rU9EWd69IzsU068SDG87o?= =?us-ascii?Q?ojgCfTfkwDL84qh2eTE=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c850d3a-422f-4ae3-6c91-08dbfa0ce9d5 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Dec 2023 05:49:17.2202 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NkK253L5dfSJCQzBNvZJoz/6Zu7E2K7fW7ivl6nHYYiMewk1JArnMaw/rrS6vZekdSY5F7e3M5gdqQKQZlmuow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7104 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: LG5a1n8Mr5OfbHtvTYZPHgGVx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="h/SXcdm8"; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Merged at bb13a4adab Thanks, Ray > -----Original Message----- > From: Ni, Ray > Sent: Saturday, December 9, 2023 9:27 AM > To: Nhi Pham ; devel@edk2.groups.io > Cc: Ard Biesheuvel ; Sami Mujawar > ; Oliver Smith-Denny > Subject: RE: [PATCH v1 1/1] StandaloneMmPkg/StandaloneMmHobLib: > Remove HOB creation >=20 > Nhi, > Thanks for the follow up! >=20 > Reviewed-by: Ray Ni >=20 > Thanks, > Ray > > -----Original Message----- > > From: Nhi Pham > > Sent: Tuesday, December 5, 2023 9:48 PM > > To: devel@edk2.groups.io > > Cc: Nhi Pham ; Ard Biesheuvel > > ; Ni, Ray ; Sami Mujawar > > ; Oliver Smith-Denny > > > Subject: [PATCH v1 1/1] StandaloneMmPkg/StandaloneMmHobLib: Remove > > HOB creation > > > > According to the discussion in "StandaloneMmPkg: Fix HOB space and > > heap space conflicted issue" [1], Standalone MM modules should be HOB > > consumers where HOB is read-only. Therefore, this patch removes the > > supported functions for HOB creation in the StandaloneMmHobLib. > > > > [1] https://edk2.groups.io/g/devel/message/108333 > > > > Cc: Ard Biesheuvel > > Cc: Ray Ni > > Cc: Sami Mujawar > > Cc: Oliver Smith-Denny > > Signed-off-by: Nhi Pham > > --- > > > StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmHobLib.c | > > 171 ++++++-------------- > > 1 file changed, 51 insertions(+), 120 deletions(-) > > > > diff --git > > > a/StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmHobLib.c > > > b/StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmHobLib.c > > index ee61bdd227d0..bef66d167494 100644 > > --- > > > a/StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmHobLib.c > > +++ > > > b/StandaloneMmPkg/Library/StandaloneMmHobLib/StandaloneMmHobLib.c > > @@ -1,5 +1,5 @@ > > /** @file > > > > - HOB Library implementation for Standalone MM Core. > > > > + HOB Library implementation for Standalone MM modules. > > > > > > > > Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.
> > > > Copyright (c) 2017 - 2018, ARM Limited. All rights reserved.
> > > > @@ -250,48 +250,13 @@ GetBootModeHob ( > > return HandOffHob->BootMode; > > > > } > > > > > > > > -VOID * > > > > -CreateHob ( > > > > - IN UINT16 HobType, > > > > - IN UINT16 HobLength > > > > - ) > > > > -{ > > > > - EFI_HOB_HANDOFF_INFO_TABLE *HandOffHob; > > > > - EFI_HOB_GENERIC_HEADER *HobEnd; > > > > - EFI_PHYSICAL_ADDRESS FreeMemory; > > > > - VOID *Hob; > > > > - > > > > - HandOffHob =3D GetHobList (); > > > > - > > > > - HobLength =3D (UINT16)((HobLength + 0x7) & (~0x7)); > > > > - > > > > - FreeMemory =3D HandOffHob->EfiFreeMemoryTop - HandOffHob- > > >EfiFreeMemoryBottom; > > > > - > > > > - if (FreeMemory < HobLength) { > > > > - return NULL; > > > > - } > > > > - > > > > - Hob =3D (VOID > *)(UINTN)HandOffHob->EfiEndOfHobList; > > > > - ((EFI_HOB_GENERIC_HEADER *)Hob)->HobType =3D HobType; > > > > - ((EFI_HOB_GENERIC_HEADER *)Hob)->HobLength =3D HobLength; > > > > - ((EFI_HOB_GENERIC_HEADER *)Hob)->Reserved =3D 0; > > > > - > > > > - HobEnd =3D (EFI_HOB_GENERIC_HEADER > *)((UINTN)Hob + > > HobLength); > > > > - HandOffHob->EfiEndOfHobList =3D > (EFI_PHYSICAL_ADDRESS)(UINTN)HobEnd; > > > > - > > > > - HobEnd->HobType =3D EFI_HOB_TYPE_END_OF_HOB_LIST; > > > > - HobEnd->HobLength =3D sizeof (EFI_HOB_GENERIC_HEADER); > > > > - HobEnd->Reserved =3D 0; > > > > - HobEnd++; > > > > - HandOffHob->EfiFreeMemoryBottom =3D > > (EFI_PHYSICAL_ADDRESS)(UINTN)HobEnd; > > > > - > > > > - return Hob; > > > > -} > > > > - > > > > /** > > > > Builds a HOB for a loaded PE32 module. > > > > > > > > This function builds a HOB for a loaded PE32 module. > > > > + It can only be invoked by Standalone MM Core. > > > > + For Standalone MM drivers, it will ASSERT() since HOB is read only f= or > > Standalone MM drivers. > > > > + > > > > If ModuleName is NULL, then ASSERT(). > > > > If there is no additional space for HOB creation, then ASSERT(). > > > > > > > > @@ -310,33 +275,19 @@ BuildModuleHob ( > > IN EFI_PHYSICAL_ADDRESS EntryPoint > > > > ) > > > > { > > > > - EFI_HOB_MEMORY_ALLOCATION_MODULE *Hob; > > > > - > > > > - ASSERT ( > > > > - ((MemoryAllocationModule & (EFI_PAGE_SIZE - 1)) =3D=3D 0) && > > > > - ((ModuleLength & (EFI_PAGE_SIZE - 1)) =3D=3D 0) > > > > - ); > > > > - > > > > - Hob =3D CreateHob (EFI_HOB_TYPE_MEMORY_ALLOCATION, sizeof > > (EFI_HOB_MEMORY_ALLOCATION_MODULE)); > > > > - > > > > - CopyGuid (&(Hob->MemoryAllocationHeader.Name), > > &gEfiHobMemoryAllocModuleGuid); > > > > - Hob->MemoryAllocationHeader.MemoryBaseAddress =3D > > MemoryAllocationModule; > > > > - Hob->MemoryAllocationHeader.MemoryLength =3D ModuleLength; > > > > - Hob->MemoryAllocationHeader.MemoryType =3D > EfiBootServicesCode; > > > > - > > > > // > > > > - // Zero the reserved space to match HOB spec > > > > + // HOB is read only for Standalone MM drivers > > > > // > > > > - ZeroMem (Hob->MemoryAllocationHeader.Reserved, sizeof (Hob- > > >MemoryAllocationHeader.Reserved)); > > > > - > > > > - CopyGuid (&Hob->ModuleName, ModuleName); > > > > - Hob->EntryPoint =3D EntryPoint; > > > > + ASSERT (FALSE); > > > > } > > > > > > > > /** > > > > Builds a HOB that describes a chunk of system memory. > > > > > > > > This function builds a HOB that describes a chunk of system memory. > > > > + It can only be invoked by Standalone MM Core. > > > > + For Standalone MM drivers, it will ASSERT() since HOB is read only f= or > > Standalone MM drivers. > > > > + > > > > If there is no additional space for HOB creation, then ASSERT(). > > > > > > > > @param ResourceType The type of resource described by > this HOB. > > > > @@ -354,15 +305,10 @@ BuildResourceDescriptorHob ( > > IN UINT64 NumberOfBytes > > > > ) > > > > { > > > > - EFI_HOB_RESOURCE_DESCRIPTOR *Hob; > > > > - > > > > - Hob =3D CreateHob (EFI_HOB_TYPE_RESOURCE_DESCRIPTOR, sizeof > > (EFI_HOB_RESOURCE_DESCRIPTOR)); > > > > - ASSERT (Hob !=3D NULL); > > > > - > > > > - Hob->ResourceType =3D ResourceType; > > > > - Hob->ResourceAttribute =3D ResourceAttribute; > > > > - Hob->PhysicalStart =3D PhysicalStart; > > > > - Hob->ResourceLength =3D NumberOfBytes; > > > > + // > > > > + // HOB is read only for Standalone MM drivers > > > > + // > > > > + ASSERT (FALSE); > > > > } > > > > > > > > /** > > > > @@ -371,6 +317,9 @@ BuildResourceDescriptorHob ( > > This function builds a customized HOB tagged with a GUID for > identification > > > > and returns the start address of GUID HOB data so that caller can fi= ll > the > > customized data. > > > > The HOB Header and Name field is already stripped. > > > > + It can only be invoked by Standalone MM Core. > > > > + For Standalone MM drivers, it will ASSERT() since HOB is read only f= or > > Standalone MM drivers. > > > > + > > > > If Guid is NULL, then ASSERT(). > > > > If there is no additional space for HOB creation, then ASSERT(). > > > > If DataLength >=3D (0x10000 - sizeof (EFI_HOB_GUID_TYPE)), then > ASSERT(). > > > > @@ -388,16 +337,11 @@ BuildGuidHob ( > > IN UINTN DataLength > > > > ) > > > > { > > > > - EFI_HOB_GUID_TYPE *Hob; > > > > - > > > > // > > > > - // Make sure that data length is not too long. > > > > + // HOB is read only for Standalone MM drivers > > > > // > > > > - ASSERT (DataLength <=3D (0xffff - sizeof (EFI_HOB_GUID_TYPE))); > > > > - > > > > - Hob =3D CreateHob (EFI_HOB_TYPE_GUID_EXTENSION, (UINT16)(sizeof > > (EFI_HOB_GUID_TYPE) + DataLength)); > > > > - CopyGuid (&Hob->Name, Guid); > > > > - return Hob + 1; > > > > + ASSERT (FALSE); > > > > + return NULL; > > > > } > > > > > > > > /** > > > > @@ -406,6 +350,9 @@ BuildGuidHob ( > > This function builds a customized HOB tagged with a GUID for > identification, > > > > copies the input data to the HOB data field and returns the start > address of > > the GUID HOB data. > > > > The HOB Header and Name field is already stripped. > > > > + It can only be invoked by Standalone MM Core. > > > > + For Standalone MM drivers, it will ASSERT() since HOB is read only f= or > > Standalone MM drivers. > > > > + > > > > If Guid is NULL, then ASSERT(). > > > > If Data is NULL and DataLength > 0, then ASSERT(). > > > > If there is no additional space for HOB creation, then ASSERT(). > > > > @@ -426,19 +373,20 @@ BuildGuidDataHob ( > > IN UINTN DataLength > > > > ) > > > > { > > > > - VOID *HobData; > > > > - > > > > - ASSERT (Data !=3D NULL || DataLength =3D=3D 0); > > > > - > > > > - HobData =3D BuildGuidHob (Guid, DataLength); > > > > - > > > > - return CopyMem (HobData, Data, DataLength); > > > > + // > > > > + // HOB is read only for Standalone MM drivers > > > > + // > > > > + ASSERT (FALSE); > > > > + return NULL; > > > > } > > > > > > > > /** > > > > Builds a Firmware Volume HOB. > > > > > > > > This function builds a Firmware Volume HOB. > > > > + It can only be invoked by Standalone MM Core. > > > > + For Standalone MM drivers, it will ASSERT() since HOB is read only f= or > > Standalone MM drivers. > > > > + > > > > If there is no additional space for HOB creation, then ASSERT(). > > > > > > > > @param BaseAddress The base address of the Firmware Volume. > > > > @@ -452,18 +400,19 @@ BuildFvHob ( > > IN UINT64 Length > > > > ) > > > > { > > > > - EFI_HOB_FIRMWARE_VOLUME *Hob; > > > > - > > > > - Hob =3D CreateHob (EFI_HOB_TYPE_FV, sizeof > > (EFI_HOB_FIRMWARE_VOLUME)); > > > > - > > > > - Hob->BaseAddress =3D BaseAddress; > > > > - Hob->Length =3D Length; > > > > + // > > > > + // HOB is read only for Standalone MM drivers > > > > + // > > > > + ASSERT (FALSE); > > > > } > > > > > > > > /** > > > > Builds a EFI_HOB_TYPE_FV2 HOB. > > > > > > > > This function builds a EFI_HOB_TYPE_FV2 HOB. > > > > + It can only be invoked by Standalone MM Core. > > > > + For Standalone MM drivers, it will ASSERT() since HOB is read only f= or > > Standalone MM drivers. > > > > + > > > > If there is no additional space for HOB creation, then ASSERT(). > > > > > > > > @param BaseAddress The base address of the Firmware Volume. > > > > @@ -481,20 +430,19 @@ BuildFv2Hob ( > > IN CONST EFI_GUID *FileName > > > > ) > > > > { > > > > - EFI_HOB_FIRMWARE_VOLUME2 *Hob; > > > > - > > > > - Hob =3D CreateHob (EFI_HOB_TYPE_FV2, sizeof > > (EFI_HOB_FIRMWARE_VOLUME2)); > > > > - > > > > - Hob->BaseAddress =3D BaseAddress; > > > > - Hob->Length =3D Length; > > > > - CopyGuid (&Hob->FvName, FvName); > > > > - CopyGuid (&Hob->FileName, FileName); > > > > + // > > > > + // HOB is read only for Standalone MM drivers > > > > + // > > > > + ASSERT (FALSE); > > > > } > > > > > > > > /** > > > > Builds a HOB for the CPU. > > > > > > > > This function builds a HOB for the CPU. > > > > + It can only be invoked by Standalone MM Core. > > > > + For Standalone MM drivers, it will ASSERT() since HOB is read only f= or > > Standalone MM drivers. > > > > + > > > > If there is no additional space for HOB creation, then ASSERT(). > > > > > > > > @param SizeOfMemorySpace The maximum physical memory > > addressability of the processor. > > > > @@ -508,23 +456,19 @@ BuildCpuHob ( > > IN UINT8 SizeOfIoSpace > > > > ) > > > > { > > > > - EFI_HOB_CPU *Hob; > > > > - > > > > - Hob =3D CreateHob (EFI_HOB_TYPE_CPU, sizeof (EFI_HOB_CPU)); > > > > - > > > > - Hob->SizeOfMemorySpace =3D SizeOfMemorySpace; > > > > - Hob->SizeOfIoSpace =3D SizeOfIoSpace; > > > > - > > > > // > > > > - // Zero the reserved space to match HOB spec > > > > + // HOB is read only for Standalone MM drivers > > > > // > > > > - ZeroMem (Hob->Reserved, sizeof (Hob->Reserved)); > > > > + ASSERT (FALSE); > > > > } > > > > > > > > /** > > > > Builds a HOB for the memory allocation. > > > > > > > > This function builds a HOB for the memory allocation. > > > > + It can only be invoked by Standalone MM Core. > > > > + For Standalone MM drivers, it will ASSERT() since HOB is read only f= or > > Standalone MM drivers. > > > > + > > > > If there is no additional space for HOB creation, then ASSERT(). > > > > > > > > @param BaseAddress The 64 bit physical address of the memory. > > > > @@ -540,23 +484,10 @@ BuildMemoryAllocationHob ( > > IN EFI_MEMORY_TYPE MemoryType > > > > ) > > > > { > > > > - EFI_HOB_MEMORY_ALLOCATION *Hob; > > > > - > > > > - ASSERT ( > > > > - ((BaseAddress & (EFI_PAGE_SIZE - 1)) =3D=3D 0) && > > > > - ((Length & (EFI_PAGE_SIZE - 1)) =3D=3D 0) > > > > - ); > > > > - > > > > - Hob =3D CreateHob (EFI_HOB_TYPE_MEMORY_ALLOCATION, sizeof > > (EFI_HOB_MEMORY_ALLOCATION)); > > > > - > > > > - ZeroMem (&(Hob->AllocDescriptor.Name), sizeof (EFI_GUID)); > > > > - Hob->AllocDescriptor.MemoryBaseAddress =3D BaseAddress; > > > > - Hob->AllocDescriptor.MemoryLength =3D Length; > > > > - Hob->AllocDescriptor.MemoryType =3D MemoryType; > > > > // > > > > - // Zero the reserved space to match HOB spec > > > > + // HOB is read only for Standalone MM drivers > > > > // > > > > - ZeroMem (Hob->AllocDescriptor.Reserved, sizeof (Hob- > > >AllocDescriptor.Reserved)); > > > > + ASSERT (FALSE); > > > > } > > > > > > > > /** > > > > -- > > 2.34.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112268): https://edk2.groups.io/g/devel/message/112268 Mute This Topic: https://groups.io/mt/103018869/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-