public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	"Ni, Ray" <ray.ni@intel.com>, "Xu, Wei6" <wei6.xu@intel.com>
Subject: [edk2-devel] Regarding MOR Secure feature
Date: Fri, 21 Jun 2024 08:03:30 +0000	[thread overview]
Message-ID: <MN6PR11MB8244F791431530375AFAAC6A8CC92@MN6PR11MB8244.namprd11.prod.outlook.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1755 bytes --]

Ard,

7 years ago, Laszlo added this commit (https://github.com/tianocore/edk2/commit/fda8f631edbbf3823760542a06f12bd60fd39181) to support some OS kernels that incorrectly "create" the MOR variable.
The OS kernel bug is captured in this bugzilla (bugzilla.redhat.com/show_bug.cgi?id=1498159<https://bugzilla.redhat.com/show_bug.cgi?id=1498159>). It seems to me the OS kernel bugs only exist in Fedora 24 and 25 which are all EOL today. Fedora 26 has the correct implementation that does NOT "create" the MOR variable. The implementation is done by you here (https://lore.kernel.org/all/20170825155019.6740-2-ard.biesheuvel@linaro.org/T/#u).

5 years ago, you added StandaloneMm variable driver and VariableHaveTcgProtocols() returns FALSE always in the standalone MM version. (Commit: https://github.com/tianocore/edk2/commit/a855f63e2fdd990837391b0e61e78b3f06b56916)
As a result, MorLock variable is not created. It causes a bug that the BIOS does not report the MOR Secure feature to OS.

My questions are:

  1.
can we revert Laszlo's commit? As the bug that commit fixes only exists in Fedora 24/25 which are all EOL today.
  2.
why is the MOR secure bug not found in ARM platform?

I think you are the best person to answer the questions because you not only fixed the kernel, but also know details on the ARM standalone MM.
I am so happy with that:)

Thanks,
Ray


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119666): https://edk2.groups.io/g/devel/message/119666
Mute This Topic: https://groups.io/mt/106795434/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 6576 bytes --]

             reply	other threads:[~2024-06-21  8:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-21  8:03 Ni, Ray [this message]
2024-06-21  8:35 ` [edk2-devel] Regarding MOR Secure feature Ard Biesheuvel
2024-06-24  8:49   ` Ni, Ray
2024-06-24 11:17     ` Gerd Hoffmann
2024-08-16 10:49     ` Xu, Wei6

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN6PR11MB8244F791431530375AFAAC6A8CC92@MN6PR11MB8244.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox