From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.10149.1679306660807401450 for ; Mon, 20 Mar 2023 03:04:20 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=f3kMH+ZX; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679306660; x=1710842660; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=8e1jvwLtwGBlh+uQ+VZROrqupd2PG5ghwiMqJ55q+s0=; b=f3kMH+ZXY+xrhKXNWf+fTbEXqlEyiEN7P7xTRfshLq183Q06wTKS9xfu DBr9XLoNEQJ/ls5zOm0RAJ+lf8i/6fl4IvqmuOZCS9kKQ+s90tMONqa2N dyThQEDTLxABB7Hnz2M9NL8185r1XzQDHA8x22stUZrlOHfheMIffFtxi /2Svf7/A4i16wFuDhdqVyBAPSrH9ygl5Z6GH4tF75SX+0rCV27Zw4we9y pd1dt97QvvBOQ0gCbcu/Biiz5t/vAEa+o+jBNx1Oi9qN5C83Bn8Q3UoTo wHf0VBBf7Ckcwlnoz5sh0Qckqej8rGfU1wHclzAgGXhYYqW0MD/sR0qVD Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10654"; a="338646829" X-IronPort-AV: E=Sophos;i="5.98,274,1673942400"; d="scan'208";a="338646829" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Mar 2023 03:04:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10654"; a="791558796" X-IronPort-AV: E=Sophos;i="5.98,274,1673942400"; d="scan'208";a="791558796" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP; 20 Mar 2023 03:04:19 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 20 Mar 2023 03:04:19 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Mon, 20 Mar 2023 03:04:19 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Mon, 20 Mar 2023 03:04:19 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Mon, 20 Mar 2023 03:04:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NVA+/I1CFs62lpnTHFawuL+1L/TeCepcZ2PvFt5Fbw3kufJeyGdL7c/6okUYnz1UHc2reXNUhGjy56Hrh+L5kU5WQAv3iMgdqP5ZKUh8hbUNIBGfflebqlPVAL92nI4Pe+XmO7Xijv9sUwmKYAvJN5dQworpuAivfmuSG6HF3H2tRkV/XmF7XTV8x4T7bzto49ZlWiHI8UOD5NAt45XZRAZVW+0Mw8I7p6pg82d66dlywM5U4UPlDQlwlFMje0BxPtuDAo83JL3zJIHzjXvaW8vJJfR2cfCVBjo/uVf9aFUtf3dAMl+UXFZoqyFwO03YE1Zng/lOT2KAl0RW2ruu7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qX4UNAmWZxDiHd40FDOIDXI4KiebHuFroxL3JwqkNG8=; b=kcjX+OgfImQ4l3uNJ+4Gpcc3jRkL2oDRNP2EZdEpIkyw+W3j7cBADuKVkXLG/pktxCLXf+yolOH6LTypGmNgpThYyXOpIOLm6PDrMZDUsjnYRmIYylBkPq6dcRtkSbq51J5h/4jqpBMlBskQWY59wmnh07+RAAfn66u1/9g2xUvTeFZq617vZ7iJpSNtNIWloJ8B6rtKNCYkZpk8pbp1LST6MczGVEiCJ722G3E7If1nafc36or3VoMghvw4qdn8eV9P0Q4hizMhfs3qoiwohuTvEjwaNmLsWxJfLpDo5iuzECWSLNYnJ7RDVP3Cf2SnGMaBNWXHGigHu0oIAyGPxw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by CO1PR11MB4884.namprd11.prod.outlook.com (2603:10b6:303:6c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Mon, 20 Mar 2023 10:04:17 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69%7]) with mapi id 15.20.6178.037; Mon, 20 Mar 2023 10:04:17 +0000 From: "Ni, Ray" To: Gerd Hoffmann , "devel@edk2.groups.io" CC: Oliver Steffen , "Kumar, Rahul R" , Pawel Polawski , "Dong, Eric" Subject: Re: [PATCH 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: drop support for obsolete processors Thread-Topic: [PATCH 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: drop support for obsolete processors Thread-Index: AQHZU06yGtAsVKSyCkukZ4DVymzl7q8DgA+w Date: Mon, 20 Mar 2023 10:04:17 +0000 Message-ID: References: <20230310124849.831839-1-kraxel@redhat.com> <20230310124849.831839-2-kraxel@redhat.com> In-Reply-To: <20230310124849.831839-2-kraxel@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|CO1PR11MB4884:EE_ x-ms-office365-filtering-correlation-id: 8d3a6207-825c-46cd-368b-08db292a775e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 5ljmdm/s30xQeGo5lzCUDU/HbrVMJ3gXaw6chBzbY9o69VPH5hcWbNgq5Ne+h5kpMbKGmGCYppgQZg5z5gwRw2z9ueJSRG7PP/1VVHTCuNi7FuIoarFmDaan7Lyb0nFicyGsKn45hF1g5UEie1jiJY3J1EO6Ezez2advKgajIA7yvrCuUeKMo7IvBpfnno6ZTxNpsyMZhcm59/sm9Ikgo6uUgSMth9NXvX0FkfRV6hHar5xiSst2+RuNMqX5ftoDj+fley57AwdHSDJtkEvPyuxkufcZOi6of9hYXDGdquEYy1Y1qwzaHAha2X5aII+EzOSq5p7+nWg5XhSg1gasKANvBT3WLkGO/Kq9XKziPuEHWy0mSxulStJ9AUjtjMolohwW/dAJlIejMOxJHSmcQA/yHpEtvcB61/UJ/UMaYpIjbgsmCRZBeDUPIwDc5WIX2Hw6ansyJFZ/+4tjMpdM8UnDyCd78cW8iuGzuNmXVNduQ82GTWPCBFjWzH6w0t7vcfnibOK62qdAdgi7/Ak7fjYwvya2NqmIedUc03nUlWvGi8OdS06o6/99f+I0w62fSyCE/dHTy92rZWCD9dvIGN4tvA8CK5csI6OV1TqL3Yzx9bHsuZ1ibl4IGs+fR2Orrvw75xefaEe6H4Iroc1Nhr8GKLIzjuwO5xHMLV7LC3efN1rwzry4MBwmlViidu3i x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(6029001)(136003)(39860400002)(366004)(376002)(346002)(396003)(451199018)(83380400001)(478600001)(86362001)(122000001)(38070700005)(38100700002)(4326008)(82960400001)(41300700001)(8676002)(66446008)(66556008)(64756008)(55016003)(66946007)(76116006)(2906002)(52536014)(8936002)(66476007)(5660300002)(9686003)(33656002)(110136005)(71200400001)(26005)(107886003)(186003)(53546011)(6506007)(7696005)(54906003)(966005)(316002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?sb9MLgHFSCEfgEZFY/btLSA3lK34OvzhK2qNtCkMvTsTEE81Q7rMrirQgUCd?= =?us-ascii?Q?gUZbp5DEizFLGapKBVAi9qDUsmGedflx63bLijpZAI+ehkOrzQnQVERBPynH?= =?us-ascii?Q?2ewouyX8dHXrfb+sucq2caosyPScMAw/+LdfT7Pk88vR4557knctIyvsEs6b?= =?us-ascii?Q?yrXz2/wAHyK0XfLKHwIbOift136VJ5MmkqpOJj/N9HHen4u6myGPPCpBK4Hz?= =?us-ascii?Q?JVjIotTNNeILoW++qAmaI+aOAWdm5ylsXEJ1ULscZQRBagx9P/2WOFeOYTCt?= =?us-ascii?Q?EkOY6oAxz8JoWjHZGn+Wss72fHdpytWQRLh3ls8Wzy3/4d1IpqPtbO4f3Vqk?= =?us-ascii?Q?8TKXfme/B1YA1etObiEYGn0SF2yeCZIYbloBawLD0eSzFJd4CcwfgrVLqEAc?= =?us-ascii?Q?nlci2z4IupI+8135OtPJ1y9BUYMDG2PkGZJjIrqWWsjbu/Ttm0lksPFHzaWb?= =?us-ascii?Q?A4EuruKtk0i4qu+BsWnugormnyJBrKDOz0qb+mp9CQINwJQUf7rbBYTCmmXY?= =?us-ascii?Q?GgTa5Tuxdjg86qkvuTD9o9SOvXXOjzj6y6DJlVAGjUbw59BIq+Q+bN7uhNMc?= =?us-ascii?Q?b2hL4tjEErZ/A30b6h+4CTYibVDY5ilfGPm3eHg2a722qIum3kxdZM5sIf2P?= =?us-ascii?Q?0IL2tdbyc/PlD9Z1DrUDuO2/8shVKqHzhbpk9dfzTlVg8QigsVeNsW+etG09?= =?us-ascii?Q?JpGaunI43/eMAsGqi3RSs5dWHOLNLQau1+I6AmGyJx7Gxy2DyynvCKrJuukd?= =?us-ascii?Q?7Rg2bPHHJPixzW6rw4MUKe3udHp7ip/JwL4bhr8SInJMcxAZ6kCP08Gl1Qmn?= =?us-ascii?Q?AoUCgnRFQAwYqJEOJCLv2P9qYVnAdUeUk08p6NN7iOW/sgdd1yELmv43hpaw?= =?us-ascii?Q?QH1DAHgCY/+g6n2NPWKouvZz+Sx4ccF9DVPUoo7Foz8n+/8uvofRapqD19SO?= =?us-ascii?Q?xDA8Sv+VoTUqRRKDVSbhylyQ1U0r7w8528LePz2KISx7b+E/pcDW7542ofl0?= =?us-ascii?Q?G4QsgThqhWDO2wnqdVWeYPxZZ0PiZzau7AXgalT0nnpYWKsQW6okGWPh+XiW?= =?us-ascii?Q?rOZuKpGWWzZQYuGSagZm6ZCEyqwDv8rnPg+ouSJx1GCPXJRN/hWDenyAWfp/?= =?us-ascii?Q?YRn5ZGFhPPE2xomrog07Ni38+9svM7rh9DYrpQgOn5EyN7hnzYTXJI4rMl3+?= =?us-ascii?Q?ND+J4u5cN4pYaXkn5D4errkyMPWE/+pGLp/FVPbp9Jt0w7H1BJLjQ2NExpqG?= =?us-ascii?Q?H2mu2dSkS6kglJFS+h4Hy671NtPWe/DP1Z6qsiAkPv0kJqkJjgu3KzaKsijC?= =?us-ascii?Q?umTArSWrM11PHbr3IXIU7LJujBh8Yiebp3lQQQBAk95OUoPO1oHGnG0BEmKZ?= =?us-ascii?Q?4CgEd9eK3x57SHRlAEPCQCC4FCstutQIbQ9n5KuibfqhfejqU0W2PTdnehP0?= =?us-ascii?Q?ncjr6ZzgXit6M7RHtRqOMhBu4ThUz1zkBScw/jZhlAX+VKu7Kqc7WeoHaTEP?= =?us-ascii?Q?1UWYJ90OBE/ze4YzQ9X0FITcwXfnR9pw2zKyzFIRVlvLTHKUWgrTFBiHKSpr?= =?us-ascii?Q?l+b39rxNWUUiXSUmj18awWfk7O/rP6y7i9/3Ptco?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d3a6207-825c-46cd-368b-08db292a775e X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Mar 2023 10:04:17.0616 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 9p2ndvMIjtPpU+32JbqyjzryPt+cDmhpA9aYvNJ4QHEYS9ULlESMW+lbOExQ7uYxYPdR5Ex8LfEx5RmpB2WdeQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4884 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Gerd Hoffmann > Sent: Friday, March 10, 2023 8:49 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Oliver Steffen ; Ger= d > Hoffmann ; Kumar, Rahul R > ; Pawel Polawski ; > Dong, Eric > Subject: [PATCH 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: drop support for > obsolete processors >=20 > It's highly unlikely the code ever runs on processors which are > almost 30 years old. Drop the code handling them. >=20 > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4345 > Signed-off-by: Gerd Hoffmann > --- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 20 +++++--------------- > 1 file changed, 5 insertions(+), 15 deletions(-) >=20 > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > index d2d0950f3b42..55a9f79da8eb 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c > @@ -871,24 +871,14 @@ PiCpuSmmEntry ( > // > DEBUG ((DEBUG_INFO, "PiCpuSmmEntry: gSmmBaseHobGuid not > found!\n")); > // > + // very old processors (i486 + pentium) need 32k not 4k alignment, > exclude them. > + // > + ASSERT (FamilyId >=3D 6); > + // > // Allocate buffer for all of the tiles. > // > - // Intel(R) 64 and IA-32 Architectures Software Developer's Manual > - // Volume 3C, Section 34.11 SMBASE Relocation > - // For Pentium and Intel486 processors, the SMBASE values must be > - // aligned on a 32-KByte boundary or the processor will enter shut= down > - // state during the execution of a RSM instruction. > - // > - // Intel486 processors: FamilyId is 4 > - // Pentium processors : FamilyId is 5 > - // > BufferPages =3D EFI_SIZE_TO_PAGES (SIZE_32KB + TileSize * > (mMaxNumberOfCpus - 1)); > - if ((FamilyId =3D=3D 4) || (FamilyId =3D=3D 5)) { > - Buffer =3D AllocateAlignedCodePages (BufferPages, SIZE_32KB); > - } else { > - Buffer =3D AllocateAlignedCodePages (BufferPages, SIZE_4KB); > - } > - > + Buffer =3D AllocateAlignedCodePages (BufferPages, SIZE_4KB); > ASSERT (Buffer !=3D NULL); > DEBUG ((DEBUG_INFO, "New Allcoated SMRAM SaveState Buffer (0x%08x, > 0x%08x)\n", Buffer, EFI_PAGES_TO_SIZE (BufferPages))); > } > -- > 2.39.2