public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"abner.chang@amd.com" <abner.chang@amd.com>
Cc: "Wu, Hao A" <hao.a.wu@intel.com>,
	Garrett Kirkendall <garrett.kirkendall@amd.com>
Subject: Re: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices
Date: Tue, 14 Feb 2023 02:18:12 +0000	[thread overview]
Message-ID: <MN6PR11MB8244FB08BBC5DF46A7F675E38CA29@MN6PR11MB8244.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230112051417.996-1-abner.chang@amd.com>

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Chang,
> Abner via groups.io
> Sent: Thursday, January 12, 2023 1:14 PM
> To: devel@edk2.groups.io
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Ni, Ray <ray.ni@intel.com>; Garrett
> Kirkendall <garrett.kirkendall@amd.com>; Abner Chang
> <abner.chang@amd.com>
> Subject: [edk2-devel] [PATCH V4] MdeModulePkg/Pci: Display more
> information of PCIe devices
> 
> From: Abner Chang <abner.chang@amd.com>
> 
> In V4: Update the copyright to 2023.
> In V3: Add AMD copyright.
> In V2: Remove the signed-off-by: Abner Chang
> 
> Display PCIe Vendor ID and Device ID in DEBUG message.
> 
> Signed-off-by: Jiangang He <jiangang.he@amd.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Garrett Kirkendall <garrett.kirkendall@amd.com>
> Cc: Abner Chang <abner.chang@amd.com>
> ---
>  MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> index 8eca8596958..6594b8eae83 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c
> @@ -3,6 +3,7 @@
> 
>  Copyright (c) 2006 - 2021, Intel Corporation. All rights reserved.<BR>
>  (C) Copyright 2015 Hewlett Packard Enterprise Development LP<BR>
> +Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<BR>
>  SPDX-License-Identifier: BSD-2-Clause-Patent
> 
>  **/
> @@ -227,13 +228,15 @@ PciSearchDevice (
> 
>    DEBUG ((
>      DEBUG_INFO,
> -    "PciBus: Discovered %s @ [%02x|%02x|%02x]\n",
> +    "PciBus: Discovered %s @ [%02x|%02x|%02x]  [VID = 0x%x, DID =
> 0x%0x]\n",
>      IS_PCI_BRIDGE (Pci) ?     L"PPB" :
>      IS_CARDBUS_BRIDGE (Pci) ? L"P2C" :
>      L"PCI",
>      Bus,
>      Device,
> -    Func
> +    Func,
> +    Pci->Hdr.VendorId,
> +    Pci->Hdr.DeviceId
>      ));
> 
>    if (!IS_PCI_BRIDGE (Pci)) {
> --
> 2.37.1.windows.1
> 
> 
> 
> 
> 


  reply	other threads:[~2023-02-14  2:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-12  5:14 [PATCH V4] MdeModulePkg/Pci: Display more information of PCIe devices Chang, Abner
2023-02-14  2:18 ` Ni, Ray [this message]
2023-02-14 23:27   ` [edk2-devel] " Michael D Kinney
2023-02-15  0:28     ` Chang, Abner
2023-02-15  0:40       ` Michael D Kinney
2023-02-15  0:41         ` Chang, Abner
2023-02-15  1:23     ` Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN6PR11MB8244FB08BBC5DF46A7F675E38CA29@MN6PR11MB8244.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox