[PATCH v1 0/1] Remove FP Init in UPL Entry

[PATCH v1 0/1] Remove FP Init in UPL Entry

[Dhaval Sharma]

Remove floating point initialization from UPL entry point

Cc: Gua guo <gua.guo@intel.com>
Dhaval Sharma (1):
  UefiPayloadPkg: Remove FP Init from UPL entryfunc

 UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 3 ---
 1 file changed, 3 deletions(-)

-- 
2.40.0.rc0.57.g454dfcbddf

[PATCH v1 1/1] UefiPayloadPkg: Remove FP Init from UPL entryfunc

[Dhaval Sharma]

Signed-off-by: Dhaval Sharma <dhaval@rivosinc.com>
Cc: Gua Guo <gua.guo@intel.com>
---
 UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
index 46ee27c905e9..07f4c1d29686 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
+++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
@@ -470,9 +470,6 @@ _ModuleEntryPoint (
     PrintHob (mHobList);
     );
 
-  // Initialize floating point operating environment to be compliant with UEFI spec.
-  InitializeFloatingPointUnits ();
-
   // Build HOB based on information from Bootloader
   Status = BuildHobs (BootloaderParameter, &DxeFv);
   ASSERT_EFI_ERROR (Status);
-- 
2.40.0.rc0.57.g454dfcbddf

Re: [edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Remove FP Init from UPL entryfunc

[Guo Dong]

Reviewed-by: Guo Dong <guo.dong@intel.com>

-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Dhaval Sharma
Sent: Thursday, March 2, 2023 11:12 AM
To: devel@edk2.groups.io
Cc: Guo, Gua <gua.guo@intel.com>
Subject: [edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Remove FP Init from UPL entryfunc

Signed-off-by: Dhaval Sharma <dhaval@rivosinc.com>
Cc: Gua Guo <gua.guo@intel.com>
---
 UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
index 46ee27c905e9..07f4c1d29686 100644
--- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
+++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
@@ -470,9 +470,6 @@ _ModuleEntryPoint (
     PrintHob (mHobList);
     );
 
-  // Initialize floating point operating environment to be compliant with UEFI spec.
-  InitializeFloatingPointUnits ();
-
   // Build HOB based on information from Bootloader
   Status = BuildHobs (BootloaderParameter, &DxeFv);
   ASSERT_EFI_ERROR (Status);
-- 
2.40.0.rc0.57.g454dfcbddf

Re: [edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Remove FP Init from UPL entryfunc

[Ni, Ray]

Curious about the background of this change.

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Dhaval
> Sharma
> Sent: Friday, March 3, 2023 2:12 AM
> To: devel@edk2.groups.io
> Cc: Guo, Gua <gua.guo@intel.com>
> Subject: [edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Remove FP Init from
> UPL entryfunc
> 
> Signed-off-by: Dhaval Sharma <dhaval@rivosinc.com>
> Cc: Gua Guo <gua.guo@intel.com>
> ---
>  UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
> b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
> index 46ee27c905e9..07f4c1d29686 100644
> --- a/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
> +++ b/UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c
> @@ -470,9 +470,6 @@ _ModuleEntryPoint (
>      PrintHob (mHobList);
>      );
> 
> -  // Initialize floating point operating environment to be compliant with UEFI
> spec.
> -  InitializeFloatingPointUnits ();
> -
>    // Build HOB based on information from Bootloader
>    Status = BuildHobs (BootloaderParameter, &DxeFv);
>    ASSERT_EFI_ERROR (Status);
> --
> 2.40.0.rc0.57.g454dfcbddf
> 
> 
> 
> 
> 

Re: [PATCH v1 0/1] Remove FP Init in UPL Entry

[Guo, Gua]

What's the issue you encounter ?

-----Original Message-----
From: Dhaval Sharma <dhaval@rivosinc.com> 
Sent: Friday, March 3, 2023 2:12 AM
To: devel@edk2.groups.io
Cc: Guo, Gua <gua.guo@intel.com>
Subject: [PATCH v1 0/1] Remove FP Init in UPL Entry

Remove floating point initialization from UPL entry point

Cc: Gua guo <gua.guo@intel.com>
Dhaval Sharma (1):
  UefiPayloadPkg: Remove FP Init from UPL entryfunc

 UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 3 ---
 1 file changed, 3 deletions(-)

-- 
2.40.0.rc0.57.g454dfcbddf

Re: [PATCH v1 0/1] Remove FP Init in UPL Entry

[Dhaval Sharma]

[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]

On Fri, Mar 3, 2023 at 6:05 AM Guo, Gua <gua.guo@intel.com> wrote:

> What's the issue you encounter ?
>
I will add this context in the next patchset. But primarily I am enabling
UPL for RiscV and during the process I found a few sequences which I
believe are arch specific and showing up in the common boot path.
While RV has a similar FP enabling concept, in my understanding this
enabling is required to automate (HW based) FP save/restore during process
context switches at OS runtime. Also OS (at least I confirmed
with Linux) have their own enabling process for FP. And I do not see any
instance in UPL/BDS that is making use of this feature. Also it appears
that UPL spec suggests BL performs this step.

>
> -----Original Message-----
> From: Dhaval Sharma <dhaval@rivosinc.com>
> Sent: Friday, March 3, 2023 2:12 AM
> To: devel@edk2.groups.io
> Cc: Guo, Gua <gua.guo@intel.com>
> Subject: [PATCH v1 0/1] Remove FP Init in UPL Entry
>
> Remove floating point initialization from UPL entry point
>
> Cc: Gua guo <gua.guo@intel.com>
> Dhaval Sharma (1):
>   UefiPayloadPkg: Remove FP Init from UPL entryfunc
>
>  UefiPayloadPkg/UefiPayloadEntry/UniversalPayloadEntry.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> --
> 2.40.0.rc0.57.g454dfcbddf
>
>

-- 
Thanks!
=D

[-- Attachment #2: Type: text/html, Size: 2166 bytes --]