From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C98FC780091 for ; Tue, 26 Dec 2023 02:17:25 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=3Ak8EyRjrA25wwCyJ5Eu4uQIVCKyZYeXOdAl1x5l/C0=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1703557044; v=1; b=liWcYz8EG8NcMWMcGRO756tGgotqtX6HHtiiz4nRYUaxyAqvzeIsU4+DE8qpQZAyNX1sXE5Z GpDGdmSgBBVDvrvDR74L/1HjPwXVZllD9VcGqHZaSl1TTcU2IAdC4Y/Uh2YhmbqSrLZMXWIb6e8 NhuCNgM3Y7GkegkSBX8PaLV0= X-Received: by 127.0.0.2 with SMTP id w22KYY7687511xhzuxgQTCp5; Mon, 25 Dec 2023 18:17:24 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by mx.groups.io with SMTP id smtpd.web11.73468.1703557043772975786 for ; Mon, 25 Dec 2023 18:17:23 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10934"; a="3606975" X-IronPort-AV: E=Sophos;i="6.04,304,1695711600"; d="scan'208";a="3606975" X-Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Dec 2023 18:17:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10934"; a="848312187" X-IronPort-AV: E=Sophos;i="6.04,304,1695711600"; d="scan'208";a="848312187" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Dec 2023 18:17:22 -0800 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 25 Dec 2023 18:17:22 -0800 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 25 Dec 2023 18:17:21 -0800 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 25 Dec 2023 18:17:21 -0800 X-Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 25 Dec 2023 18:17:21 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XdN4HTEybb7jfTsXP7xcy4Z08nqSVFHzqRc6GW1g6RVawz9SE9BRttjuia2YqU24LhXwWHkiksgHtKI6bkovQI6QS2VTnWUzMexseZCbrN6aEcE2ygg9QqznXUzXueRpfTTC/8q4B5XgI1iarQfBJjl9rwv7FGeWjOqGofqZgasM//OFRYcqUjIuTJJ4awbxx25kvjRWEgqc25Hg94GPcoPuwq6XPYft1LhrvSmNuMVJZThyqtJF521Qe19lIAH68wwk0UoeRhM78QeWXMpUKdsmXc8s6Ghl7EAqaYg7pvLVR0bACNxsODElIG1WaZv3UbIQr36N4uEYo/xBtISvrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6sOuWDtpfaAju+UIu5hZHISDI9t/LGgjoy4boOLrhDs=; b=RGtRDrlY+6LMvnbJZxfr2SSUWZIsjEE4qajSHS/2bSqy/J3cUJuarfyKMutyCuDHX20i2x+WwL4g65PMf79y6P+wtDf/svod3kNF7IljRR7y6fBATxZTlBnfx6vw1DnUQr1fvtIVgC8oVRsb+175MQd0Wfy5CXSxKYtKLco63JDISyt4X4JeaM309+gVbQn6FuUcd3ULGEylqKMcwLN4AS4eXNkJi1lILwNpB01HgTDxLnNmklvSkRBid7Tk0M8tyPnqNcHOHDUUhm06ap+KhSys4Jcll9XOfrROiUGrBuJHRApsh2U00mltVWWwKbHCooOtHwmpeaA/nRAiiz1jVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by DS0PR11MB7804.namprd11.prod.outlook.com (2603:10b6:8:f3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.27; Tue, 26 Dec 2023 02:17:17 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858%4]) with mapi id 15.20.7113.026; Tue, 26 Dec 2023 02:17:17 +0000 From: "Ni, Ray" To: "Wu, Jiaxin" , "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH v2 1/6] SourceLevelDebugPkg/Library: Indicate SMM Debug Agent support or not Thread-Topic: [PATCH v2 1/6] SourceLevelDebugPkg/Library: Indicate SMM Debug Agent support or not Thread-Index: AQHaN05S1dS/38nhC0unCyVOUAXNmbC61AOA Date: Tue, 26 Dec 2023 02:17:16 +0000 Message-ID: References: <20231225162034.2052-1-jiaxin.wu@intel.com> <20231225162034.2052-2-jiaxin.wu@intel.com> In-Reply-To: <20231225162034.2052-2-jiaxin.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|DS0PR11MB7804:EE_ x-ms-office365-filtering-correlation-id: 705b59b9-dc3b-4018-576c-08dc05b8c826 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: lNrnT4KdF/AL6X4AXwpJUck8W69GbmeX96YpyiDvcFQUHcuBpiCQIX5pVuMUxbfwMYy2yu7qHB1uQgwFOyT2ZG/BMNsRGI/uGHCix1iW6KRdmOPXCQUc0HRmeWXtrFgDclGOvr5J4UQ0/A55Le4og2zVQJ9kISF+S96LWkt9HXzWX1FIk4rCrDHeyclL0Myp70FxwMEAG0Kc9WWsaI0G+mFtHE9zYVbBeGZkd0CUkiXB6jnG4gMi6hiSufMAgv+6iXDHbtIzT9ihB9FAehm5GeDnmuLBpqwjzqyFsMbtVGtm2dI4A9r63zxH1O0zBDjmkuf+LLcWMsN53S37Q35PKzxO9dNIBupyNf3YCnC+qryvlPExuwjPcg/t/90iZG/FeRGTRTueUPdxHtb4z9xqSEmQg3YZgX3wLRk5pU61zYbJNKDICm8Yi1TJLZdVCZee13qU7umTNiXxhMJwx3PvDOA0YSTUgJO/utqCng5XZ0KMUlfRhyMZBibZ8ko77cOR+TYIU8bA2foGnk9OZEV9zg8IrjvsDSg37LGqUN2QgYFFvJ5nwUlAD3Jq7uS80dmDPrJzsdSJhR/3xWK7lOYzKA0R2JJbwjcb+837yHbQ3Iocz+WZ35IJwQQncx1OxCKB x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?yuRE57YKmxmMfyLp6Pfr5rOwz+nIEROoMU8IDJ1F/C8nPVaP7XXTCTzh5TQ5?= =?us-ascii?Q?kOm87mHPsNP6ViM39f9XL1/+MaVJSO8fXh+Nd68tXcQZRKFIxtdPyMUBDpJp?= =?us-ascii?Q?2SL4z4A2dFIoJqHRXCUTwzWuQNxla5XbjdHXIGsh5gGU6ynGNzWHlueJrYo6?= =?us-ascii?Q?cgb7v84Du/DirbRhyVtJu+EbaGEdJ+/GFY39CANTKCtapn9ucPRkmBOJRGNW?= =?us-ascii?Q?r/ov1h7heY94KqgcoYnkSxbcJI3QWYqkTbLk4yU1LagceJYuHTVfQ4gn8zHe?= =?us-ascii?Q?HRyn8d24yMBjwnePKRWt/52StwXfLtLOS3ohol3qth1/l/L7Y1mtBIqOFz8J?= =?us-ascii?Q?YCuVX9OipR6cssW0mwtiy/a9jqChrC1hB02FLxnKR1iKm30BhInPDjm5/FLl?= =?us-ascii?Q?/1Fsyr6+pnbLFjkUtXQOtWZKQHsw3RNAffFyh/RfWNQdAO3MUuQ+ddVRt2gH?= =?us-ascii?Q?BKqb8SpLa+ALXrPQf6lrYedwLgsYR4hBTopqGHOS01zzoKiAiH5ws107dt3+?= =?us-ascii?Q?20gveB8ZleWu4w9uUvKCvGxsifx+NobIEoXytsa2JwLrLvkoAHxV/hOzv86+?= =?us-ascii?Q?AI/zIn1O3qYzVJdapNRH6UB8bk3wHQ10+mEsegw41Z2QX8FCLJB8lfHK+fSQ?= =?us-ascii?Q?5bvaUDIdKJRmCMR+lfEHajb1JAzPRC+5lYpBmc9QZ0h8DJo13+18j/clU+J7?= =?us-ascii?Q?+OSj3MIBsRTI3kyKpbLwDYAS3U/jxRHyF5eGU6Q8fL7N2PstVJqxoo9fCdce?= =?us-ascii?Q?l6k14cUdFyAkEr+KsCHUPbgwtiU1OJNSE/kECW1pFhoVRlQuqKusZPdSBDBE?= =?us-ascii?Q?JgOBZdsdhvcVhTvnSFwcKOODIMn89eydqtOf/xglcTcDzcelPDvJG+gbuNoW?= =?us-ascii?Q?np0uKZxHhK1FtVj4dI48yzby+Hbc7r0iaYoDzs1MNbKQB91+0nnG94673hw/?= =?us-ascii?Q?LP2PlTChbw3i0fjucq+/kwDXdQk1WejgGmAu3wvMrfNyVoSrB2oknbXve2JZ?= =?us-ascii?Q?PDj5AzzjbN0R8Vgb7W94Dfvi4NKPOvFur3vV4ioLQaz3zF0K5YFJtW5E6pdL?= =?us-ascii?Q?Tw/j5kTce50/VygDRGWwl3pAczWBmYF4Bh6u3Bn2DP+xLgtl1jkeXxw2HQUv?= =?us-ascii?Q?HoOMUpdhptgdLiIcAO6RxZqvTq73E9NbPdfPX/TsTGhCLnUR0BbPb1sdrFKF?= =?us-ascii?Q?ehcUAMUkYFcMSG9hRmHzStcKpuUvObb/RAedjRp8gytLSMng19JzbyCyp33/?= =?us-ascii?Q?EA5KXDCuuU3/TjcXl359J2pCsYWeZzPkVlF5j2VcbWWgmCGYkfMtQHZYj8fY?= =?us-ascii?Q?p2q72RNk7lod8CUe+xB/0ybQq6BQNKTzid42+GwWmlvuY4otVKeuBlhyQVd3?= =?us-ascii?Q?uoLLiYd/dZC9ehCcuyQzHQ66Z5JE87MeM6EnTcj9Na+DzyIjVuMqob8nluHx?= =?us-ascii?Q?PYpOmgRX75e6CbOIUot8fT9XhdZtuSq/j+C/gMj9GKuT+q8FyOxLx0EqESY5?= =?us-ascii?Q?qfUk0O1YNO+A0uXxMAPjfRfuYrdG0tQXcyjJh/scBqv46vceloDiOYcEafrV?= =?us-ascii?Q?hdRMZLIi4uP5E0KvAMg=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 705b59b9-dc3b-4018-576c-08dc05b8c826 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Dec 2023 02:17:16.9416 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: E5UpChIm553b4WsWPfmNOA9DlKiHvEiK89n0Fvpqz+wHQED3xl3PxMtfVXrCocYL1lGGWGNwn2ObClA5Tf03NA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7804 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 26jAv4TCZBPk5vx9o9lmbAiqx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=liWcYz8E; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Jiaxin, I missed one minor issue in offline review. Check below. Thanks, Ray > + it will override IDT table entries and initialize debug port. Context = must > + point to a BOOLEAN if it's not NULL, which indicates SMM Debug Agent > supported The comment says Context must point to a BOOLEAN "if it's not NULL". So, it's ok to be NULL. Then, the code below should modify the Context memory only when it's not NU= LL. With this change added, Reviewed-by: Ray Ni -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112899): https://edk2.groups.io/g/devel/message/112899 Mute This Topic: https://groups.io/mt/103360802/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-