From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.35264.1686879303469324442 for ; Thu, 15 Jun 2023 18:35:03 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=aiT6rSNO; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686879303; x=1718415303; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Nt9E0e7Ca7c6RVOE6Zk2dbz1FTjBjTKiLCaZca487kI=; b=aiT6rSNOKy/FOX4B0f2L0pZeblV5ApKO58ak/y8NKTnf3D+YcmxDH7d7 SOTMQC9wpFvXZq6prOTXoiub/carfzgGtVGfQDbYmB7HdOSo1ESLu11yc GatkP7mc2Tk0EOh2FJNopJSWFOyfqjeGakqlWX4rarygAvWxO5rHH+ykg RlIZEYT18eDTw/3Z9dCn4JJnFUdzb3vB0R1ci7OzyR8YYE6El33nFNDp0 SWng5AxTGOYWyuk26thAq9MhsAfQVMPSHPexLtzfMjzFgsFUXvWJaoQMQ ckSeeDUXzdpr3+xv8+Wd2rtr6u5z4hK3pI0fJ8h8r9jowMcg1rSPf1b5c w==; X-IronPort-AV: E=McAfee;i="6600,9927,10742"; a="348796051" X-IronPort-AV: E=Sophos;i="6.00,246,1681196400"; d="scan'208";a="348796051" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jun 2023 18:35:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10742"; a="712673612" X-IronPort-AV: E=Sophos;i="6.00,246,1681196400"; d="scan'208";a="712673612" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga002.jf.intel.com with ESMTP; 15 Jun 2023 18:35:02 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 15 Jun 2023 18:35:02 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 15 Jun 2023 18:35:01 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 15 Jun 2023 18:35:01 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.104) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 15 Jun 2023 18:35:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jhVbUnNtJhxioBbYANsC9vrdO4CsIl9yd6GOvNwuJTZLwkn/lgJjB91w9SMv5+2s5FOQnnZFAwLy4QlQmG7GvMWXrSkJjCVh92bkLvKMN5o8IQ32UGoS2ntCDhYjvKZ66RzVlkdYccTGRYLyF1olWyKpmm7sDq0t71VHG1odnEhf6BHU5Nj+HSqDIaKfDy+JQr9VUDYz0PWXtymc0uUtbFcLMqYPUQcFd65iAqSQBVwOcHTs26aZHJ52sD/48E33QfagBNACoEo8UrZxO56e5uKw2uwDtHYqPR6mG6kihhDlsk1sk8ZbSCaHKqlL7D28mEfKCZFQfwcuRrjHTAE/iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=L9zpZl/23w0TJC+EPP5aPNuDwxCtv7RUN0lZ0pRnxh8=; b=gQ/TpjPyFmzMrxcIFaASQqYVAzkS0B0inyQIUwqPAZEH16FlN7nlI6jS6PwXGCsGW3JX3OaYQ/IJ5XZ9m6C3tl4QlBupO9XqBqHPvl+hxcxgLGGTvttgAFiitnDRl6psHB0b+LLzN4JHJbzmZG9u58J84X/iFgfo/GPor7Zs84hRqc0it6AHQSFJAY89A1uwR+89iK3ZSc1T/AQHUBwyPvLwS74VBV4qJ9vwaMAKD8uzMZeYdgF/QD5ysUUgS8e+NkYiulLytncb2ZMQEkgqV6x0BJnDxPRHVUwqtQ7IBNBRCfRUT9H4unVhS1pO4qQ99V8V9CqEe3EhygZeNm5SXg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by MN2PR11MB4664.namprd11.prod.outlook.com (2603:10b6:208:26e::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.27; Fri, 16 Jun 2023 01:34:54 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d%2]) with mapi id 15.20.6455.034; Fri, 16 Jun 2023 01:34:54 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "abdattar@amd.com" , Gerd Hoffmann CC: Paul Grimes , Abner Chang , "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann , "Kinney, Michael D" , "Gao, Liming" , "Liu, Zhiguang" , "Ard Biesheuvel" , "Yao, Jiewen" , "Justen, Jordan L" Subject: Re: [edk2-devel] [PATCH v14 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib Thread-Topic: [edk2-devel] [PATCH v14 0/8] Adds AmdSmmCpuFeaturesLib and MmSaveStateLib Thread-Index: AQHZmD1JlDbj9OpVo0u/ANYVGD6XrK+IaF4wgARMekA= Date: Fri, 16 Jun 2023 01:34:54 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|MN2PR11MB4664:EE_ x-ms-office365-filtering-correlation-id: c959799a-7eb0-4b9a-5b82-08db6e09e312 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: LMqxSYKITzIqc6nUUrhGDD/QsOz8UY1Wj6h50r+nAi9mOXqf41Y3tFP9gAkcWVD4pX2PFs/Bn2y6sor4pJ8cP1zLG7NeM8+dLTBJ7EH/jG+75DrAQVB1ERIzJdVDJnp9Iso4HjDdLSV6f0gj3EqZux4eJ/O3cI3vbWqZRkfoAk+oAwn5uHZRpM29yrzeA8jG1bw284VhJsi1AwGt7mf8OxNhO4XpTNY7OQJ+NeBOYG+7SvjBqvfcAUFcC5BVRXDpBYuO3pNxsbC8QGkhdEv9dxvhkxotk4d1jJScD8REGuoQITovHk8XfhwdZw977Sg5sO2nnShV8/KRAXjUfxNSZaY8ezRWYibBQUaoohZnEBV6Le+JbxEP4v4BqEzJtC5uVm66mZzBw3HX3PaTxzPwcDyrzPUAgBtej5cD9+bcCI6CrG6tGg5VNwRxZftJttK3axs7Pl9JnDb2AG2n5THVKrxu0Y6BCjdm+3hnbCJqcBCZ6TbNcivpx1K+xRYB41ly4P8bOkZLbr6aH1u1VE/pHnk6ST+opMCoChvD0Lk863m/mYpAhI96Oqvybenrs3Dlz/68YYcjsVwd7roltfv24GzCbZliYj+WNal6wNkqAgedyQG5jhFAMICk8yVWY4EYcN9Xyj6/qgBscShOXpubvn2eIbiF9IewNBhg9T3ZbiA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(6029001)(39860400002)(136003)(346002)(366004)(376002)(396003)(451199021)(52536014)(5660300002)(966005)(83380400001)(38100700002)(82960400001)(122000001)(6506007)(2906002)(186003)(53546011)(26005)(107886003)(9686003)(38070700005)(478600001)(55016003)(66556008)(64756008)(66946007)(66476007)(316002)(33656002)(71200400001)(8936002)(66446008)(7696005)(86362001)(41300700001)(8676002)(4326008)(76116006)(54906003)(110136005)(19627235002)(66899021)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mNHIbIrpAVDrIOJaO4z5XN78lWe+aPfG4qiZUMK0wV9N2q1XnQipPA0PEBkE?= =?us-ascii?Q?XTf7WRV6cARjEWKdc/L+IITLwZggiu37WIfIaJmv0NwJUzGVRRHUPZMVFphA?= =?us-ascii?Q?ytTR3JWqQ3V9BvR7w9m1GbnTykFdyLHoCTDGXJCUXyTLpVSajKOD4A/UFQoA?= =?us-ascii?Q?Kxiw0IredrOQOVq9PrzVmwbULBsTJJ3Q50/XBbCDNM5tEWZ7XZBXbfMrWg/Z?= =?us-ascii?Q?MNON1WpWza0iE0nkpZTwPIzLY64Gykyuf9vRYkdwLZlJpp7ZQhWg7EkBpQjC?= =?us-ascii?Q?F1ihkcYDazGvUUrTKWkjigrTl1Hn+IdXzmyXjaNKvGlSQJVd7R5WaBhD/ODJ?= =?us-ascii?Q?DTSLHf8Y0b8ZZt/y/BanmFHUj+GKqPkZbSeUWy/n3+T/0cbMu4W2weqfCB8D?= =?us-ascii?Q?PR4arqtD9uQzcjjR47lztEYPvxJv1LeGGSo0tlrD2aB/ey7/O9Ams4cxTDQ0?= =?us-ascii?Q?brQt1wVc8OMLg3WxTceJjmhNME5MhmezS7QFSJtohxTKsSMlIRWIAYdvDPkq?= =?us-ascii?Q?TrCi++CA+MG2kIOtsKVaugbVS7cLYo/C/tT+nKBSXr7b9lXlCXClkJWgcc+0?= =?us-ascii?Q?m4npAH+hzsS9DM4KGLlJGak9ogbEqFBL1DdUsrbdIgAb46CswS6Vq8JEoRPU?= =?us-ascii?Q?Li6orh6u32NVNMQa8SPMa7s6dB/zQCRxVijc78A2mn09EMrSxEEGM69aD0XP?= =?us-ascii?Q?7LhkF8REwFvNRlL3cyhPyBEfcelWJOT22kxwN5gxy3+o28ecamaKYlcIHA5n?= =?us-ascii?Q?4QOmBOjk8iA3gDj6MMy24OTT/GyJmpEJmY2+10VLCNUTLr7nYGwMu3jLGork?= =?us-ascii?Q?YyV9MGEj9hdQrx93IddaZomdKejqcT/vHf2r8QCmgD+qjnI2/ZUvi+6FZfEW?= =?us-ascii?Q?qDEoadVHnQ4Mo9rynXFihFUonZyzcnpU/PH89WEsCge/B165vlDB4hA4hcOl?= =?us-ascii?Q?vM3gP+sgHn8ro0jL8XBYYpMhfzNmUj/Ptbqy1SYSaCp2JjrdB5tUlZF0DykF?= =?us-ascii?Q?NqZZ0ea4rxTpWtKfUVvWuvpNizw5dEvjBLJlw/MbEcjRxMp4o2H0ClZGKvpI?= =?us-ascii?Q?GgldQ9rWTZvZ0/I/Wp66IzfW+VlWmymiN8JV2lc3YHDRhWLN6jEzyZC4aeFj?= =?us-ascii?Q?TAIUcVsx7JwwJyoB3DvUsoZlKrqPn//p7BuZqkVmqdPxWJ0pSflol5cWqk5j?= =?us-ascii?Q?znIv0dl170A3n1UCz+2jo1YID020cIW/XuoOVQOFPHjigMTnW+XDeVRltlXE?= =?us-ascii?Q?av397igWhRpYMrTaqm1/qKQKKCSJWFHYZKRHd0zpChcjpGye8BDM6eOCL201?= =?us-ascii?Q?M7krBdxgz+V+rKEDaPSGn/pPCBRhxH0iMTZ2CeVEaZc7JCvYSPPDTimZmvIo?= =?us-ascii?Q?jKptvRGYdMOiMlG88OVsYgEAWvuW+p/0YMbkrv7QUDtiRLB8kCDm3e4OEMLU?= =?us-ascii?Q?bmC8ZW5gfYHhGAED6pO/DaVSVP2zrtnGbfrEi3e2SQpx8k0WJg4ci5AIYQbe?= =?us-ascii?Q?BvwFuh+y379gJTZjFaqaZQM6yG0YZFCHQ31xiH2sqkWzcjJ82eG/UqMTcKA+?= =?us-ascii?Q?Z6wye6K0AhHLuRyCAno=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c959799a-7eb0-4b9a-5b82-08db6e09e312 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jun 2023 01:34:54.6045 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: F7AfQUF/ZIV/NUlad3GUhW8mBa9FRRbnoNVq4Lkqzi6TY04XW2NUUEvkcHsYWmFRJdkBeQogh/IAaX0dfJRRrw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB4664 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Gerd, Can you kindly provide "Reviewed-by" for the patch series? Thanks, Ray > -----Original Message----- > From: Ni, Ray > Sent: Tuesday, June 13, 2023 3:56 PM > To: devel@edk2.groups.io; abdattar@amd.com > Cc: Paul Grimes ; Abner Chang > ; Dong, Eric ; Kumar, Rahul R > ; Gerd Hoffmann ; Kinney, > Michael D ; Gao, Liming > ; Liu, Zhiguang ; Ard > Biesheuvel ; Yao, Jiewen > ; Justen, Jordan L > Subject: RE: [edk2-devel] [PATCH v14 0/8] Adds AmdSmmCpuFeaturesLib and > MmSaveStateLib >=20 > Reviewed-by: Ray Ni >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Abdul > Lateef > > Attar via groups.io > > Sent: Tuesday, June 6, 2023 2:07 PM > > To: devel@edk2.groups.io > > Cc: Abdul Lateef Attar ; Paul Grimes > > ; Abner Chang ; Dong, > Eric > > ; Ni, Ray ; Kumar, Rahul R > > ; Gerd Hoffmann ; Kinney, > > Michael D ; Gao, Liming > > ; Liu, Zhiguang ; Ard > > Biesheuvel ; Yao, Jiewen > ; > > Justen, Jordan L > > Subject: [edk2-devel] [PATCH v14 0/8] Adds AmdSmmCpuFeaturesLib and > > MmSaveStateLib > > > > Backward-compatibility changes: > > This patch series removes the SmmCpuFeaturesReadSaveStateRegister > > and SmmCpuFeaturesWriteSaveStateRegister interface/function. > > SmmReadSaveState() and SmmWriteSaveState() now directly invokes > > MmSaveStateLib > > routines to save/restore registers. > > > > PR: https://github.com/tianocore/edk2/pull/4519 > > > > V14: Delta changes > > Added @note to the MmSaveStateLib.h. > > SaveState(Read/Write) of > > > EFI_SMM_SAVE_STATE_REGISTER_PROCESSOR_ID/EFI_MM_SAVE_STATE_REG > IS > > TER_PROCESSOR_ID > > is handled by PiSmmCpuDxeSmm driver. > > Fixed PatchCheck warnings. > > V13: Delta changes > > Address review comments from Ray Ni > > Changed the BASE _NAME of AmdSmmCpuFeaturesLib. > > Removed EFIAPI from local function. > > Removed CpuIndex parameter from MmSaveStateGetRegisterLma > > Modifed MmSaveStateGetRegisterIndex () to accept RegOffset > > as second parameter. > > Removed FILE_GUID library instance for intel implemention from > > UefiCpuPkg.dsc. > > V12: > > Addressed review comments from Michael. > > Added LibraryClasses to .inf file. > > removed duplicate MACRO definations. > > Moved related MACRO defination to respective file. > > V11: Delta changes > > Drop the OVMF implementation of MmSaveStateLib > > V10: Delta changes: > > Addressed review comments from Abner. > > V9: Delta changes: > > Addressed review comments. > > Rename to MmSaveStateLib. > > Also rename SMM_ defines to MM_. > > Implemented OVMF MmSaveStateLib. > > Removes SmmCpuFeaturesReadSaveStateRegister and > > SmmCpuFeaturesWriteSaveStateRegister > > function interface. > > V8 delta changes: > > Addressed review comments from Abner, > > Fix the whitespace error. > > Seperate the Ovmf changes to another patch > > V7 delta changes: > > Adds SmmSmramSaveStateLib for Intel processor. > > Integrate SmmSmramSaveStateLib library. > > V6 delta changes: > > Addressed review comments for Ray NI. > > removed unnecessary EFIAPI. > > V5 delta changes: > > rebase to master branch. > > updated Reviewed-by > > V4 delta changes: > > rebase to master branch. > > added reviewed-by. > > V3 delta changes: > > Addressed review comments from Abner chang. > > Re-arranged patch order. > > > > Cc: Paul Grimes > > Cc: Abner Chang > > Cc: Eric Dong > > Cc: Ray Ni > > Cc: Rahul Kumar > > Cc: Gerd Hoffmann > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Zhiguang Liu > > Cc: Ard Biesheuvel > > Cc: Jiewen Yao > > Cc: Jordan Justen > > Cc: Abdul Lateef Attar > > > > Abdul Lateef Attar (8): > > MdePkg: Adds AMD SMRAM save state map > > UefiCpuPkg: Adds MmSaveStateLib library class > > UefiCpuPkg: Implements MmSaveStateLib library instance > > UefiCpuPkg/SmmCpuFeaturesLib: Restructure arch-dependent code > > UefiCpuPkg: Implements SmmCpuFeaturesLib for AMD Family > > UefiCpuPkg: Implements MmSaveStateLib for Intel > > UefiCpuPkg: Removes SmmCpuFeaturesReadSaveStateRegister > > OvmfPkg: Uses MmSaveStateLib library > > > > UefiCpuPkg/UefiCpuPkg.dec | 4 + > > OvmfPkg/OvmfPkgIa32.dsc | 1 + > > OvmfPkg/OvmfPkgIa32X64.dsc | 3 + > > OvmfPkg/OvmfPkgX64.dsc | 1 + > > UefiCpuPkg/UefiCpuPkg.dsc | 13 + > > .../MmSaveStateLib/AmdMmSaveStateLib.inf | 34 + > > .../MmSaveStateLib/IntelMmSaveStateLib.inf | 34 + > > .../AmdSmmCpuFeaturesLib.inf | 38 + > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 2 + > > .../Include/Register/Amd/SmramSaveStateMap.h | 194 +++++ > > UefiCpuPkg/Include/Library/MmSaveStateLib.h | 74 ++ > > .../Include/Library/SmmCpuFeaturesLib.h | 52 -- > > .../Library/MmSaveStateLib/MmSaveState.h | 94 +++ > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 56 +- > > .../SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 767 ------------------ > > .../Library/MmSaveStateLib/AmdMmSaveState.c | 309 +++++++ > > .../Library/MmSaveStateLib/IntelMmSaveState.c | 410 ++++++++++ > > .../MmSaveStateLib/MmSaveStateCommon.c | 132 +++ > > .../SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.c | 387 +++++++++ > > .../IntelSmmCpuFeaturesLib.c | 70 ++ > > .../SmmCpuFeaturesLibCommon.c | 128 --- > > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 11 +- > > UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 500 +----------- > > MdePkg/MdePkg.ci.yaml | 4 +- > > 24 files changed, 1810 insertions(+), 1508 deletions(-) > > create mode 100644 > > UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveStateLib.inf > > create mode 100644 > > UefiCpuPkg/Library/MmSaveStateLib/IntelMmSaveStateLib.inf > > create mode 100644 > > UefiCpuPkg/Library/SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.inf > > create mode 100644 > MdePkg/Include/Register/Amd/SmramSaveStateMap.h > > create mode 100644 UefiCpuPkg/Include/Library/MmSaveStateLib.h > > create mode 100644 UefiCpuPkg/Library/MmSaveStateLib/MmSaveState.h > > create mode 100644 > UefiCpuPkg/Library/MmSaveStateLib/AmdMmSaveState.c > > create mode 100644 > UefiCpuPkg/Library/MmSaveStateLib/IntelMmSaveState.c > > create mode 100644 > > UefiCpuPkg/Library/MmSaveStateLib/MmSaveStateCommon.c > > create mode 100644 > > UefiCpuPkg/Library/SmmCpuFeaturesLib/AmdSmmCpuFeaturesLib.c > > > > -- > > 2.25.1 > > > > > > > >=20 > >