public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Bret Barkelew <Bret.Barkelew@microsoft.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>, Eric Dong <eric.dong@intel.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Hao Wu <hao.a.wu@intel.com>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Andrew Fish <afish@apple.com>, Jiewen Yao <jiewen.yao@intel.com>,
	Michael D Kinney <michael.d.kinney@intel.com>,
	Laszlo Ersek <lersek@redhat.com>, Star Zeng <star.zeng@intel.com>,
	David Wei <david.wei@intel.com>
Subject: Re: [Patch 00/10] Add BmpSupportLib class and instance
Date: Sun, 11 Feb 2018 00:16:49 +0000	[thread overview]
Message-ID: <MW2SPR01MB06B7A18E0D03E8F3A00363EFF00@MW2SPR01MB06.namprd21.prod.outlook.com> (raw)
In-Reply-To: <20180207225822.28876-1-michael.d.kinney@intel.com>

Approved.
Reviewd-By: Bret Barkelew Bret.Barkelew@microsoft.com

- Bret

From: Kinney, Michael D<mailto:michael.d.kinney@intel.com>
Sent: Wednesday, February 7, 2018 2:58 PM
To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
Cc: Ruiyu Ni<mailto:ruiyu.ni@intel.com>; Eric Dong<mailto:eric.dong@intel.com>; Ard Biesheuvel<mailto:ard.biesheuvel@linaro.org>; Hao Wu<mailto:hao.a.wu@intel.com>; Jordan Justen<mailto:jordan.l.justen@intel.com>; Andrew Fish<mailto:afish@apple.com>; Jiewen Yao<mailto:jiewen.yao@intel.com>; Michael D Kinney<mailto:michael.d.kinney@intel.com>; Laszlo Ersek<mailto:lersek@redhat.com>; Star Zeng<mailto:star.zeng@intel.com>; David Wei<mailto:david.wei@intel.com>
Subject: [edk2] [Patch 00/10] Add BmpSupportLib class and instance

https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D800&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C8f2b7148ac5c4d774a9f08d56e7e4fd2%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C1%7C636536411170052762%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=E96biwS3Q8OTee365hQJScLXa%2Fb7yBGC7IiVxO5A9aM%3D&reserved=0

Branch for review:
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmdkinney%2Fedk2%2Fcommits%2FBug_800_BmpSupportLib_V2&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C8f2b7148ac5c4d774a9f08d56e7e4fd2%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C1%7C636536411170052762%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=6qpw0S0fJ9pOARdFzlE8p15OKZGKTTOkZOb%2BjD9FutI%3D&reserved=0

Based on content from the following branch/commits:
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2FMS_UEFI%2Ftree%2Fshare%2FMsCapsuleSupport&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C8f2b7148ac5c4d774a9f08d56e7e4fd2%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C1%7C636536411170052762%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=WTOBgpOsBidzuSJVVDtc691afJ%2BMDANyaMHEFBCWl14%3D&reserved=0
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2FMS_UEFI%2Fcommit%2F33bab4031a417d7d5a7d356c15a14c2e60302b2d&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C8f2b7148ac5c4d774a9f08d56e7e4fd2%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C1%7C636536411170052762%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=uQiy6y4TpMcOBU0uFvQOL21j7Hk7vJrShwcZQARzFXQ%3D&reserved=0
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2FMS_UEFI%2Fcommit%2Fca516b1a61315c2d823f453e12d2135098f53d61&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C8f2b7148ac5c4d774a9f08d56e7e4fd2%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C1%7C636536411170052762%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=jlakW5VAPCJ9l0TS6xyCA0HO6nTj555FOi7bh5VGKow%3D&reserved=0
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoft%2FMS_UEFI%2Fcommit%2F2b9f111f2e74a4c2ef4c4e32379e111f016dbd9b&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C8f2b7148ac5c4d774a9f08d56e7e4fd2%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C1%7C636536411170052762%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=BuD2uK61vuVRagd12PXDWQAvaf%2BBuU2e3jP3NjFZOKo%3D&reserved=0

Add BmpSupportLib class and instances that provides services to
convert a BMP graphics image to a GOP BLT buffer and to convert
a GOP BLT buffer to a BMP graphics image.

Cc: Sean Brogan <sean.brogan@microsoft.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Cc: Eric Dong <eric.dong@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: David Wei <david.wei@intel.com>
Cc: Mang Guo <mang.guo@intel.com>
Cc: Kelly Steele <kelly.steele@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Cc: Andrew Fish <afish@apple.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>

Kinney, Michael D (1):
  MdeModulePkg: Add BmpSupportLib class and instance

Michael D Kinney (9):
  MdeModulePkg/DxeCapsuleLibFmp: Use BmpSupportLib
  MdeModulePkg/BootGraphicsResourceTableDxe: Use BmpSupportLib
  IntelFrameworkModulePkg/GenericBdsLib: Use BmpSupportLib
  OvmfPkg: Add SafeIntLib and BmpSupportLib to DSC files
  Vlv2TbltDevicePkg/Override/GenericBdsLib: Use BmpSupportLib
  QuarkPlatformPkg: Add SafeIntLib and BmpSupportLib to DSC files
  DuetPkg: Add SafeIntLib and BmpSupportLib to DSC files
  EmulatorPkg: Add SafeIntLib and BmpSupportLib to DSC files
  ArmVirtPkg: Add SafeIntLib and BmpSupportLib to DSC files

 ArmVirtPkg/ArmVirt.dsc.inc                         |   4 +-
 DuetPkg/DuetPkgIa32.dsc                            |   4 +-
 DuetPkg/DuetPkgX64.dsc                             |   4 +-
 EmulatorPkg/EmulatorPkg.dsc                        |   2 +
 .../IntelFrameworkModulePkg.dsc                    |   4 +-
 .../Library/GenericBdsLib/BdsConsole.c             | 250 +--------
 .../Library/GenericBdsLib/GenericBdsLib.inf        |   3 +-
 .../Library/GenericBdsLib/InternalBdsLib.h         |   3 +-
 MdeModulePkg/Include/Library/BmpSupportLib.h       | 105 ++++
 .../BaseBmpSupportLib/BaseBmpSupportLib.inf        |  49 ++
 .../BaseBmpSupportLib/BaseBmpSupportLib.uni        |  20 +
 .../Library/BaseBmpSupportLib/BmpSupportLib.c      | 583 +++++++++++++++++++++
 .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.c       | 268 +---------
 .../Library/DxeCapsuleLibFmp/DxeCapsuleLib.inf     |   3 +-
 .../DxeCapsuleLibFmp/DxeRuntimeCapsuleLib.inf      |   3 +-
 MdeModulePkg/MdeModulePkg.dec                      |   6 +-
 MdeModulePkg/MdeModulePkg.dsc                      |   3 +
 .../BootGraphicsResourceTableDxe.c                 | 425 +++++++--------
 .../BootGraphicsResourceTableDxe.inf               |   4 +-
 OvmfPkg/OvmfPkgIa32.dsc                            |   2 +
 OvmfPkg/OvmfPkgIa32X64.dsc                         |   2 +
 OvmfPkg/OvmfPkgX64.dsc                             |   2 +
 QuarkPlatformPkg/Quark.dsc                         |   4 +-
 .../Library/GenericBdsLib/BdsConsole.c             | 251 +--------
 .../Library/GenericBdsLib/GenericBdsLib.inf        |   3 +-
 .../Library/GenericBdsLib/InternalBdsLib.h         |   3 +-
 Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc            |   4 +-
 Vlv2TbltDevicePkg/PlatformPkgIA32.dsc              |   4 +-
 Vlv2TbltDevicePkg/PlatformPkgX64.dsc               |   4 +-
 29 files changed, 1018 insertions(+), 1004 deletions(-)
 create mode 100644 MdeModulePkg/Include/Library/BmpSupportLib.h
 create mode 100644 MdeModulePkg/Library/BaseBmpSupportLib/BaseBmpSupportLib.inf
 create mode 100644 MdeModulePkg/Library/BaseBmpSupportLib/BaseBmpSupportLib.uni
 create mode 100644 MdeModulePkg/Library/BaseBmpSupportLib/BmpSupportLib.c

--
2.14.2.windows.3

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.01.org%2Fmailman%2Flistinfo%2Fedk2-devel&data=04%7C01%7CBret.Barkelew%40microsoft.com%7C8f2b7148ac5c4d774a9f08d56e7e4fd2%7Cee3303d7fb734b0c8589bcd847f1c277%7C1%7C1%7C636536411170052762%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwifQ%3D%3D%7C-1&sdata=%2FU%2B%2FtWTELfUVLVfOv5iEzYX%2Bsla09a2GUVrAqcZfQUU%3D&reserved=0



  parent reply	other threads:[~2018-02-11  0:11 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-07 22:58 [Patch 00/10] Add BmpSupportLib class and instance Kinney, Michael D
2018-02-07 22:58 ` [Patch 01/10] MdeModulePkg: " Kinney, Michael D
2018-02-08  5:10   ` Zeng, Star
2018-02-07 22:58 ` [Patch 02/10] MdeModulePkg/DxeCapsuleLibFmp: Use BmpSupportLib Kinney, Michael D
2018-02-07 22:58 ` [Patch 03/10] MdeModulePkg/BootGraphicsResourceTableDxe: " Kinney, Michael D
2018-02-07 22:58 ` [Patch 04/10] IntelFrameworkModulePkg/GenericBdsLib: " Kinney, Michael D
2018-02-07 22:58 ` [Patch 05/10] OvmfPkg: Add SafeIntLib and BmpSupportLib to DSC files Kinney, Michael D
2018-02-07 23:17   ` Laszlo Ersek
2018-02-07 23:48     ` Kinney, Michael D
2018-02-08  0:35       ` Laszlo Ersek
2018-02-08  7:43         ` Ard Biesheuvel
2018-02-08  8:32           ` Jordan Justen
2018-02-08  9:25             ` Laszlo Ersek
2018-02-08  9:32               ` Ard Biesheuvel
2018-02-08  9:47                 ` Laszlo Ersek
2018-02-08  8:55           ` Laszlo Ersek
2018-02-07 22:58 ` [Patch 06/10] Vlv2TbltDevicePkg/Override/GenericBdsLib: Use BmpSupportLib Kinney, Michael D
2018-02-07 22:58 ` [Patch 07/10] QuarkPlatformPkg: Add SafeIntLib and BmpSupportLib to DSC files Kinney, Michael D
2018-02-07 22:58 ` [Patch 08/10] DuetPkg: " Kinney, Michael D
2018-02-07 22:58 ` [Patch 09/10] EmulatorPkg: " Kinney, Michael D
2018-02-08  8:33   ` Jordan Justen
2018-02-07 22:58 ` [Patch 10/10] ArmVirtPkg: " Kinney, Michael D
2018-02-07 23:25   ` Laszlo Ersek
2018-02-11  0:16 ` Bret Barkelew [this message]
2018-02-11  0:19 ` [Patch 00/10] Add BmpSupportLib class and instance Bret Barkelew

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MW2SPR01MB06B7A18E0D03E8F3A00363EFF00@MW2SPR01MB06.namprd21.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox