From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web10.3332.1587137036133977242 for ; Fri, 17 Apr 2020 08:23:56 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=GdW53Tg1; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: erik.c.bjorge@intel.com) IronPort-SDR: HqooxXPP3INBgQ11w3PyOHWyyYGNJMfEHefIXweUyCVmOag63Uf8+Z6N+P9vkVP2vS1sTEsPPe gIGABOf0NTtw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2020 08:23:55 -0700 IronPort-SDR: KQ4xmwyMw5Wy6AYLmmN+1xvUCiVhA9aczUl5bdUTjaklqznprfHYl4K1z/+rhi23OcXhS/Xn3A 9s22Qb/BIvSQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,395,1580803200"; d="scan'208";a="364355978" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga001.fm.intel.com with ESMTP; 17 Apr 2020 08:23:53 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 17 Apr 2020 08:23:53 -0700 Received: from NAM02-BL2-obe.outbound.protection.outlook.com (104.47.38.56) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 17 Apr 2020 08:23:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KOkN6FgdTwTBuO3QD/dZZzv9fWncr0dv94UjqjH0lFRLrvfiItte5c57SdPwVjRwkgU1EnhGC1sxAIZOxkXCRGIlFVaRdE4V6H4fiOM7FJNq6cxdEiSuG6m36xdEVtXFGe2X5UTG3IoK0ptghc9cRLw8R0bmqpjx+fitgB5Z0yQDPUcCXf66sUREv3fS/psqPY7won8QdUdNhTz14G5zLisU9XuQLf29XIy2EnkZmIPIUNbMsYZhqYeEfJuWE5CQZGYkoF+6A1gRbG0o9uXqPMJV6K2r3Bq0g/xDzQB1zXnFXJJypMkuODKjF7u2OSsY0weeOdpjKXAwoEMKM7J2QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bx+F/YHLVR17fApIieXRSFZrWL2d0MiueMGmlXnqSJ0=; b=Pg1oFAz90wV54vTl2qjKZiwl9b5P6ufXy12IZmRw/gFQDEGhET/ChtnZbqoF54SFUdsl7aS7aYb3RYNfzqGl/59oK7VxzaZ/yVT5ptt9ZBxQ7cYM3ratwfJWMWlPn5Lc3lhmbcB0jySEz+WTiUxopc3ltInVqyUS8j8dig5v4ktAhPItbHelz2kblUwXh/hPhLkyzcDxl784hRpKtfoh1RcJ6hdo/RHM13ITLzKWWkVOsRCRG+z1EP8iwnuP9i/jxUBhwAxNPTOgEO7owB5iTVIxkW7doOP1Mue7cztUhETCDcFd9Q8ucR11aqzjlhrIYizk8FYVyWar2ODMbvXA1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bx+F/YHLVR17fApIieXRSFZrWL2d0MiueMGmlXnqSJ0=; b=GdW53Tg1XRqhXmyLAGaNW+/jsn5b7tUx1hlXPh/6hatP6A7Mu32FouQ9uZ3aDfTTeWO8mtUge/8qeNNyYGIshGCDrNjS/4Osap+J7Ado9yVNi5MQxhDB+35DxiV2hVfND3ahMWGjh+ybFgURwho1uzdL3/tsA1zEAThHLNNGR9U= Received: from MW3PR11MB4554.namprd11.prod.outlook.com (2603:10b6:303:5d::7) by MW3PR11MB4617.namprd11.prod.outlook.com (2603:10b6:303:59::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2921.29; Fri, 17 Apr 2020 15:23:51 +0000 Received: from MW3PR11MB4554.namprd11.prod.outlook.com ([fe80::c569:9903:4c10:9281]) by MW3PR11MB4554.namprd11.prod.outlook.com ([fe80::c569:9903:4c10:9281%5]) with mapi id 15.20.2921.027; Fri, 17 Apr 2020 15:23:51 +0000 From: "Bjorge, Erik C" To: "Desimone, Ashley E" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Pandya, Puja" , Bret Barkelew , "Agyeman, Prince" Subject: Re: [edk2-staging/EdkRepo] [PATCH 6/6] EdkRepo: Add 'get' functions for Manifest Repo data Thread-Topic: [edk2-staging/EdkRepo] [PATCH 6/6] EdkRepo: Add 'get' functions for Manifest Repo data Thread-Index: AQHWFGi9eB4nMX63+kq38g5aQ3GSYKh9b4iw Date: Fri, 17 Apr 2020 15:23:51 +0000 Message-ID: References: <20200417033123.34972-1-ashley.e.desimone@intel.com> <20200417033123.34972-7-ashley.e.desimone@intel.com> In-Reply-To: <20200417033123.34972-7-ashley.e.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: spf=none (sender IP is ) smtp.mailfrom=erik.c.bjorge@intel.com; x-originating-ip: [192.55.52.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8f65f857-39a4-4f4c-ae8e-08d7e2e35596 x-ms-traffictypediagnostic: MW3PR11MB4617: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-forefront-prvs: 0376ECF4DD x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4554.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(366004)(136003)(376002)(346002)(39860400002)(396003)(478600001)(66946007)(66476007)(9686003)(8676002)(66556008)(64756008)(66446008)(71200400001)(81156014)(8936002)(76116006)(55016002)(107886003)(4326008)(54906003)(7696005)(316002)(86362001)(26005)(110136005)(2906002)(33656002)(5660300002)(186003)(52536014)(6506007)(53546011);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XTnrQ1e2U43HY9n9sK1fypwoh/jRcuCiXezSNv4Ps7ax+zC9QXXmxlY/zdGkVF5N1g9p6nY4YXEm3gvq9Eo3m5l97LuA/Ci7FYBfUKe/aEmAEh7Ee1X/X3ymzkhIMDKTFv6tIgFy3ARjTXWg55jjNQjuQxkSF9hoa8nnUMxMrHnf9Gs0b5jzOkTj0FMcbDI7bccOF7X5asUC94KCI1EBu1JcgHkB5iJlnnoc5JNjIUh19NlbC6XzssmteEE6RWfByh730UK98PMEU7qCBQcv60RvCUb7HEcv2dDgp/PE/941zbu8RGb+EzSvGNQyAhu/kyPrFUffNi8cptui2+H5/lS48oOGWPiSoF1VH2nYCVfaGELnXSjBbP/0XNXwpnq0tb+K6l8/EI5cvHVq75fsFKJ04ivatTXZifMd2JhhVrBstxxa8h7OgeyOq6gVgZkY x-ms-exchange-antispam-messagedata: JfKzl4xMGVHriDOGxUG4HQcZSXRNGgtDdN5wZwJBUIa6MSDJbKZd4S+YCRRj8Vsn1FUmBamHBg9To0vRRsxcJrMAghUs/+j42nNBC42Pkbjj2ej4UXRRTxjrRn7mnh83ANYonuM/6Qodo73mTEwF7Q== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 8f65f857-39a4-4f4c-ae8e-08d7e2e35596 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2020 15:23:51.6013 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: O/g/QCHgHfCUYJ4SwoMJLuKlUPkFj6ArpGdHxRh7cyavg0uw545lrCBobuP03e6FBdoBuc1mSg8vYwcCsM2eKg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4617 Return-Path: erik.c.bjorge@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Erik Bjorge -----Original Message----- From: Desimone, Ashley E =20 Sent: Thursday, April 16, 2020 8:31 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barke= lew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH 6/6] EdkRepo: Add 'get' functions fo= r Manifest Repo data Added functions to get the URL, LocalPath, Branch and the absolute path for= individual manifest repositories to the BaseConfig class. Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Cc: Prince Agyeman --- edkrepo/config/config_factory.py | 37 ++++++++++++++++++++++++++++++++++++= + 1 file changed, 37 insertions(+) diff --git a/edkrepo/config/config_factory.py b/edkrepo/config/config_facto= ry.py index a4daba3..022e0bb 100644 --- a/edkrepo/config/config_factory.py +++ b/edkrepo/config/config_factory.py @@ -131,6 +131,43 @@ class BaseConfig(): repo_props.append(prop) return repo_props =20 + def get_manifest_repo_url(self, manifest_repo): + """=20 + Returns the URL value for a given manifest repo based on config + file contents. + """ + for prop in self.manifest_repo_props(manifest_repo): + if 'URL' =3D=3D prop.key: + return self.cfg[prop.section][prop.key] + return None + + def get_manifest_repo_branch(self, manifest_repo): + """ + Returns the Branch value for a given manifest repo based on config= file + contents. + """ + for prop in self.manifest_repo_props(manifest_repo): + if 'Branch' =3D=3D prop.key: + return self.cfg[prop.section][prop.key] + return None + + def get_manifest_repo_local_path(self, manifest_repo): + """ + Returns the Local path value for a given manifest repo based on co= nfig + file contents. + """ + for prop in self.manifest_repo_props(manifest_repo): + if 'LocalPath' =3D=3D prop.key: + return self.cfg[prop.section][prop.key] + return None + + def manifest_repo_abs_path(self, manifest_repo): + """ + Returns the absolute path of a single manifest repo based on confi= g + file contents and the global_data_dir location. + """ + return os.path.join(self.global_data_dir,=20 + self.get_manifest_repo_local_path(manifest_repo)) + class GlobalConfig(BaseConfig): """ Class access structure for the edkrepo.cfg file. This file is read on= ly and maintained by the -- 2.16.2.windows.1