From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.3772.1587155256753129637 for ; Fri, 17 Apr 2020 13:27:36 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=KB3dRIFa; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: erik.c.bjorge@intel.com) IronPort-SDR: o1Gl3qxbfENRvk1yCHIPpoTBylR0wOFrCBjUSMj1wd/qYdvpRkw4GjaOpgQNnf/1wSaCBbcmDz EoEIeCRBxT+A== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2020 13:27:36 -0700 IronPort-SDR: LQbik3wZEwMprM8vW8kdbQWcWHhAMJfawlJnPLdJzqrHUHd3B322fcdx3evSz/rPPU5r6ziJA7 a1Qib+rGkm3g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,395,1580803200"; d="scan'208";a="454842227" Received: from orsmsx110.amr.corp.intel.com ([10.22.240.8]) by fmsmga005.fm.intel.com with ESMTP; 17 Apr 2020 13:27:36 -0700 Received: from ORSEDG001.ED.cps.intel.com (10.7.248.4) by ORSMSX110.amr.corp.intel.com (10.22.240.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 17 Apr 2020 13:27:35 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 17 Apr 2020 13:27:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i8xowqRXZooM93dBzrslmIS71CMHLUuVI8mk1zo8VJDEIJPKlkBlbMXbWrlXcYu14l3+u51V/TYJ6vuL1j+NRfR4vcgaASs9lpXWgLUYjilkLeWUJd0Ra77mTgDbbmsxHFOXuYgYrOfaoXzp7WIyEH7k4jn4Y4QCJPa3PJJUtLMKhqiIRtbTGAja1xEJuVnHcYSkuoFKUGRJNjtfgDhb4MiRjA/SVaroeb+5A7kcX6Mc85GVp/XVqGiPCR56hZL8ORtH9NHOu1kumYfVNsiZyFJRon1rOi46sR9HwQQ0yoLhC2pFasozk1ojVfZ1ML50xX9F+4DlhWPisNyPXhUdIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h6jEqYjwbLTs3cVgd9BFaVVYNgsbLHw6af6bCOUxWvg=; b=d36Bwr/Tdn9R+t+4dSdpM60mDf3y5IsUNfTsvs8R54KBM1JmgXQn6e+AupHEEWvJ2pnq45BrBX01kgf5wtuB9VZNjqzYvYDBav5V74qwb5dxHwmhMgSaP7zr4JQqVRSgERJS1D8Uj7JHE05BzCZubTJnJLgR0Hvhfr/+EVpQsKAbHO8wpb+GYYc3+3SuvDfCyLvkzn5w3iTU3r5Jf1n9V7LZITkvpi1RAZKfdVylkiBHCPVATpm1t2jk4gjluaKXtaCHnSGbJ3iwJpcorSl12vkPfeRFF3FV2myqecVSB+8gNapHe+vw7twuv7a7HfGsoqMzOE9yKYwG3JlurwQcLg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h6jEqYjwbLTs3cVgd9BFaVVYNgsbLHw6af6bCOUxWvg=; b=KB3dRIFaYIFekYraSRilYUyT3njoo5/3NyS9ui3t22iMRWL2ArRCzlUmfCyQBXecq8/4rR2D7g1V1nFdZmr/OrKVDQeUk9FU3+HyDyo/j+agGYmWola+maXDdPODA2Q1mKyOTY2jL8glQgtcOIBG4NmgzMI6snmRhlb28kANGWs= Received: from MW3PR11MB4554.namprd11.prod.outlook.com (2603:10b6:303:5d::7) by MW3PR11MB4761.namprd11.prod.outlook.com (2603:10b6:303:53::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.26; Fri, 17 Apr 2020 20:27:35 +0000 Received: from MW3PR11MB4554.namprd11.prod.outlook.com ([fe80::c569:9903:4c10:9281]) by MW3PR11MB4554.namprd11.prod.outlook.com ([fe80::c569:9903:4c10:9281%5]) with mapi id 15.20.2921.027; Fri, 17 Apr 2020 20:27:34 +0000 From: "Bjorge, Erik C" To: "Desimone, Ashley E" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Pandya, Puja" , Bret Barkelew , "Agyeman, Prince" Subject: Re: [edk2-staging/EdkRepo] [PATCH v2 6/6] EdkRepo: Add 'get' functions for Manifest Repo data Thread-Topic: [edk2-staging/EdkRepo] [PATCH v2 6/6] EdkRepo: Add 'get' functions for Manifest Repo data Thread-Index: AQHWFNxLrJWSi++p30ek4wN0vlZeC6h9w4Cg Date: Fri, 17 Apr 2020 20:27:34 +0000 Message-ID: References: <20200417171829.23032-1-ashley.e.desimone@intel.com> <20200417171829.23032-7-ashley.e.desimone@intel.com> In-Reply-To: <20200417171829.23032-7-ashley.e.desimone@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: spf=none (sender IP is ) smtp.mailfrom=erik.c.bjorge@intel.com; x-originating-ip: [192.55.52.194] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 13790a10-93c4-4b90-ede1-08d7e30dc379 x-ms-traffictypediagnostic: MW3PR11MB4761: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3044; x-forefront-prvs: 0376ECF4DD x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4554.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(10019020)(376002)(366004)(39860400002)(396003)(346002)(136003)(71200400001)(8676002)(81156014)(110136005)(54906003)(4326008)(7696005)(316002)(8936002)(478600001)(86362001)(55016002)(9686003)(2906002)(107886003)(53546011)(6506007)(186003)(66556008)(26005)(33656002)(52536014)(5660300002)(66946007)(66446008)(64756008)(66476007)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vbhlREXsu57rVWnhoHHd1XQcXgpWuHclNVZu4cf3l3E0rbtc8DH3mVOv5jjzwMrgxvARcOVLolgoTLu5hzPUNDt3CwyDNwPc+Tr3UbGJqkoZ1/I12nbbIWkYxi8W70thl+ox3UcoVy+bmwmEYqKp7O/FwQBeX8Kt9L4UwwkcTD/yx4AcKG9sg+vJw71tbuxCXh8S8t4UZABs/f5bypRX7O22i9zeZRGN4/3pq/bAIyAs3YNXJtuIlUkgUgfDPAUu4AeSKzcJumIpjMveA7Et3i/NCieN3FDJAu0X2KORRZ2F/QYDU1xzJy9GMY3DGc1TdcO3Dhq9JeprMOk08rx+cDgKUkVskTf2t8mPccFPGs4D+UAxiPdLwXAgob+FygMl7EC1GYdc1OaUU/FAOoNTz/7NXh6L4pfvakVr1mfQ6zcbk+GRBC6JH3QTjkB0Dgfh x-ms-exchange-antispam-messagedata: WhpoTzJrb0rBkX+/PCMKvoFXUazwyE3Jt2nd88rTlJjEDi1LH/StSOEip3yYLp0lb3vAVqxW2kcoTSG5CMUdcRAIvSpR7HsVcuzQv1BZCafEQcIqYN5Qr1fenVE4Tcq/ENdlr5VMoFyge4gm4q8C6Q== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 13790a10-93c4-4b90-ede1-08d7e30dc379 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Apr 2020 20:27:34.8707 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: B6y2oal3YfyHTeddwom5Y/g3w+cMDUZVM0FnV4Rqw/qjtYuM5IAKyawOnQrHZr21bRLM3h6mx8XND67ckwvg9g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4761 Return-Path: erik.c.bjorge@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Erik Bjorge -----Original Message----- From: Desimone, Ashley E =20 Sent: Friday, April 17, 2020 10:18 AM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barke= lew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH v2 6/6] EdkRepo: Add 'get' functions= for Manifest Repo data Added functions to get the URL, LocalPath, Branch and the absolute path for= individual manifest repositories to the BaseConfig class. Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Cc: Prince Agyeman --- edkrepo/config/config_factory.py | 37 ++++++++++++++++++++++++++++++++++++= + 1 file changed, 37 insertions(+) diff --git a/edkrepo/config/config_factory.py b/edkrepo/config/config_facto= ry.py index 4ae06f6..90f393c 100644 --- a/edkrepo/config/config_factory.py +++ b/edkrepo/config/config_factory.py @@ -127,6 +127,43 @@ class BaseConfig(): """ return [x for x in self.prop_list if manifest_repo in x.name] =20 + def get_manifest_repo_url(self, manifest_repo): + """=20 + Returns the URL value for a given manifest repo based on config + file contents. + """ + for prop in self.manifest_repo_props(manifest_repo): + if 'URL' =3D=3D prop.key: + return self.cfg[prop.section][prop.key] + return None + + def get_manifest_repo_branch(self, manifest_repo): + """ + Returns the Branch value for a given manifest repo based on config= file + contents. + """ + for prop in self.manifest_repo_props(manifest_repo): + if 'Branch' =3D=3D prop.key: + return self.cfg[prop.section][prop.key] + return None + + def get_manifest_repo_local_path(self, manifest_repo): + """ + Returns the Local path value for a given manifest repo based on co= nfig + file contents. + """ + for prop in self.manifest_repo_props(manifest_repo): + if 'LocalPath' =3D=3D prop.key: + return self.cfg[prop.section][prop.key] + return None + + def manifest_repo_abs_path(self, manifest_repo): + """ + Returns the absolute path of a single manifest repo based on confi= g + file contents and the global_data_dir location. + """ + return os.path.join(self.global_data_dir,=20 + self.get_manifest_repo_local_path(manifest_repo)) + class GlobalConfig(BaseConfig): """ Class access structure for the edkrepo.cfg file. This file is read on= ly and maintained by the -- 2.16.2.windows.1