From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web12.3786.1611885321338724424 for ; Thu, 28 Jan 2021 17:55:21 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Z04yzBAU; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: aiden.park@intel.com) IronPort-SDR: fMVxAssS5vJ0Ozf00cIxbAESh+rveO89qUMAOxCEuV58r4u2NJsUGVeK+UMGm0b592JXOBqMDF IhnRuUNdokfA== X-IronPort-AV: E=McAfee;i="6000,8403,9878"; a="199187133" X-IronPort-AV: E=Sophos;i="5.79,384,1602572400"; d="scan'208";a="199187133" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jan 2021 17:55:20 -0800 IronPort-SDR: N3IStzVwfh/AUN/stZQF3kBMg3EV7vj/iP1hBVGE4pOUsEnZ13uluVAAbUn+humoxiRpghjRLN ggtnzKooLkkQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,384,1602572400"; d="scan'208";a="573864517" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga005.jf.intel.com with ESMTP; 28 Jan 2021 17:55:20 -0800 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Thu, 28 Jan 2021 17:55:19 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Thu, 28 Jan 2021 17:55:19 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 28 Jan 2021 17:55:17 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BLVn5ouC0/H7fKkmQku5Qnf9O4bJ308tPunWl5GLzA4yvSzwlqEhzoMl8Ge1TleA+E6tuHutmde++gIed2Q3DlAEm3QcCsnvb1V8olNcywVWsLdvjuhGpi4AeAmMDV1BkZ0QSGNabAS4T8FlX66oyPm/Mybydx724NCjXSy0PmV488oiMmqD2LzebBK8Y10TEFE97kspRasDEsqUUM4uSVOzApCfvG4unUiRg8uxP3V+9YX/8xHnYnydNt/fvkWQOVyfATyg8eVwGGI5OZXZiUAsaPCUBCsNUqk6pc8MbIPmfTlk3ITqb/mXphgsgTwsAywsXOSsXdRtu3r+eOl6jQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YLz9zLNnclG0Q8v5r80QynNqlu7qYvDYFqOf6ZGc1kY=; b=dzLGgiXFQh7kMm39+FTDifnx10S7S2JZu+YgUhdShq77Coh50G2p2f/Vt5XVx0c/jm9GxnLMX591mD5/IAmvnvsJzqOFG/VZk0SnUScRDypjeZZJvcTxtI8hSbVZhfAE73CH5oB+rNen2tlg8ydJbiOi+QJlarw7AFkhOGTT03P02tcrIbC+8uyjDF2jY+wHuliHX55DSnZ2z8cYJVHRj6PM4dBcIpBORGN3DhZJBgxo1aTU6zU+tfguZuNpo8mC/mvUCIgyVSkra5bKDZ1cef5N6w7YCMHeITxIaYDpDBRi0AIvHdBdC9LcUwGdun7ds1m3FIu2uqhPNm7Uhv8uZg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YLz9zLNnclG0Q8v5r80QynNqlu7qYvDYFqOf6ZGc1kY=; b=Z04yzBAUhEOD0bkvIOqpmTbMRAoifWI79VZ33grM5EoaZxguHobTQpkUjl/Hr2VtTYi+5dHNka5WU2FYCRzeuZ1+i/NQx8N8ZTuX5Ln+9ZddDr4h+b1LBayjRo8RKsKYtoicz1Lmx8TUWl1o4gb688gRKET+5LZTNHBmBm6Ty9Y= Received: from MW3PR11MB4570.namprd11.prod.outlook.com (2603:10b6:303:5f::22) by CO1PR11MB5154.namprd11.prod.outlook.com (2603:10b6:303:95::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3805.17; Fri, 29 Jan 2021 01:55:17 +0000 Received: from MW3PR11MB4570.namprd11.prod.outlook.com ([fe80::d1b1:838a:7ea7:539c]) by MW3PR11MB4570.namprd11.prod.outlook.com ([fe80::d1b1:838a:7ea7:539c%3]) with mapi id 15.20.3805.017; Fri, 29 Jan 2021 01:55:17 +0000 From: "Park, Aiden" To: "Wu, Hao A" , "Ni, Ray" , "devel@edk2.groups.io" CC: "Ma, Maurice" , "Dong, Guo" Subject: Re: [PATCH] MdeModulePkg/PciBusDxe: Fix a bug in ProcessOptionRomLight Thread-Topic: [PATCH] MdeModulePkg/PciBusDxe: Fix a bug in ProcessOptionRomLight Thread-Index: AQHW6d6AQ3LFTbh7y0KOHFNEbRuNK6o97p9A Date: Fri, 29 Jan 2021 01:55:16 +0000 Message-ID: References: <20210113190114.19888-1-aiden.park@intel.com> In-Reply-To: <20210113190114.19888-1-aiden.park@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [162.213.76.84] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 26cf4cd9-820e-4e45-0f65-08d8c3f8ed20 x-ms-traffictypediagnostic: CO1PR11MB5154: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +HuWzEfMa0qfOvwOmKsu3DDQQ5CG8ETAPVX8Zy7d2L78qJvIi89LoJHtDtPAInrktllAsjV7EAKclsiIg9akA9B6cfRCd7pffoi8bGFXhWxpjq4KY1Ubctth2RHgKO8WxWmGknZrVK+2wVvafT3dWHi+YnTFPqC4/dnscYSNAucZvFAauwp4BtlvYABs3AefylT1voBeuX+ukQ4MOnKHEE3Jd/wQ2yIigfb3F2HpBfzicBgCesZo5tjlQqzyDkD6LNYFrfnDQkEmx0UYOgOdAumvpOeWhDsrm9YrVi+swqbDcFx2sTUzSk3Sup9V5t9/y5y5Iw1zcZbPcz+NDicfEumP6n2Btt+wOZT/t0x6DhT+dZwqwNQXirA5Hgz4tgCPCDblSGtiLwiAD54jEC+sESze//25zBIM/pJbeuo9xcFHFoPWegJI35B9hx/BoFIptWCPcZNHGVvEbRPtBq+kUag1mPdzm4gLANLL1RPXFZLX1he/iXgkDOwAFuDtRAcAfVhScDSl2wqCw91aN45eGQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4570.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(136003)(346002)(376002)(366004)(39860400002)(396003)(71200400001)(55016002)(9686003)(107886003)(478600001)(7696005)(2906002)(8936002)(8676002)(4326008)(86362001)(53546011)(33656002)(66946007)(66476007)(316002)(66556008)(64756008)(26005)(186003)(66446008)(6506007)(76116006)(110136005)(54906003)(83380400001)(5660300002)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ipWjF7TnYzZRCLo8ME/G1htFnVNXcpEeAX6ZU7pde3WvKzZA81ZXhslBnACR?= =?us-ascii?Q?fVx53Dnhy43eLGrqf8AWiyAmOnW6bByLZddXJf+ni+xD6w7BEePBeM2D9EYx?= =?us-ascii?Q?88U6QzuL1J0cTz2jenYdr0VXmzQkLz4cmKH5nZ967ISe2o49sjjMD/dfWPO3?= =?us-ascii?Q?2YQSFAknE5jPY/8IdTROtBdw1KZMQdun9FJMCpYsokp8sNZflDGnl7d3iXHN?= =?us-ascii?Q?kgMYWsBdVUbp5SG4Nqa43NUOS3EaXDCGrHaGNiy4+C+LKdm1Gb05tvW5vpUX?= =?us-ascii?Q?ivpBsETxsiSgaT5Af/ISSywJapeMZXXD3SzCiLZF0OLUaREkgAl4yCAN1jAo?= =?us-ascii?Q?NsNYgklGIknkOkpyZbl5s2bYsSjYAam/mlaJqyNh3gfHr/C+SJ7O6/oa0Yp1?= =?us-ascii?Q?GL+a3lS9Fu+Sj4W+AJGmse2aCz3WqEbv8Bod9BvILMEm3ErRX2VFTmOsSCKm?= =?us-ascii?Q?BdtpDhJ0WSCEcZtBu38l2jqR1Okv+vmo3Fl5ctxss0EIrsaBGOaSyqjAQVWt?= =?us-ascii?Q?kyLxcEh6GhtrA1g/Z7NnEhpqwjru7v1A5jUy1fdg1cE/56sfl46WUZPDtoI7?= =?us-ascii?Q?4mnRtoxIJ1NTIhbNDuQ0ZhPJRdTtP6eMq8RMnDOSZmabEx8vJJ4aBPHZXmLy?= =?us-ascii?Q?LDvpbbxeOBT51qtsXEQB/Xk+9Tl3xPdjBAPjv4IfgdQTSpBkpoMi+5wvfTGU?= =?us-ascii?Q?ezrGtZ47qdi+Ghp4FAwoeDMpJL9WjbesP+UMCLcFfOj6ES7SdQPrhY6CJ4dW?= =?us-ascii?Q?EiZ7Tgom88bfG/UhUzH11LxbXAYQc1hKcIUsttY9wwoi+Gh16qyK6qIuiOHQ?= =?us-ascii?Q?6lxLqDPjRJpn24Afs8UJicmguIxOKzXHWJNnTJY1A64Zu8qKOIPpLW/LL/KR?= =?us-ascii?Q?3YTQC+rFgBzDN8HyIPcazDbtITp6dN9TZs4lHwyIBdaq45GGlv+FxQYA7Fpx?= =?us-ascii?Q?E3Aw9imauYwJwiDnapm9BwlAFmvD+kIpBcm10oes3cQgdhQfUkxmR+GzapSK?= =?us-ascii?Q?gVUoMgFKCNw4qdo+E9vTxM23rvMkob+RLcMtR+WxdIGswCQ8NL2Xw04xo6Ug?= =?us-ascii?Q?FM5qEvFR?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4570.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 26cf4cd9-820e-4e45-0f65-08d8c3f8ed20 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jan 2021 01:55:16.9217 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Xvm05nxJXyzlYyG4C7v+CfaeVwmQHRSi/WC9l3q/h4XRPBQQ16wRTGpnSexBs4fsuG+t7pADxIZwnQ9TR3rWlg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5154 Return-Path: aiden.park@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hello, Can you please review this? > -----Original Message----- > From: Park, Aiden > Sent: Wednesday, January 13, 2021 11:01 AM > To: Wu, Hao A ; Ni, Ray ; > devel@edk2.groups.io > Cc: Park, Aiden ; Ma, Maurice > ; Dong, Guo > Subject: [PATCH] MdeModulePkg/PciBusDxe: Fix a bug in > ProcessOptionRomLight >=20 > From: Aiden Park >=20 > The ProcessOptionRomLight() assumes that OpRom has already been processed > in the previous full enumeration and updates AllOpRomProcessed flag to TR= UE > by default. However, this may not be applicable with other pre-stage boot > firmwares. >=20 > This will update AllOpRomProcessed flag properly by checking > PciRomGetImageMapping(). >=20 > Signed-off-by: Aiden Park > --- > MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) >=20 > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c > index 1b64924b7b..e8337e865e 100644 > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c > @@ -1168,12 +1168,7 @@ ProcessOptionRomLight ( > ProcessOptionRomLight (Temp); > } >=20 > - PciRomGetImageMapping (Temp); > - > - // > - // The OpRom has already been processed in the first round > - // > - Temp->AllOpRomProcessed =3D TRUE; > + Temp->AllOpRomProcessed =3D PciRomGetImageMapping (Temp); >=20 > CurrentLink =3D CurrentLink->ForwardLink; > } > -- > 2.20.1 Best Regards, Aiden