From: "Bjorge, Erik C" <erik.c.bjorge@intel.com>
To: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Desimone, Ashley E" <ashley.e.desimone@intel.com>,
"Pandya, Puja" <puja.pandya@intel.com>,
"Bret Barkelew" <Bret.Barkelew@microsoft.com>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Display commands alphabetically
Date: Tue, 31 Mar 2020 22:59:32 +0000 [thread overview]
Message-ID: <MW3PR11MB4571B24ADFA102923A531C2DAEC80@MW3PR11MB4571.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200327203126.28208-1-nathaniel.l.desimone@intel.com>
Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>
-----Original Message-----
From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Sent: Friday, March 27, 2020 1:31 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E <ashley.e.desimone@intel.com>; Pandya, Puja <puja.pandya@intel.com>; Bjorge, Erik C <erik.c.bjorge@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>; Philippe Mathieu-Daudé <philmd@redhat.com>
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Display commands alphabetically
Currently edkrepo --help shows a listing of commands that is not in alphabetical order. This is confusing.
This change makes the list shown in alphabetical order.
Cc: Ashley DeSimone <ashley.e.desimone@intel.com>
Cc: Puja Pandya <puja.pandya@intel.com>
Cc: Erik Bjorge <erik.c.bjorge@intel.com>
Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
---
edkrepo/commands/composite_command.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/edkrepo/commands/composite_command.py b/edkrepo/commands/composite_command.py
index b476445..ff53d3b 100644
--- a/edkrepo/commands/composite_command.py
+++ b/edkrepo/commands/composite_command.py
@@ -36,4 +36,4 @@ class CompositeCommand(object):
command_names = []
for command in self._commands:
command_names.append(command.get_metadata()['name'])
- return command_names
+ return sorted(command_names)
--
2.25.2
prev parent reply other threads:[~2020-03-31 22:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 20:31 [edk2-staging/EdkRepo] [PATCH] EdkRepo: Display commands alphabetically Nate DeSimone
2020-03-27 22:28 ` Desimone, Ashley E
2020-03-31 22:59 ` Bjorge, Erik C [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW3PR11MB4571B24ADFA102923A531C2DAEC80@MW3PR11MB4571.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox