From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web09.1168.1624925442551610196 for ; Mon, 28 Jun 2021 17:10:42 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=j+HrIIGG; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: rangasai.v.chaganty@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10029"; a="206235159" X-IronPort-AV: E=Sophos;i="5.83,307,1616482800"; d="scan'208";a="206235159" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2021 17:10:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,307,1616482800"; d="scan'208";a="557756227" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP; 28 Jun 2021 17:10:41 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 28 Jun 2021 17:10:40 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Mon, 28 Jun 2021 17:10:40 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Mon, 28 Jun 2021 17:10:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BC+5EYSzbIWWIjoltqrw8R+qGfl14EtpkL5+diFU/WFj//Wr0toavxoyV82IA+1FIXjP35FCGgRjrVTEdIUOzqZT9fwOPijN0It5rdfvz/mv50g73jlszTadC83KpYEoh5LKR4Ch1GqDfI14OeBWlBYPydboCXJrNp3hOT/rQE7sxpms9tk+Yo/ZTD6Jfytugilo6TEivvJoHxzeaaCGwj8u0z7L4qoSgbOc6vqo24Opo5FngT7TwEsL2MQMphiiLkRUQ2p4dcr8oQvEI56KchMuk5HeDcgtJL36ftJxQ+tgDFRHLChz0mhOS4KC5J+3SjI3DB6/eUu1x2+TF8zbnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bkUeSLSuD1tvv42K02TKvCJMC/TRkr+nCtfg7yUErCY=; b=mlHh3+TJgKea0AwMjbdBKjYSdAPI44T0QgnoSyjNvimtDwIKdWxxOojCUJU/yBKMsUV5cUC7E7vr4LcYcMtUMK5gULye/wmfhUYDEMPDAjLRsDmQoy3eBo9JgWHBV7xBDj+HapNr1a7iWDWMeoTTcjvU3Olflns2Cj5bCMbj9syV6vtQvsNrORZWDamZEPHZPCGVYRrTRm0Pat3VITkeMZ0n0kshzbcZ+7kIa2soRWAUroPlm05W5E8I/xeYM2OkQIT2WVDwAwncZZNWChELrGySr4awDzU07ArZRnTgezFgSvSqVZ15TmqQ4zlbqWYJwC1ys2rceDShE3hFanrQ4g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bkUeSLSuD1tvv42K02TKvCJMC/TRkr+nCtfg7yUErCY=; b=j+HrIIGG/5cvHOdKIY+urBjkcft4Whwt1ywR294+8Qv2JVf+BjF2I3cjv7bDwamxiPo2L507PwSZc8ruoZsVDLn8gSzq4guqa2jrgBz6s/M7G1cbin80FWGFj3ls4o74sijV79Q/GaIcmJ4hQWpUwnTfU4walPabijEj9YMH0pk= Received: from MW3PR11MB4602.namprd11.prod.outlook.com (2603:10b6:303:52::19) by CO1PR11MB4849.namprd11.prod.outlook.com (2603:10b6:303:90::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18; Tue, 29 Jun 2021 00:10:39 +0000 Received: from MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::451e:1727:7108:3873]) by MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::451e:1727:7108:3873%9]) with mapi id 15.20.4264.026; Tue, 29 Jun 2021 00:10:39 +0000 From: "Chaganty, Rangasai V" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Kethi Reddy, Deepika" , "Esakkithevar, Kathappan" Subject: Re: [edk2-platforms][PATCH v4 20/41] CometlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib Thread-Topic: [edk2-platforms][PATCH v4 20/41] CometlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib Thread-Index: AQHXaghAHcUy2t5NP0mMqjrioJHZ6qsqIkXg Date: Tue, 29 Jun 2021 00:10:39 +0000 Message-ID: References: <20210625212120.235-1-mikuback@linux.microsoft.com> <20210625212120.235-21-mikuback@linux.microsoft.com> In-Reply-To: <20210625212120.235-21-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.45.159.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 64c96d8d-be26-48e0-b983-08d93a9253c0 x-ms-traffictypediagnostic: CO1PR11MB4849: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2oYc7MVEMo/3QxJM/2e4UN0RaE2lr3m22ehgCKdwdTyo+AhLFREhGoOFYVexZe8Kmc3R+ow/YlTQeUJQEskUYUjqiVBUzCyYCsEihUJzVrTBak4gUDjEWBuMOaLGGtZat6jNXO4EtFVEzajW6+ZsgDzpB7zWON//xIic15Iz8EKKzaJg/vbvHHj03HExkhMy5rYSTrteLzDyMc/m5QNCX3gElDLpaPicSAY8lEn8Es2hGErp91J0AaVgckZ14NN0riLkLBMMZTPPgmIl7hlD0+oDShTtTkbIfn295vvLADep02rJ9zQ+Wbz1zfLSieXxTpiv3eOF6csT2ZXfVAdMxfRgEhBBOeQ1khsIJlXRVqDbFPZNVLd4kzWebb/LWaUfHqHh7ZuqMPfkKfLInzTTcIqEPX/mIo5rOlgYNI4sZCSnYwc/9S6SE8JOEawvdKJFYPFF3+lwL0yx7a7VfvE4ypWitEpMsoXm4L+kfZdLB3mdku7n/9CVWMNAO5a+kBKA00JyV8vrOXb56xRJy2Q22UU+yKGmFaCfJJe/GB0fiByGwiw0SPrfrY1ClCyA9Dm2srBWlLWuQvs2unkr+UrHFJLVOs4qekDZ5cM0bLY16ct5reiNkTKzOrKVTk47mi7w65KDIL74XdkcRr0ni21UB9+NR29wZ8cwCJdI4DM4XUPlpzZyfhVoM8MUuZFL0MKFCiqMEKm5jMOQOn2DSDTN+XcCTh05u7kdMwtS+87xKOpFHlToFBqBAv5WIgxdKeoW0R1L4KI/NpHbh/EdFSeFkg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4602.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(39860400002)(396003)(376002)(346002)(136003)(366004)(186003)(83380400001)(8676002)(8936002)(38100700002)(26005)(122000001)(71200400001)(316002)(110136005)(54906003)(5660300002)(86362001)(15650500001)(33656002)(6506007)(53546011)(66446008)(64756008)(66556008)(7696005)(52536014)(66946007)(478600001)(76116006)(4326008)(2906002)(55016002)(9686003)(66476007)(107886003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vW5FZhOZ0uJCAbGMUqbb0AxYxIafK4TnzUppmsv/DyJWlDeH+ZPmvEwj502g?= =?us-ascii?Q?IaMeTDSGXdNoLOxrQzlGhazE+FGExLRVRyj+CbD0IVNXdeEoIHKU+BdnkY7P?= =?us-ascii?Q?kG0tk3Lp+gRIQ1DQC6vSXU6BQxji5RAbpjgm03ZG0LLMOJ0ynVqsJhMulKIi?= =?us-ascii?Q?iDxq4gBCFFmMaubI8CQccGLj65CmkSbef6sPpyRzlmcd2sgpTJGvBegMxmGo?= =?us-ascii?Q?f5xmTujcKn6C8q1S+gp47jhPv0u0FhyBmqZRn+99ula9W4RIR1gONKEnG62w?= =?us-ascii?Q?Oy3Y74G4BA1a7puF3trwyScdrLWJRkoo0JAkQlOXuEmvrihqydGwuwTN2Zv2?= =?us-ascii?Q?DtH+5Ed88mPRHZIPcZ8JQdfmmCZti/1EpxcLpeg3OPfXAfQc6my3tLV989GP?= =?us-ascii?Q?JwaBjUXjI8WXCOQUVz/clxUTvHOBur8xb+mAf+WDT0D94ER91s1wUS5QTLGi?= =?us-ascii?Q?wMAoewqkQGRTZlv2GoYBYg/T90wZ1DEZysLf3DSxUDvu9g7dPMclmEatdX4F?= =?us-ascii?Q?TSFy1cUwwXnuLbpcy3m/vVCg3hexIBIhxm1JjA3/tahBN3ftZ9LnYbc7yvho?= =?us-ascii?Q?BaaowVIu0rVsqUhFE1DxGDV1048fQR8RHXT4FM12NFCELIiR1eKTTqhEuDtT?= =?us-ascii?Q?/uIAhhETidUk2+4fMLDYapkwaYnvBVvbA6Wvp92okzVgiu2v0bQfv+QomVXl?= =?us-ascii?Q?0OwqbXWfMwBEjfegN3JLYIkTgMNXg65DKs1cimAF+M3eDhFp4zS9hmf+gvB5?= =?us-ascii?Q?2yVODk8rFTYw58yrNhYIvt+681ux1fDUpZGqza+KQoLsqoGD1fnWLP/lhCYH?= =?us-ascii?Q?fxVG7VDd1yGXlM3gJW4P7MGvF8nbldHxQrXGnFFbGxhyz8CIJ38hslBk/XVa?= =?us-ascii?Q?1DFsMkJPZLGbW+BEjTZ7s602O+vE5eRHtqvxhIRBe/WL/a2aRiURDL3dcL07?= =?us-ascii?Q?cMD3HnAKc9pBz+B2VtcQCOTK60suhVw0CidJoKswjK1sxfTPTcXLY1uJ/xLo?= =?us-ascii?Q?ENSRHwa3f2pyBzbuBzEemkCdzXg4U/vqVXszERvqdv8zcXEyU34ryhRyJDQj?= =?us-ascii?Q?Z9PpUyv4LDXE9lZrAKc3/DhS8fUrJDjvJnZmiinGZJDgmGI0ubxhu4F5/1Dg?= =?us-ascii?Q?mo+PmG3SWCJ8v2TzXllq4KoyoEjlX5uagJ988fKqdtkqUrp1msjWYIpe2Eac?= =?us-ascii?Q?2akrynvjmMCERBBJ2W5sAI8W62lgPNMa/0wAS56kMWIAFNIMhhgkDQ9mt4Za?= =?us-ascii?Q?tjGoxsii8kBEiw7/kCoJRn1HfgBmAZ2v2RLXiBp4WaWgNX5VVRBgNhMl3Vp4?= =?us-ascii?Q?abMEVQZE2fnjgzDkKb1GKdMH?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4602.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64c96d8d-be26-48e0-b983-08d93a9253c0 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2021 00:10:39.2848 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: D1ocuxPbZ/wtUV9SakyqM+Ms7b0lzZnwPHth59D8cVhm9B96y/752JcYc+AKaXDOaQgIoWBEq78UIv36bnXSz2pS4bp1dm6XzAeBVoTwn38= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4849 Return-Path: rangasai.v.chaganty@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sai Chaganty =20 -----Original Message----- From: mikuback@linux.microsoft.com =20 Sent: Friday, June 25, 2021 2:21 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Chaganty, Rangasai V = ; Kethi Reddy, Deepika ; Esakkithevar, Katha= ppan Subject: [edk2-platforms][PATCH v4 20/41] CometlakeOpenBoardPkg: Update Spi= FvbService & SpiFlashCommonLib From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 Updates CometlakeOpenBoardPkg to use the SmmSpiFlashCommonLib instance in I= ntelSiliconPkg and the SpiFvbServiceSmm driver in IntelSiliconPkg. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Rangasai V Chaganty Cc: Deepika Kethi Reddy Cc: Kathappan Esakkithevar Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone Reviewed-by: Chasel Chiu --- Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 7 ++= +++-- Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf = | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPk= g.dsc b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc index 44a1bd54d6e9..316100e9a599 100644 --- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc +++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.ds +++ c @@ -254,7 +254,7 @@ [LibraryClasses.X64.DXE_SMM_DRIVER] ####################################### # Silicon Initialization Package ####################################### - SpiFlashCommonLib|$(PLATFORM_SI_PACKAGE)/Pch/Library/SmmSpiFlashCommonLi= b/SmmSpiFlashCommonLib.inf + =20 + SpiFlashCommonLib|IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiF + lashCommonLib.inf =20 ####################################### # Platform Package @@ -401,6 +401,10 @@ [Components.X64] $(PLATFORM_SI_PACKAGE)/SystemAgent/SaInit/Dxe/SaInitDxe.inf $(PLATFORM_SI_BIN_PACKAGE)/Microcode/MicrocodeUpdates.inf =20 +!if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly =3D=3D FALSE + IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSmm.inf +!endif + ####################################### # Platform Package ####################################### @@ -421,7 +425,6 @@ [Components.X64] =20 !if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly =3D=3D FALSE =20 - $(PLATFORM_PACKAGE)/Flash/SpiFvbService/SpiFvbServiceSmm.inf $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitSmm/PlatformInitSmm.inf =20 $(PLATFORM_PACKAGE)/Acpi/AcpiSmm/AcpiSmm.inf { diff --git a/Platform/Int= el/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf b/Platform/Intel/Co= metlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf index 6397d80d3895..e341285f4b1a 100644 --- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf +++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fd +++ f @@ -407,7 +407,7 @@ [FV.FvOsBootUncompact] !if gMinPlatformPkgTokenSpaceGu= id.PcdBootToShellOnly =3D=3D FALSE INF UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpu= DxeSmm.inf INF $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitSmm/PlatformInitSmm.inf -INF $(PLATFORM_PACKAGE)/Flash/SpiFvbService/SpiFvbServiceSmm.inf +INF IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSmm.inf =20 INF $(PLATFORM_PACKAGE)/Acpi/AcpiTables/AcpiPlatform.inf INF $(PLATFORM_PACKAGE)/Acpi/AcpiSmm/AcpiSmm.inf -- 2.28.0.windows.1