From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.568.1628549185352045571 for ; Mon, 09 Aug 2021 15:46:25 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=l3/mtzLR; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: rangasai.v.chaganty@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10070"; a="195065207" X-IronPort-AV: E=Sophos;i="5.84,308,1620716400"; d="scan'208";a="195065207" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2021 15:46:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,308,1620716400"; d="scan'208";a="421006245" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by orsmga006.jf.intel.com with ESMTP; 09 Aug 2021 15:46:23 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 9 Aug 2021 15:46:23 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 9 Aug 2021 15:46:23 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 9 Aug 2021 15:46:22 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=crjxUMQF8/RJ9+uZH0yakW+kCfU7W6gw/8Qs6BIDaJdTJU0gWQ379fKU+UTqgkjall2NbfjnEMM18MQSQWjvIajQ1c+UBhwpeUMK+HxhnRrznIyLdDVndHtepgLMkC7wN7wSzNDTWQjI1VIP+6p6TycsJ12+2AKACz9Nh7sD4EZOD1JPHlFwKR4rc//nvvn/kWXEzltbLS450snDQnBxHFyvDN/aUdZQh/aBLtlabRclT6WczqLhsbb8a+S/mZdApk/dxDmFDroxtgYpACAYvSQw3EjOFafyWikR8puOPbxMbCtDRi/Y2pYfQX0BL2sWCnPq6GwK+1lm6ACgKnv3vQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ED+Jhlyd8KnxO+YRE9elBqNVEHSuyFISq1gic+3hnSQ=; b=oIHJJawhxA1NJYhNJHlxCc2cO+HBQefCoF0+niNIeOCxc0BtxhAEZbwCrGWTOSoRev74PEUySmixvKXQZhup6IJ60oSxlb0H7Lee7wn1wrnYsOjYaXNdY7LGEZn4tevwDa1L93abaWpzXtNdb9NFLEv6yS4S/n33O3KeRUy/gOxvqcO48+VKoD9TWbuhuBoDQTGhur+bdNsMoJvBgzV8qKPkTsHctVRyzvy+Te54FccEdrWNF73up0gS1Ub11yFxE91m+fi3zRjF8SAIWhZThcTQGrG6FwD9CcOw1MfvOREUBIXkIXbEsx4x5BvNavFciR2N6oOS41ZztoLOrSKq+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ED+Jhlyd8KnxO+YRE9elBqNVEHSuyFISq1gic+3hnSQ=; b=l3/mtzLRDveAwKZrWmkm7YcU+A/Dem4AP1Cbqmq0kvp7Vzw8gD44YTdA6mWYS+CbiDUekWuFdC3uLQ6A6F/OGD93EgaJTwaQBQSLnRvZPLPw9b3G1jgRiDGF59T2ba1dq4qy16rwJWljmSNIadAEJXtE+s0W01DP6rE4otE92Zw= Received: from MW3PR11MB4602.namprd11.prod.outlook.com (2603:10b6:303:52::19) by MWHPR11MB1984.namprd11.prod.outlook.com (2603:10b6:300:110::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.20; Mon, 9 Aug 2021 22:46:21 +0000 Received: from MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::f015:1569:4279:35e5]) by MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::f015:1569:4279:35e5%2]) with mapi id 15.20.4394.023; Mon, 9 Aug 2021 22:46:21 +0000 From: "Chaganty, Rangasai V" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Ni, Ray" Subject: Re: [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement Thread-Topic: [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Remove S3 requirement Thread-Index: AQHXjSQnbM1oR0p3KkGrRFXpt58QQatrxmZw Date: Mon, 9 Aug 2021 22:46:21 +0000 Message-ID: References: <20210809133938.2430-1-mikuback@linux.microsoft.com> In-Reply-To: <20210809133938.2430-1-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 74bab92d-061a-40a9-0969-08d95b878245 x-ms-traffictypediagnostic: MWHPR11MB1984: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 06u1JrUotYQDZN8jLf+oRTrO9qlYloCdaRhc3Z4yhJQ1yFmsDsIEsJwcfszn1FMMDLeW7mSrfPXKS2ttXA3qNUqp6leWSWt8OpYWrk3Hlu5abr22KczD2zo9dGJguQDt0Um9oe2RHDBLmpaf39SioDC8MaYqLxn4Bd9iw3o0ed1Q2sO8CoJgIwlngGBh96PZ3CEXoW+5kHhM0G1jC8xtgQ5goPkWI3F4BOUpfUHcVX+MzOwKhUGuebWG4V6ONttbWQBKtY9QnhGWg50mR3MTxg6LWd3xAVTRMaDXirl2r7kv5BYa7FumDnZe6yxDKa/oUcNUczaVavl+C7HExRoaY1wlLQlIrbmA2AyULLkC61Y5eOgb1Ia3UV1gFMYMyr5Omr5tMCGw7jPhCGXPxfMpCkJGHfy3sZijV6cAUQp2Yi9NZr838zH2blp0K/s1qmCqzNjptlGMUeSsAKmykgqIRj4xZgt68wNs8xKEnTpPCn1OYYwpv6m1Ymca591p/dF7avcuwngp6EL96aboNsnIxcNdxUgLm1zTHZBsK8BVLCW9TBs/a5V3nO/MVk/3Mv6YSpNf+Od3rVud0OznmYaIuM22tGyfX+oRdAFPPN02fLkV0+vaAiPnKKoJaPA9FEk2y01Wzf2Zd8MphL2er8J3zXM4AiqhV8Oyb57KCEgoyaGGrHtnRK9HV4ABPYcjS+3+lSy7UEYO3azVUqCHj4R4o5Wq29AOMvxP4/KwNsemGg2vTanncWF/+1H99aIZ2VF+929gHXL83ZPeoA8KSwz6FiYESSeNs3rGhBiHpJRt+Rs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4602.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(136003)(366004)(346002)(396003)(39860400002)(66446008)(64756008)(2906002)(55016002)(76116006)(66556008)(66946007)(7696005)(66476007)(4326008)(83380400001)(71200400001)(9686003)(107886003)(38100700002)(52536014)(122000001)(5660300002)(86362001)(110136005)(478600001)(8936002)(186003)(26005)(316002)(38070700005)(53546011)(33656002)(6506007)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?8QRJ+lcTphMLKOifML4ZnDvETOlnpCJYIOd1RqM1kKH0cOpvJ4DvQ9pL1yHJ?= =?us-ascii?Q?JXZjjoGfSJI3Nbv8F+qJ0uIyVURrVTdeZGj6gYOYm0lFo+F2B9UJbut5t1Eu?= =?us-ascii?Q?VuuttC2U0TznCmkYIcmUG8nKOIWJzktIAPmZUbW/4qQ4swRiWoUxX3oYT/sR?= =?us-ascii?Q?Ou+yJC8nWrCXzbH6MWlWTaPui3XwhWQDBoiVp5iJcX7w9H4pM6PwOc9L9piT?= =?us-ascii?Q?kfzaqgzqk2WABmH7b2MNUVg4DhVRpQvuxH5DYq46ztcol7pc433Cpyzw1VYg?= =?us-ascii?Q?TqtklPRhynadNAWPK62TmdRV6zbnsOlIE96pPoGzbSYmzCpXQlzjeDSWv9/E?= =?us-ascii?Q?fexc50IpCfJi61Dcx33sa5VESfVUQuEzr8JuUt1kmq8+SRpQYb8NIE9v7FX3?= =?us-ascii?Q?iO2YD5uTFarFZOT0+za8d4sLETxlrEUxeyjegQTDFgcsvhj1lmfcdqGyhRJs?= =?us-ascii?Q?BocGzPQdb3hVn/a52umMkVxY3QF2eN5TMFTVjuReZmxA8Q9ckPaPrMESRTrF?= =?us-ascii?Q?NCE/EmxrvpEPPMPMJF5RTkfirDk0NozbaS/DXdKmU7kpwFg4gaEiLkl8JMKq?= =?us-ascii?Q?FOs2Ms22vAPx8u81/YBAwhPx4TVNSvYRsEyzFPn+iHE73jTaszl4LDBKWHf7?= =?us-ascii?Q?nEsYPncyaJS8CU/PCgNiJxz3hdqEMU/7ky78hQOtpfsGib5ZF21DQYxJ2C3Z?= =?us-ascii?Q?IWNiDx76C+hWhtujI80sXCf2mGxGJY0Hm4K6jcQSfpBtFhiSntguWjr+ljts?= =?us-ascii?Q?5v965kWb4bgZ9Ad1/PZVeuGMN/aLg2/jBLDVXiRfFoz7ORcn7hmJfoFEvLew?= =?us-ascii?Q?uIKGZo9PRKqILRELMz0NgygDKqJHgvNX0NNRaFD6JVdFJ4NPMO1QKlsAUcvf?= =?us-ascii?Q?M5Aa93oDXXH6FodhiteOg2O38zWKnkJvJKRhTD6s822eNygLsZkTPqU77acx?= =?us-ascii?Q?HpBjZ2JtGxuG9WMyc5QpKJ/0tJBoz2QwWgcAT3uncpGux1YX3SA9n6M9OqkW?= =?us-ascii?Q?NBcHK+dLDX0WcdKFMObGmO6YEggCc8Rb0OezV2ue/zYHEQUdot8fNL7ICLLo?= =?us-ascii?Q?kqTmaSvpQTuUZ/+oTCa7wCLy0Ur+qfWhvXDID0/62iwlQMcFUUPlvmNOygKV?= =?us-ascii?Q?66euh9rWYrPhZpv8DsuCZ9Z4cczpioTpZntEUxD5dh/Lr0TWCT46xYqRXZKd?= =?us-ascii?Q?wkeglCbLO3RorWdYrOhR+L2f128NucoBAdmQRLskD2ZjUJoySyLi8hsIl8Yh?= =?us-ascii?Q?bJ/+w9vVCX503Pfr4jfVj7kUe87sZRos5Hy1CSGVhVG1MKvvQQoGpx+t3lZ0?= =?us-ascii?Q?UweSrTv7kiX27nS3Mdb3RUf3?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4602.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74bab92d-061a-40a9-0969-08d95b878245 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2021 22:46:21.2915 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7NQuwJ8cUsvXCdtr2LTjDiwDmZWP+CobePL1i6vl3b3NDVhYv8oFnWU6mCO8SpenEYDUCIufN28j9FGBORzfvV4t3vK5i3f/HplUdF9XL7U= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1984 Return-Path: rangasai.v.chaganty@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sai Chaganty =20 -----Original Message----- From: mikuback@linux.microsoft.com =20 Sent: Monday, August 09, 2021 6:40 AM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V Subject: [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/PeiSmmAccessLib: Re= move S3 requirement From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3539 PeiInstallSmmAccessPpi() currently requires the boot mode be set to S3 to a= ctually install gEfiPeiMmAccessPpiGuid. This change removes this requirement in the function implementation for two= reasons: 1. Practical use cases exist to require this PPI in cases other than the boot mode being set to BOOT_ON_S3_RESUME. 2. It is poor API design to implicitly bury this requirement within a function whose responsibility is to install the PPI. The caller can easily place arbitrary constraints around whether to call based on conditions such as the boot mode being BOOT_ON_S3_RESUME. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Michael Kubacki --- Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/PeiSmmAccessLib/Pe= iSmmAccessLib.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/PeiSmm= AccessLib/PeiSmmAccessLib.c b/Silicon/Intel/IntelSiliconPkg/Feature/SmmAcce= ss/Library/PeiSmmAccessLib/PeiSmmAccessLib.c index d9bf4fba983e..4df0d695fdaf 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/PeiSmmAccessL= ib/PeiSmmAccessLib.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/PeiSmmAcce +++ ssLib/PeiSmmAccessLib.c @@ -252,19 +252,7 @@ PeiInstallSmmAccessPpi ( EFI_SMRAM_HOB_DESCRIPTOR_BLOCK *DescriptorBlock; SMM_ACCESS_PRIVATE_DATA *SmmAccessPrivate; VOID *HobList; - EFI_BOOT_MODE BootMode; =20 - Status =3D PeiServicesGetBootMode (&BootMode); - if (EFI_ERROR (Status)) { - // - // If not in S3 boot path. do nothing - // - return EFI_SUCCESS; - } - - if (BootMode !=3D BOOT_ON_S3_RESUME) { - return EFI_SUCCESS; - } // // Initialize private data // -- 2.28.0.windows.1