From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.482.1628548961465880229 for ; Mon, 09 Aug 2021 15:42:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ikkERUAe; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: rangasai.v.chaganty@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10070"; a="201975972" X-IronPort-AV: E=Sophos;i="5.84,308,1620716400"; d="scan'208";a="201975972" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Aug 2021 15:42:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,308,1620716400"; d="scan'208";a="589061774" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga001.fm.intel.com with ESMTP; 09 Aug 2021 15:42:39 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 9 Aug 2021 15:42:38 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 9 Aug 2021 15:42:38 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 9 Aug 2021 15:42:38 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 9 Aug 2021 15:42:38 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VkoOsApcTcHHZfRNRqO1m5YjI2Pv5VtKjeqccgzb0H4xMziw3GE2qGT1nDO05p08ZQdsS8ZQRwEAKXU7MOV9+hbNxujIGx3mCVn8q1rd8BG1Oh+rnJz25iALSE+U6PdD5305ieyuAxYtRBDZjglXyPkQx1B2xLDYqleUh9KOlxUKYXCBVJ9hP9/199GSmV3mT+hrxzzHCj0A10ydsWLr8FkU4+fdGeYTS8kKJE16WyE2tub78+wOtnuHGdln06rcIHWCOQWcKd5TJgQCj7aB6urVtFr6/T7l79OjBNBgOtdFDWwl8RSXuU81X3/YgRDFb3ICEMdUlDYWt6OchQfacg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HDPv19nOhQGiqcwR+jAjdCyhej9PJA3W9GON/TvHa0g=; b=Xnfipt4K/ziX0wKpCLX551V4A1tgYdkIQEbA0gcnvkvDjNTyP/yLrmWEdtLHhcnzdhE5zZcGZ+TlCQxTFnJV2a5vyvQw6ZH7gvVteUummEY2oB+GGmbI0aLE6lbBiBujmTsPeBV7YktPTF5KdQaCT9U/WxchXvMaA/OxarEoqt6P8DeUlFMPhBclmkH/6SpK2/iNF0LfUSDKaYyxy9vlr2k7o0mrAfkMVyZCwT4b4hoRFHxl1Un5mWz4oM0SL1ILegl4PPucEtsq2Dgceo7K8ln2KD31g4WKSa0qCFtUUnUFrbRbNU00uBJav+BN0ZlyMwMbbISrTjGREHexwfEzMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HDPv19nOhQGiqcwR+jAjdCyhej9PJA3W9GON/TvHa0g=; b=ikkERUAezWQF/iucVXUIVkAYpdNlVOTfDcEeDoN4KXjrPRi9fmE6T+xR2drW53HEwkW/MkYoLxg+CaS6kRN/Ojm/M6RN+/as0zVIvzMnlcRRHaCWIv1Vx2SlVUtFg0zAtI3cG1crhIfnWuZ8J7RaZV4Kb3EBGVfvcyPy/Bvqbd8= Received: from MW3PR11MB4602.namprd11.prod.outlook.com (2603:10b6:303:52::19) by MWHPR11MB1984.namprd11.prod.outlook.com (2603:10b6:300:110::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.20; Mon, 9 Aug 2021 22:42:37 +0000 Received: from MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::f015:1569:4279:35e5]) by MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::f015:1569:4279:35e5%2]) with mapi id 15.20.4394.023; Mon, 9 Aug 2021 22:42:37 +0000 From: "Chaganty, Rangasai V" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Ni, Ray" Subject: Re: [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg: Add BaseSmmAccessLibNull Thread-Topic: [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg: Add BaseSmmAccessLibNull Thread-Index: AQHXjSkjzi6qrou/o0a0ksdLg++LIKtrxVNQ Date: Mon, 9 Aug 2021 22:42:37 +0000 Message-ID: References: <20210809141554.2568-1-mikuback@linux.microsoft.com> In-Reply-To: <20210809141554.2568-1-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 427775f8-6fb3-4b9e-b17a-08d95b86fcef x-ms-traffictypediagnostic: MWHPR11MB1984: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1303; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: jLq5Zx2K4/7k1E0R2gpDjWKtn3xTRmm/RQ7u5OByCFBD0E2vr17+j/ciE6O89m8vg9v5jXoBARkrHm5AYvtmyZNP3WcOGYld0uWtqQFGja7sevCkB0547rBIva4BS1c9ZVqJOIqiAgddHXGM4VTgd2IzQo905NSaRh3GOw23/QRUv5tBEJ4JbE5FG8oJsbkbjC10DE8fiWgNB18pI0ompoK4v7UniasIZdDZXcSZjAp7xYnsl3wpjsz1UziTBdCxc8yb7kHj+GVRWz/342XRWGIoJnYX0XWm9zmT5tKuObGTXFKJQTIFQHt2GiO974Aqy3ZL6mdIl5RE6JsOodn0gkkrFEJc99yHNyoasWMA4Gb2rnsjLVH4XtnDAicjrdc/m8eUPpg2W1KAxPZTsWThERytjDD3CAxwtj1LvcXL68e49LT0l1SIt50sYUb+yNPS+7+vfU7lkPXikl3smdQ9W6FUuEiOoz/PJsMEHLOmVNGW3Y74cjPHYtvGuuF+V5+YsebBqIhSNZ4h7Hk+T8qeN5VwODoOTOgqcTfa6qlswYydgxxI4NBiO3caady80/h7V/I+spHrHFHJDsjpmnk3JpbiYii0rnAuWqTBDeGPww1KNRSd7w3wcS2eJQeHW79Iewm3pZVaotR+xLjFJg553Li49p+CaskEjvVipddPwpE9tR97bMjZqI7BgkjnsvpSzTb/MFvoYfLqSEESy3YnyoI9NoxCim0dK6bVasgGI7XnoK8kmwdlXykibyqwKvn7W2Q5B33ae/xf+z+QpE2uwNyNtkNMLkNTiHdCjNqfviNCfHRvhhM8lnMRsfM4tX3d x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4602.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(346002)(39860400002)(366004)(376002)(136003)(478600001)(8936002)(110136005)(186003)(26005)(316002)(6506007)(8676002)(33656002)(38070700005)(45080400002)(53546011)(83380400001)(71200400001)(9686003)(107886003)(66556008)(66446008)(64756008)(76116006)(2906002)(55016002)(4326008)(66946007)(7696005)(66476007)(86362001)(5660300002)(52536014)(38100700002)(122000001)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gp74HP8pBJ7OTRnvOM4cx4erpCoAc09wxNeo68hDX6JCaA0OcXyB40YXfln3?= =?us-ascii?Q?gN8+/xWppvf+BBVCxuWsnrYFURlMbO+3XyccfNLyH9EeFrO4uYth+WKqx4Z3?= =?us-ascii?Q?oqEfJ6ml8b9qQ6GyFx218yhECK2VlCEyjNa1Y18Fgi6FyC1kO6m9/CHGVO9q?= =?us-ascii?Q?z7OwajBeaEmXJCte/4m0LxCWHdm9YI+SBmEAG8FyDYTZ5G0VWrFVE5xRH4/l?= =?us-ascii?Q?5V9n77F/DuX/fiL05UevHw0or6avV8oT3mYLk6HwkfpljkbMHzU+1uYNrG08?= =?us-ascii?Q?e1XZKElZL5BfUILm5jaeTUAADFv2L20uz9dBGrUSaK+qk6ClihNbhGj5iR27?= =?us-ascii?Q?h1x93hI68Nm0V7Dq3QWgfBZxO82kvhoJpoN5EanGCxYX1wR0kixVjICJ0H5E?= =?us-ascii?Q?ZEm88nxCrm+zIkErDP9THbZIMlyEqBvBYicRvdok4upv6dKa51RDuW083n3H?= =?us-ascii?Q?BQ7RJ2ahtqm5OkwmUZVmpcSCnJ1gIlA1DpQCz8LxK7bILDSk76fx3mNNdgYe?= =?us-ascii?Q?BbHLQ3p0X5uRw+p8kRRlcNOovTrKY+Pa0S/B20dvmRa9ZNr1zNFlqKtl9Olk?= =?us-ascii?Q?DoxtaaX9vBoDXjwKATmTUq6QzrBXVHJLtLlIKXNiLEJxyVlcxrlTub8CbHJO?= =?us-ascii?Q?bjVH+iphA4RSsf7RLY+OuKbm1iiEfFF18YwBJm82AQf/8bRFJo0CrrjEZlCm?= =?us-ascii?Q?OrwNvPfYzM0otlWQ1WQOXKqHV8/XZ5yetB+fb5XGrwaj0hUHRKms9bWY1ZSi?= =?us-ascii?Q?F8Ru+z/VGbXp0WX876wS5h6DEcDzgWFzyg2mSos0kpu750qJaAiJqt+6pVHN?= =?us-ascii?Q?+dwG3HhISoIjXWIY65k2Xchrki48XMLYeSFX1Hm4HVydEcfHCpcdOxmRY9EU?= =?us-ascii?Q?b4qKoFK5BBHhEXxQN4oIrOIRl1pVGkQydN4hEdg03ODksmMAAI0QcPYwg5ez?= =?us-ascii?Q?VVFZHIjArb5tKycan6t05wOcnKTThTCqidd5U9DLOSSbdDH821d0WDsPoM41?= =?us-ascii?Q?LCO79A9jgIf+GfR44hUmTmqgAWaCjGUbqX5g5+zOt7js+79pz9qvnQvmhlYR?= =?us-ascii?Q?cxNZZQjCQuxkMBPWtWP4ZXC4f1RQecn+S4nZv1UEB1WfEOfZWQkMVbOKBK86?= =?us-ascii?Q?NG1YHqJfxUr0CuXXduViu9Xq49ZB66MWIYWjwhOS7RYGrnzFdydF1GRybzZj?= =?us-ascii?Q?EcqbKXAHFnb2Xm3VIB6FQuNyLYHkLLe0Y4HZYa/MGd7aT7E4J3dGdRoioWHR?= =?us-ascii?Q?mfja5dp8L9FoQgiNEkWV6jBvjiwrijGd/nzfcB3w0Oo7raTnVnhqZPhAZXXx?= =?us-ascii?Q?/Kxo3Elz3jqS+bnUPGjHJcv2?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4602.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 427775f8-6fb3-4b9e-b17a-08d95b86fcef X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Aug 2021 22:42:37.6490 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0fXmOH5VwUIVwhcYrZq5qLOPQGzqUUG+kgcAQtiVBIGnQaHeSwEKVWJ6GhxMFMdnJzgn5ZlaZDrvF9r3l45NiaKqThOu50eOIY/N9LDHKbU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1984 Return-Path: rangasai.v.chaganty@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sai Chaganty =20 -----Original Message----- From: mikuback@linux.microsoft.com =20 Sent: Monday, August 09, 2021 7:16 AM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V Subject: [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg: Add BaseSmmAccessL= ibNull From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3540 Adds a NULL instance of SmmAccessLib. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Michael Kubacki --- Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/BaseSmmAccessLibNu= ll/BaseSmmAccessLibNull.c | 33 ++++++++++++++++++++ Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/BaseSmmAccessLibNu= ll/BaseSmmAccessLibNull.inf | 26 +++++++++++++++ Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc = | 1 + 3 files changed, 60 insertions(+) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/BaseSm= mAccessLibNull/BaseSmmAccessLibNull.c b/Silicon/Intel/IntelSiliconPkg/Featu= re/SmmAccess/Library/BaseSmmAccessLibNull/BaseSmmAccessLibNull.c new file mode 100644 index 000000000000..f5ad306b380b --- /dev/null +++ b/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/BaseSmmAcc +++ essLibNull/BaseSmmAccessLibNull.c @@ -0,0 +1,33 @@ +/** @file + A NULL library instance of SmmAccessLib. + + Copyright (c) 2019 - 2020, Intel Corporation. All rights=20 + reserved.
Copyright (c) Microsoft Corporation.
+ + SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ + +#include +#include +#include + +/** + This function is to install an SMM Access PPI + + @retval EFI_SUCCESS - Ppi successfully started and installed. + @retval EFI_NOT_FOUND - Ppi can't be found. + @retval EFI_OUT_OF_RESOURCES - Ppi does not have enough resources to in= itialize the driver. + @retval EFI_UNSUPPORTED - The PPI was not installed and installati= on is unsupported in + this instance of function implementation= . + +**/ +EFI_STATUS +EFIAPI +PeiInstallSmmAccessPpi ( + VOID + ) +{ + ASSERT (FALSE); + return EFI_UNSUPPORTED; +} diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/BaseSm= mAccessLibNull/BaseSmmAccessLibNull.inf b/Silicon/Intel/IntelSiliconPkg/Fea= ture/SmmAccess/Library/BaseSmmAccessLibNull/BaseSmmAccessLibNull.inf new file mode 100644 index 000000000000..7fd3b0b89655 --- /dev/null +++ b/Silicon/Intel/IntelSiliconPkg/Feature/SmmAccess/Library/BaseSmmAcc +++ essLibNull/BaseSmmAccessLibNull.inf @@ -0,0 +1,26 @@ +## @file +# A NULL library instance of SmmAccessLib. +# +# Copyright (c) 2019, Intel Corporation. All rights reserved.
#=20 +Copyright (c) Microsoft Corporation.
# SPDX-License-Identifier:=20 +BSD-2-Clause-Patent # ## + +[Defines] +INF_VERSION =3D 0x00010017 +BASE_NAME =3D BaseSmmAccessLibNull +FILE_GUID =3D C1A14AB6-B757-4046-9B92-9DCE1A2154C6 +VERSION_STRING =3D 1.0 +MODULE_TYPE =3D BASE +LIBRARY_CLASS =3D SmmAccessLib + +[Packages] + MdePkg/MdePkg.dec + IntelSiliconPkg/IntelSiliconPkg.dec + +[LibraryClasses] + DebugLib + +[Sources] + BaseSmmAccessLibNull.c diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc b/Silicon/In= tel/IntelSiliconPkg/IntelSiliconPkg.dsc index 1092371d848e..dd0928ec58f3 100644 --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc @@ -90,6 +90,7 @@ [Components] IntelSiliconPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.in= f IntelSiliconPkg/Feature/Capsule/Library/MicrocodeFlashAccessLibNull/Micr= ocodeFlashAccessLibNull.inf IntelSiliconPkg/Feature/ShadowMicrocode/ShadowMicrocodePei.inf + =20 + IntelSiliconPkg/Feature/SmmAccess/Library/BaseSmmAccessLibNull/BaseSmm + AccessLibNull.inf IntelSiliconPkg/Library/PeiDxeSmmBootMediaLib/PeiFirmwareBootMediaLib.in= f IntelSiliconPkg/Library/PeiDxeSmmBootMediaLib/DxeSmmFirmwareBootMediaLib= .inf IntelSiliconPkg/Library/DxeAslUpdateLib/DxeAslUpdateLib.inf -- 2.28.0.windows.1