From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web12.1184.1624925247069946895 for ; Mon, 28 Jun 2021 17:07:27 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=P9mQHcRT; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: rangasai.v.chaganty@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10029"; a="208000846" X-IronPort-AV: E=Sophos;i="5.83,307,1616482800"; d="scan'208";a="208000846" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jun 2021 17:07:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,307,1616482800"; d="scan'208";a="558550661" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga001.fm.intel.com with ESMTP; 28 Jun 2021 17:07:23 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 28 Jun 2021 17:07:23 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Mon, 28 Jun 2021 17:07:23 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.170) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Mon, 28 Jun 2021 17:07:23 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R4XmW+srHg4wIYZdCGixNNzmmWtwrFlMRZLyyb9Ytg7f9nHeGj2LV1Pw75xer0/1O6mXwgOXWsmPGSbAg5raXBvdBtn1MNJbfxOv7YmRCMDABePr4AvZCs5VxX2XSxMrW4EcQmQp3ynG5/A16gvjjFHJhCtn1tLM7I6FNSJUmS2P+m1Nlp9tKH2090IBasvE4JMdbJgiMQBILTTaP7Fv6zvaJ+qXKP3S4uXDRjomT47zIu6kpVNXMb0v/o4l4XL25JsqGTgwI1jSMG6QWOLCfklVaP2O7cLPKpavEmGporEL7vyhbiHnoqkzaElfha7I1XUpV/618gAyltCW8XdwZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l0g+73p9xi/aNRT8CDKPS9DlM/fnL9/fABFJaA4QXcw=; b=JlhZtXhA71OFUt2qCs+goAsOAQvuNgGs5VUNUqHK0aUjAbkzQ037O0UJM+kZUj5eXibFPW7EfnKzOTRjRBn+qop21Ut+uW/DNjSSXOD7HH1Lds7VuyfowYtrZOnlNhsKIr5BH7tLiJ0EG94EUkVLiLc65RKZZT/0tFr0oyckOmgn5oMv/LAQmk1gxaUriiGvUWQ87FR/LqazOi9ZtFLf47U4SqwW3ySKxgvs+KrujjmhP10IsWW0zLypMTXcbmZzCc0epgHckLvCqdUQFLPyBleTnbbZ+5ZCd0BvJjsRPB7s1kiHnIBbGdu4CkpOTmGi3+iMtdY9yQ3NOv53FR4URQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l0g+73p9xi/aNRT8CDKPS9DlM/fnL9/fABFJaA4QXcw=; b=P9mQHcRT/FQmyK269Ox5LZ+5aPELw4iC6mBABqxRcKkrcubpa9pVfr4qFW2m2f4xs800eG1GGYRdHqAJU8gwqGZc+TuJrTOHriLKjqZEA+Z3GtuxnyHK08uaq1UnmlADEu35uIyVuUB9UGm3d86TmKSV4t1xzMGlFMBccyeTIOo= Received: from MW3PR11MB4602.namprd11.prod.outlook.com (2603:10b6:303:52::19) by MWHPR11MB0048.namprd11.prod.outlook.com (2603:10b6:301:6a::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.20; Tue, 29 Jun 2021 00:07:22 +0000 Received: from MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::451e:1727:7108:3873]) by MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::451e:1727:7108:3873%9]) with mapi id 15.20.4264.026; Tue, 29 Jun 2021 00:07:22 +0000 From: "Chaganty, Rangasai V" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Ni, Ray" , "Desimone, Nathaniel L" Subject: Re: [edk2-platforms][PATCH v4 37/41] IntelSiliconPkg: Identify flash regions by GUID Thread-Topic: [edk2-platforms][PATCH v4 37/41] IntelSiliconPkg: Identify flash regions by GUID Thread-Index: AQHXaghLCciFY3VGu0S6nGn35cAhGKsqIL9Q Date: Tue, 29 Jun 2021 00:07:21 +0000 Message-ID: References: <20210625212120.235-1-mikuback@linux.microsoft.com> <20210625212120.235-38-mikuback@linux.microsoft.com> In-Reply-To: <20210625212120.235-38-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [50.45.159.74] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2c331f05-13bd-4615-e838-08d93a91de39 x-ms-traffictypediagnostic: MWHPR11MB0048: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1923; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: m3PaS1DV4oNrGGLbAcCb0rCLgDx6E0+TOGmY+nQNvVOGJDx3M3jesZWA9VohW9LaguCOxppozdDYsEP2iVOfefuClEjtoXmSGPyDIQHCHHqZhjdlmFAmPH7t1gwqqBFJ9yt9FvyJ5aO5Y6j2LJLAuYws2MWpmX3Jj3MHYhxX7fBJUppmGA7/RnecvRCnKhaxQoAipBOn82MJNkOXs69OQD9cBgs28JYbAcFCliKZG2KYqEB9fGcG3/j+znHNUQv2xyv7O/E08yY3DBdwGfxW27qfrISZ6PgKXfYT6B/AoM8pBQwKMuSaX4WhMURRUnHRTqEeyzklNHpjS+oyb7lA0N0Dckgqto7QVf3wbWgWbAHPE0pOqnT1tWV03e9fU208FyTtYtxxd3M2r7oD+cpk9XtsCjprHhontfJ+TDTkD2Y5zXmMF9wWZKABEzvh5hlH18joY//cUBbNzsSZiADlH9zPEx+XxXA4fTj/0BKa2RhbRN+FgZtSkIU/oHGG4hWeFyV8Cp5rjYce/HFwYG5lloWf1E95bIi78HRiHh9PD3SYmHXQCnPnq0QdGV1IMmSzKFAC/2JYvDGQ85+1xS2764BFDh2ZFmuXxl1R7zNaMsL0y9ryeIp25XZRVfu+Ko9VpprBkzKGkWqSbBQR52GYTz4eFtXHPuViuEEB+KCmhItLgUKubB79B9dF0gbkKgMxrYhbMAGGCxgxcLJykQXfryATYImUwLTW89mxWtjY81EsQXkIDToYqCVFifXl7SO9dFRuMpVKyn9wFyogiMiMFw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4602.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(376002)(39860400002)(366004)(396003)(346002)(54906003)(110136005)(316002)(86362001)(83380400001)(478600001)(2906002)(107886003)(4326008)(8676002)(66556008)(66946007)(8936002)(33656002)(9686003)(66476007)(76116006)(55016002)(66446008)(7696005)(64756008)(186003)(6506007)(53546011)(52536014)(38100700002)(122000001)(71200400001)(26005)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kIoHvrEvryH5fG2kBgRkf0FXOTOkPfpLvzm85n9GACK4FmaUutC0Ch11M2lU?= =?us-ascii?Q?zU7q8DzwPXNZyab2BZoMZEuZVJY+vmHHPukxnj8coT4wKnHrjLpi5+60N4hn?= =?us-ascii?Q?4oIksIfcOoyui19dy/E+3AdusaaoqZkLN8q75yIrIinrn1JtVDuR5X7ozmyR?= =?us-ascii?Q?eKxOKUcfJ5dlxs7Y8+Kp4B/q91XV7LTvKlaoFO06gwG7WWVDqg7k921hezlr?= =?us-ascii?Q?a0iKUxwzXAQv/03HJjWVSb3CGMGFrivm3WjyEwSa7GlRZ8JNYh5WdbxMXfOj?= =?us-ascii?Q?+xE9HZHKXsfp4RzCOwWc+pWGoGrsrB7g8OEuaivqD+oqMgvvgfPqZcjKP2pt?= =?us-ascii?Q?IMSXE49TqF48yKOp/q2BhSjzAkZuJ2LgfkVTagdZsDUB73e+3pi7iDZy8ub2?= =?us-ascii?Q?KkIVPnifYgFnfWGd6WARk2GyJCTqTd56VPTISs3CbW3cELG1wXfNhG+6OqCz?= =?us-ascii?Q?WL8uTJY+pRXZWaHeTK91V9rlLsdjowmfRpHy7Y3Lprg3xnyV2E65s+72aOPS?= =?us-ascii?Q?KRE5NYDsn9CMvPxBAItYr0hVZTEZy/qWHi8icxb3NXUQzeVadoqnrJppXre3?= =?us-ascii?Q?y6I3lXQTNAB2jDHQGjkcFPif9PjsvLVFAxR43t4GioctnTaLzuJbigr0Awhu?= =?us-ascii?Q?taT0+uhetVvwrHcNzw8OkVeorS3PXML4wi9NDNa0tTFVbDhCldU4o8GmWsDI?= =?us-ascii?Q?PONNC6fS/NEMYNQRQOudRIyDWKRkDdhcmnKZQ1hChQMovrP4bnwYGU2dtxL+?= =?us-ascii?Q?iqtkHXLTDt1fonn2CisW1RagRmz7m+CNxVGBPI0mye/wszILss9HoH38P1sO?= =?us-ascii?Q?KqvZR0iOgNSqH7QnMpFU1MGjzK56hCOrhw01i4garVQ29WCyV/dxlhk8wNIJ?= =?us-ascii?Q?tgZ//76HlQzBWBZQO49/JDRYBIaJe4azerLZTa0vW2F+hxK5JU+15PA7TbXp?= =?us-ascii?Q?JHpVMk8UUEw36EIKw0HH4ahJQWtfgiCbWqug3RA0i86r0jzBsIr/os7ESu23?= =?us-ascii?Q?AFEe52fIRlpKzsRt0bA+F08C4oPfjViAOYvGkhiGmH51pj1EsrDoaBWUYSf8?= =?us-ascii?Q?gvcTBCSgq2559zm7gmgtEBviDIIYFB9T+9yxal8uaHP2kEiy9pZvQvPz01xo?= =?us-ascii?Q?i+xbXxkd7V7hDhj/jNWKHYX/WeFzah2apsPf8txeI5kQ3RM9JfKoeHAsnqSH?= =?us-ascii?Q?sUmhrIVVfo9h6+s3f9iFf9GYk5k9JhrxyG7vXiVn+Rt9dxm7YyD6Hy6Dcacv?= =?us-ascii?Q?LNf9yYgo/bZ1gaFtlGQK6lcA7SQTXHOiTJZ4Z+LGY6l0UNLV4E1SQDifSgLG?= =?us-ascii?Q?mfWfBzgDqojpb/haaRDbVJjg?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4602.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2c331f05-13bd-4615-e838-08d93a91de39 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Jun 2021 00:07:21.8171 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6ucUv6/l+cuV430xhw870alpReARDDb0CmdJbbtv0K0NGOmOZABeLMB4vnM0k+d++nsIUydCConTIh53Yeu7m1X5Ujnlt7HQN+PgbJzwqHA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB0048 Return-Path: rangasai.v.chaganty@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sai Chaganty =20 -----Original Message----- From: mikuback@linux.microsoft.com =20 Sent: Friday, June 25, 2021 2:21 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [edk2-platforms][PATCH v4 37/41] IntelSiliconPkg: Identify flash r= egions by GUID From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 Updates the SPI protocol to identify flash regions by GUID instead of fixed= values defined in an enum. Packages consuming IntelSiliconPkg are able to = associate a given GUID with their chosen values based on their SPI flash de= tails as implemented in their PCH_SPI_PROTOCOL instance. Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Nate DeSimone Signed-off-by: Michael Kubacki --- Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiFlashComm= onLib.c | 2 +- Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SpiFlashCommon.= c | 4 +- Silicon/Intel/IntelSiliconPkg/Include/Protocol/Spi.h = | 43 ++++---------------- Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiFlashComm= onLib.inf | 3 ++ 4 files changed, 14 insertions(+), 38 deletions(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/Smm= SpiFlashCommonLib.c b/Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashComm= onLib/SmmSpiFlashCommonLib.c index 7941b8f8720c..2c9c889e7f48 100644 --- a/Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiFlas= hCommonLib.c +++ b/Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiF +++ lashCommonLib.c @@ -52,7 +52,7 @@ SmmSpiFlashCommonLibConstructor ( ); ASSERT_EFI_ERROR (Status); =20 - mSpiProtocol->GetRegionAddress (mSpiProtocol, FlashRegionBios, &BaseAddr= , &RegionSize); + mSpiProtocol->GetRegionAddress (mSpiProtocol, &gFlashRegionBiosGuid,=20 + &BaseAddr, &RegionSize); mBiosOffset =3D BaseAddr; return Status; } diff --git a/Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/Spi= FlashCommon.c b/Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/= SpiFlashCommon.c index daebaf8e5e33..62c1d099fc2c 100644 --- a/Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SpiFlashCo= mmon.c +++ b/Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SpiFlas +++ hCommon.c @@ -127,7 +127,7 @@ SpiFlashWrite ( } Status =3D mSpiProtocol->FlashWrite ( mSpiProtocol, - FlashRegionBios, + &gFlashRegionBiosGuid, (UINT32) Offset, Length, Buffer @@ -201,7 +201,7 @@ SpiFlashBlockErase ( =20 Status =3D mSpiProtocol->FlashErase ( mSpiProtocol, - FlashRegionBios, + &gFlashRegionBiosGuid, (UINT32) Offset, (UINT32) RemainingBytes ); diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Protocol/Spi.h b/Silicon= /Intel/IntelSiliconPkg/Include/Protocol/Spi.h index c13dc5a5f5f5..2b09ca1faf02 100644 --- a/Silicon/Intel/IntelSiliconPkg/Include/Protocol/Spi.h +++ b/Silicon/Intel/IntelSiliconPkg/Include/Protocol/Spi.h @@ -19,33 +19,6 @@ extern EFI_GUID gPchSmmSpiProtocolGuid= ; // typedef struct _PCH_SPI_PROTOCOL PCH_SPI_PROTOCOL; =20 -// -// SPI protocol data structures and definitions -// - -/** - Flash Region Type -**/ -typedef enum { - FlashRegionDescriptor, - FlashRegionBios, - FlashRegionMe, - FlashRegionGbE, - FlashRegionPlatformData, - FlashRegionDer, - FlashRegionSecondaryBios, - FlashRegionuCodePatch, - FlashRegionEC, - FlashRegionDeviceExpansion2, - FlashRegionIE, - FlashRegion10Gbe_A, - FlashRegion10Gbe_B, - FlashRegion13, - FlashRegion14, - FlashRegion15, - FlashRegionAll, - FlashRegionMax -} FLASH_REGION_TYPE; // // Protocol member functions // @@ -54,7 +27,7 @@ typedef enum { Read data from the flash part. =20 @param[in] This Pointer to the PCH_SPI_PROTOCOL instance= . - @param[in] FlashRegionType The Flash Region type for flash cycle wh= ich is listed in the Descriptor. + @param[in] FlashRegionGuid The Flash Region GUID for flash cycle wh= ich corresponds to the type in the descriptor. @param[in] Address The Flash Linear Address must fall withi= n a region for which BIOS has access permissions. @param[in] ByteCount Number of bytes in the data portion of t= he SPI cycle. @param[out] Buffer The Pointer to caller-allocated buffer c= ontaining the dada received. @@ -68,7 +41,7 @@ typedef EFI_STATUS (EFIAPI *PCH_SPI_FLASH_READ) ( IN PCH_SPI_PROTOCOL *This, - IN FLASH_REGION_TYPE FlashRegionType, + IN EFI_GUID *FlashRegionGuid, IN UINT32 Address, IN UINT32 ByteCount, OUT UINT8 *Buffer @@ -78,7 +51,7 @@ EFI_STATUS Write data to the flash part. Remark: Erase may be needed before write t= o the flash part. =20 @param[in] This Pointer to the PCH_SPI_PROTOCOL instance= . - @param[in] FlashRegionType The Flash Region type for flash cycle wh= ich is listed in the Descriptor. + @param[in] FlashRegionGuid The Flash Region GUID for flash cycle wh= ich corresponds to the type in the descriptor. @param[in] Address The Flash Linear Address must fall withi= n a region for which BIOS has access permissions. @param[in] ByteCount Number of bytes in the data portion of t= he SPI cycle. @param[in] Buffer Pointer to caller-allocated buffer conta= ining the data sent during the SPI cycle. @@ -91,7 +64,7 @@ typedef EFI_STATUS (EFIAPI *PCH_SPI_FLASH_WRITE) ( IN PCH_SPI_PROTOCOL *This, - IN FLASH_REGION_TYPE FlashRegionType, + IN EFI_GUID *FlashRegionGuid, IN UINT32 Address, IN UINT32 ByteCount, IN UINT8 *Buffer @@ -101,7 +74,7 @@ EFI_STATUS Erase some area on the flash part. =20 @param[in] This Pointer to the PCH_SPI_PROTOCOL instance= . - @param[in] FlashRegionType The Flash Region type for flash cycle wh= ich is listed in the Descriptor. + @param[in] FlashRegionGuid The Flash Region GUID for flash cycle wh= ich corresponds to the type in the descriptor. @param[in] Address The Flash Linear Address must fall withi= n a region for which BIOS has access permissions. @param[in] ByteCount Number of bytes in the data portion of t= he SPI cycle. =20 @@ -113,7 +86,7 @@ typedef EFI_STATUS (EFIAPI *PCH_SPI_FLASH_ERASE) ( IN PCH_SPI_PROTOCOL *This, - IN FLASH_REGION_TYPE FlashRegionType, + IN EFI_GUID *FlashRegionGuid, IN UINT32 Address, IN UINT32 ByteCount ); @@ -206,7 +179,7 @@ EFI_STATUS Get the SPI region base and size, based on the enum type =20 @param[in] This Pointer to the PCH_SPI_PROTOCOL instance= . - @param[in] FlashRegionType The Flash Region type for for the base a= ddress which is listed in the Descriptor. + @param[in] FlashRegionGuid The Flash Region GUID for flash cycle wh= ich corresponds to the type in the descriptor. @param[out] BaseAddress The Flash Linear Address for the Region = 'n' Base @param[out] RegionSize The size for the Region 'n' =20 @@ -218,7 +191,7 @@ typedef EFI_STATUS (EFIAPI *PCH_SPI_GET_REGION_ADDRESS) ( IN PCH_SPI_PROTOCOL *This, - IN FLASH_REGION_TYPE FlashRegionType, + IN EFI_GUID *FlashRegionGuid, OUT UINT32 *BaseAddress, OUT UINT32 *RegionSize ); diff --git a/Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/Smm= SpiFlashCommonLib.inf b/Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCo= mmonLib/SmmSpiFlashCommonLib.inf index f6a06351ace5..b28ea3c2719d 100644 --- a/Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiFlas= hCommonLib.inf +++ b/Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiF +++ lashCommonLib.inf @@ -37,6 +37,9 @@ [Pcd] gIntelSiliconPkgTokenSpaceGuid.PcdBiosAreaBaseAddress ## CONSUMES gIntelSiliconPkgTokenSpaceGuid.PcdBiosSize ## CONSUMES =20 +[Guids] + gFlashRegionBiosGuid + [Sources] SmmSpiFlashCommonLib.c SpiFlashCommon.c -- 2.28.0.windows.1