From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.3615.1642138198563574680 for ; Thu, 13 Jan 2022 21:29:59 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=PnWvB33q; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: rangasai.v.chaganty@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642138198; x=1673674198; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=v08aY0adtTdUvmuCeZr5jWR/8GGhROR1ZHCd29yxqrk=; b=PnWvB33q2AnDidsmA/KUor2imeEn1MpM8c6NLbVTAY+zhlXkDW61RdBU DlecUIRnR388x7bE/4QgwAl7RXxxqhewzFYp0BBloJQGVOpDRU3dmetFo uR/KO1yPRzfmx2dvZCEQnh9MfBxbwxrQSRVh/tWP7kmcSzcmCCgS8a43a kjrf9qnS6b3IOVcwqMFHMeVg/e5hhLJdfvcnnyP071P1h7Sbfg9+6ANrp PXaVgiC6dZ2JvQL9e9lXdeS6xN6Y3+vwADi24vgg3Rtgpg8qCCwZFzQ2h KlfomMgRF1ZxvqiMbLac7/R0DcnC0G9avz9X6YjHYAOrpNXI4jxb1Q1Nz g==; X-IronPort-AV: E=McAfee;i="6200,9189,10226"; a="231535214" X-IronPort-AV: E=Sophos;i="5.88,287,1635231600"; d="scan'208";a="231535214" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2022 21:29:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,287,1635231600"; d="scan'208";a="692077833" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga005.jf.intel.com with ESMTP; 13 Jan 2022 21:29:57 -0800 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 13 Jan 2022 21:29:56 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 13 Jan 2022 21:29:56 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 13 Jan 2022 21:29:52 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 13 Jan 2022 21:29:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SQFIFE5EfzLv/nt+auLHN19xfPRqX0p/SiPJd1EbDc06tb0A5zPbWxbmn5ChAzP8PFjhaLbLC8UZplwymReTpM6VjUarxmp2R5aAYg00XxvLZRlz/QTAcWmUHAF5SLwO0S9sle14eXForZPLzZ5KcHKtKEx92SlTO4ZpyR4hIb0jBs7ZHqdCruXtERmoKqStqTmVrg7NTqtJ8tOH/Gmzzo1MgoA6emwftfAZOtJeeT59+RtzV0IXctESVmTzEGGGJrLtqcUEyM7ag69fqwX0jGD5Ik//SCGHHSZW8qfIwG1qTUo5x57ev1iSSXKnVVQPiOH7u7RJxXPhZqMuiSjM4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tkHD8Bp7gEw+caxhw/QgvhcN5bodNaQBwMx1loT8Ofo=; b=cbKL3YaGeSP/Xiqeb9GrW8S6b2VsE5ezksCePz0XCTDKbpS/Xn5J+nWhRVu2RDn33OeZw0pjyw4+JF6yVL+91XgYu9jPhCkic2jcjf88IAUmmszILGjBK/ofc1EJbtwPN9Tg4SNrnSUJKP3GG6Ljf9CIdeaPXoNq8uM+jWAQK1+vYJro/K4BlOvWqJhpO5OmfnqU0krA+khThqLNOY/9Lqyj5n3BEDpd99lGh8IAOx/FS6111Vg0uLhP/zmE+WZISKySgRn09qkgkKGqzJPHHNhlt+500lGDlpxmgNX8EJ9sfUSj4prWffX/MMYN+iE5+YOUbDfd+KuqPR6aut2wbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW3PR11MB4602.namprd11.prod.outlook.com (2603:10b6:303:52::19) by MWHPR1101MB2174.namprd11.prod.outlook.com (2603:10b6:301:50::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Fri, 14 Jan 2022 05:29:50 +0000 Received: from MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::ec00:565c:a1db:998b]) by MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::ec00:565c:a1db:998b%5]) with mapi id 15.20.4888.012; Fri, 14 Jan 2022 05:29:50 +0000 From: "Chaganty, Rangasai V" To: "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Gao, Liming" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 07/27] S3FeaturePkg: Use MinPlatformPkg build include files Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 07/27] S3FeaturePkg: Use MinPlatformPkg build include files Thread-Index: AQHYB1sH9aZl6enqY0OK0j9OIXCnJ6xiAMLw Date: Fri, 14 Jan 2022 05:29:50 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fa500bd6-a05d-4e86-1f21-08d9d71ee2c2 x-ms-traffictypediagnostic: MWHPR1101MB2174:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: iD0rBADhDPPeHthzwT/xRpT2vUxyvD11pCJRplzhES+LPNKBhlKfwahVUeG5DINQMbGXYyJwBfoeUzGGm6q4j8dFQj3brVGqM/YAboBie56zJDcrbSCLY6bb8PdtlBJhBcK5ArZnisNEqnef23fOPJCLryB7LCpWec9SQvUAnFjg5PAhxHdnSx6LpWjUK/n6nVVs36xkg4KAZXLDpriWc+tZrGcwZTXHIVE51IlNj/P4xSTM1YhPzIRDlsDEnc8Mt3qzvKXIzolUM/w2IJ4cvClM3YmpB2Wcebod5HEX0kiIk/MgLkBMMTjN+/rVIxqjWTM7Llcr1f3X02/CO0R5HNX5Mw/arihNfw04HQzuVG2Xvw4+DCmKRPni5Jp3fW9PAB0/45udjtZTd8dNl8A4AxqwTZIyMpgLkyFtFF3biz+v7bfRiKntpnddNJRiML1YinvbO2P66rrUiNCPhbmFVCMhhiXDERtLWv80vVCAv4wEB9fgYYY49RkE8QoVWrMoX8S4GY7nxm36hFrXK7qNrNaWdCBOoWAwunLiXTCZIFG7TtIZHp0WBYMq5y6DtmNYSKPrEVYQPGTlO0mcG2/K/1OEHIBU/ttvI9sq7LgmUaDoI4U1/ciJaaAW3el84aFgR1MxwTYp6HsTWoZD6T1fXsEnB1/YVqDro7pdraH8ZiOZoPrGwyPytwtdxmA1muWDfpvDT0AVoOzM8tZyaXmPIjZprVlixFEUildltuxlc4uGjlcJ3gg8zrDwihGVk4toReHW9R95dEw8/v3AnXHqHYqhNrLkIMC4mxgy1ExHsdI= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4602.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(66476007)(19627235002)(8676002)(53546011)(26005)(5660300002)(82960400001)(66946007)(83380400001)(8936002)(9686003)(38100700002)(186003)(508600001)(4326008)(38070700005)(76116006)(316002)(71200400001)(110136005)(2906002)(55016003)(7696005)(966005)(66556008)(64756008)(33656002)(122000001)(66446008)(86362001)(6506007)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?g2nlo1XoUS4JLl47YQJgjNcuiP8oFJR6xQqz0cMSkk6DENoN2wyxi5X4BmeJ?= =?us-ascii?Q?piF9xA9VnlBDLdd0SD6pxO9L7RNxcdIm8j4RmyNUJ1O8ZvrD19Eq+bp9dace?= =?us-ascii?Q?GFsItkbqamJI52i6TOkAnEz62HsAcDX55RAVu1D1xjT0L6CY0WDsOqv5Wznn?= =?us-ascii?Q?/2Ao1qtw2FASBUVGDG0ctZ/AzDoSa5HJ5AI8THCp4x9GsYdVunjpLL89yiGw?= =?us-ascii?Q?Agq53vIUPva7M2VuIa/7n9PPFibBdtZ5WpRjaUbYLWLVGTE5awM1HE7lCLY2?= =?us-ascii?Q?zo73Q8CP2T/8O636F2md7Wu5IPbkZAoNsSkwOlKMpQJORLpFckuEUkC6a+1d?= =?us-ascii?Q?FiciszObR7+G9jP5j21CIoN8EPiQPbeSVKKwA/QMlF5GO+GA4qmdYPFCvq3E?= =?us-ascii?Q?oUZKqOyHBtxBFP25NRByQram/02u6xNK5B5zLji8lpQPCc7iSbyWu9DLaW/5?= =?us-ascii?Q?BhJLTMN0Ol23q6glyPA/n/dPk7uCE3QmznqCY/uBjkEI0anj7onyUKzqHiNZ?= =?us-ascii?Q?9MnowqcFEOZxDccwOjHiHa5HLrF3tTfhBz9Tbak6ecFzY0Hza4UZATuaQgMa?= =?us-ascii?Q?0/iTL122Is1LorJfTr+fG2fdeG//Hp7gnecFwW5jj9kXonHnQL0iaSfule0M?= =?us-ascii?Q?UofVQ0C/6+diSA+zq+qy9IkTV0GohvWUGbmtwOqqgCzvE1ga6FfJoA94pnui?= =?us-ascii?Q?DL2aN05Qm8HkomKpIlEGCV6matGSwvkwbQKAIfAHRmsYXZeNJaONZBi/KA3Z?= =?us-ascii?Q?jtUhQUprylzjcwYsORkz9XBGoJxyUDWDWSdaYTqhdPAvoH4fkY56RjRvzklr?= =?us-ascii?Q?onSZb0/v2gdEXDau9Pj0gJ0K68ZEzVtO9a0t9Y7VPnSGYvxuGxENxuRNm8Xy?= =?us-ascii?Q?VYbenOxSWQESVNJUB8CrW7XYsAMtDbsRjY9HpMruSkmT47/mxnpb2K1W5HIF?= =?us-ascii?Q?+8o+ybiwyqCyKlbYmTUVXYZ+wWf1EMEXJBNbbrQ3IwO6MHCFTlW5U3xpqyNP?= =?us-ascii?Q?KlejSrVErfPTqzLC1YbEwO7GGPbHqoq9rrVkJOtXNiXqnWa4LSoECixC9K6S?= =?us-ascii?Q?WgpHrpKmdvVnvGZpv7ZHoQTTcvATMGP/X+ShKBNQPcsC0aeMd/+Wn0uJSBCC?= =?us-ascii?Q?CVae+GwowY6vWyIauaKEv7hYsz+/OiziuUGTsFDDk/fq+aFw3zxvxtw8ttCg?= =?us-ascii?Q?FEo/TX33ZCenW66GOLCbsafH2bTa4X1BCJfQ5TSMvTR2r9Nss/lYONb60bEp?= =?us-ascii?Q?iSsn/TNzVzHT/j/7Ns679w4OwfqHuR1vgfrc2lqR6F7bTH0UyjJLinhtEUbe?= =?us-ascii?Q?b1CavgL8gh61LrCI47AyeKm0DECayHJhsFfygOaBiYHc7ptCge5Rnt4mlvgV?= =?us-ascii?Q?/u781pKNvUL0QliYHsHX9EdWIi0rkl+eEXv5XwZ3T5EJ2sjJcYaU8CxpbNpH?= =?us-ascii?Q?wugj/GhXOdE80USAUTMRTWul0lsgflNRcR5T/e0pkgBb0MueuGbNzmsdI78o?= =?us-ascii?Q?wPVgnpHGlb8SM/fOwnBy0d1e/lfhcaNqtaudnbuepzgGwOlbjrjEiVmbyVSp?= =?us-ascii?Q?3PnpNz9uRLO6xSPQf+FbE3ff5ots8wRbFBN7JOCkSKR/83WkGmNJbPdo/3iG?= =?us-ascii?Q?VD857z4YZdfpk7jFeM8QQiwt2PvA49GsH6MtMQldbiAKJfYCPfmWizafTD5c?= =?us-ascii?Q?IrtzNA=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4602.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fa500bd6-a05d-4e86-1f21-08d9d71ee2c2 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jan 2022 05:29:50.1749 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mYpeO1cdNBGQp2exbl9c/+XjZSHjxOyok0t284nAu+ulPYK+Wdawf6xux90G4NXHPqhVBKGy79LPW3faeDFSWG9/4twdIJCn7Tiz8lV3xmQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2174 Return-Path: rangasai.v.chaganty@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sai Chaganty -----Original Message----- From: Oram, Isaac W =20 Sent: Tuesday, January 11, 2022 6:20 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-devel][edk2-platforms][PATCH V1 07/27] S3FeaturePkg: Use Min= PlatformPkg build include files Use the MinPlatformPkg common core build files to build libraries needed by= this feature. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Isaac Oram --- Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.fdf | 2 +- = Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc | 72 ++-= ----------------- Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc | 18 +++= ++ 3 files changed, 26 insertions(+), 66 deletions(-) diff --git a/Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.= fdf b/Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.fdf index 34caf3dacc..fdd16a4e03 100644 --- a/Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.fdf +++ b/Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.fdf @@ -7,4 +7,4 @@ # ## =20 - INF S3FeaturePkg/S3Pei/S3Pei.inf +INF S3FeaturePkg/S3Pei/S3Pei.inf diff --git a/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.= dsc b/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc index f94bd2b431..cc34e78507 100644 --- a/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc +++ b/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc @@ -18,12 +18,12 @@ # ##########################################################################= ###### [Defines] -!ifndef $(PEI_ARCH) - !error "PEI_ARCH must be specified to build this feature!" -!endif -!ifndef $(DXE_ARCH) - !error "DXE_ARCH must be specified to build this feature!" -!endif + !ifndef $(PEI_ARCH) + !error "PEI_ARCH must be specified to build this feature!" + !endif + !ifndef $(DXE_ARCH) + !error "DXE_ARCH must be specified to build this feature!" + !endif =20 ##########################################################################= ###### # @@ -31,34 +31,7 @@ # ##########################################################################= ###### =20 -!include MdePkg/MdeLibs.dsc.inc - -[LibraryClasses] - ####################################### - # Edk2 Packages - ####################################### - BaseLib|MdePkg/Library/BaseLib/BaseLib.inf - BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRepStr.inf - DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf - IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf - PciCf8Lib|MdePkg/Library/BasePciCf8Lib/BasePciCf8Lib.inf - PciLib|MdePkg/Library/BasePciLibCf8/BasePciLibCf8.inf - PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci.i= nf - -[LibraryClasses.common.PEI_CORE,LibraryClasses.common.PEIM] - ####################################### - # Edk2 Packages - ####################################### - HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf - MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAlloc= ationLib.inf - PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf - PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf - PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf - PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/= PeiServicesTablePointerLibIdt.inf - - ####################################### - # Silicon Initialization Package - ####################################### +[LibraryClasses.common.PEIM] SmmAccessLib|IntelSiliconPkg/Feature/SmmAccess/Library/PeiSmmAccessLib/P= eiSmmAccessLib.inf =20 ##########################################################################= ###### @@ -92,34 +65,3 @@ =20 # Add components here that should be included in the package build. S3FeaturePkg/S3Pei/S3Pei.inf - -# -# Feature DXE Components -# - -# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzi= lla.tianocore.org/show_bug.cgi?id=3D2308 -# is completed. -[Components.X64] - ##################################### - # S3 Feature Package - ##################################### - - # Add library instances here that are not included in package components= and should be tested - # in the package build. - - # Add components here that should be included in the package build. - -##########################################################################= ######################### -# -# BuildOptions Section - Define the module specific tool chain flags that = should be used as -# the default flags for a module. These flags are a= ppended to any -# standard flags that are defined by the build proc= ess. They can be -# applied for any modules or only those modules wit= h the specific -# module style (EDK or EDKII) specified in [Compone= nts] section. -# -# For advanced features, it is recommended to enabl= e [BuildOptions] in -# the applicable INF file so it does not affect the= whole board package -# build when this DSC file is active. -# -##########################################################################= ######################### -[BuildOptions] diff --git a/Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc b= /Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc index 28ee49d429..e16a1f8d00 100644 --- a/Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc +++ b/Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc @@ -24,6 +24,24 @@ PEI_ARCH =3D IA32 DXE_ARCH =3D X64 =20 +[Packages] + MinPlatformPkg/MinPlatformPkg.dec + +[PcdsFeatureFlag] + # + # PCD needed for MinPlatform build includes + # + gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable = |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable = |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |FALSE + +# +# Include common libraries +# +!include MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc +!include MinPlatformPkg/Include/Dsc/CorePeiLib.dsc +!include MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc + # # This package always builds the feature. # -- 2.27.0.windows.1