From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web08.18670.1629687438123524132 for ; Sun, 22 Aug 2021 19:57:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=VpyIeyGp; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: rangasai.v.chaganty@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10084"; a="197273022" X-IronPort-AV: E=Sophos;i="5.84,343,1620716400"; d="scan'208";a="197273022" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Aug 2021 19:57:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,343,1620716400"; d="scan'208";a="574502055" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga004.jf.intel.com with ESMTP; 22 Aug 2021 19:57:17 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sun, 22 Aug 2021 19:57:16 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Sun, 22 Aug 2021 19:57:16 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Sun, 22 Aug 2021 19:57:16 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Sun, 22 Aug 2021 19:57:16 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UKP8yuAzdok0A7buq0a0aq7JuNMNbyUHAcgPeut/dmRQyfBsHJRprH+d22B8bAtRNDZ56XdyYoYoIBfUQoXJ+A55fWetC0R2paAUpVCPU5YFWPd6NfufnDrIfUvfTMMQdkuagTDHIG4EQMbq3iZ8GxIbZYrHwKygeoCHO2CX3Wak1tP2be0Ss6CSMuHdSyS7+f1ignx1mXYbIlYeIpubAijMN7jCuZNtfXLQE8MzGR8w9oNTKHKwVsKdSDSLYEkM9ujvKr9JkGrK7FZJMJeqn/V0a0N+dMdV3KiDatEvWJ681Poaw0pF60GDVkR+Nb4bZZ51cilwbATCeerBV+Dniw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BgPwfaV3MiA8oqI7o9rB/FoHkvDnkb6NW5KZRwsP2MA=; b=EX4uEigCRXBuDQMLtkRqqdqNaB8nyp1eGBmfo3kSdlHMABg9LMokYXgdD/wf+UBvF5xsrqb3rcu9ZgtYFOH2UEDRJtOtFD3M/mMilA8uApvZybb0Zg/u1otf9LXUDWBsrTSx6MdiD7YogCBPZ9DHrCA4tYTx+bWkEhTfRP646SBzDfYEH+VYtF0k8YCLS3NOM1sqreR9ROo8NW1HMxbfb6a4ivCpXgT1UvXRLWRzvrjsQIUu4FRIO5FCJvyEXet+w1yu6j4eC5WSai6C+kcSInHadv2euan++hHH5hFITZuQ9iA1T9R2j1Ku//xQPNvYenmAbr+PGJpp0rzdvQwxUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BgPwfaV3MiA8oqI7o9rB/FoHkvDnkb6NW5KZRwsP2MA=; b=VpyIeyGpvEWBCJG6Xb4Y5/zbftKZr8nybC4+rFzKWtzRpmk2P6dn4IblDNGn7G98xEFIBeNv0hxs6IrrqrK9whYy8XypvD572vppZBpzNmCeqXiDvWzG5gUIrpHOr2NeYABjZRGVvzHTgOyG/+KNiOOjPUnVw8VIwydn6FjUZbQ= Received: from MW3PR11MB4602.namprd11.prod.outlook.com (2603:10b6:303:52::19) by MW3PR11MB4650.namprd11.prod.outlook.com (2603:10b6:303:54::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.19; Mon, 23 Aug 2021 02:57:15 +0000 Received: from MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::f015:1569:4279:35e5]) by MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::f015:1569:4279:35e5%2]) with mapi id 15.20.4436.024; Mon, 23 Aug 2021 02:57:15 +0000 From: "Chaganty, Rangasai V" To: "mikuback@linux.microsoft.com" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Luo, Heng" Subject: Re: [edk2-platforms][PATCH v5 23/46] TigerlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib Thread-Topic: [edk2-platforms][PATCH v5 23/46] TigerlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib Thread-Index: AQHXiBD8+Zj+6gFHvE+sGgJqdPxtU6uAhPyA Date: Mon, 23 Aug 2021 02:57:14 +0000 Message-ID: References: <20210803023914.1569-1-mikuback@linux.microsoft.com> <20210803023914.1569-24-mikuback@linux.microsoft.com> In-Reply-To: <20210803023914.1569-24-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: linux.microsoft.com; dkim=none (message not signed) header.d=none;linux.microsoft.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f56146e4-cebe-4047-7c05-08d965e1b663 x-ms-traffictypediagnostic: MW3PR11MB4650: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4941; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CtwWxp0gZ0VkAzy+oiP8NymGNi6o1w8KrfkQt800h7BMOJxILPlj/EeNUnoT1ZtM7eDTeRh+NwCvgvu7rTkt8Z/B6eVZ5SaVSArsN8oza+7JUzK4wTYMRD4MbB/DLOy9RDpvh9ctEgMUNN4seEr8cy+7tQBIOeRTRnBP0XIXLFzQMjNVfus1zOIh5Pa/deVFQ/YujdOnLWUikrTBQELXelDd+pg+xiKBYwDf5OQ8H/nbhNsyhhzcGhY9HbvjUaQjHnBlef0qU5j6CnHbKQINtXSyn0kB8CvW46fzAWsrH2WSxQAlJqMIKo18fMQtzMtmrnfwOgOaeesrfRz4+WO+x2i/LCrV2ajRfE80E57BchiGexItVjO+r6t3oNMu3ZcYL3JtzeZzNmwu24AaDoz6W6nHYMYzcRo3vgLfdfRdjzZIXUgXCJMDGCEi7+cVqinB1W/rix1ICR5YARWcQdRAShbUIMKD2qlXXB5fuXmEf6P+s6msbqpNd4C4g6ysQs/aGcI3POS+rV81Ql0THa2IYWAklQSZSJppD5O3LmGTW8PZdWIzd7eOl6lyu+i3q7PSFys0rF/w/H5nfvZkZGFdMMMFfqe9jBui9cOcscO5lvovAr9ilfLAx0smXIT+yM3W5WJTeTZ8nJHANMnFc1epISf9PPicsRcDXXD5ikTklO9VbXFvuK1rXb1oOkwzYy+FLyRHIGBq185Q586YbQpv0WNhqz9i2PEtx7Cx54SeCHQM5DmcQHfGSwsH1uBb6VXyBala44gb2EEvng/RxBMVmStxKjptqigmN0K0Qf3FITE= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4602.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(346002)(376002)(396003)(39860400002)(366004)(136003)(86362001)(316002)(52536014)(122000001)(38100700002)(33656002)(26005)(8676002)(186003)(38070700005)(83380400001)(66446008)(71200400001)(8936002)(66556008)(6506007)(9686003)(76116006)(4326008)(7696005)(55016002)(107886003)(2906002)(53546011)(66946007)(66476007)(110136005)(54906003)(5660300002)(478600001)(15650500001)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EOr9MBOkXhGO21CA3/ymUOg3grJV7JrdA1fi4c37p0pqVf+ieyJPlUv6AsFM?= =?us-ascii?Q?1AmtSoIe2VALMfFjZZHQfoGzLblz0Rd4j403CXaIS7CpV2iqW4JYz3MRB2Ob?= =?us-ascii?Q?LO0WF2ST5qJcgMJ61GiAPlPqCy+96Uos9m+TH61lkgN+pM/7c9xpsN8uNiy4?= =?us-ascii?Q?155c7w3H2Ks1SfrcOIIO/RuDmT2dXVvbsYc0BtJA1mxrZFcN/MbwztYLr8hT?= =?us-ascii?Q?LwSf+sO9AuD/sYBBJmUsY3S7H6pEKG+hSXiiccvv/Wtf7zQER0SUk+bmB/7o?= =?us-ascii?Q?dnLBUyS0Y7/1WwdIsQJDpesaMRzLaz9GR1A1mo+llDDeQW7LGqExjGJQLXgQ?= =?us-ascii?Q?nYhURb+TGkS2W83ynoJZZ+daUWsKMVDjY4qEHriszDVYZGVTRKLzW7jQAO3X?= =?us-ascii?Q?CjguaCD32J6mMD9dCTpn31+It5sjGGZXH3vOsq6tQX0emmLMP72fTnV8kDQh?= =?us-ascii?Q?XJQJVFWgiftRzegf4fbAR/OnlV0/NfPxVSHuajvPGGQSSgMKEjvWr589cPBm?= =?us-ascii?Q?c/GTrUScCAJtlVHb40LwM/ZIP4B6dQi9y3TzvUZb84YFbyN5QF9P463wiWtm?= =?us-ascii?Q?8Lkn6EgJEuZAfnuxwS9JebcoYZj2hTWQ0WCD48/Do5s06CjnHNLflFhFL01b?= =?us-ascii?Q?C2xn3INwHDZ4VuqSFWg5Nxex1SzyqlWyPRoniu7/diMH853YZrKbHi5VdSiU?= =?us-ascii?Q?YV2NfVCtBkJSQCgHtPrM4ySvQa+xe7yzAEke9REgeg5oD+0w/6y0wN8PGLXe?= =?us-ascii?Q?fuk0p2/HFQJomoZhU1nZlcpzoqaKQqhN7mUsEO5rpOYjUzVYNu1PQhuqBMrQ?= =?us-ascii?Q?nD9ay49iK/zgb72fLGzwpMi/cgLNBtAqM65IhskA+H4HcHAXKDzrmQID2L1h?= =?us-ascii?Q?dLkYIOxFLofzP/cPAFdH/Vuz6wXAxvVFrdA+tN+N1SBnXbZppvGd8r/vOY9E?= =?us-ascii?Q?uuYiaj1IiXy+0+7Ee+D19dvz6l34iDGawUqIptxSI+UtHe1yt+/YCkyvxkZd?= =?us-ascii?Q?bC8vGUEvzgNX9DCm1BlNHDjshOaZnPKrAjZNwZslO6H5egFY1c+5038Q/LiI?= =?us-ascii?Q?2oLHZ1iP351LGT980zsJ1N6kpMwowseSElCbWoFXHBD89MfvW1fsfjq3eQKR?= =?us-ascii?Q?vfEUc6tfdHgvF2bzYW5DBQ5QOm5NCmDVipEZ9nthKkHwmfDrIBW+0M+BjUoy?= =?us-ascii?Q?xVvazXxoFqt1IxLDya9aO5AqZPBBL5v3vnEdxXUcIttROGz+DMSQwpa9/Np7?= =?us-ascii?Q?aMzv8odfRN6l3IY5Jpc4GzUP9LK02j8+J+FczDiq9sXDj21X/V4oq4/Vlwia?= =?us-ascii?Q?NhPWz3V98SxfCgof3bgNbWEX?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4602.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f56146e4-cebe-4047-7c05-08d965e1b663 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Aug 2021 02:57:14.9724 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aE00REjsd7fu2+GDXPSyUUC4izSm6jXaXPZe4o9Rp15DVsHFRTwzjuhX7+t8/ESnLdcPcLk22eVoCVCJIMnhNWgQRkAr0twiIsh8pCWNzPo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4650 Return-Path: rangasai.v.chaganty@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sai Chaganty =20 -----Original Message----- From: mikuback@linux.microsoft.com =20 Sent: Monday, August 02, 2021 7:39 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Desimone, Nathani= el L ; Luo, Heng Subject: [edk2-platforms][PATCH v5 23/46] TigerlakeOpenBoardPkg: Update Spi= FvbService & SpiFlashCommonLib From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 Updates TigerlakeOpenBoardPkg to use the SmmSpiFlashCommonLib instance in I= ntelSiliconPkg and the SpiFvbServiceSmm driver in IntelSiliconPkg. Cc: Sai Chaganty Cc: Nate DeSimone Cc: Heng Luo Signed-off-by: Michael Kubacki Reviewed-by: Nate DeSimone --- Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc | 7 ++= +++-- Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.fdf = | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPk= g.dsc b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc index 1adf63403450..758b966fee81 100644 --- a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc +++ b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.ds +++ c @@ -173,7 +173,7 @@ [LibraryClasses.X64] !include $(PLATFORM_SI_PACKAGE)/SiPkgDxeLib.dsc =20 [LibraryClasses.X64.DXE_SMM_DRIVER] - SpiFlashCommonLib|$(PLATFORM_BOARD_PACKAGE)/Library/SmmSpiFlashCommonLib= /SmmSpiFlashCommonLib.inf + =20 + SpiFlashCommonLib|IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiF + lashCommonLib.inf !if $(TARGET) =3D=3D DEBUG TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLib/Smm= TestPointCheckLib.inf !endif @@ -297,6 +297,10 @@ [Components.X64] !include $(PLATFORM_SI_PACKAGE)/SiPkgDxe.dsc $(PLATFORM_SI_BIN_PACKAGE)/Microcode/MicrocodeUpdates.inf =20 +!if gMinPlatformPkgTokenSpaceGuid.PcdBootToShellOnly =3D=3D FALSE + IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSmm.inf +!endif + # # SmmAccess # @@ -326,7 +330,6 @@ [Components.X64] NULL|$(PROJECT)/Library/BoardAcpiLib/SmmMultiBoardAcpiSupportLib.inf } =20 - $(PLATFORM_PACKAGE)/Flash/SpiFvbService/SpiFvbServiceSmm.inf $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitSmm/PlatformInitSmm.inf =20 UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf { diff --git a/Platform/Int= el/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.fdf b/Platform/Intel/Ti= gerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.fdf index e3b2f048524c..b802c2167d06 100644 --- a/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.fdf +++ b/Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.fd +++ f @@ -434,7 +434,7 @@ [FV.FvOsBootUncompact] !if gMinPlatformPkgTokenSpaceGu= id.PcdBootToShellOnly =3D=3D FALSE INF $(PLATFORM_PACKAGE)/PlatformInit/S= iliconPolicyDxe/SiliconPolicyDxe.inf INF $(PLATFORM_PACKAGE)/PlatformInit/PlatformInitSmm/PlatformInitSmm.inf -INF $(PLATFORM_PACKAGE)/Flash/SpiFvbService/SpiFvbServiceSmm.inf +INF IntelSiliconPkg/Feature/Flash/SpiFvbService/SpiFvbServiceSmm.inf =20 INF UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf INF $(PLATFORM_PACKAGE)/Acpi/AcpiTables/AcpiPlatform.inf -- 2.28.0.windows.1