From: "Chaganty, Rangasai V" <rangasai.v.chaganty@intel.com>
To: "Holland, Michael" <michael.holland@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [PATCH] Define FIT 4 record
Date: Fri, 8 Oct 2021 23:33:08 +0000 [thread overview]
Message-ID: <MW3PR11MB46024C7958F8BF6C54D67236B6B29@MW3PR11MB4602.namprd11.prod.outlook.com> (raw)
In-Reply-To: <SJ0PR11MB50248A0A2F297956257D2B0BEAA99@SJ0PR11MB5024.namprd11.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 777 bytes --]
HI Michael,
The actual changes are fine.
A couple of comments on the patch format.
* It's good to include the repository and package name, in the subject line
[Repo Name: [Optional] Patch Version# #/total #] PackageName: <One line summary of the change>
* Commit message is missing the BugZilla reference.
* CC maintainers as part of the patch mail.
You can get more details on these guidelines here<https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process>.
Regards,
Sai
From: Holland, Michael <michael.holland@intel.com>
Sent: Tuesday, September 28, 2021 7:15 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Ni, Ray <ray.ni@intel.com>
Subject: [PATCH] Define FIT 4 record
[-- Attachment #2: Type: text/html, Size: 5547 bytes --]
prev parent reply other threads:[~2021-10-08 23:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 2:15 [PATCH] Define FIT 4 record Holland, Michael
2021-10-08 23:33 ` Chaganty, Rangasai V [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW3PR11MB46024C7958F8BF6C54D67236B6B29@MW3PR11MB4602.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox