From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.7645.1625812361349746683 for ; Thu, 08 Jul 2021 23:32:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=K5iZ9ZWT; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: rangasai.v.chaganty@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10039"; a="209472758" X-IronPort-AV: E=Sophos;i="5.84,226,1620716400"; d="scan'208";a="209472758" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2021 23:32:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,226,1620716400"; d="scan'208";a="424239300" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga007.fm.intel.com with ESMTP; 08 Jul 2021 23:32:36 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 8 Jul 2021 23:32:36 -0700 Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Thu, 8 Jul 2021 23:32:35 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 8 Jul 2021 23:32:35 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Thu, 8 Jul 2021 23:32:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O1Vxh3k6Gud1Zo699seJxQw14nJRYT/T7Mm3z+4EQc5sh03QzLEnxMgPl3yz+74I9YtXC/fd/c9txcXe5d/ZTU1abGWVqV4zj6UKr2TcKPWDdNjWEFsUWabtFpPAZgy52sCxVIy3OxG2GvS076CFpOMjtxxbMlZJIV6duKZ5XyEWjOxTcXjkVswFY2yLojl3X7dDiSlEEk8xowTNU9gh9iz30lhQoq8jaBmKvDWoeLpx+EA6hrh0SRMplmitsTqwrufRJ/0XAM8l2j5yyjHJ4mANvIbaiAeCEl4ZboYW0ogJdu1Rbm/lbAL1p36mDxG3ebMxhxVf1jY+LCArguJKLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SjYJymx1RfIWdK3GYju5UT+BD1R05HA1IXlKgCorFBs=; b=kvhSJJ5zLOFKrZ+6xG5XELFoCBeTlpuOSuvg+xSamlAtoau/9hQ7VNegt/cgbpn8Y1TEVT2urdJlLImLsR22DR5YswnHPJ3QQZ4H7VB9xMkeU6Cn5BXf8dEHcNPmTbeDbPKG8H0j3hT7JMIrSV5CbVvnJOZy5U+KxURHpO3nZZXU8Wb5Wx2Vf5Tp0MtGNafeznaKAptFl3hfd5CH1IDpRpMEVmZ1KCWos+KeK8on5KW8bwDFJZ58Qoobs/8SQSCAQPSZJuUfqspD1ZLmx0fKzVLJHDJJSpJSyi9qKP0B3gm6DhdRZ1pLLse28eeqvcwWfpspHX94mHdkM5hdAwaGvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SjYJymx1RfIWdK3GYju5UT+BD1R05HA1IXlKgCorFBs=; b=K5iZ9ZWTf0RUEPdmMvNUSJFOyPpoWg+4MqAR+gJlx8LOMDjbvFmvo8QvdRous7bbOEHMcjVNBPFl0IHvLrJUG25svsa2Abk3Bujt+6xfWPQ0XdO+4FmWzPiJ6l7gFKrDbSw8HzQ/6cDxEwm42w/0KDJRl2PhqtxWDyqmuzl4AlI= Received: from MW3PR11MB4602.namprd11.prod.outlook.com (2603:10b6:303:52::19) by CO1PR11MB4803.namprd11.prod.outlook.com (2603:10b6:303:90::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.22; Fri, 9 Jul 2021 06:32:34 +0000 Received: from MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::5d92:adb0:834d:f5f2]) by MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::5d92:adb0:834d:f5f2%7]) with mapi id 15.20.4308.023; Fri, 9 Jul 2021 06:32:34 +0000 From: "Chaganty, Rangasai V" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , Liming Gao , "Oram, Isaac W" Subject: Re: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package. Thread-Topic: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package. Thread-Index: AQHXdAdgwsm5h3WpZUCDml1qJmd9yqs56OvAgABHMoCAAAAT8A== Date: Fri, 9 Jul 2021 06:32:33 +0000 Message-ID: References: <20210708144056.1740-1-chasel.chiu@intel.com> <20210708144056.1740-2-chasel.chiu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 773b0e7c-1f76-4f3c-67ee-08d942a35617 x-ms-traffictypediagnostic: CO1PR11MB4803: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:27; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: KHaR23anobcmcEHm5IBSjnS6YgNdAWidreZf3sBR5Zm/39Aeyu8mnQ9YjbByvzKd9TueDElHHdndlsF3vm0WtVWKnfTIGy/Jq97eej/R7Vq3M2DW9PcUJ/y0HaR9MkIwmvdGgWC1+fZwh7BmBipFm0ilhA2BXeRVQcAVLq5bCSeqxnyA7QWNCOacDTnIoaLcoVT6ngvSqWBZX6MZ/3ivS2t3ZF/SbqsstxTvMWap7oyegiYZ6gc6uzjw5yBD2NC9KDUNl3CUPRflBWjVP/CL64/DqYVITdsVYb+CFsP9vBrmNsFpErmSdFxoA4rQNjKKYOaojXQsHBh/QPaQ/uF8wva10XYdX1voQvTm9y2nOc53fTmaZA5Tn3WznlNqJ8UtiUzq0nO1zN6+lF+BQYYYoXHZAqbXlofEFurwuyTHZp4kpD+gXJf4iLIZkMFAHDlb8Zd65cDZNubyjNqwr3Qo9cD+U7PdPjCUKzcD+WX2GeA+l7TNxK83SJN2hTRVlaQ5r/VnCpMnbcgJahe31q7G47OjUstW7qubs+XeUE6IvzPQotN18+1TuJa2xPt8zVeUCuramz/UvTmaVBw6XGtSSDYVPQqXeW29N6Q1jEuEte4uVPfuPt7onDhBh2EBcNZS1fwNUzC7S0zilhFQCtvwtoCMcIbulkEK9AH6t5RdlA9SEcZB2JIPF5UYKVA2Y9QPpOi7xoq46RfOQoi6gZIQphd2Koss9Sah6a6lCv6uz9c= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4602.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(396003)(39860400002)(346002)(376002)(136003)(366004)(71200400001)(76116006)(8936002)(83380400001)(186003)(478600001)(33656002)(8676002)(316002)(7696005)(52536014)(66476007)(966005)(66446008)(4326008)(86362001)(6506007)(110136005)(64756008)(107886003)(5660300002)(55016002)(9686003)(122000001)(66946007)(66556008)(2906002)(38100700002)(53546011)(54906003)(26005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2QBcrkZt4PBsu1TvjAtMV/n3nPM4iUXGdCXcO4QIdt/Olo4xP+ypMPkxvP/T?= =?us-ascii?Q?I1e1XS1kq1p0FNKmwwVXXYIROyer1mRxPGgfZkHkqwqsDQtBgqf43BtQZlYt?= =?us-ascii?Q?qqDtf0KIiswOCT+xMcNfTNTZlJkft6OMTx14S+lxR+pekrPNwZxmwaAvr2Ab?= =?us-ascii?Q?F+OulpULWdsvFQ/YdUJ8i3q0Vp0Ps8ma+pX8KxcQ6K83C5rcQgkpYMhV6L/O?= =?us-ascii?Q?oaq/sO6xw2SUpKpn9nA8v+rRDv1pkc44f4F6ne9SJU+5JEqLrriPrTrAEeZl?= =?us-ascii?Q?M9fo6bsHUG7NxgYaKCXGRdmM4vLJO34uqzByEOxDWg7wV0TERkNOblPBUrua?= =?us-ascii?Q?dhaPob/5taGv350fRUOfl3dVCpBRTafonO804j6FToeIVfp5KyzUoaN2dOay?= =?us-ascii?Q?008XU/OfLvx/jYDlY+wFJFtrOaCTfHfb9Ujg9bRwjDkrFK5GG6rZxBYnkMVF?= =?us-ascii?Q?Q7fu5KFu7v/LRJ9+/uBEZAn6tUCUd+1dKtucBADNo2VjFMqau50nQdwBIiQf?= =?us-ascii?Q?bGNqPnk1g04WIIVUYprQdl+veQ3XFPzgfTjxrfZiKNcGaOoN8jzcyDron5jI?= =?us-ascii?Q?lKfHgvgM1J1VaXRJsLgfIFbdMyxpoOjRFdYDUNcyX6rjqefOn4LCEGgmBf7S?= =?us-ascii?Q?CeEaul+LGOZs0gXY/eZUG3DZnViYoXU8WkiO5pfF3lyfUFH3n9xxzNSr0b9Y?= =?us-ascii?Q?a5Zra9JB0aXupfr44e47m+Xo84ByEL+QnBA49lI6zuH8MNK/mkJcsAR/9Zf8?= =?us-ascii?Q?BSRPvYLlfubNeAktYvuYQgrt79ZmJCZmOKbNnmNGVg1AvxjtspNBJtDmoF6O?= =?us-ascii?Q?kSq3mRGxoZTDr7Bj8XJZV1zWkaN8VRXWjCU/uPhKitmEN4/+qaCiiJA90Q3Z?= =?us-ascii?Q?03S5JOSa3eVtueoHeuu8/3ITzm6R8rTpSzQyG0rttEBeTIeRcPTC0cUohSJk?= =?us-ascii?Q?YbG30POsVay957JTZdWN6II6HASbxsyamoT9AF6wIq8syewsH7LUKdI3OWcx?= =?us-ascii?Q?tmo3xug3zhumpnUB9KSItbVXqDs3U3CrLalvfNI/wzDUENq/T1Q8mC1Pxbdu?= =?us-ascii?Q?ncRbsycKzJN3UdgizOh5T5yBYOXhIWLsIa1PpS8O/QSQiLQlXotPWZn4jXkM?= =?us-ascii?Q?l092mhbm9YauytyBCZWU+lNQ+EdC5YM4T1FIo1qlVRBuQv2Rr4+SrJ7v/z97?= =?us-ascii?Q?C9D+/tDssR9TaK9iQxRUTPFYZO5k8prQHfEaOcQ33CgR69RRb1m9ymE30so8?= =?us-ascii?Q?kVSQL1lsx1eY+l1nXZzorwp/xSRS3xzvrfabDaI4Gv5HUhk0jZfsBQl9Yn+J?= =?us-ascii?Q?rBm954lbOHw2QZ/L4PDUc1nC?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4602.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 773b0e7c-1f76-4f3c-67ee-08d942a35617 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2021 06:32:34.0047 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NzdZpUQP1cHh/tHeXDosNOFdHqRZ9+9Qs5J7bFF+LUv4WJ6mdwF8BoCgIP4T7eR/DS8g3retTJ3zhR3U421fYODhpad8zBSID48B9gDlljM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4803 Return-Path: rangasai.v.chaganty@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sounds good. -----Original Message----- From: Chiu, Chasel =20 Sent: Thursday, July 08, 2021 11:32 PM To: Chaganty, Rangasai V ; devel@edk2.groups= .io Cc: Desimone, Nathaniel L ; Liming Gao ; Oram, Isaac W Subject: RE: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this= package. Hi Sai, We will fix the build failure first and macro naming convention will be che= cked separately later. Thanks, Chasel > -----Original Message----- > From: Chaganty, Rangasai V > Sent: Friday, July 9, 2021 10:25 AM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Liming Gao=20 > ; Oram, Isaac W > Subject: RE: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build=20 > this package. >=20 > In ServerManagment.h, please make sure the newly added macros and=20 > structure names are EFI/PI spec defined. > If they are not, please remove "EFI_" prefix from the names. > With that: > Reviewed-by: Sai Chaganty >=20 > -----Original Message----- > From: Chiu, Chasel > Sent: Thursday, July 08, 2021 7:41 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L=20 > ; Chaganty, Rangasai V=20 > ; Liming Gao=20 > ; Oram, Isaac W > Subject: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build=20 > this package. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3484 >=20 > Fixed the build failure of this package. >=20 > Cc: Nate DeSimone > Cc: Sai Chaganty > Cc: Liming Gao > Cc: Isaac Oram > Signed-off-by: Chasel Chiu > --- >=20 > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/P > eiGenericIpmi.inf | 1 + >=20 > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeatu > re.dsc | 11 +++++++++++ >=20 > Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerMa > nagement.h | 17 +++++++++++++++++ > 3 files changed, 29 insertions(+) >=20 > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei > /PeiGenericIpmi.inf > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei > /PeiGenericIpmi.inf > index 0ef2c18116..bd995ef25f 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei > /PeiGenericIpmi.inf > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei > /PeiGenericIpmi.inf > @@ -42,6 +42,7 @@ > DebugLib >=20 > IoLib >=20 > TimerLib >=20 > + ReportStatusCodeLib >=20 >=20 >=20 > [Guids] >=20 >=20 >=20 > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFea > ture.dsc > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFea > ture.dsc > index a1fcefad70..05a7d4f0af 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFea > ture.dsc > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFea > ture.dsc > @@ -59,6 +59,12 @@ > PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf >=20 > PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf >=20 >=20 > PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibId > PeiServicesTablePointerLib|t/P > eiServicesTablePointerLibIdt.inf >=20 > + > ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiR > eportStatusCodeLib.inf >=20 > + >=20 > + ##################################### >=20 > + # IPMI Feature Package >=20 > + ##################################### >=20 > + > IpmiBaseLib|OutOfBandManagement/IpmiFeaturePkg/Library/PeiIpmiBaseL > ib/PeiIpmiBaseLib.inf >=20 >=20 >=20 > [LibraryClasses.common.DXE_DRIVER,LibraryClasses.common.UEFI_DRIVER] >=20 > ####################################### >=20 > @@ -72,6 +78,11 @@ > UefiLib|MdePkg/Library/UefiLib/UefiLib.inf >=20 >=20 > UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib > /UefiRuntimeServicesTableLib.inf >=20 >=20 >=20 > + ##################################### >=20 > + # IPMI Feature Package >=20 > + ##################################### >=20 > + > IpmiBaseLib|OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLib/ > IpmiBaseLib.inf >=20 > + >=20 >=20 > ########################################################## > ###################### >=20 > # >=20 > # Component section - list of all components that need built for this fe= ature. >=20 > diff --git > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Server > Management.h > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Server > Management.h > index 244b86e91a..7591f33aba 100644 > --- > a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Server > Management.h > +++ > b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Server > Management.h > @@ -149,6 +149,15 @@ typedef enum { > #define UPPER_NON_RECOVER_GOING_LOW 0x400 >=20 > #define UPPER_NON_RECOVER_GOING_HI 0x800 >=20 >=20 >=20 > +// >=20 > +// Definitions for Get BMC Execution Context >=20 > +// >=20 > +#define EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT 0x23 >=20 > +// >=20 > +// Current Execution Context responses >=20 > +// >=20 > +#define EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE 0x11 >=20 > + >=20 > // >=20 > // Server Management COM Addressing types >=20 > // >=20 > @@ -318,6 +327,14 @@ typedef struct { > UINT16 IoBasePort; >=20 > } IPMI_HOB_DATA; >=20 >=20 >=20 > +// >=20 > +// Constants and Structure definitions for "Get Device ID" command=20 > +to > follow here >=20 > +// >=20 > +typedef struct { >=20 > + UINT8 CurrentExecutionContext; >=20 > + UINT8 PartitionPointer; >=20 > +} EFI_IPMI_MSG_GET_BMC_EXEC_RSP; >=20 > + >=20 > // >=20 > // COM Layer Callback >=20 > // >=20 > -- > 2.28.0.windows.1