From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web08.4583.1626765621920112984 for ; Tue, 20 Jul 2021 00:20:22 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=i23obh55; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: rangasai.v.chaganty@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10050"; a="209287312" X-IronPort-AV: E=Sophos;i="5.84,254,1620716400"; d="scan'208";a="209287312" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jul 2021 00:20:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,254,1620716400"; d="scan'208";a="414590765" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga006.jf.intel.com with ESMTP; 20 Jul 2021 00:20:20 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 20 Jul 2021 00:20:20 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Tue, 20 Jul 2021 00:20:19 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Tue, 20 Jul 2021 00:20:19 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.104) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Tue, 20 Jul 2021 00:20:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HhSm+8cjOy+7ITGj6t3VaevGFpEo5DhxkAXeRTSUONK5o2+rlNNQkq9RLv5FrLcNk3XRYR41tGIPtRTCmKB99wrdECWIFejLi5iqF4/B2OrE/IJg9N5gEeAzj0f+loZVKZl3YiujJSOBrhke1633NO2taW3Etoelrzfyqyl9MDqk95paZM0Hd1ctXIe5gzj7+WXtDiWj4okQviqSCCOhhdUS7fR+Kxt4TwUx/iaPWHSnlSrr8vCNN4qzrq4S/Pql2Cvc2pZVmvho2t+8ZsdIrlSJ7g9Jq6Dt+EM/Zv6AZMsjVVlczmjbhj1w/EgCiyhmAuFvy0PqIat4aEBfjjcybQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FHwE+87QyKnYMRxmdQ82ez+bEdnacmuc5eE/mAEGkaA=; b=DuOZvSgrlnaMQlxEzlupZWuzZQreeo9cE8jjv31nHyBd4aOljIsFWv8iWV4FqBu9s8mnvelPBNlVu2GcGibe9mhYol0QqBTlP1WSFMEGMui7z6q10kCZTY8h7wCD115pFfra/P3ZsFDA22JSnbRhCCaTTIcQ0qDFmvpjVfG6NLSOtxlv31vf8fYGztHFmNeO8whEKs/6OXQ6spi1a2HYKW6I634nHZC0TrRVWISyoE2/RdBBDUWPHsrjSdJ18YocOkUP52GOOXh9rpsZijfiRxkx3YG86kRpyYJaWYGrCBgTAY8qY4sfA6nNPO0DfKU8MK9uYaE6wB2vFcJ6N+IagA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FHwE+87QyKnYMRxmdQ82ez+bEdnacmuc5eE/mAEGkaA=; b=i23obh55SqvtHZuN5mfh31+Mty2R4Fsj1oy7lbBC03IJWfQ1l6gNObClkbL+RLtReQVZZ/fnasdZR9QmZ0C2Vxa+8HCjSLt7zxAuK7YElN6WWRq9Qwzmvh43A+7wB5LYmHWIDjrXpcRWLBGXLQllh+C74XIO+Mpepj9sLbFhG6c= Received: from MW3PR11MB4602.namprd11.prod.outlook.com (2603:10b6:303:52::19) by MWHPR1101MB2189.namprd11.prod.outlook.com (2603:10b6:301:51::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4331.24; Tue, 20 Jul 2021 07:20:15 +0000 Received: from MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::5d92:adb0:834d:f5f2]) by MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::5d92:adb0:834d:f5f2%9]) with mapi id 15.20.4331.034; Tue, 20 Jul 2021 07:20:15 +0000 From: "Chaganty, Rangasai V" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , Liming Gao , "Oram, Isaac W" Subject: Re: [edk2-platforms: PATCH] Features/Intel/IpmiFeaturePkg: Use MdePkg macros instead of redefining. Thread-Topic: [edk2-platforms: PATCH] Features/Intel/IpmiFeaturePkg: Use MdePkg macros instead of redefining. Thread-Index: AQHXeYcGgBI1DfsaTUSfRcb0PM3gjatLfESA Date: Tue, 20 Jul 2021 07:20:15 +0000 Message-ID: References: <20210715143741.1295-1-chasel.chiu@intel.com> In-Reply-To: <20210715143741.1295-1-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: eeea6861-bcdb-4067-52bd-08d94b4ed253 x-ms-traffictypediagnostic: MWHPR1101MB2189: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:404; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: j4lWRJRaW3DOc6JBqeHuaoPlYDe/WoTDvt28vPusfLhBNRGDf/f6mMFx0w1LyeGoaEpzLTlWpKpu9Fyl3ZxA7/GDl3uDn4KT1Flmg4mSoihXjkL3SgV+V8WncEetlmYB1+3ZPxzRbS2JbqIwL8LTPMXuDz8YC1mPrzrYyfmE+2Zpq+g0GtCVRQvzed8Y6XbGPftpEbyK2Mw6m7PW5Y5FZHL3SHmlBl1VpFzmo80W6JukZ0RvZ6KMV2XwlVhoiZCovM6lVQUFR8MytwemH7vmoPERpJPKLkp03ZkEC02zFUw9CZbEcchG3oqeb4IbjbLr2KwJB2ua947ykA14dpJiupXR5omzbNcwp5ZGQBZ343o60BQAoXrcs/MGwgXl2qPvkiipQl9v8QFgiySLv+w9d3qJkk7+8Rx5BzIGp2j9sBg//c/45qSdqEPVDO+BQ/6AYWtir5rMfPz3ey8UTfBol2Zl/uq9QApHX0y5B0wei/lzQbCaSLqNasrAwp5lFkcb3/wpmBy/68BUIwrrjdwhAMdWFOVWpKcW7ldXpqy2/pg2hS0yXqFz5nlFSF41L4ptpB5zJeZUWn23DmBEW/XHF/y5A/jTtPbv1qH+6fczAPOVn1/BDWvMs/7VqCAKFLbJrzhcAQJf0rY4l6SMAZ4UlfDcWYXnqvb+H/fceta/ZQrFNNP5O6fLMHambLYSd9hPlw6lBidhy0AjClNYvZkCZ5XmI6jrTdkDiZiuR6eEIE/29bTgGT5ujGn3UcM3rLScmifGpa2p0b/hdkwfsSKFQhVHVm8vTraIulycnVj1u5w= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4602.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(396003)(39860400002)(136003)(346002)(376002)(366004)(52536014)(110136005)(478600001)(71200400001)(86362001)(33656002)(316002)(5660300002)(53546011)(122000001)(38100700002)(54906003)(4326008)(26005)(8936002)(107886003)(186003)(66946007)(76116006)(66446008)(66476007)(64756008)(66556008)(9686003)(83380400001)(7696005)(2906002)(6506007)(8676002)(55016002)(966005)(38070700004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4pUmtRwVGSXzVNYpkgXe0zGnFdUrOFd3dQCV3K+0xpt/Gxf4yPfWMHuzVQpR?= =?us-ascii?Q?cFULaD415A7xHjsZyIionqnVcey5lL/LBg/d6ZQEKm+x0LVFz9VsXLt7iRtX?= =?us-ascii?Q?Zr1OLs66ZYIXjksidh0yBiBY17bUrogjrzOAqlXgWgcnGcvJwVHi5smGhONo?= =?us-ascii?Q?uqthKGyPNZ5FGP3IxxF3VDO/kp7YpnXqwOJOrdtMLUjIvMGZBD6YHK/K0weK?= =?us-ascii?Q?sv0TV5uVdt8XjLQ0sJw3Lu3WxBCX0b04ncrxTiSluiLzRbBZRSOxmnQsGbd/?= =?us-ascii?Q?tdv9VQPDKZubsKd0CB5cOvCHx0b91vb3cpM5I9A7h15WcfU238O2RDTriT9M?= =?us-ascii?Q?rQnh0WLv9sozOUP1oI0dijjv2mApDthH/ZvO6DcN5LXpelDkQU7K8+DVGrOw?= =?us-ascii?Q?e+XQlLFXfRYAUenpQKmyEU5Q7HgwQilfgJmj+N/qgbxjDYI8pF5oezl6Kx4w?= =?us-ascii?Q?fvZQV1Nt0uacWq7uAuBRBU1feH0R1Bqk56lO7roHnuNqZIiWgUntB4m+nTGw?= =?us-ascii?Q?wr/dnx4f9ReJ19yeEJcV+B/z0JRLo1VU3OFCxTDjjSqsLLFbogza04ATCfb4?= =?us-ascii?Q?XKlj+GXgJ+ks5ZD57mqnnGidUq+iq23fDlPYd9xANmf/JafWDFzQjyfEGfIs?= =?us-ascii?Q?knPgGz8rrP0KVVNj+eg9PXFdHgc9i7yD1P05ThO8x6Z9dsPW4PQvAMH+rWqo?= =?us-ascii?Q?vJzh3ww/76MAgEo66a7/qvJrOvUXcmsJG6k01yuUeufqQlPtL+3herI22Sj0?= =?us-ascii?Q?qrRAK4ZkcLCd8mbTk5P5WAC+ub2HedDAO83Xy/hwglSXNCfMp6P9a9LxO9If?= =?us-ascii?Q?iv4vdA0SK1vYC/33OT2x9unA2Xpzo84LfvTVWTHriom6FrfLD0XerItM0cge?= =?us-ascii?Q?KhIcxCQSFnTioUosMwgKlf5pIk7GC81aZhxgoGXkoZ8VIfEaZqP7UujCr3Ka?= =?us-ascii?Q?Nc/KtEgOr4Z4xtwWf9lRwlVfEPC4gWbo54UEBbRRDwscOTPRuZ3XMZ8HzuPl?= =?us-ascii?Q?NjBL7n3xeC3Ow5WkAXF1VUuEng9zVjL0Jyn82yhmsfSvbUNbjOqm4YQIIbnT?= =?us-ascii?Q?NMVhedJizwXIBptH63PL6/DS46WyNYlohNVnvZyyDXVZ6Th2yitXwk6agBDu?= =?us-ascii?Q?0zSZdeIm+23t8wawqzu4X1AKNcqjxNZbKgEAXWsC+5+7QwUlMftb/Lbe9C0w?= =?us-ascii?Q?D+iTqCGAtBEoduHBnsjR50FNEZCjd4DEfmHXsrQhr/yhyltdbQ/gHWItJRCB?= =?us-ascii?Q?jow58V1gFW6j+Q/47a2szEdKgbB6ej+8fHnp6Q56Bwk3PQeoWsHAMdZtaNav?= =?us-ascii?Q?iq9phIFdlNnmIl2b9VS1tM/f?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4602.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: eeea6861-bcdb-4067-52bd-08d94b4ed253 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jul 2021 07:20:15.7435 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: SLePlluSsPoj8gEOtzeFtdVZGtCDioPNPOa8BjOWyxCEt3K9iYM+r5pqtDjZir8zwhLI5oFChTT8UOxNF5loirL2N5vCVGi/BeAz9aa8gbg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2189 Return-Path: rangasai.v.chaganty@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sai Chaganty =20 -----Original Message----- From: Chiu, Chasel =20 Sent: Thursday, July 15, 2021 7:38 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Chaganty, Rangasai V = ; Liming Gao ; Oram, Isaac W Subject: [edk2-platforms: PATCH] Features/Intel/IpmiFeaturePkg: Use MdePkg = macros instead of redefining. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3494 Renamed below macros and structure to use MdePkg ones. IPMI_MSG_GET_BMC_EXEC_RSP IPMI_GET_BMC_EXECUTION_CONTEXT IPMI_BMC_IN_FORCED_UPDATE_MODE Cc: Nate DeSimone Cc: Sai Chaganty Cc: Liming Gao Cc: Isaac Oram Signed-off-by: Chasel Chiu --- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit= .c | 8 ++++---- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include= /ServerManagement.h | 17 ----------------- 2 files changed, 4 insertions(+), 21 deletions(-) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Dxe/IpmiInit.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericI= pmi/Dxe/IpmiInit.c index 1e0c132508..d788b48867 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/Ipm= iInit.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/ +++ IpmiInit.c @@ -242,7 +242,7 @@ Returns: EFI_STATUS Status; UINT32 = DataSize; SM_CTRL_INFO *pBmcInfo;- EFI_IPMI_MSG_GET= _BMC_EXEC_RSP *pBmcExecContext;+ IPMI_MSG_GET_BMC_EXEC_RSP *pBmcEx= ecContext; UINT32 Retries; #ifdef FAST_VIDEO_SUP= PORT EFI_VIDEOPRINT_PROTOCOL *VideoPrintProtocol;@@ -301,14 +301,= 14 @@ Returns: Status =3D IpmiSendCommand ( &IpmiInstance->IpmiTranspo= rt, IPMI_NETFN_FIRMWARE, 0,- EFI_FIRMWARE_GET_= BMC_EXECUTION_CONTEXT,+ IPMI_GET_BMC_EXECUTION_CONTEXT, = NULL, 0, IpmiInstance->TempData, &DataSize = ); - pBmcExecContext =3D (EFI_IPMI_MSG_GET_BMC_EXEC_RSP*)&IpmiIn= stance->TempData[0];+ pBmcExecContext =3D (IPMI_MSG_GET_BMC_EXEC_RSP*)&I= pmiInstance->TempData[0]; DEBUG ((DEBUG_INFO, "[IPMI] Operational statu= s of BMC: 0x%x\n", pBmcExecContext->CurrentExecutionContext));- if ((pBm= cExecContext->CurrentExecutionContext =3D=3D EFI_FIRMWARE_BMC_IN_FORCED_UPD= ATE_MODE) &&+ if ((pBmcExecContext->CurrentExecutionContext =3D=3D IPMI_= BMC_IN_FORCED_UPDATE_MODE) && !EFI_ERROR (Status)) { DEBUG ((= DEBUG_ERROR, "[IPMI] BMC in Forced Update mode, skip waiting for BMC_READY.= \n")); IpmiInstance->BmcStatus =3D BMC_UPDATE_IN_PROGRESS;diff --git = a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerManagemen= t.h b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerManag= ement.h index 7591f33aba..244b86e91a 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerManag= ement.h +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerMa +++ nagement.h @@ -149,15 +149,6 @@ typedef enum { #define UPPER_NON_RECOVER_GOING_LOW 0x400 #define UPPER_NON_RECOVER_GOIN= G_HI 0x800 -//-// Definitions for Get BMC Execution Context-//-#define E= FI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT 0x23-//-// Current Execution Context= responses-//-#define EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE 0x11- // // S= erver Management COM Addressing types //@@ -327,14 +318,6 @@ typedef struct= { UINT16 IoBasePort; } IPMI_HOB_DATA; -//-// Constants and Structure def= initions for "Get Device ID" command to follow here-//-typedef struct {- U= INT8 CurrentExecutionContext;- UINT8 PartitionPointer;-} EFI_IPMI_MSG_= GET_BMC_EXEC_RSP;- // // COM Layer Callback //--=20 2.28.0.windows.1