From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.5848.1634194377889174952 for ; Wed, 13 Oct 2021 23:52:59 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=s6fNlj1/; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: rangasai.v.chaganty@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10136"; a="214553494" X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="214553494" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2021 23:52:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,371,1624345200"; d="scan'208";a="524940416" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga001.jf.intel.com with ESMTP; 13 Oct 2021 23:52:43 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 13 Oct 2021 23:52:43 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 13 Oct 2021 23:52:43 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 13 Oct 2021 23:52:39 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XpAkfc7M1hRbHB7r4TJUb24+s9ohxmDB6vvdxIkqEaji+so5XAyyFO5A/Ahowb1aQVPYmgN9a1WI9r2g+3J3R8NSYbi7dcv5GkD+5u1u6Y4PpFR+IirDOCEnjWSwm9ie5AittdYk4oXeiBif0LxjL/FySIJ0j0BxKLQBWDjSoOgR/dWInmbbqDX+o/Cd/vw0qfmuWq+3S9rK0p6rgfYAzCXlqA0v943GyMeqYoetl6c9ZVP0O7T//UbJW+vvKZ++huqLr7Iy/COAvCUYKEYMMSdJYSRWVATD5UzMhaFWMS5tXAvxkmwCoMQ7NJL+fNpXTgcBKk0RpC394sbIwO8nyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=We+gS61TU2GkmqfCX89i+geXL2+tzkRidGNfqVqyP38=; b=A2FQdGB/VxR3UgOMWYNC89NvVJyCsRuczoreviBdZUgmz9WFcQEbb4qlogZTqC1tzzhsaDrPleYnonTo83UOGjzYvvQcLweqqHEFcqlUhtjBrl8K7jElGkDVpL2kAiY/ab5wRhOtexewIoPkSJH28F46i+342MRJkOULa3n5bbeLVPmC0YeQTElSbvftMu2u0FNy87vUIG72SUoZ3P2fsJZ/xQoeaMrB3uMev7+mKPF48/yrgXZwynOtU4Ex+QzhaDpbRxiSG+TxLfd/ovScOjhS6z9y5DHXlNP3ueWlP8wSj+Vi5KJYFZZh6ERTKBzP7c5F3KJb+p00gP2JAbK8Pg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=We+gS61TU2GkmqfCX89i+geXL2+tzkRidGNfqVqyP38=; b=s6fNlj1/pfG9bJ9K0H4lGm1f4I0gjcZRqeKdavRFUkj0hb9Iw3CIAZSF69VgTNGSBHQ1+mjg86v4+p12rjD9yNjBH7l+DpzraM7VN5r5jeISa7CaGozknvgkrSfnRlGUtmbr8rmJtXcLQUKGhxEISPhsrWoMJMfSuRSUWgsYu+k= Received: from MW3PR11MB4602.namprd11.prod.outlook.com (2603:10b6:303:52::19) by MWHPR1101MB2319.namprd11.prod.outlook.com (2603:10b6:301:52::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4608.15; Thu, 14 Oct 2021 06:52:38 +0000 Received: from MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::a57d:cb7d:3d8b:1064]) by MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::a57d:cb7d:3d8b:1064%9]) with mapi id 15.20.4587.030; Thu, 14 Oct 2021 06:52:38 +0000 From: "Chaganty, Rangasai V" To: "Czajkowski, Maciej" , "devel@edk2.groups.io" CC: "Ni, Ray" Subject: Re: [edk2platforms][PATCH v1 1/1] IntelSiliconPkg: Add IntelDieInfoProtocol Thread-Topic: [edk2platforms][PATCH v1 1/1] IntelSiliconPkg: Add IntelDieInfoProtocol Thread-Index: AQHXu49xoDZD3a6nYEqvCVOZw4f6J6vSFe+g Date: Thu, 14 Oct 2021 06:52:37 +0000 Message-ID: References: <20211007152420.878-1-maciej.czajkowski@intel.com> <20211007152420.878-2-maciej.czajkowski@intel.com> In-Reply-To: <20211007152420.878-2-maciej.czajkowski@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1bf67aef-5368-483c-5036-08d98edf35c4 x-ms-traffictypediagnostic: MWHPR1101MB2319: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6790; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XhmbBi64+lnU4M5GXBa6OgyDhKwqUAJmjTj0vOtE4Ll55y+omiKcT7mCuSk0OqdVXGiH0ksQYdAheoewDXPD/MgTjAdfXbpGMc9RBI91rNN6PS76vTzoUj2vONu8VE5ftREdo64y4wx+yR7C4PQ+2TDflltC5jnV1unCZhwJlGQZ/B7uJCyEbzvlh6beuR9BQoMQYG1HmC6JjuKp8YvvRV9vZvGGPFdcnskUuZDxVLx75wcSVyLpOrIxFAvJBCFUAzyZGXWXOGoNSTzPH0Ir7yq8l5ncCfLV28+gH3Uj7SuDVDnD5+63++22cun7H2Jd2Tp2XAL9ixIY++4COtG09XTYFn3eEbw5qQJROnsnTDX3qbfuDqrRXaYWe7F1riv3sLOiZ1mnIHcJfQX9lhquoVzwAgU3BXun78nMDrPfvkH4uf4aXtV4aLPoIHiggwtAV2W3IIZ2OSuKSPFMHi+Q2B6CLT4CLbMpwlV9KJURSz4oRDeMZPap7DtCyaETo2Zq7/e6gUOZ05bbX39CKRorxRzQddS1a7tv726Z5yy41vd3krgosIh2zrKX3Iu9/TWGKIJoTGS5wRH5zoXfQqi4JxqJL5DSGwXEB6tq0ys/m9Dd2U3QD12GkUOdHW9ttrJGWqaeUAitiWnhe1RszNtfJ6YbPaqOo0fS5MrFpyGx1TA30lIeyspnDWK7MYwduZ9qlpp6/pDcK+NfRHRTJ9NcvA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4602.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(82960400001)(6506007)(8676002)(7696005)(55016002)(83380400001)(71200400001)(316002)(4326008)(508600001)(38100700002)(53546011)(122000001)(9686003)(5660300002)(38070700005)(186003)(107886003)(33656002)(86362001)(52536014)(2906002)(66946007)(76116006)(66476007)(64756008)(66556008)(26005)(8936002)(110136005)(66446008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oL5YmhoVb31636kWEM9qpKl5Y73HDTyc/UsEPPxZwyeAh2O3gEURDseTuG7H?= =?us-ascii?Q?zcR6ZrnxUI3TAbTkC8i/SDpRZF9B8Eahj3yqgwuxARkeRcGNczTk378TEx9K?= =?us-ascii?Q?CdCp+epaHwh/OGS72pcpTr2ZXo0zRNS/a1NMSwtSzEELD/+VOTWWCDNo2Dqn?= =?us-ascii?Q?RNGTwmwaAvxqllpsnInmJ3oGWnTePtJ4bcKkVrA3rl8lUtr+nUT/CTc8k//h?= =?us-ascii?Q?TXUzydg+n/BWgcAHUc7caszo4pymA+xPzgmPUnwbPbZPHlOamz4dqd4DE6Tn?= =?us-ascii?Q?C6xUWo5yWmpX2aJV1Cx+nvVo4FLEz6oJ2FEpJHhxr/hQDAb/rlg9imzdDP/N?= =?us-ascii?Q?ruyQVvO5HT8RwAPjhIjSsIiCodbuaaQvrCz5vDaEu+NxpHTyzIHwIkNEkL6t?= =?us-ascii?Q?2IFyCFYvp482e0xrVHXZp8nPbKEg2b+cWZUF3iSgftD+qG7VVHPoZC10okL7?= =?us-ascii?Q?HO6jWFniE+qMU59G6JOr52ZXlTaFV/zEgsxdM1Ilk4g9M+TIHjMM/58w+abf?= =?us-ascii?Q?ymgReya5U9wJTDvo3/Ed9AXMrBPegAp3BG6a20RWjaXpRYsoY/quEKrct/SM?= =?us-ascii?Q?oCQPDy8BaEbZpklpXsfYBy4xwAS97qwo8wkzS68n1gVrk4610oGapu5kTCuK?= =?us-ascii?Q?YnOSxvRA9hNuzlnLBcR/awQ7yYzsZ68wx3LF8J0lwrBSpYErOcReRmJ0wu0i?= =?us-ascii?Q?CQpBkPFwnJst+cGjjkYTbbKJ7KGsqTozMNy+EK14UxQgD4sT3b+G1hLllD+s?= =?us-ascii?Q?WEr9LMzC+Vs6c5VPrqg8SnxrAn8J9BK16/EywTW2Y8O/21v0cAY8SdPXj26e?= =?us-ascii?Q?RD783hUts78O3zYGDsV/OPJB6iyK1RDfe8m7TSIBqPkwml4XIOEX4r9cJgR2?= =?us-ascii?Q?RVFYYJm0FLYiKQtxrQz+eXQ/SBD17kfBPUMjmQ2BCf7bYqH8xuHkReEFaAhy?= =?us-ascii?Q?7psvM6h3iuYbS2Mgsl/zNU329FQAJ3J3TGhCVQ4zzJlB9tO1jGjQDLsOlUb8?= =?us-ascii?Q?7xM13juJ7OfOH75E0L6qA0kNryq1BYM29BqUwUccNnB9n+PfXzW5NQDVzyxS?= =?us-ascii?Q?kTOi3mk3D+wIMpWWPOEt4M99+1bFq/sMjCvRTe7Fpm7PlJ/W5hQrZZYCQQfp?= =?us-ascii?Q?UVpPFsj+Q4vzEYjfxN4hjbxdutBy8/Kpvmk8AsgHCQHBGovCy5OeK5V7UM76?= =?us-ascii?Q?0plYR3sPlRC2QEEi5ARyLLn5mkLzKqcxGKyTE53vYBDhpAUMOyKyrXSeXDY2?= =?us-ascii?Q?S8hOl45ZtHR+FH/47LEIrfGkwFXOVCMYsiw+SIqEihON6OkmUuxDpRFMRFsB?= =?us-ascii?Q?SRh9kQAeqAoHevz+c0HlBvI/?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4602.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1bf67aef-5368-483c-5036-08d98edf35c4 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2021 06:52:37.8872 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: zgEGrI1/hb3REp/zgGnhzjjK+Wy0ypM7rSZjmqCPRNmYCIg4lHc4w6xxEpreOQOQyNjs3ehp4K80DYxXvWXYoI12XcbZJT1xNvpQru2yza8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2319 Return-Path: rangasai.v.chaganty@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Maciej,=20 Please add description of the interface in the comment block in line 103, s= pecifically covering the purpose of the interface, the producer and consume= r of this interface.=20 DieId's description says "Generation and die specific ID number". Can you a= dd some details on how a producer of this interface would know the values t= o be assigned here? Does this contain any sort of encoding of generation an= d Die specific ID in a single UINT64 ? Same question for Stepping ID. Any reason the die specific GUIDs are not declared in the .dec file? Thanks, Sai -----Original Message----- From: Czajkowski, Maciej =20 Sent: Thursday, October 07, 2021 8:24 AM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V Subject: [edk2platforms][PATCH v1 1/1] IntelSiliconPkg: Add IntelDieInfoPro= tocol Added IntelDieInfoProtocol header into IntelSiliconPkg tree. The purpose is to have generic and unified interface for getting informatio= n about dies installed in the system. It will be implemented by silicon code. Change-Id: I219f238a6245eb81dbaebe6b826304baf3f78dc2 Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Maciej Czajkowski --- Silicon/Intel/IntelSiliconPkg/Include/Protocol/IntelDieInfoProtocol.h | 10= 9 ++++++++++++++++++++ Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec | = 2 + 2 files changed, 111 insertions(+) diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Protocol/IntelDieInfoPro= tocol.h b/Silicon/Intel/IntelSiliconPkg/Include/Protocol/IntelDieInfoProtoc= ol.h new file mode 100644 index 000000000000..6182947e82fc --- /dev/null +++ b/Silicon/Intel/IntelSiliconPkg/Include/Protocol/IntelDieInfoProtoco +++ l.h @@ -0,0 +1,109 @@ +/** @file+ IntelDieInfoProtocol definition++ Copyright (c) 2021, Intel C= orporation. All rights reserved.
+ SPDX-License-Identifier: BSD-2-Claus= e-Patent++**/+#ifndef _DIE_INFO_PROTOCOL_H_+#define _DIE_INFO_PROTOCOL_H_++= typedef struct _INTEL_DIE_INFO_PROTOCOL INTEL_DIE_INFO_PROTOCOL;+typedef I= NTEL_DIE_INFO_PROTOCOL INTEL_DIE_INFO_PPI;++extern EFI_GUID gIntelDieInfoP= rotocolGuid;+extern EFI_GUID gIntelDieInfoPpiGuid;++#define INTEL_DIE_INFO_= PPI_GUID \+{ 0xAED8A0A1, 0xFDE6, 0x4CF2, { 0xA3, 0x85, 0x08, 0xF1, 0x25, 0x= F2, 0x40, 0x37 }}++#define INTEL_DIE_INFO_PROTOCOL_GUID \+{ 0xAED8A0A1, 0xF= DE6, 0x4CF2, { 0xA3, 0x85, 0x08, 0xF1, 0x25, 0xF2, 0x40, 0x37 }}++#define D= IE_INFO_PROTOCOL_REVISION 1+#define DIE_INFO_PROTOCOL_SIGNATURE SIGNATURE_= 32 ('I', 'D', 'I', 'P')++#define DIE_INFO_PCH_GUID \+{ 0x62CB6D68, 0x4771, = 0x4569, { 0x81, 0xFA, 0x1E, 0x99, 0x6E, 0xA9, 0x91, 0xC5 }}++#define DIE_IN= FO_SOC_GUID \+{ 0x63287105, 0x578E, 0x4799, { 0xBE, 0x55, 0x5D, 0xDA, 0xCA,= 0x03, 0x74, 0xD0 }}++#define DIE_INFO_IO_GUID \+{ 0x23DA4C74, 0x54A0, 0x4E= 01, { 0x83, 0xB1, 0x8C, 0xA7, 0x43, 0x43, 0x1F, 0xF0 }}++#define DIE_INFO_C= PU_GUID \+{ 0x6E5AF2E3, 0x5D84, 0x48F2, { 0x84, 0x28, 0x99, 0xE4, 0x93, 0x4= F, 0x51, 0xE4 }}++#define DIE_INFO_GFX_GUID \+{ 0x1D3D2599, 0x7A1C, 0x4B1E,= { 0x8C, 0xC5, 0x0F, 0x88, 0x27, 0xA0, 0x2E, 0xEC }}++/**+ Returns pointer= to constant string representing die name.+ Name is specific to die type.+= + @param[in] This Pointer to the DieInfoProtocol context structure+ @ret= val Pointer to the const string+**/+typedef+CONST CHAR8*+(EFIAPI *INTEL_DIE= _INFO_GET_DIE_NAME_STR) (+ IN INTEL_DIE_INFO_PROTOCOL *This+ );++/**+ R= eturns pointer to constant string representing stepping of the die.++ @par= am[in] This Pointer to the DieInfoProtocol context structure+ @retval Poi= nter to the const string+**/+typedef+CONST CHAR8*+(EFIAPI *INTEL_DIE_INFO_G= ET_STEPPING_STR) (+ IN INTEL_DIE_INFO_PROTOCOL *This+ );++/**+ Returns = pointer to constant string representing SKU of the die.++ @param[in] This = Pointer to the DieInfoProtocol context structure+ @retval Pointer to the = const string+**/+typedef+CONST CHAR8*+(EFIAPI *INTEL_DIE_INFO_GET_SKU_STR) = (+ IN INTEL_DIE_INFO_PROTOCOL *This+ );++/**+ Protocol/PPI definition.+= + Revision 1:+ - Initial version.+**/+struct _INTEL_DIE_INFO_PROT= OCOL {+ UINT32 Signature; ///< Protocol signatur= e+ UINT32 Revision; ///< Current protocol revisi= on+ /**+ Type of the die that particular instance is reffering to. See = DIE_INFO_*_GUID+ **/+ EFI_GUID Type;+ /**+ In= dex of the die in the system.+ **/+ UINT32 DieI= ndex;+ /**+ Generation and die specific ID number.+ **/+ UINT64 = DieId;+ /**+ Generation and die specific stepping = ID.+ **/+ UINT32 SteppingId;++ INTEL_DIE_INFO_= GET_DIE_NAME_STR GetNameStr;+ INTEL_DIE_INFO_GET_STEPPING_STR GetSteppin= gStr;+ INTEL_DIE_INFO_GET_SKU_STR GetSkuStr;+};++#endif // _DIE_INFO= _PROTOCOL_H_diff --git a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec = b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec index 2461ab8e06e7..7af784d77abc 100644 --- a/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec +++ b/Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec @@ -73,9 +73,11 @@ [Guids] [Ppis] gEdkiiVTdInfoPpiGuid =3D { 0x8a59fcb3, 0xf191, 0x400c, { 0x97, 0x= 67, 0x67, 0xaf, 0x2b, 0x25, 0x68, 0x4a } } gEdkiiVTdNullRootEntryTableGui= d =3D { 0x3de0593f, 0x6e3e, 0x4542, { 0xa1, 0xcb, 0xcb, 0xb2, 0xdb, 0xeb, 0= xd8, 0xff } }+ gIntelDieInfoPpiGuid =3D { 0xAED8A0A1, 0xFDE6, 0x4CF2, { 0x= A3, 0x85, 0x08, 0xF1, 0x25, 0xF2, 0x40, 0x37 }} [Protocols] gEdkiiPlatfo= rmVTdPolicyProtocolGuid =3D { 0x3d17e448, 0x466, 0x4e20, { 0x99, 0x9f, 0xb2= , 0xe1, 0x34, 0x88, 0xee, 0x22 }}+ gIntelDieInfoProtocolGuid =3D { 0xAED8A= 0A1, 0xFDE6, 0x4CF2, { 0xA3, 0x85, 0x08, 0xF1, 0x25, 0xF2, 0x40, 0x37 }} = ## Protocol for device security policy. # Include/Protocol/PlatformDevic= eSecurityPolicy.h--=20 2.27.0.windows.1