From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web09.3886.1642140628691672819 for ; Thu, 13 Jan 2022 22:10:28 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Zf5UqQy6; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: rangasai.v.chaganty@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642140628; x=1673676628; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ES3jviwIJwQtY4my7XYZ+Tb5V6gTKpPOVvJKHjQk35U=; b=Zf5UqQy6yDowYoxKKw4NuHWvX/z4csP5xrrCJPAeWWZ8lSvdXgadaZbP tTsSKwcKPggIWt0LIWKqq1sVX9eHuY1dqJpdyeYq5n7+O6Eme4jijf/Ag MO63mi6+Bpmn3ljIJl7m0S69/ZxZUreRW2kWDVbN/ddxb/Uig+V4l82sR TW4tJLVa4xFkyimExJF8EA62KW2fRmChVm34cmPmAlYBCqIC8+A6oBXff XVTRYpXsTcB+90jA7FW2TzHX6+CMtL0lM05aOltGsHLQKLtArbHUE8VOG Wm7we6WsyXKDMKFPBmiVlpb+GSSUsN6RUqM1HBfg8dFTRuGMbmq3TNHIN g==; X-IronPort-AV: E=McAfee;i="6200,9189,10226"; a="224173055" X-IronPort-AV: E=Sophos;i="5.88,287,1635231600"; d="scan'208";a="224173055" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2022 22:10:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,287,1635231600"; d="scan'208";a="491389972" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga002.jf.intel.com with ESMTP; 13 Jan 2022 22:10:27 -0800 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 13 Jan 2022 22:10:26 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 13 Jan 2022 22:10:26 -0800 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (104.47.56.46) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 13 Jan 2022 22:10:26 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=manJSL8xnfo3Ehoyu+wUKHKMFHwFsIoVIP7cJZx2dIEtVs0xR/fweTCCgcS6r7gKWPOrDugqyIKmSbBr5ccU32IkTfktDX6o+0AhVVs1rhHm+ogKiwGvTahJF1l0gStreMlnhvbYgg1ixZajxBG+zh3ZClXUNDHJmyRnREO3J9pr/asVznfuDERd4BnA8ADzK0YNoXVs49WcVNX3HxNeKRrqUKvshzKszQURs1CVKbzMGWgBuDpJcVEwzN3JXqKOLREjaSVd78b2fyW2HqmIZQgE0FTlWF44roZ3+DYFAg9NH3izy7zHkK7C0kIl322zfz7ob0J5eHaccwOwIFdjFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EHDclEBl6lfI2njdbGewxdAaVvoxDjp9QVSKCYP+WWM=; b=ZwFjGTD4lccz1KTWmOr9n66OZdJ/nAPakU+U71yaOieQ59JWbOyquwjXUpMBONg8PvFT5k+LSn+u4zZBGPhOSfgKI6HHUHf2WEbjPLp9FHM44AkPGJ2O8VcTmYQ3v/iz2OCEKMfElJ8jHTYW8odXULnwP3upSJFpE0z0OWEtU0BMAqGwxvmmWqVwyieJTMifgVIWeMStgISWKODiPnRAQcUkkhxSwnjS2AyAeNukBB0axGwQQSCqWni7mbM06l6VU3EFTvJTonWkJM79PnQExf7mwqz0T4Hn5VcBHzKJvtkWGBdgGZmIsG3z3VeAXAvm9U9Rto7f4HhAISjfiJFa9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW3PR11MB4602.namprd11.prod.outlook.com (2603:10b6:303:52::19) by PH0PR11MB4918.namprd11.prod.outlook.com (2603:10b6:510:31::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.9; Fri, 14 Jan 2022 06:10:25 +0000 Received: from MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::ec00:565c:a1db:998b]) by MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::ec00:565c:a1db:998b%5]) with mapi id 15.20.4888.012; Fri, 14 Jan 2022 06:10:24 +0000 From: "Chaganty, Rangasai V" To: "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Gao, Liming" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 20/27] SpcrFeaturePkg: Use MinPlatform build include files Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 20/27] SpcrFeaturePkg: Use MinPlatform build include files Thread-Index: AQHYB1sJHvXmuBN7xk2aX0yemuW0ZKxiDBkA Date: Fri, 14 Jan 2022 06:10:24 +0000 Message-ID: References: <9fe41786a6142a31b8724632f37eab047e3d9deb.1641953242.git.isaac.w.oram@intel.com> In-Reply-To: <9fe41786a6142a31b8724632f37eab047e3d9deb.1641953242.git.isaac.w.oram@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: ca2b95b5-1120-4599-54bb-08d9d7248dd7 x-ms-traffictypediagnostic: PH0PR11MB4918:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: oWkiGosKYuDbWyV6QpSmQ8IJa66KhbfRlYMpgJrNx3nlYJ9aIQFHCqaTgVzZeo1ULyxm7ZqMN2rxxWly2Y4X7Rk4lNdEj1Tpardu4XGglbq0GGxzJggDCQSLCTFXsfZQyJmbqb6aoGEy815Ksx1VPkano1QD7V8tACDCw0z6Fj8YSsEdGcqLEh6jnbm/gwu+UXzS8moXy5uJFznIB/jA17R3S16aE2tHnyRO6/0RdDn947HmLEsXO/tV9jzVesKEQGINtHmkCxHFEeXDtdZIGGkrKPAMf4w8kCsYdPZEBJltcZ6uxeXPxMzo5KCqIkMVaa/WlN7qy5MsceYtTmBAVGLYkae+EIjuk3m/FzBTGyi6UTsyORkLhAC0v2G5bWdeMlxCpwkHTIU8jCOIckYwNimvzifd/erTMeqPPpClCGPBjCv0sFLFzRrg2Z7MneqMmYCNFv45oEzc11WxHrlDI/jJwG8lWSndNfbXc5/BMWzNKgFzH3I+RreVcJOdGEULIKcBeJ+leeCN/zcefZR2WVExpc5LGh//7zR8WfCpL0lgkOd2djcUne7p0v8WEnOoOmRkNWdJ1+rIZ6og2MRfFZpGU+/Il1FmAVKyZ9v1TDXeeMRSzxCmTNtLstclV1sSGygQ/Fgoa8Dph/oHoeph3bQd4JU9n66AD/5MfW0ZLyQrKVIAukD4siDsIuIM1TeiukDESyEUoUxUjC+pPW/xjjLvuj4RHPAp5kg7b2luapPpH4Khz847gSMWg3YllI470x7lmoyHscRxjJAY7FDgj9vlqL820LPXtxAu+0uVOGg= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4602.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(30864003)(316002)(966005)(4326008)(55016003)(9686003)(8676002)(71200400001)(82960400001)(38070700005)(83380400001)(33656002)(110136005)(38100700002)(122000001)(5660300002)(186003)(7696005)(26005)(64756008)(2906002)(6506007)(66556008)(8936002)(66476007)(66946007)(66446008)(52536014)(86362001)(508600001)(53546011)(76116006);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6tf6HPjRw7kquMgJa9zrs16eaoZ10Bd376oP+cFxRuYSDrfmytdi0UHIyxiU?= =?us-ascii?Q?uwd/Un3Pih564F7fFo+KMco6h5IRnvVwLaEB1TyYecluZnmPT+bbbRVDmaSr?= =?us-ascii?Q?ldEzE0AVceVODn0hvOIHA75rZn4g3EoleXew7EHkQrWdNayf72DCyfli9hAX?= =?us-ascii?Q?UL2lHuKUAE8Iga+Yn1DvfEXaHdPlV7n4u1U1otYX+grCg7ic2+xkjboowufd?= =?us-ascii?Q?mPckZG3oA0V6pI9KdIrSmUfYPGlM2uJtwtylB4pmcFWbAk4i5bE4RH8vEjZ7?= =?us-ascii?Q?VBeG8eUPNbedZ1IUF77ogMztWVd3a0xSGtbAXWxigGwpmqrkqDmhZ38nlOVb?= =?us-ascii?Q?GQV+QryAtq48RfJeAF73MpNpMIcRqmNaGdZW6gnFZvCg05xF7TXND41kodrA?= =?us-ascii?Q?H1rn8QsbYg/k/gxxsmDIoB2yYQVf/tzhwXInWihehba1K8WIK/h/k0JhVYuz?= =?us-ascii?Q?qyKwj32SpfG26A6dsl4b0hLkpUkd4OPBUHP0HRyJsWXKvz5eDoNWYw4/eALj?= =?us-ascii?Q?7cMlIo9dqpVpjad08IlbJh6pBuDnAx+UDUoxGRiOWp74sb39qW430cTTCiQI?= =?us-ascii?Q?Qp7g0zRMW6ppkBU7W5fMy6ECVnAFpxCUlY4qo5gN59fKHy2X+Nh9CLSY6lO9?= =?us-ascii?Q?ac3Uri3ALhcuEZVlzK6aonFIdqGCjP+H7fU+KW1leunDdwPkXQ2rfC/sfraf?= =?us-ascii?Q?cZkRshWwMe546XsIMrrJ11Rxp1d/6T/oQfFq+Xcj7amY74ZfOi8pFF2XGcYe?= =?us-ascii?Q?/6MEGUPJoUDb0/MQEpywXc5NW7ZI4N4QGiSk5mz+giDD0Cs4OtAeCPFOUuB4?= =?us-ascii?Q?gKsmLDFTun+6sAVb0vbJzjRA3fwNwbO6qzL03ZCmwiALnv6whuZoSRlYqIcy?= =?us-ascii?Q?eyGt0+FR5omfGU+JU9JPfrgjpsLgOpq80s0pKfbKBIwXqBvv6ho8BKwCZjdq?= =?us-ascii?Q?5Sg3Wo/PaOVe3AHhnsqDuFyU3PRVd1VEVzLYBZiRNv/zVqI5qJOdn5CTUbmr?= =?us-ascii?Q?2X/xbKbtYpZ9FXQdJjJ4aq53/sZSorKKBTdEjsuBBTv5IjZix2KcfckUoxoY?= =?us-ascii?Q?UsucI/J9mLMffglGwMTqXC0+tdFNd47xXvnCcVY6bCOf0XHTC4qTIC69c1f1?= =?us-ascii?Q?Q1fNK/6/ljHsVaDqRERvtEtoWeJJe4qbJr5PEkEZdbztX1pcLIbfkoOHJ2C3?= =?us-ascii?Q?AEdzf1Jv7MHCA7OTeghl7Q2KGJMVyVQfvG2X0xVMPZSKycFMwY0D/e8qBoR2?= =?us-ascii?Q?2kpZbkb3D0QyRSL6iSJdYEO/BcqWR6nWClSA9qTKWtudSiVWSEAGUcxfVgpr?= =?us-ascii?Q?Ox+r4YHZ3+Qke3uYz8QV/CWhim2eQBTutfsXRTIqxJg8smbDqgjCAjJO3IVl?= =?us-ascii?Q?UuZ59JTGgNGxw67DA6vjMgmuYxDwCOsgJVAo2DFwKgykhihEWpo6kXtjcvrv?= =?us-ascii?Q?dgVT/HLcYqkoaJHlIQUoYGtT6YYXpH8pqSBNr/9Dx+qxVQHnY6TxVs1y/KBT?= =?us-ascii?Q?nQp4LgKL+pz0AkAoeknbAM1IRdL8L/wdC4SKuJxnNSpSQ+pEfDjzmogtvOlI?= =?us-ascii?Q?p+m8Ym0EYHhlSNVo6dvbQg6d9emh7xWC06lvn94xFQrC1QSqPgMN1h8KMPxO?= =?us-ascii?Q?CiamXjex1uOEh7SUkObIuo/WOVVJ1O7AmIZEsGBYVCi700hopnbOAmVXOR+6?= =?us-ascii?Q?dxDAwg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4602.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca2b95b5-1120-4599-54bb-08d9d7248dd7 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jan 2022 06:10:24.7036 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Whcj/kDonpwu6UWoAIFmo5C+9ApcxNqi4adva8Y4lNusSpV90LDjBl0rYUqi+HtgsPl+XaMY8QbJgn6NPqDL23Dn6+h76YqE2cELxeAP9Uo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4918 Return-Path: rangasai.v.chaganty@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sai Chaganty -----Original Message----- From: Oram, Isaac W =20 Sent: Tuesday, January 11, 2022 6:20 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-devel][edk2-platforms][PATCH V1 20/27] SpcrFeaturePkg: Use M= inPlatform build include files Also added feature enable flag Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Isaac Oram --- Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Library/SpcrDevi= ceLib.h | 2 +- Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PostMemory.fdf = | 13 ++++ Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PreMemory.fdf = | 11 ++++ Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc = | 62 -------------------- Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Readme.md = | 12 ++-- Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.dec = | 6 ++ Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.dsc = | 18 ++++++ 7 files changed, 55 insertions(+), 69 deletions(-) diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Libr= ary/SpcrDeviceLib.h b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Inc= lude/Library/SpcrDeviceLib.h index 947813815e..2e50270ee6 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Library/Spc= rDeviceLib.h +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Library/ +++ SpcrDeviceLib.h @@ -12,7 +12,7 @@ =20 /** Get a Serial Port device used for SPCR. - The caller should call FreePool() to free the memory if return value is = not NULL. + The caller should call FreePool () to free the memory if return value is= not NULL. =20 @retval NULL Can not get device. @retval Others A serial port device path. diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Post= Memory.fdf b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Post= Memory.fdf new file mode 100644 index 0000000000..f963f567c2 --- /dev/null +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PostMemo +++ ry.fdf @@ -0,0 +1,13 @@ +## @file +# FDF file for post-memory SpcrFeature advanced feature. +# +# This file is intended to be included into another package so=20 +advanced features # can be conditionally included in the flash image=20 +by enabling the respective # feature via its FeaturePCD. +# +# Copyright (C) 2022 Intel Corporation. +# +# SPDX-License-Identifier: BSD-2-Clause-Patent ## + +INF SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpiDxe.inf diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PreM= emory.fdf b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PreMe= mory.fdf new file mode 100644 index 0000000000..3c461e7fbc --- /dev/null +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PreMemor +++ y.fdf @@ -0,0 +1,11 @@ +## @file +# FDF file for pre-memory SpcrFeature advanced feature. +# +# This file is intended to be included into another package so=20 +advanced features # can be conditionally included in the flash image=20 +by enabling the respective # feature via its FeaturePCD. +# +# Copyright (C) 2022 Intel Corporation. +# +# SPDX-License-Identifier: BSD-2-Clause-Patent ## diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Spcr= Feature.dsc b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Spc= rFeature.dsc index c51e552df5..b06ddf4fe6 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature= .dsc +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeat +++ ure.dsc @@ -25,40 +25,9 @@ !error "DXE_ARCH must be specified to build this feature!" !endif =20 -##########################################################################= ###### -# -# Library Class section - list of all Library Classes needed by this featu= re. -# -##########################################################################= ###### - -!include MdePkg/MdeLibs.dsc.inc - [LibraryClasses] - ####################################### - # Edk2 Packages - ####################################### - BaseLib|MdePkg/Library/BaseLib/BaseLib.inf - BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRepStr.inf - DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf - UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntry= Point.inf - UefiLib|MdePkg/Library/UefiLib/UefiLib.inf - PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf - PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf - UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBoo= tServicesTableLib.inf - DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf - UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/U= efiRuntimeServicesTableLib.inf - - ####################################### - # SpcrFeaturePkg Packages - ####################################### SpcrDeviceLib|SpcrFeaturePkg/Library/SpcrDeviceLibNull/SpcrDeviceLibNull= .inf =20 -[LibraryClasses.common.DXE_DRIVER] - ####################################### - # Edk2 Packages - ####################################### - MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAll= ocationLib.inf - ##########################################################################= ###### # # Component section - list of all components that need built for this feat= ure. @@ -74,38 +43,7 @@ # ##########################################################################= ###### =20 -# -# Feature DXE Components -# - # @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzi= lla.tianocore.org/show_bug.cgi?id=3D2308 # is completed. [Components.X64] - ##################################### - # Spcr Feature Package - ##################################### - - # Add library instances here that are not included in package components= and should be tested - # in the package build. - - # Add components here that should be included in the package build. SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpiDxe.inf - #{ -# -# SpcrDeviceLib|SpcrFeaturePkg/Library/SpcrDeviceLibNull/SpcrDeviceLi= bNull.inf -# } - -##########################################################################= ######################### -# -# BuildOptions Section - Define the module specific tool chain flags that = should be used as -# the default flags for a module. These flags are a= ppended to any -# standard flags that are defined by the build proc= ess. They can be -# applied for any modules or only those modules wit= h the specific -# module style (EDK or EDKII) specified in [Compone= nts] section. -# -# For advanced features, it is recommended to enabl= e [BuildOptions] in -# the applicable INF file so it does not affect the= whole board package -# build when this DSC file is active. -# -##########################################################################= ######################### -[BuildOptions] diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Readme.md b/= Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Readme.md index 0a5d48876d..66138ee0f6 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Readme.md +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Readme.md @@ -22,10 +22,10 @@ Platform can implement its own library to select the se= rial port device. * SpcrDeviceLibNull =20 ## SpcrAcpiDxe -The main driver of convert the serial port device info to ACPI table. -It will call the function GetSpcrDevice() in the library SpcrDeviceLib to = get the serial port device path. +The main driver of convert the serial port device info into an ACPI table. +It will call the function GetSpcrDevice () in the library SpcrDeviceLib to= get the serial port device path. If the serial port device path is not NULL, then use gEfiPciIoProtocolGuid= to get the PCI info, and use the gEfiSerialIoProtocolGuid to get the seria= l port info, such as the baud rate etc. -If the serial port device is PCI device 00:16:03 (AMT serial over lan PCI = device), then will set the BaseAddress. +If the serial port device is PCI device 00:16:03 (AMT serial over LAN PCI = device), then will set the BaseAddress. At last fill the ACPI table as Windows required. =20 ## SpcrDeviceLibNull @@ -37,19 +37,19 @@ Fill the serial port device info used for SPCR to ACPI = table. =20 ## Configuration There is not special configuration. -But the platform maybe implemente its own SpcrDeviceLib. +But the platform may implement its own SpcrDeviceLib. =20 ## Data Flows GetSpcrDevice() -> serial port device path -> get PCI info and serial port= info -> ACPI table. =20 ## Control Flows -GetSpcrDevice() in SpcrDeviceLib -> SpcrAcpiDxe. +GetSpcrDevice () in SpcrDeviceLib -> SpcrAcpiDxe. =20 ## Build Flows There is not special build flow. =20 ## Test Point Results -* Check the output ACPI table. +There are not test points implemented. =20 ## Functional Exit Criteria * Check the output ACPI table. diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeatureP= kg.dec b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.d= ec index 03776abf06..b084fad892 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.dec +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.d +++ ec @@ -21,6 +21,12 @@ [Includes] Include =20 +[Guids] + gSpcrFeaturePkgTokenSpaceGuid =3D { 0xe978c988, 0xeeba, 0x4671, { 0xb8,= =20 +0x0d, 0xcc, 0x8b, 0x89, 0xb5, 0xd1, 0xef }} + +[PcdsFeatureFlag] + =20 +gSpcrFeaturePkgTokenSpaceGuid.PcdSpcrFeatureEnable|FALSE|BOOLEAN|0x0000 +0001 + [LibraryClasses] ## @libraryclass Provides an API for get SPCR device. # diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeatureP= kg.dsc b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.d= sc index 82d2d3ac73..2ee874a58e 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.dsc +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.d +++ sc @@ -24,6 +24,24 @@ PEI_ARCH =3D IA32 DXE_ARCH =3D X64 =20 +[Packages] + MinPlatformPkg/MinPlatformPkg.dec + +[PcdsFeatureFlag] + # + # PCD needed for MinPlatform build includes + # + gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable = |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable = |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |FALSE + +# +# Include common libraries +# +!include MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc +!include MinPlatformPkg/Include/Dsc/CorePeiLib.dsc +!include MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc + # # This package always builds the feature. # -- 2.27.0.windows.1