From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web11.1172.1627494460090053941 for ; Wed, 28 Jul 2021 10:47:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=LrGhq5td; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: rangasai.v.chaganty@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10059"; a="192312119" X-IronPort-AV: E=Sophos;i="5.84,276,1620716400"; d="scan'208";a="192312119" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2021 10:47:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,276,1620716400"; d="scan'208";a="580941785" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga001.fm.intel.com with ESMTP; 28 Jul 2021 10:47:39 -0700 Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Wed, 28 Jul 2021 10:47:38 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Wed, 28 Jul 2021 10:47:38 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Wed, 28 Jul 2021 10:47:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ri/6jpZlheMIqjEefmdvYKLr66qkcyrhRpstO0EJNM8U3lWbZJVn8KWvHaJMGAg5fej4c5U1uIBCjmXIAvGVLVFAyQNUGdGdDCP1hIvrK++rpUBYBE+Je6F3lYAo9UWb0tVl+2mIQPUomS/mdz5uofZdv6uyRPt7wGdpZAIvhJNU4E8nYq8bubBnlMwpBafUWBW4AsyNswjcQpCRRtUFNDYH5YhoURVysN8BRopvTeOiiP2ZAnWVo9eundyMRMgrGmEj+G1ean0zs3jRqoGE4sZzALztuigRTDSbBYicq+rSmtTaMdEflcqxISDhzqIkWZLB5eZ+l82Sp/XoGJDwcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L/LCPfcArbVjgj7tzjM0M9r5YbrpJFxfNQvYF3N1F5w=; b=ERr6lNTlouK9pzfxnrSdbLQCoHL+ogwy8QR6oGs3S5KWaClkzEwM/IkvbrLqvYIO2zTHTeeDD2N4C5bofq2vkFyHOrnVjZ4TdnixfBNyKUHUjqfpiWG1GkwEfgQNxRkE8NQ1jXRD5rQFUx5Un3rPYB9jqtn9QsYOqeyCfW5zafxPBePz0HJg4h1qOr2cMS8fzFbtBy87nnk16hFLzQgVHCYhao6oBJ3iM00xT+KLu0e28E0Gl5gBVMPRQZzP39GXb+BTEb7Q0Rz515XZtXG/Msg3D9jTGIV8OOQyOFMl2gTyVxexLB90e168rGjb89G7PpfulhoujzNJNAaJJAFQZA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=L/LCPfcArbVjgj7tzjM0M9r5YbrpJFxfNQvYF3N1F5w=; b=LrGhq5tdwlGqP3p1BRx4T0IVBJhMl5L53+1NNPWGzUMSs22jSSw3nlwf2FBFeLZ5b/MPpHYp3ElKeteaLxCQwf0QxbBCsP1dBW+0yxVMxwPEb1goTTux/GnQY/QnN0uyFJfGuR6m7d2auLxnAHF3aFvJThO9UXsspRHQXSyFXdU= Received: from MW3PR11MB4602.namprd11.prod.outlook.com (2603:10b6:303:52::19) by CO1PR11MB4817.namprd11.prod.outlook.com (2603:10b6:303:98::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18; Wed, 28 Jul 2021 17:47:31 +0000 Received: from MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::5d92:adb0:834d:f5f2]) by MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::5d92:adb0:834d:f5f2%9]) with mapi id 15.20.4373.018; Wed, 28 Jul 2021 17:47:31 +0000 From: "Chaganty, Rangasai V" To: "Solanki, Digant H" , "devel@edk2.groups.io" CC: "Ni, Ray" , "S, Ashraf Ali" Subject: Re: [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD OpRegion v3.0 Thread-Topic: [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD OpRegion v3.0 Thread-Index: AQHXfu9XZwKS/v/DIk+wptW8u469oatYs1vg Date: Wed, 28 Jul 2021 17:47:31 +0000 Message-ID: References: <20210722114654.18447-1-digant.h.solanki@intel.com> In-Reply-To: <20210722114654.18447-1-digant.h.solanki@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7c451ff9-115a-4de5-fabf-08d951efc648 x-ms-traffictypediagnostic: CO1PR11MB4817: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:142; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: s6BlqPwRWH9CiJkfWZERvy9dLWHWM7blDIP71LxKchF8onlBYXeUpN0gSLdLgwACpVeJMjpfLXC6I6cR3+gJeCiQRYL/GlGJZnewfLHfkG4vhTwQHMX2YqDZwmD0BMDPVON20g/CtJVYMfuSTKkpkYXClXii63qqWuLzcjTdZx7ompiVr7cUmRqWxYeh/pJ76Ysj0JnLaWGXoCFvFn3c6G4wm1Wul8ighVcKkgqszO06WsQ3moqRuXwn7sUa/nhIWxyT7H+FeASmJWDx4YZ75Uj5pAB+qIW4K/oq8zHdNsFvZFrW+Iu3gx+sib4qWbjRJdHWZmdfc/QLKv2iyBTETO83QgIlJ3B7au6wMUt2E+hXFkPe9c/XC+kj5wmE8AUbS72A9tX/uiSBHhDNK8BL/a1YI1yYlYTPXR9jOkiCZgbbP8riv9yqmqSvp83ogv2sPsd5T3kTHIY2HZ4RLHF2FGVFA48Rjqq4XmuqaJWWaQygRM03SSwlIhT1XoRMzh9lPcIEj/qbTcGbYB6ryOZpw92tnzO07i8t5KcHxq2c2/qEzBKkSuVFLbvvXc6MXUhl42kqmHKLRq4Q6Oa4iFn9Kja3nZhpizbmloRniXctDipzYBrFDKXpITHf9gGb/90F83d8a7wrfSzLe+5a3kUy7G6z2YntcPpU8omwz8N6qhb7S7g3q80Jc3YGQeuvdBWrGbc2K5PQVUNhMsoMqqaXH6LRsKSU6KoZxCSOJzfJlF0fAVR6ctnz5ReAIRLCyIDHRIP8tPUDT6E/999cIzTsbn7qXIGgxru72LnqcsIzkUg= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4602.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(396003)(39860400002)(366004)(376002)(136003)(346002)(66556008)(66476007)(64756008)(76116006)(7696005)(66946007)(71200400001)(4326008)(110136005)(86362001)(316002)(478600001)(54906003)(33656002)(2906002)(83380400001)(8676002)(107886003)(9686003)(5660300002)(186003)(6506007)(8936002)(55016002)(52536014)(66446008)(38070700005)(26005)(38100700002)(122000001)(53546011);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?pjPKQU+lzOXDh+eeIecAOvL0AyFt+a7MYPO6yfkOTPawYEGx/pe515m6Nw9Y?= =?us-ascii?Q?YvxYaPcv9UzwKn+M2nIIHvyhR4AWsqMuqKqCzdXzRiydyQD1THmtK902+Wuj?= =?us-ascii?Q?F4v1PCN33f5CIqQdnNM7QvWL2z3BEaW1BFrtOKy+H/erOCmBPdMGbDPWPxPx?= =?us-ascii?Q?WrtC19R4zEqopcsCONzfz+J89+GEqkzYHEWzzrs8ZW9bmwi44fA//tpmv4Ek?= =?us-ascii?Q?4rMqRCqzBVFFYS0ZmBoAP1VC4lfWtXZAozxiFTlTOh1t05QoovIX70iqeuA3?= =?us-ascii?Q?U4ip6HTCH2W1hL8NJbNJkkpHbYTH/GMyNgM86pyhhaecKjZo5m+K0jcfzCVz?= =?us-ascii?Q?stPfKYYWctz1pV/jPudCG+rycoPbJa2d4j6U3rlg2X+6ZsPZyyTini+d/KEq?= =?us-ascii?Q?o9+bAm9BSMXhycnt/SRIFwk4Nk4dtjWJww9bJDb7VSqPBBEG84ZvYsRInpcC?= =?us-ascii?Q?Cu+ZLuHOUeaDEsdmzJXuFsY+LkFYaVWsVvJJ/aq9beXxAY53vJ3sh9ttWodw?= =?us-ascii?Q?yYSEwG0C78Ew0I2EdTP6k1QYB/ucBYIZMpyVOSx+lvUR/RLtwxnJegDQW7uI?= =?us-ascii?Q?bDKA9RWWsIObFgjdiQaG6EZQTYWckOjvssarQIFNdaw0bMv4Y8UiH+ibewCj?= =?us-ascii?Q?EpCHjxpDUwA3EY8BCL5PJ6wEhfkBSa5IkwxTPcb/wGfS1Gb4uzMlO8uB4SoR?= =?us-ascii?Q?mEjd79VzwO3wSQy5gS2eG7Jb3HHs8Sua8NTKOCSJHGs7B0/2ggwITy6pABfE?= =?us-ascii?Q?Wp4zJByhpe6U2c7SFP/mqhTJxJl0q4sEeRuWT811ys7vlOo/u1yj6P/1yVQ/?= =?us-ascii?Q?z/GXTXsyUmoR14scKXUqoNhkZY4g5bmakjfTaROUL8oNBr9HQqZ9rfppd5ka?= =?us-ascii?Q?E312VWzRxbBmbm9ukfTtKVMJ0Qo132W8qDAiaybePk9pISbZYbBJjfEVu/rz?= =?us-ascii?Q?xuPg1cLsad84UgjlXdH4BocL73+OMvgUcOe9NbO+iM67pqQjm3kanYPza4SB?= =?us-ascii?Q?7U+McsLcy3WZC4Vp2eywarfQmmx4KWTw7WjVBwWZTFAXaObAkqUtq0f998/Y?= =?us-ascii?Q?Wj6G/jXkeJvUnCH9PVfr3K2KwL2a6Qt3vipq/o6fHVBnhw0SAyf6OWdcDnOp?= =?us-ascii?Q?NOAJ+WZJUYQ7GgovzzNStoZJtaO1UhuHJfe3mBq/LEqknhUniabfOA9ipl6f?= =?us-ascii?Q?Mt30bx7BLGQ+GJ9WMR6QpNVGbYUT6OeU6edlpk3v+Ek0KfKk8Mki8Ob1AlDF?= =?us-ascii?Q?8lx01jLCvgSbG9Jg744xewrxTGUgTcq3XAGy2qIjWS+5qDXTUHhqkGxDtCYv?= =?us-ascii?Q?uAkCmh5QXFQpSJNAfq83FGgJ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4602.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c451ff9-115a-4de5-fabf-08d951efc648 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2021 17:47:31.4594 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 225I1NZ2zInAvYLp/6W0C4ySTZrLY/GDg7cRc6bjaQ3GXeI82lmDRApZpdzwl+DrPpkZHzifyxpV1jbeLvvkcDE7Gq76D7WalvNVfQ3tHzk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4817 Return-Path: rangasai.v.chaganty@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sai Chaganty =20 -----Original Message----- From: Solanki, Digant H =20 Sent: Thursday, July 22, 2021 4:47 AM To: devel@edk2.groups.io Cc: Solanki, Digant H ; Ni, Ray ; Chaganty, Rangasai V ; S, Ashraf Ali Subject: [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD Op= Region v3.0 REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3426 - There are many OpRegion fields obsoleted in MBOX1 - MBOX2 is re-purposed for Backlight related fields for dual LFP. - Backlight related fields moved to MBOX2 from MBOX3 and some fields are ob= soleted in MBOX3. Signed-off-by: Digant H Solanki Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Ashraf Ali S --- Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion30.h | 1= 01 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++ 1 file changed, 101 insertions(+) diff --git a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/IgdOpRe= gion30.h b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegi= on30.h new file mode 100644 index 0000000000..c9948ab55f --- /dev/null +++ b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion +++ 30.h @@ -0,0 +1,101 @@ +/** @file + IGD OpRegion definition from Intel Integrated Graphics Device=20 +OpRegion + Specification based on version 3.0. + + Copyright (c) 2021, Intel Corporation. All rights reserved.
+ SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ +#ifndef _IGD_OPREGION_3_0_H_ +#define _IGD_OPREGION_3_0_H_ + +#include "IgdOpRegion.h" + +#define IGD_OPREGION_HEADER_MBOX2_VER_3_0 BIT5 + +#pragma pack(1) +/// +/// OpRegion Mailbox 1 - Public ACPI Methods /// Offset 0x100, Size=20 +0x100 /// typedef struct { + UINT32 DRDY; ///< Offset 0x100 Driver Readiness + UINT32 CSTS; ///< Offset 0x104 Status + UINT32 CEVT; ///< Offset 0x108 Current Event + UINT8 RM11[0x14]; ///< Offset 0x10C Reserved Must be Zero + UINT32 DIDL[8]; ///< Offset 0x120 Supported Display Devices ID Lis= t + UINT32 CPDL[8]; ///< Offset 0x140 obsolete + UINT32 CADL[8]; ///< Offset 0x160 obsolete + UINT32 NADL[8]; ///< Offset 0x180 obsolete + UINT32 ASLP; ///< Offset 0x1A0 ASL Sleep Time Out + UINT32 TIDX; ///< Offset 0x1A4 obsolete + UINT32 CHPD; ///< Offset 0x1A8 obsolete + UINT32 CLID; ///< Offset 0x1AC Current Lid State Indicator + UINT32 CDCK; ///< Offset 0x1B0 Current Docking State Indicator + UINT32 SXSW; ///< Offset 0x1B4 obsolete + UINT32 EVTS; ///< Offset 0x1B8 obsolete + UINT32 CNOT; ///< Offset 0x1BC obsolete + UINT32 NRDY; ///< Offset 0x1C0 Driver Status + UINT8 DID2[0x1C]; ///< Offset 0x1C4 Extended Supported Devices ID Li= st (DOD) + UINT8 CPD2[0x1C]; ///< Offset 0x1E0 obsolete + UINT8 RM12[4]; ///< Offset 0x1FC - 0x1FF Reserved Must be zero +} IGD_OPREGION_MBOX1_VER_3_0; + +/// +/// OpRegion Mailbox 2 - Backlight communication /// Offset 0x200, Size=20 +0x100 /// typedef struct { + UINT32 BCL1; ///< Offset 0x200 Backlight Brightness for LFP1 + UINT32 BCL2; ///< Offset 0x204 Backlight Brightness for LFP2 + UINT32 CBL1; ///< Offset 0x208 Current User Brightness Level fo= r LFP1 + UINT32 CBL2; ///< Offset 0x20C Current User Brightness Level fo= r LFP2 + UINT32 BCM1[0x1E]; ///< Offset 0x210 Backlight Brightness Levels Duty= Cycle Mapping Table for LFP1 + UINT32 BCM2[0x1E]; ///< Offset 0x288 Backlight Brightness Levels Duty= Cycle Mapping Table for LFP2 +} IGD_OPREGION_MBOX2_VER_3_0; + +/// +/// OpRegion Mailbox 3 - BIOS/Driver Notification - ASLE Support ///=20 +Offset 0x300, Size 0x100 /// typedef struct { + UINT32 ARDY; ///< Offset 0x300 obsolete + UINT32 ASLC; ///< Offset 0x304 obsolete + UINT32 TCHE; ///< Offset 0x308 obsolete + UINT32 ALSI; ///< Offset 0x30C obsolete + UINT32 BCLP; ///< Offset 0x310 obsoleted in ver 3.0, moved to M= ailbox 2. + UINT32 PFIT; ///< Offset 0x314 obsolete + UINT32 CBLV; ///< Offset 0x318 obsoleted in ver 3.0, moved to M= ailbox 2. + UINT16 BCLM[0x14]; ///< Offset 0x31C obsoleted in ver 3.0, moved to M= ailbox 2. + UINT32 CPFM; ///< Offset 0x344 obsolete + UINT32 EPFM; ///< Offset 0x348 obsolete + UINT8 PLUT[0x4A]; ///< Offset 0x34C obsolete + UINT32 PFMB; ///< Offset 0x396 obsolete + UINT32 CCDV; ///< Offset 0x39A obsolete + UINT32 PCFT; ///< Offset 0x39E obsolete + UINT32 SROT; ///< Offset 0x3A2 obsolete + UINT32 IUER; ///< Offset 0x3A6 obsolete + UINT64 FDSS; ///< Offset 0x3AA obsolete + UINT32 FDSP; ///< Offset 0x3B2 obsolete + UINT32 STAT; ///< Offset 0x3B6 obsolete + UINT64 RVDA; ///< Offset 0x3BA Physical address of Raw VBT data= . Added from Spec Version 0.90 to support VBT greater than 6KB. + UINT32 RVDS; ///< Offset 0x3C2 Size of Raw VBT data. Added from= Spec Version 0.90 to support VBT greater than 6KB. + UINT8 VRSR; ///< Offset 0x3C6 Video RAM Self Refresh + UINT64 DLHP; ///< Offset 0x3C7 Dual LFP Hinge Alignment Paramet= ers + UINT8 RM32[0x31]; ///< Offset 0x3CF - 0x3FF Reserved Must be zero. +} IGD_OPREGION_MBOX3_VER_3_0; + +/// +/// IGD OpRegion Structure +/// +typedef struct { + IGD_OPREGION_HEADER Header; ///< OpRegion header (Offset 0x0, Si= ze 0x100) + IGD_OPREGION_MBOX1_VER_3_0 MBox1; ///< Mailbox 1: Public ACPI=20 +Methods (Offset 0x100, Size 0x100) + IGD_OPREGION_MBOX2_VER_3_0 MBox2; ///< Mailbox 2: Backlight=20 +communication (Offset 0x200, Size 0x100) + IGD_OPREGION_MBOX3_VER_3_0 MBox3; ///< Mailbox 3: BIOS to Driver Notif= ication (Offset 0x300, Size 0x100) + IGD_OPREGION_MBOX4 MBox4; ///< Mailbox 4: Video BIOS Table (VB= T) (Offset 0x400, Size 0x1800) + IGD_OPREGION_MBOX5 MBox5; ///< Mailbox 5: BIOS to Driver Notif= ication Extension (Offset 0x1C00, Size 0x400) +} IGD_OPREGION_STRUCTURE_VER_3_0; +#pragma pack() + +#endif -- 2.30.2.windows.1