From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web08.5812.1625797551346478439 for ; Thu, 08 Jul 2021 19:25:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=mxhnrG8V; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: rangasai.v.chaganty@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10039"; a="273469491" X-IronPort-AV: E=Sophos;i="5.84,225,1620716400"; d="scan'208";a="273469491" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2021 19:25:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,225,1620716400"; d="scan'208";a="411113157" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by orsmga006.jf.intel.com with ESMTP; 08 Jul 2021 19:25:49 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 8 Jul 2021 19:25:48 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Thu, 8 Jul 2021 19:25:48 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.176) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Thu, 8 Jul 2021 19:25:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WbHo1pynPGxvs1wkEJXidKyhOjnafLSCXJabldA4V9CrcReXqin14ZpcPJgNYEEozUki/vq4tORRrlnjQPvL4GTIw0Ep0HV6cMNj9XkulvwpwyaTIJj0UDznpNl89L6pz4Sdow8UlQ5bJlOFdy1ixiyxfttTX4y2oojneLALrVY4hVQ0x3f5K8/7E/RF87Wxt2QULO4YhYu8x4R9b0QdnrKOGVu+S8MoIcjdU8simCnmZ21fNUsD4Ldv9QY+qST0LQrVq9JgyQpMN6D8EtmXtxOo6xorqBSHG/qH0UYcnNWB+QzqorzcuWSSjBbH7WttszydhBtdBMtpMEU9wcOZ6g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F9uT6hR3H2HRJviQ27WCAm3j8/OPnY3Cq/IYWXRgV6g=; b=T9WGCvfi9ewRwnQAhcdJtRdKn4od8Dm99k0Y4KSqmVpfz26VVBeOxo0Lj/6VUQOBZtPwOLqLdO6kwmIq+7bdgc4Qo23K2hKmfryll8onfeBIAUxxefG6+fz2ykjvqO4dySod7GRDM6BMlFIlY23pm50bGiq4fIdfr9/eoqFCE0/snu15RnKKt/nx2nNQpRvknYipR5P2246Sd19nZKjOS0dEbulV87L1G6OacnDqk6WltVBJ3WMsn4pp9GR4laWpGKgFmjE8lfORpRdfGaAmSVwF82k8+uclu8avlJoR5uKe/UGfJ3dC3ZB/m4e9Tbg+1QA+h361kC4K33QmnWERbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=F9uT6hR3H2HRJviQ27WCAm3j8/OPnY3Cq/IYWXRgV6g=; b=mxhnrG8Va59o9Rbv3JosUUCzN4jLXl6d/JfSVP9GBEQJhenEgveP4wMsFLgMmdvIE+aggLHuQmLzzTc3OmNdN1/KpFfAc6s97AH+J0e1jzZGhI10C9R8dtPLYLJcLYxP76111taQc6PNidYflaZJIR5i5NLzCom7DwyhYnw8Om4= Received: from MW3PR11MB4602.namprd11.prod.outlook.com (2603:10b6:303:52::19) by MWHPR11MB1631.namprd11.prod.outlook.com (2603:10b6:301:10::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.20; Fri, 9 Jul 2021 02:24:58 +0000 Received: from MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::5d92:adb0:834d:f5f2]) by MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::5d92:adb0:834d:f5f2%7]) with mapi id 15.20.4308.023; Fri, 9 Jul 2021 02:24:58 +0000 From: "Chaganty, Rangasai V" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , Liming Gao , "Oram, Isaac W" Subject: Re: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package. Thread-Topic: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this package. Thread-Index: AQHXdAdgwsm5h3WpZUCDml1qJmd9yqs56OvA Date: Fri, 9 Jul 2021 02:24:58 +0000 Message-ID: References: <20210708144056.1740-1-chasel.chiu@intel.com> <20210708144056.1740-2-chasel.chiu@intel.com> In-Reply-To: <20210708144056.1740-2-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 69407871-07d0-42c3-345b-08d94280bf7b x-ms-traffictypediagnostic: MWHPR11MB1631: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:21; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: OnfT+jaYeqlrxsmGFzRMhThJgqASaUxfw3xkA9X9cGS15SoeJtS8BZtwYr1f8b89fpA0Qu4iXGX2cK9pYV2a/jYPeI37DHKVDZ/cwfLO/yrwLOi40We0cuIRpGDMuii4+6qpWXiJU1ZQ3FZ28fBvseZ0iq4CGSpUxcQy1IbU0SndbBH/n4H35m1kNbTBD63DGqOlYoFVG6BZzYnfLPAqj8rRCqh+9dSlsuePpueOUKDfmsvxl9Jnr3BdUNXt1Q9GedAtFlV5RgHhGivAIxFNO9zmL6AOOiKmiIZ0A+sz+9lzveJYFMwkKAuSpAEpKdEnEG8XQpH8PB8sjhius/pezYnbZQJTwhTqFMIIIXZ0buC/rJYNrLxQFgg9gc43SFa5+4hgew1hDjhpN4yRsM8Vw59Bcu1lp1qiAM5WSl3z0xewuRAph8h7d0ChAIPe8oyfoObq7ZMAiH/bWdU1jqRzxMy36MnxFQbyYaxN1NTNRyEXPB523XqeVfXvqIlKYW10UsNYrYlsnuTnMcUTvTxty8KshEzrU3mWdYf5yNsRvO3UYlQRHqv8GQTMrnGs5mvzBfjArgu2k14KdcKgQ6E2qoPCTmfUkTYsg+XdEEJWpE00kmxviFNVyTCIPpj4drojhiPl54Nlij2vxVX37vGdDhr+7CTtTi9G3TEygaIl5kH279Zfudw8O//XbQNDCz/hPpueksYgf8Yd6ywp/hzPSLVekd1zm3LYwZyrorXtyZc= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4602.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(396003)(376002)(39860400002)(366004)(346002)(966005)(33656002)(55016002)(9686003)(8936002)(8676002)(54906003)(316002)(110136005)(86362001)(83380400001)(71200400001)(478600001)(6506007)(4326008)(53546011)(38100700002)(122000001)(52536014)(7696005)(2906002)(186003)(64756008)(66446008)(26005)(76116006)(66476007)(66556008)(66946007)(107886003)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?m5dKz8ZockrtNz504BaPKc/wdEpUzpb0KhW20d/Bhir3hkSly19zrvZ0H/Nv?= =?us-ascii?Q?3pGxgnD/g0cty5h21H12j6di4wgeXfcm5Zgyxqu7qi879lkwqK82p9wioAHF?= =?us-ascii?Q?QkR89mbUQ+blysem3naSPvI7fi0WL+CldZEWH7iDH4db7VVuOi0+RdFDYGf1?= =?us-ascii?Q?67bk4l8JLtrkP/eUbZVkPLbQgq6TmNyQFUogBn8QRmdMc9PHyVUrlCSTaMu7?= =?us-ascii?Q?IKE3Ze9RuH2GWrKj+X1b9k9yUhW2ciRIpUbLt53ADAp+oiSrHqR5C+2plfkA?= =?us-ascii?Q?trmaGfltCvCSRnCmct6MvV1ucGntglunyTGc3JtVn1YG5uyxbbBVhzX4JdkW?= =?us-ascii?Q?p5KDLLufMb41iyHeRqBGNM5H1wcSazBcy2wgYRbuYaEfXndIUnT6qygygsep?= =?us-ascii?Q?6VodTu7ulhY+s75AtP76cVn+ZNl6iop1W486EzgO8P29ilo6lzdiFENalhI/?= =?us-ascii?Q?ANZLDFRiAItCMRWAcx3qPJXJ1ZKm2LZ0mC4UWTQ0nPTIcM2m1vK4DQXJic4V?= =?us-ascii?Q?KaxyQXbOdmYqDOq0vzEwjjhvKNDAuS1aGcBtEZ9TZQDOIqjHM1nEmtuNk/sR?= =?us-ascii?Q?QLyZOJ2f3epcYrT4bUKWOHYA/zGDUCMy3B7jJswPJsmlyl27g81VSXnN3Jms?= =?us-ascii?Q?rks7Gikv0WLHGApOBmHWCbB8y6Yg4zs+YA47r6tXcoOxm/8ESuHelouiRowE?= =?us-ascii?Q?DmFQGvFHq7E3bG9XIvxkY8yp0fZscut50yAN5PjCIoSym0ntR6Y1hXZxE31K?= =?us-ascii?Q?tRCMn5KU9E7Cvqo4ifRcJwQiHQoMZTjOY959OvjiXezzsHWxAtf+5Y0tdYEq?= =?us-ascii?Q?Om7pbVceRCUYx78anCNLWGVCJoGDl4PuQNC/qptdeBrrgVq/N9YMgqi9t16W?= =?us-ascii?Q?6x1AyktTOulETXf/M/E7jCU2FzNv5kymuYRgBPn9/fLCDcLmzLjlpKRFWzNi?= =?us-ascii?Q?+vvLBzMiCa6Ng1Uqx3j1Gz4TkAd1iL1Jxhw6csllOA9yHWq/9eezWPG6fEkk?= =?us-ascii?Q?6yWh+XBF+nuFto/YedlaUR9OM12Hc0y8FSipAoH+YtqnLm1mJpnDAx1pkPGT?= =?us-ascii?Q?44NBeIUqX9rzQ9Jt+KajIEGs3O08MECyKR8axKPA+Ad9tcmaHsVolxTzfwaP?= =?us-ascii?Q?m4YSJcpZ/3T4wf/Fn9LYi+LAdxBLtQZr++zKLCRNQreX7dIIUgQraTwnwA3r?= =?us-ascii?Q?9Rzl79FcDQGNFe5qwU5YjTY2Xqd9tvQkhtFIrFp3UHbCEiFkXclDTgcr8A6A?= =?us-ascii?Q?fsbWKABZaxpLghFPOdO/5r32dRRt7qjBhnbkQo7rzeDHjKoa6AozZUYsSgU4?= =?us-ascii?Q?4buMwqaHZhhRgtWsh3yClQbI?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4602.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69407871-07d0-42c3-345b-08d94280bf7b X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2021 02:24:58.4439 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ECfS62xUHbnQuzVIpRHD3jyZTPJ0KQEvwFziwzKS0bMxlu2VfQCnJjmCCNyHSdcShMLC3plYVuNl8EHHg9KzNE1S5ipr0Z+ueFzHdrdhzfA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1631 Return-Path: rangasai.v.chaganty@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable In ServerManagment.h, please make sure the newly added macros and structure= names are EFI/PI spec defined.=20 If they are not, please remove "EFI_" prefix from the names.=20 With that: Reviewed-by: Sai Chaganty =20 -----Original Message----- From: Chiu, Chasel =20 Sent: Thursday, July 08, 2021 7:41 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Chaganty, Rangasai V = ; Liming Gao ; Oram, Isaac W Subject: [edk2-platforms: PATCH 1/2] IpmiFeaturePkg: Fail to build this pac= kage. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3484 Fixed the build failure of this package. Cc: Nate DeSimone Cc: Sai Chaganty Cc: Liming Gao Cc: Isaac Oram Signed-off-by: Chasel Chiu --- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGener= icIpmi.inf | 1 + Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc = | 11 +++++++++++ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerManagement= .h | 17 +++++++++++++++++ 3 files changed, 29 insertions(+) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Pei/PeiGenericIpmi.inf b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/= GenericIpmi/Pei/PeiGenericIpmi.inf index 0ef2c18116..bd995ef25f 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/Pei= GenericIpmi.inf +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/Pei= GenericIpmi.inf @@ -42,6 +42,7 @@ DebugLib IoLib TimerLib + ReportStatusCodeLib =20 [Guids] =20 diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Ipmi= Feature.dsc b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Ipm= iFeature.dsc index a1fcefad70..05a7d4f0af 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature= .dsc +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature= .dsc @@ -59,6 +59,12 @@ PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/= PeiServicesTablePointerLibIdt.inf + ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiRepor= tStatusCodeLib.inf + + ##################################### + # IPMI Feature Package + ##################################### + IpmiBaseLib|OutOfBandManagement/IpmiFeaturePkg/Library/PeiIpmiBaseLib/Pe= iIpmiBaseLib.inf =20 [LibraryClasses.common.DXE_DRIVER,LibraryClasses.common.UEFI_DRIVER] ####################################### @@ -72,6 +78,11 @@ UefiLib|MdePkg/Library/UefiLib/UefiLib.inf UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/U= efiRuntimeServicesTableLib.inf =20 + ##################################### + # IPMI Feature Package + ##################################### + IpmiBaseLib|OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLib/IpmiB= aseLib.inf + ##########################################################################= ###### # # Component section - list of all components that need built for this feat= ure. diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/Serv= erManagement.h b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/= ServerManagement.h index 244b86e91a..7591f33aba 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerManag= ement.h +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/ServerManag= ement.h @@ -149,6 +149,15 @@ typedef enum { #define UPPER_NON_RECOVER_GOING_LOW 0x400 #define UPPER_NON_RECOVER_GOING_HI 0x800 =20 +// +// Definitions for Get BMC Execution Context +// +#define EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT 0x23 +// +// Current Execution Context responses +// +#define EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE 0x11 + // // Server Management COM Addressing types // @@ -318,6 +327,14 @@ typedef struct { UINT16 IoBasePort; } IPMI_HOB_DATA; =20 +// +// Constants and Structure definitions for "Get Device ID" command to fol= low here +// +typedef struct { + UINT8 CurrentExecutionContext; + UINT8 PartitionPointer; +} EFI_IPMI_MSG_GET_BMC_EXEC_RSP; + // // COM Layer Callback // --=20 2.28.0.windows.1