From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.1276.1627494870072332460 for ; Wed, 28 Jul 2021 10:54:30 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=cz2yaife; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: rangasai.v.chaganty@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10059"; a="199898359" X-IronPort-AV: E=Sophos;i="5.84,276,1620716400"; d="scan'208";a="199898359" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2021 10:54:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,276,1620716400"; d="scan'208";a="456573294" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga007.jf.intel.com with ESMTP; 28 Jul 2021 10:54:27 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 28 Jul 2021 10:54:26 -0700 Received: from orsmsx606.amr.corp.intel.com (10.22.229.19) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 28 Jul 2021 10:54:26 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Wed, 28 Jul 2021 10:54:26 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Wed, 28 Jul 2021 10:54:26 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gWtF8jeioFEnmvTCF4SWsnzSMrSSh75zQYFrC5jGk4nje2qVHTTy6VBwAQwhjFvputj9FKILBOW1XTUqjUzfApgmZOrVpUYjwVC86G2V3nuBRk46Oufjl2PbsLO5BPloqk26RgWeoFNL56u5kJwhK3KOGhtidvao7P/xaX5NuJ2j7/4lz4pTZ0DlsnLfjU1Bh6Cj/2FTGUiX4w2lx9P+IQ/TQb1TZDQ+A6/T+gF+rjLfMKQ0gQSAuRiYoViQQPQPg4RwuBWHKbv1TSpjoA7c89hxNtGPgkbbXy2zemqpGFxs6Kv6Nhmf6k7Ndr2/9nFYbxOHc6sBGldzQL12lNqNEA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7UR+CXXCaELsno+e1KygSolQ+AQz2d1B/9fFX0Et+I8=; b=N/plbgf9vR9qD1uUDk3xmFbabAKskap2Rt2ckIbF2tIPBpkTl87ARhY92SdasNWkIJmN8FU7Gw1rIc8wNngBRdnHMCu1SccDKDLNPWAbfvJGDptk98DImEs46Im3BEgVPMGXuXiOydlJVka/GxZdnidhTDwRLAjnP+Ok42eB0hrvoHq7H5POPikBebkutBwGn5kxaOcpdKauzqb+Qrd8nRHzGKkqrXEinjvDY2QYP0ET+Nv96mLvAG8/uFvit1IOl4iaCBhjcDnLsi0uXrkCSnyzZQgo28fsxGkCywPNDBor8CvO6+WoNaVmqOb+PT9E1qVxFmrI4Sa3uA+R5EznbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7UR+CXXCaELsno+e1KygSolQ+AQz2d1B/9fFX0Et+I8=; b=cz2yaifeeWSRBVWviJRUtGrfODR8InjEx0cmEx5IJv85fR/TnbKRORUyPy6gZt7NyKEtcr9Ag8aWUv6ie8RaGkUnVKKc5uENzVMxuRHCoOGthZXtBvj1MPDxIUF5XVKho1oB3Nim5ebw6yfVWnu9owwmUAfsOaqqqnqkgMjNEWA= Received: from MW3PR11MB4602.namprd11.prod.outlook.com (2603:10b6:303:52::19) by MWHPR11MB1423.namprd11.prod.outlook.com (2603:10b6:300:22::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4352.26; Wed, 28 Jul 2021 17:54:24 +0000 Received: from MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::5d92:adb0:834d:f5f2]) by MW3PR11MB4602.namprd11.prod.outlook.com ([fe80::5d92:adb0:834d:f5f2%9]) with mapi id 15.20.4373.018; Wed, 28 Jul 2021 17:54:24 +0000 From: "Chaganty, Rangasai V" To: "Solanki, Digant H" , "devel@edk2.groups.io" CC: "Ni, Ray" , "S, Ashraf Ali" Subject: Re: [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD OpRegion v3.0 Thread-Topic: [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD OpRegion v3.0 Thread-Index: AQHXfu9XZwKS/v/DIk+wptW8u469oatYs1vggAABN8A= Date: Wed, 28 Jul 2021 17:54:24 +0000 Message-ID: References: <20210722114654.18447-1-digant.h.solanki@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: c8e60381-867b-49fc-076a-08d951f0bc6d x-ms-traffictypediagnostic: MWHPR11MB1423: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:462; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aMMKJGCTfAtoS9WZBlqySYRJONwNExANQ60n+rlhUGKVdX8FrmAo6DHj46jtliw7pcS45GSW2Q5Hl0Xyg0LTbG1JKrimgsqvScxukmEhVJte9qhSCUGJtPX4sqy6qcXXgYK6/4fFwURobYVkVecmgKj5St5/u8UKz+SfQbH/BX7alNXdu2hONbVMM7umCf2J0E/nTu5EVHhamGRNwqELtSWZriTrhRBYZCsE1dQm+hmvtW/E53Xdo33CNg4iJFc6So2erLpxMPLkgW0mk0RAGjUO3heHucDQmu3fobeVoe7X3fnmEgytwn128bRDDYRXF2CRN8mCQiZEa1l1UA1gSoJXSEjJUssbh6diiFpM4MWasVZQ8Hw0nFP/4D55AUw73KS9uJc8uAIVys8xWeCiUPdkXMzZg2iY2ThuFTy6g93gj0hpD10taISeMqOW38/M2Cb7j+1Swq33KFWSdyOqxc8DMTTEydm7b61At9vqNgrs1AKOrUxR5eqZkSb0lCXTGKBQU8G6HLng2Q0zyMn6w80AnOjOiSli6nyKJaYAkpkL7m0mxWvn4TlpfEcoT2R9Jh8HX9bCg0FyKqNS0NL/0BRoG6GcWPj3I5bPIlMDbRqaQGY6ONxO0A/5LKTNBINKt9gPLtYrbw730ohyu6NOmvmvSdEQoaYLouWO5hBic+H+yUnvFGNF5m0eNNzfC0XhYjCJJBdght5li1jft1u3D071IrmNJDGlIxGNMX53Vu0NG/8TZzD6o63hqmMTFTHEohzbeCu+hwexeI+boIx8JiN6PaDKwY5WgjTKLCJyYUU= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4602.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(6029001)(4636009)(39860400002)(346002)(136003)(376002)(396003)(366004)(86362001)(6506007)(66476007)(66556008)(53546011)(76116006)(66446008)(2940100002)(9686003)(26005)(186003)(122000001)(110136005)(64756008)(55016002)(7696005)(478600001)(66946007)(2906002)(54906003)(33656002)(52536014)(8936002)(83380400001)(5660300002)(107886003)(316002)(38100700002)(8676002)(4326008)(71200400001)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?c20b9ZvrTEJ+Xt/gOMkfM7UAyihQ9ZXg2hHL9YlcgNLpCCYOg/dpsh+ZgNv2?= =?us-ascii?Q?VFQCsyOTj7eHsdfvwXLaoz/7ICn9oUphwpIZgA9gpTomKPescFoUDq7/y3vV?= =?us-ascii?Q?aYvw4MQArXs3bmg/pfroGHaThk/0B/EnWmG1XR5Z8d8qCtPlqYH/kM3Dc8AA?= =?us-ascii?Q?urOMzgqXIPgaQ5n+AFBTF2rtAoMnEzp7ik9oth8oEKp9dxrA4/FQbuo25OCo?= =?us-ascii?Q?g1Sh/fz2Lwz63zXgd44n/2c68AvSc6B/aURTp4+rQ0ObL2Oui4vgDGZ2jz87?= =?us-ascii?Q?2wztilDQ0DU1DzRt/dRzYPVERPo/LQHcsXvdJIxGyNGVjWNIZuSvDl560mh+?= =?us-ascii?Q?YEj0bYHzsuL7mk3N6rz30xC0lutUcgSrn+qg3550Vya2RR63YNvZEXetxPyw?= =?us-ascii?Q?M6TBYAVARufOk0gFkaUqviDQ3DpctPiNnQzmDqoEvDzdzl7KjCoSf6eoO6/S?= =?us-ascii?Q?Q6Is5ZuYAqMvlGPiQ8/W6C3gr3+jHLaoP1Uk5Bx+6jk7rhfivE8oKe6anl+N?= =?us-ascii?Q?E6L9Pa0td0t019QVg9GKm3ykPA2aqJUDCDrykq2ROKK+Rke0e239EH0glXFx?= =?us-ascii?Q?i0Pv7ZjRn8sRHSKVHPAgk73e/ijIAtOCGmuPmSBbiWWeefADgnRCwrwuG6yj?= =?us-ascii?Q?MXIhhIZpzsQyzFbn9dhkCpVaUIXyFl8Eq7kKGJ4o99vGXPsVeK2yWrRYRCIP?= =?us-ascii?Q?fhWVu+Yxf5OLyCX78/DnLr6wQsiih8nCyKCD/gZhjivGOTswSCwwBuV7UhD9?= =?us-ascii?Q?GrdSjzfmbCWWm63PRwId8Ej5eVLJqBDR2pAKtkbBymYXsSHzXDvKFovtcdZq?= =?us-ascii?Q?hCvg0s25+NV3B7AesdJ/Z+UMshate/zAwBWCkcs8SmVv3CUmxpjCA1PVYn6l?= =?us-ascii?Q?lDzoy8y6HMK/hU8QRYFEvMN1rKrix0U8cXZrZbZhXPa+dfg2FBwJGSOyyT+7?= =?us-ascii?Q?PVLJuKrWsSuJhxycARzvbp2F+dmvoh7S/Z1Mhgv2a3zvgDd08vSHQREuzT2t?= =?us-ascii?Q?3guEuMVtTD/91ojvBqcJlC7fqsFyPYh37MEnhPS3gVizdLXNgvDNaJxyg4PT?= =?us-ascii?Q?NqKY3V97q/K46klQwl0JA4CGE6BF4YEV6Lf/awQkh4IIFxs8orsd6Y/Xu3+a?= =?us-ascii?Q?zUCAp87Y2rX6n6pXv88jA4zEtpOGcgQ5JKdOniZw5RWOIoNvajhfEQRHdruB?= =?us-ascii?Q?/gQ9UC5vmpNZ09c54ZuRDP7Eq7iCyuGUE0zta+Sh4TruC131ieeJqSu7ntxr?= =?us-ascii?Q?LfOBgvFL3aFAP9B5euV4dvxU3dDaq14J274qbbILMNfbybHuVIfXJQVP0Mr5?= =?us-ascii?Q?F7g3TVE9lx/aSlaBVTrNxgiQ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4602.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c8e60381-867b-49fc-076a-08d951f0bc6d X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2021 17:54:24.3942 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: JDrMIQTN53Ix84oXTqc3G542D0xzmpzghdpspLn/zPj/B32VRoeWGjjLGHzsXVwAHNj47IUabAgSB6Di5K89EO0ps3S3BnEKkXDTdYQyJ8k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1423 Return-Path: rangasai.v.chaganty@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Digant,=20 The notation "PATCH 3/3" indicates part 3 of a 3 patch series.=20 However since this is a single patch, the subject line could simply indicat= e [PATCH v3]. Something to consider for future reviews.=20 Thanks, Sai -----Original Message----- From: Chaganty, Rangasai V=20 Sent: Wednesday, July 28, 2021 10:48 AM To: Solanki, Digant H ; devel@edk2.groups.io Cc: Ni, Ray ; S, Ashraf Ali Subject: RE: [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IG= D OpRegion v3.0 Reviewed-by: Sai Chaganty =20 -----Original Message----- From: Solanki, Digant H Sent: Thursday, July 22, 2021 4:47 AM To: devel@edk2.groups.io Cc: Solanki, Digant H ; Ni, Ray ; Chaganty, Rangasai V ; S, Ashraf Ali Subject: [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD Op= Region v3.0 REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3426 - There are many OpRegion fields obsoleted in MBOX1 - MBOX2 is re-purposed for Backlight related fields for dual LFP. - Backlight related fields moved to MBOX2 from MBOX3 and some fields are ob= soleted in MBOX3. Signed-off-by: Digant H Solanki Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Ashraf Ali S --- Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion30.h | 1= 01 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++ 1 file changed, 101 insertions(+) diff --git a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/IgdOpRe= gion30.h b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegi= on30.h new file mode 100644 index 0000000000..c9948ab55f --- /dev/null +++ b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion +++ 30.h @@ -0,0 +1,101 @@ +/** @file + IGD OpRegion definition from Intel Integrated Graphics Device=20 +OpRegion + Specification based on version 3.0. + + Copyright (c) 2021, Intel Corporation. All rights reserved.
+ SPDX-License-Identifier: BSD-2-Clause-Patent + +**/ +#ifndef _IGD_OPREGION_3_0_H_ +#define _IGD_OPREGION_3_0_H_ + +#include "IgdOpRegion.h" + +#define IGD_OPREGION_HEADER_MBOX2_VER_3_0 BIT5 + +#pragma pack(1) +/// +/// OpRegion Mailbox 1 - Public ACPI Methods /// Offset 0x100, Size +0x100 /// typedef struct { + UINT32 DRDY; ///< Offset 0x100 Driver Readiness + UINT32 CSTS; ///< Offset 0x104 Status + UINT32 CEVT; ///< Offset 0x108 Current Event + UINT8 RM11[0x14]; ///< Offset 0x10C Reserved Must be Zero + UINT32 DIDL[8]; ///< Offset 0x120 Supported Display Devices ID Lis= t + UINT32 CPDL[8]; ///< Offset 0x140 obsolete + UINT32 CADL[8]; ///< Offset 0x160 obsolete + UINT32 NADL[8]; ///< Offset 0x180 obsolete + UINT32 ASLP; ///< Offset 0x1A0 ASL Sleep Time Out + UINT32 TIDX; ///< Offset 0x1A4 obsolete + UINT32 CHPD; ///< Offset 0x1A8 obsolete + UINT32 CLID; ///< Offset 0x1AC Current Lid State Indicator + UINT32 CDCK; ///< Offset 0x1B0 Current Docking State Indicator + UINT32 SXSW; ///< Offset 0x1B4 obsolete + UINT32 EVTS; ///< Offset 0x1B8 obsolete + UINT32 CNOT; ///< Offset 0x1BC obsolete + UINT32 NRDY; ///< Offset 0x1C0 Driver Status + UINT8 DID2[0x1C]; ///< Offset 0x1C4 Extended Supported Devices ID Li= st (DOD) + UINT8 CPD2[0x1C]; ///< Offset 0x1E0 obsolete + UINT8 RM12[4]; ///< Offset 0x1FC - 0x1FF Reserved Must be zero +} IGD_OPREGION_MBOX1_VER_3_0; + +/// +/// OpRegion Mailbox 2 - Backlight communication /// Offset 0x200, Size +0x100 /// typedef struct { + UINT32 BCL1; ///< Offset 0x200 Backlight Brightness for LFP1 + UINT32 BCL2; ///< Offset 0x204 Backlight Brightness for LFP2 + UINT32 CBL1; ///< Offset 0x208 Current User Brightness Level fo= r LFP1 + UINT32 CBL2; ///< Offset 0x20C Current User Brightness Level fo= r LFP2 + UINT32 BCM1[0x1E]; ///< Offset 0x210 Backlight Brightness Levels Duty= Cycle Mapping Table for LFP1 + UINT32 BCM2[0x1E]; ///< Offset 0x288 Backlight Brightness Levels Duty= Cycle Mapping Table for LFP2 +} IGD_OPREGION_MBOX2_VER_3_0; + +/// +/// OpRegion Mailbox 3 - BIOS/Driver Notification - ASLE Support ///=20 +Offset 0x300, Size 0x100 /// typedef struct { + UINT32 ARDY; ///< Offset 0x300 obsolete + UINT32 ASLC; ///< Offset 0x304 obsolete + UINT32 TCHE; ///< Offset 0x308 obsolete + UINT32 ALSI; ///< Offset 0x30C obsolete + UINT32 BCLP; ///< Offset 0x310 obsoleted in ver 3.0, moved to M= ailbox 2. + UINT32 PFIT; ///< Offset 0x314 obsolete + UINT32 CBLV; ///< Offset 0x318 obsoleted in ver 3.0, moved to M= ailbox 2. + UINT16 BCLM[0x14]; ///< Offset 0x31C obsoleted in ver 3.0, moved to M= ailbox 2. + UINT32 CPFM; ///< Offset 0x344 obsolete + UINT32 EPFM; ///< Offset 0x348 obsolete + UINT8 PLUT[0x4A]; ///< Offset 0x34C obsolete + UINT32 PFMB; ///< Offset 0x396 obsolete + UINT32 CCDV; ///< Offset 0x39A obsolete + UINT32 PCFT; ///< Offset 0x39E obsolete + UINT32 SROT; ///< Offset 0x3A2 obsolete + UINT32 IUER; ///< Offset 0x3A6 obsolete + UINT64 FDSS; ///< Offset 0x3AA obsolete + UINT32 FDSP; ///< Offset 0x3B2 obsolete + UINT32 STAT; ///< Offset 0x3B6 obsolete + UINT64 RVDA; ///< Offset 0x3BA Physical address of Raw VBT data= . Added from Spec Version 0.90 to support VBT greater than 6KB. + UINT32 RVDS; ///< Offset 0x3C2 Size of Raw VBT data. Added from= Spec Version 0.90 to support VBT greater than 6KB. + UINT8 VRSR; ///< Offset 0x3C6 Video RAM Self Refresh + UINT64 DLHP; ///< Offset 0x3C7 Dual LFP Hinge Alignment Paramet= ers + UINT8 RM32[0x31]; ///< Offset 0x3CF - 0x3FF Reserved Must be zero. +} IGD_OPREGION_MBOX3_VER_3_0; + +/// +/// IGD OpRegion Structure +/// +typedef struct { + IGD_OPREGION_HEADER Header; ///< OpRegion header (Offset 0x0, Si= ze 0x100) + IGD_OPREGION_MBOX1_VER_3_0 MBox1; ///< Mailbox 1: Public ACPI=20 +Methods (Offset 0x100, Size 0x100) + IGD_OPREGION_MBOX2_VER_3_0 MBox2; ///< Mailbox 2: Backlight=20 +communication (Offset 0x200, Size 0x100) + IGD_OPREGION_MBOX3_VER_3_0 MBox3; ///< Mailbox 3: BIOS to Driver Notif= ication (Offset 0x300, Size 0x100) + IGD_OPREGION_MBOX4 MBox4; ///< Mailbox 4: Video BIOS Table (VB= T) (Offset 0x400, Size 0x1800) + IGD_OPREGION_MBOX5 MBox5; ///< Mailbox 5: BIOS to Driver Notif= ication Extension (Offset 0x1C00, Size 0x400) +} IGD_OPREGION_STRUCTURE_VER_3_0; +#pragma pack() + +#endif -- 2.30.2.windows.1