From: "Sumana Venur" <sumana.venur@intel.com>
To: "Ni, Ray" <ray.ni@intel.com>, "Wu, Hao A" <hao.a.wu@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of the data read during oprom shadow
Date: Fri, 11 Jun 2021 17:01:48 +0000 [thread overview]
Message-ID: <MW3PR11MB46344BD1E46578F73F4694439E349@MW3PR11MB4634.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210611163744.19368-1-sumana.venur@intel.com>
Hello Maintainers
This patch is for MdeModulePkg/Bus. Please review and help with merging to master
It was sent a few months ago, might have been reviewed already. But due to CI failures and low importance it was lost.
Gerrit link - https://git-amr-7.devtools.intel.com/gerrit/#/c/117842/
Thanks
Sumana
-----Original Message-----
From: Venur, Sumana <sumana.venur@intel.com>
Sent: Friday, June 11, 2021 9:38 AM
To: devel@edk2.groups.io
Cc: Venur, Sumana <sumana.venur@intel.com>
Subject: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of the data read during oprom shadow
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2989
Long times spent on shadowing oprom from graphics card to system memory. We are currently using 8 bit read cycles.
This needs to be wider, at least 32bit reads to reduce the time for oprom shadow
Signed-off-by: Sumana Venur <sumana.venur@intel.com>
---
MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
index c994ed5fe3..a981f93f43 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
@@ -521,9 +521,9 @@ LoadOpRomImage (
//
PciDevice->PciRootBridgeIo->Mem.Read (
PciDevice->PciRootBridgeIo,
- EfiPciWidthUint8,
+ EfiPciWidthUint32,
RomBar,
- (UINT32) RomImageSize,
+ (UINT32) RomImageSize/sizeof(UINT32),
Image
);
RomInMemory = Image;
--
2.16.2.windows.1
next prev parent reply other threads:[~2021-06-11 17:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-11 16:37 [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of the data read during oprom shadow Sumana Venur
2021-06-11 17:01 ` Sumana Venur [this message]
2021-06-17 1:33 ` 回复: [edk2-devel] " gaoliming
2021-06-23 10:19 ` Laszlo Ersek
-- strict thread matches above, loose matches on Subject: below --
2021-01-08 4:05 Sumana Venur
2021-01-08 2:32 Sumana Venur
2021-01-07 6:29 Sumana Venur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW3PR11MB46344BD1E46578F73F4694439E349@MW3PR11MB4634.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox