From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web08.273.1623430912103651452 for ; Fri, 11 Jun 2021 10:01:52 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=QYVcUDJK; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: sumana.venur@intel.com) IronPort-SDR: ZrIxFezB9GhkB6aX0vq788NoRbGeTSc94p/fuzP7i4LlqBr8pcyjP7/yA4DGGvuCzgu1oXEVJD 5JSdy//+5ZEA== X-IronPort-AV: E=McAfee;i="6200,9189,10012"; a="202537847" X-IronPort-AV: E=Sophos;i="5.83,265,1616482800"; d="scan'208";a="202537847" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2021 10:01:50 -0700 IronPort-SDR: TLF3wHwN+EZhQQPk2XZWP89nBQiaL3u0VaJwfZH1i9fpvDMKnHdl72OE/FHCLTSToodpBhTI6H MmoqrL+//IJg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,265,1616482800"; d="scan'208";a="414503565" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by fmsmga007.fm.intel.com with ESMTP; 11 Jun 2021 10:01:50 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Fri, 11 Jun 2021 10:01:50 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Fri, 11 Jun 2021 10:01:49 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Fri, 11 Jun 2021 10:01:49 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Fri, 11 Jun 2021 10:01:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CLHOiK3J7O3bfpeQTzaV0FXDGY74kmNjzSZ2988y9x84ykSdnhO4X9PejKh6PEA48jbaYDsAGYmDY5vh18+7afjSoVuW/kHl+oodqo9zXPPGbADvokIifsPyYhi0Ykoot2GKj+gBfQ9Qr9/rYSk7U2Zy3kR9n4pw/olddnZHry+jgEgPUNOzbf7KL6lkjYkruhCdTkw/GvGLde0/98nvPIa8JjkXqvMxcNtqEJNEtChAr8SPafn9Pa+zwivoCsQlyMs1JRTXsPolFWTVOp2JtdiJnRyH5SIy9CPon3GCUDp4XJ/3ryAWrGXHaYQoAR/Q8Kp7wQvvZgRGzJtrdLheIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uETD5QPRsyP8qNRH7BXJGpdZhPqTurIcXuxe+5mXWl0=; b=P86KpPgjS9sEds2MFkbknb7WsNhAhM2SpVIZafOQ+qqe9CBEn/FcZJ1FDXZ57RiJbuDaTPV8rYNeOnfH69GNfiPIfdyVqoj4qvkh9IyXWyw8ih7dYbRsyqc0/knWfyR7B6BSqENaiKTlWYhrJsH27SQsoYRgLKXQbT2ntNuCGwPF9mYCTDmPKQhpja3mdgbO+czmaPl5uC9l9f2ZJVzklHgkL7dc+YS2VVpB1CtsNhyH1Gy/Ei2QXNlyWSAeTYTzwgymaTqhxrx1Idt195Cx5Xkj0qJW/AFRkPQzCY3NbjJfTv62NcIL+mLBEZWoAJwphqBdDY0ecJVxdHbwizW6yA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uETD5QPRsyP8qNRH7BXJGpdZhPqTurIcXuxe+5mXWl0=; b=QYVcUDJKFj0s9ZZ04wNNdsxH6f4zN/jBGZ+llOVM4qMO4NZBXh8WLb0KKYnYSF959AqmZ6IQAZQKeE7aeG7TddWB9U85N97H64wFsSJHfJNFTnsuX5X+8WYMwieGPHO4qe5Zn0uCVOiZeK9iPnbCMoMMO1Ll4qTpa4jfMl6GPVA= Received: from MW3PR11MB4634.namprd11.prod.outlook.com (2603:10b6:303:54::16) by CO1PR11MB5139.namprd11.prod.outlook.com (2603:10b6:303:95::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Fri, 11 Jun 2021 17:01:49 +0000 Received: from MW3PR11MB4634.namprd11.prod.outlook.com ([fe80::6060:172e:1344:b268]) by MW3PR11MB4634.namprd11.prod.outlook.com ([fe80::6060:172e:1344:b268%6]) with mapi id 15.20.4219.022; Fri, 11 Jun 2021 17:01:48 +0000 From: "Sumana Venur" To: "Ni, Ray" , "Wu, Hao A" CC: "devel@edk2.groups.io" Subject: Re: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of the data read during oprom shadow Thread-Topic: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of the data read during oprom shadow Thread-Index: AQHXXuAsyu2suzTUHU2YK/c0j8VBv6sPCFUg Date: Fri, 11 Jun 2021 17:01:48 +0000 Message-ID: References: <20210611163744.19368-1-sumana.venur@intel.com> In-Reply-To: <20210611163744.19368-1-sumana.venur@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [134.134.136.200] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7d40f061-d5f0-4042-1d62-08d92cfa9a2d x-ms-traffictypediagnostic: CO1PR11MB5139: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5797; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: RKmjW91TY6lC4/IC9dl7Vt/g2lRdhkKdgcTtNzCgCzX2y+HMrNcn+Bw4kacs833ITtOWr8P5pEzju11jgAp72/pRjiIwcgCGFKywkREJrmFWqvS3QMUnl3poaDSTVkZ3l7I5qT+F1F/RsvQxMlJiqq+TdFgo97UBY6Oa3dCTGHNfrgszD7xWPKmnU7nGUPDWc4UZu5biOSyubA4nS6oy13iMSXd6Gv5FEl1wRwOfZVwuX3VbbjdVZraRuI7eucpZ+HV+U+I6xjxO2X8jO8Yln23I8rsurWd7qSsLuZ/bzDuooCnJR2yin3rRyOEvN727bPaxu7hYXayeoOZ4pA+LxXAkdHhxgJxG2LluP/cig3KCRYFJ6nPO0IzSy9bZjpd2AstN7ewKvF6ZXy/EYnoxkOvK3rTNa4YkuzRywC+1QN2yHssdGybALGcGVP+0i88gg4DqzxCrjWrehC2xWtb25XRmuK34cNyYFnOEVEfDsqYr2vrRBIfIjo/dXxseWjuJqpEtVtcBGhoySXd84ez9hCX6cyB5e5ldHUQXozQwwqMT2kjJ2bJCb2LR1Xh6wYcV22bqgR1W1B1H1MVaagKNfJee86O39Fhv/Xjat1WE/atTBBW8uAuLeYSraHm1uYlA4zOopm4Fz2eA4MvQlzs1IQ4Ov5E5y+aUpKl0ThG+mGQZTo//l5SFI2BipeNUHQagzO+VcSI8x9PeTgj1dzGfwxSOpMZvgL+q9Jn57c+eUPRgTeQmcS/bbX5pEah51q+O0vaBz/tVTR1iJtl40p89HPdlB18eBDymTq1oClxTfgrFNJ5y/PJzyWierI4edQQR x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4634.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(396003)(366004)(346002)(376002)(39860400002)(110136005)(316002)(66476007)(66556008)(38100700002)(8936002)(53546011)(71200400001)(66446008)(4326008)(26005)(8676002)(66946007)(33656002)(122000001)(64756008)(76116006)(966005)(86362001)(9686003)(186003)(55016002)(6506007)(83380400001)(7696005)(478600001)(52536014)(6636002)(2906002)(5660300002)(3903001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?oAvBxSz5AJov7SUbQRQFCsFJUXR2Y0ndF5VXSJ5QEjQLeZvGr2R0W4y7paLC?= =?us-ascii?Q?13rY7SB47K6gGOuScerbmrkqPjialiHw8Rs7ASEWMSRy2wq1uW2Q1ZuzxE71?= =?us-ascii?Q?ytQLzCJzBtfHazlbz2x7mQDU0gMkHBnyUhLPEow/o0KugQw/rXA2BM5B58Ge?= =?us-ascii?Q?EF1+kLsK+F0MIRGPdpW1A09LjpVYRPtdnbciM+v8IWBk7yCNCvsM7snPKlOm?= =?us-ascii?Q?niaF+IPuLCEiBj50HOcfsrX2GoZo+oB4/oCSRe54RROWv0qC32cR6tucqaSK?= =?us-ascii?Q?TPEq5uOCDVciiwGhUEQXohG0xo9hPjamPeOiwGaaePLuCbw39RJA4MyTQWAn?= =?us-ascii?Q?PWhDVx7DLxSA1SczubdiOocs36qaKDu466Lq8e8aSfiItFNRlMxmLF4BQs1T?= =?us-ascii?Q?fNKZ8EDbk8tmQL0q1D4IZTwRUpv/Y/fPz3kzHwO/7Opn8ENbRR0BdX6oeox6?= =?us-ascii?Q?QmqFjgu8f0knaOxu1+EgQ9UoXCnjwu+pNwwEW/V9Gu0eZmJ8w5+eQRTz7HhP?= =?us-ascii?Q?gW1NM3b4GdDlc4hAknBC5kPgUAyOrep7tiS1gaznSdWQuW4eAUkMrJi9Ekgc?= =?us-ascii?Q?4vVFNSLzgjp4J+mbe9ptE28V6WS9wOecM5EyO28dwme8XHkkyzMMgxFtpUb4?= =?us-ascii?Q?cE1cO59pDgHxtEwjSSzqwefOz3hVpgGuVVUpx/095WjCumeTb75xXNiHfr/c?= =?us-ascii?Q?Kxbpy1I2Wq+kcRX8q0Dk0CAZWHDp/SJzEDXic0Vol6N7K6ykNXMOvwET/B/g?= =?us-ascii?Q?PCM5Hssm0LZaVEG0a29x995LOQNW9q0iHC+xbTMwurdu1y9yMhu/7nC9OuaQ?= =?us-ascii?Q?lc++jWKM0bp/LdOx9digi9vnnQWZY0PQzhjjgQjBmF73GLPQpAbx2eNyjdV0?= =?us-ascii?Q?cWBIFoRXMIlD7zJEH+U0SOtbuEGIBrqut43bM6g4L2LfQfQKCyK3TlXoURF9?= =?us-ascii?Q?r8lloGSGsIvJQ2IQzwopO5zXN91sXvILSe3ewXDB56b4YC4RHBgK/EtkMVPb?= =?us-ascii?Q?ZIZzHt3/D9fxbYdWGv9rYDbkVv/r1/KHGVOo7rSiJd/4nOpADg+Iq0dU9wIX?= =?us-ascii?Q?cxtMm3v1YJkHj+N9Bc+hKKDjrZI1VmZedoqsaL/9wfiOyv548xRwSa4zOBlk?= =?us-ascii?Q?fnh22Vto31sACYDITv6tmfQNGlR4UymUXo2iWDKC042mIMA81lBkQfWhxzxd?= =?us-ascii?Q?8Wrpc/3b2zkbmhd5hGgjczbQu/S8TxbCe4+7hskN2QFbcB+ySbKJU4ZXuMiF?= =?us-ascii?Q?+EprlZT7i/647BYRrex4LpPtMDe+FdQKUpcJz4hU3UlfduYaMlhwv3WCtWJb?= =?us-ascii?Q?hhds6nBHaWqOJVaMB9B8m6s/?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4634.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d40f061-d5f0-4042-1d62-08d92cfa9a2d X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jun 2021 17:01:48.8903 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TWaMpH8oq09coG5XQaBFR9Af5g/KrUK+yL53YgpQgA4ivgK6AkbvfHCqEOaJZ1ZFoInCGAW3BHqfURuWl9CPeA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5139 Return-Path: sumana.venur@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hello Maintainers=20 This patch is for MdeModulePkg/Bus. Please review and help with merging to = master It was sent a few months ago, might have been reviewed already. But due to = CI failures and low importance it was lost. Gerrit link - https://git-amr-7.devtools.intel.com/gerrit/#/c/117842/ Thanks Sumana -----Original Message----- From: Venur, Sumana =20 Sent: Friday, June 11, 2021 9:38 AM To: devel@edk2.groups.io Cc: Venur, Sumana Subject: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of the = data read during oprom shadow REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2989 Long times spent on shadowing oprom from graphics card to system memory. We= are currently using 8 bit read cycles. This needs to be wider, at least 32bit reads to reduce the time for oprom s= hadow Signed-off-by: Sumana Venur --- MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c b/MdeModu= lePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c index c994ed5fe3..a981f93f43 100644 --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c @@ -521,9 +521,9 @@ LoadOpRomImage ( // PciDevice->PciRootBridgeIo->Mem.Read ( PciDevice->PciRootBridgeIo, - EfiPciWidthUint8, + EfiPciWidthUint32, RomBar, - (UINT32) RomImageSize, + (UINT32) RomImageSize/sizeof(UINT32)= , Image ); RomInMemory =3D Image; --=20 2.16.2.windows.1