* [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of the data read during oprom shadow
@ 2021-06-11 16:37 Sumana Venur
2021-06-11 17:01 ` Sumana Venur
0 siblings, 1 reply; 7+ messages in thread
From: Sumana Venur @ 2021-06-11 16:37 UTC (permalink / raw)
To: devel; +Cc: Sumana Venur
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2989
Long times spent on shadowing oprom from graphics card to system memory. We are currently using 8 bit read cycles.
This needs to be wider, at least 32bit reads to reduce the time for oprom shadow
Signed-off-by: Sumana Venur <sumana.venur@intel.com>
---
MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
index c994ed5fe3..a981f93f43 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
@@ -521,9 +521,9 @@ LoadOpRomImage (
//
PciDevice->PciRootBridgeIo->Mem.Read (
PciDevice->PciRootBridgeIo,
- EfiPciWidthUint8,
+ EfiPciWidthUint32,
RomBar,
- (UINT32) RomImageSize,
+ (UINT32) RomImageSize/sizeof(UINT32),
Image
);
RomInMemory = Image;
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of the data read during oprom shadow
2021-06-11 16:37 [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of the data read during oprom shadow Sumana Venur
@ 2021-06-11 17:01 ` Sumana Venur
2021-06-17 1:33 ` 回复: [edk2-devel] " gaoliming
0 siblings, 1 reply; 7+ messages in thread
From: Sumana Venur @ 2021-06-11 17:01 UTC (permalink / raw)
To: Ni, Ray, Wu, Hao A; +Cc: devel@edk2.groups.io
Hello Maintainers
This patch is for MdeModulePkg/Bus. Please review and help with merging to master
It was sent a few months ago, might have been reviewed already. But due to CI failures and low importance it was lost.
Gerrit link - https://git-amr-7.devtools.intel.com/gerrit/#/c/117842/
Thanks
Sumana
-----Original Message-----
From: Venur, Sumana <sumana.venur@intel.com>
Sent: Friday, June 11, 2021 9:38 AM
To: devel@edk2.groups.io
Cc: Venur, Sumana <sumana.venur@intel.com>
Subject: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of the data read during oprom shadow
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2989
Long times spent on shadowing oprom from graphics card to system memory. We are currently using 8 bit read cycles.
This needs to be wider, at least 32bit reads to reduce the time for oprom shadow
Signed-off-by: Sumana Venur <sumana.venur@intel.com>
---
MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
index c994ed5fe3..a981f93f43 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
@@ -521,9 +521,9 @@ LoadOpRomImage (
//
PciDevice->PciRootBridgeIo->Mem.Read (
PciDevice->PciRootBridgeIo,
- EfiPciWidthUint8,
+ EfiPciWidthUint32,
RomBar,
- (UINT32) RomImageSize,
+ (UINT32) RomImageSize/sizeof(UINT32),
Image
);
RomInMemory = Image;
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* 回复: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of the data read during oprom shadow
2021-06-11 17:01 ` Sumana Venur
@ 2021-06-17 1:33 ` gaoliming
2021-06-23 10:19 ` Laszlo Ersek
0 siblings, 1 reply; 7+ messages in thread
From: gaoliming @ 2021-06-17 1:33 UTC (permalink / raw)
To: devel, sumana.venur, 'Ni, Ray', 'Wu, Hao A'
Create PR https://github.com/tianocore/edk2/pull/1728 for it.
This patch has been reviewed by Ray Ni.
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Sumana
> Venur
> 发送时间: 2021年6月12日 1:02
> 收件人: Ni, Ray <ray.ni@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
> 抄送: devel@edk2.groups.io
> 主题: Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase
> the width of the data read during oprom shadow
>
> Hello Maintainers
>
> This patch is for MdeModulePkg/Bus. Please review and help with merging to
> master
> It was sent a few months ago, might have been reviewed already. But due to
> CI failures and low importance it was lost.
>
> Gerrit link - https://git-amr-7.devtools.intel.com/gerrit/#/c/117842/
>
> Thanks
> Sumana
>
> -----Original Message-----
> From: Venur, Sumana <sumana.venur@intel.com>
> Sent: Friday, June 11, 2021 9:38 AM
> To: devel@edk2.groups.io
> Cc: Venur, Sumana <sumana.venur@intel.com>
> Subject: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of
> the data read during oprom shadow
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2989
>
> Long times spent on shadowing oprom from graphics card to system memory.
> We are currently using 8 bit read cycles.
> This needs to be wider, at least 32bit reads to reduce the time for oprom
> shadow
>
> Signed-off-by: Sumana Venur <sumana.venur@intel.com>
> ---
> MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
> b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
> index c994ed5fe3..a981f93f43 100644
> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
> @@ -521,9 +521,9 @@ LoadOpRomImage (
> //
> PciDevice->PciRootBridgeIo->Mem.Read (
> PciDevice->PciRootBridgeIo,
> - EfiPciWidthUint8,
> + EfiPciWidthUint32,
> RomBar,
> - (UINT32) RomImageSize,
> + (UINT32)
> RomImageSize/sizeof(UINT32),
> Image
> );
> RomInMemory = Image;
> --
> 2.16.2.windows.1
>
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: 回复: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of the data read during oprom shadow
2021-06-17 1:33 ` 回复: [edk2-devel] " gaoliming
@ 2021-06-23 10:19 ` Laszlo Ersek
0 siblings, 0 replies; 7+ messages in thread
From: Laszlo Ersek @ 2021-06-23 10:19 UTC (permalink / raw)
To: devel, gaoliming, sumana.venur, 'Ni, Ray',
'Wu, Hao A'
On 06/17/21 03:33, gaoliming wrote:
> Create PR https://github.com/tianocore/edk2/pull/1728 for it.
>
> This patch has been reviewed by Ray Ni.
Yes, here:
https://edk2.groups.io/g/devel/message/70091
https://listman.redhat.com/archives/edk2-devel-archive/2021-January/msg00578.html
msgid
<CO1PR11MB493022CF646498C69E13B34A8CAC0@CO1PR11MB4930.namprd11.prod.outlook.com>
(FWIW, the repost should have included Ray's R-b.)
Thanks
Laszlo
>
> Thanks
> Liming
>> -----邮件原件-----
>> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Sumana
>> Venur
>> 发送时间: 2021年6月12日 1:02
>> 收件人: Ni, Ray <ray.ni@intel.com>; Wu, Hao A <hao.a.wu@intel.com>
>> 抄送: devel@edk2.groups.io
>> 主题: Re: [edk2-devel] [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase
>> the width of the data read during oprom shadow
>>
>> Hello Maintainers
>>
>> This patch is for MdeModulePkg/Bus. Please review and help with merging to
>> master
>> It was sent a few months ago, might have been reviewed already. But due to
>> CI failures and low importance it was lost.
>>
>> Gerrit link - https://git-amr-7.devtools.intel.com/gerrit/#/c/117842/
>>
>> Thanks
>> Sumana
>>
>> -----Original Message-----
>> From: Venur, Sumana <sumana.venur@intel.com>
>> Sent: Friday, June 11, 2021 9:38 AM
>> To: devel@edk2.groups.io
>> Cc: Venur, Sumana <sumana.venur@intel.com>
>> Subject: [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of
>> the data read during oprom shadow
>>
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2989
>>
>> Long times spent on shadowing oprom from graphics card to system memory.
>> We are currently using 8 bit read cycles.
>> This needs to be wider, at least 32bit reads to reduce the time for oprom
>> shadow
>>
>> Signed-off-by: Sumana Venur <sumana.venur@intel.com>
>> ---
>> MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
>> b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
>> index c994ed5fe3..a981f93f43 100644
>> --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
>> +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
>> @@ -521,9 +521,9 @@ LoadOpRomImage (
>> //
>> PciDevice->PciRootBridgeIo->Mem.Read (
>> PciDevice->PciRootBridgeIo,
>> - EfiPciWidthUint8,
>> + EfiPciWidthUint32,
>> RomBar,
>> - (UINT32) RomImageSize,
>> + (UINT32)
>> RomImageSize/sizeof(UINT32),
>> Image
>> );
>> RomInMemory = Image;
>> --
>> 2.16.2.windows.1
>>
>>
>>
>>
>>
>
>
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of the data read during oprom shadow
@ 2021-01-08 4:05 Sumana Venur
0 siblings, 0 replies; 7+ messages in thread
From: Sumana Venur @ 2021-01-08 4:05 UTC (permalink / raw)
To: devel; +Cc: Sumana Venur
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2989
Long times spent on shadowing oprom from graphics card to system memory. We are currently using 8 bit read cycles.
This needs to be wider, at least 32bit reads to reduce the time for oprom shadow
Signed-off-by: Sumana Venur <sumana.venur@intel.com>
---
MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
index c994ed5fe3..a981f93f43 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
@@ -521,9 +521,9 @@ LoadOpRomImage (
//
PciDevice->PciRootBridgeIo->Mem.Read (
PciDevice->PciRootBridgeIo,
- EfiPciWidthUint8,
+ EfiPciWidthUint32,
RomBar,
- (UINT32) RomImageSize,
+ (UINT32) RomImageSize/sizeof(UINT32),
Image
);
RomInMemory = Image;
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of the data read during oprom shadow
@ 2021-01-08 2:32 Sumana Venur
0 siblings, 0 replies; 7+ messages in thread
From: Sumana Venur @ 2021-01-08 2:32 UTC (permalink / raw)
To: devel; +Cc: Sumana Venur
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2989
Long times spent on shadowing oprom from graphics card to system memory. We are currently using 8 bit read cycles.
This needs to be wider, at least 32bit reads to reduce the time for oprom shadow
Signed-off-by: Sumana Venur <sumana.venur@intel.com>
---
MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
index c994ed5fe3..19dceb3f91 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
@@ -521,9 +521,9 @@ LoadOpRomImage (
//
PciDevice->PciRootBridgeIo->Mem.Read (
PciDevice->PciRootBridgeIo,
- EfiPciWidthUint8,
+ EfiPciWidthUint32,
RomBar,
- (UINT32) RomImageSize,
+ (UINT32) RomImageSize/4,
Image
);
RomInMemory = Image;
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of the data read during oprom shadow
@ 2021-01-07 6:29 Sumana Venur
0 siblings, 0 replies; 7+ messages in thread
From: Sumana Venur @ 2021-01-07 6:29 UTC (permalink / raw)
To: devel; +Cc: Sumana Venur
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2989
Long times spent on shadowing oprom from graphics card to system memory. We are currently using 8 bit read cycles.
This needs to be wider, at least 32bit (even 64bit) reads to reduce the time for oprom shadow
Signed-off-by: Sumana Venur <sumana.venur@intel.com>
---
MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
index c994ed5fe3..fe6c7db417 100644
--- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
+++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciOptionRomSupport.c
@@ -521,7 +521,7 @@ LoadOpRomImage (
//
PciDevice->PciRootBridgeIo->Mem.Read (
PciDevice->PciRootBridgeIo,
- EfiPciWidthUint8,
+ EfiPciWidthUint64,
RomBar,
(UINT32) RomImageSize,
Image
--
2.16.2.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-06-23 10:19 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-11 16:37 [PATCH] MdeModulePkg/Bus/Pci/PciBusDxe: Increase the width of the data read during oprom shadow Sumana Venur
2021-06-11 17:01 ` Sumana Venur
2021-06-17 1:33 ` 回复: [edk2-devel] " gaoliming
2021-06-23 10:19 ` Laszlo Ersek
-- strict thread matches above, loose matches on Subject: below --
2021-01-08 4:05 Sumana Venur
2021-01-08 2:32 Sumana Venur
2021-01-07 6:29 Sumana Venur
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox