From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web08.423.1635800717118178225 for ; Mon, 01 Nov 2021 14:05:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=EdAx2oUB; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: isaac.w.oram@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10155"; a="211171124" X-IronPort-AV: E=Sophos;i="5.87,200,1631602800"; d="scan'208";a="211171124" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Nov 2021 13:43:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,200,1631602800"; d="scan'208";a="467436647" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga002.jf.intel.com with ESMTP; 01 Nov 2021 13:43:18 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 1 Nov 2021 13:43:17 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Mon, 1 Nov 2021 13:43:17 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Mon, 1 Nov 2021 13:43:17 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.106) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Mon, 1 Nov 2021 13:43:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VCjOo41TdbrDBHlXI3vOlVO5Gf9+f6SGNrsxbtZWv8WTM4TA0zLLEkOhxlDih1OXPblYTBnN4zv5D3wVvjSsrZbNiKnZMkJNF3pOiwmczmfDg/d42wm7L62uAaNxQwjAivaGxbBMd3p/Ie35EIY6YVSz6Wc9evVmYMe6LsV9Cj3yStTPF2kJLPL27q9TvJSXYg5+Az9XVGCWLBcy9Cqoicd6t4+u2lAusPQ3MAT4nquW6VxSJ5PMBITqk/mR64lEnYMay+SAzF5SR+iZIz/YYQlZxDyUcp/04Gd5DhuaN+HGA4mnCnVumfYR3RVREYJvgrOVqQ05MCabi9vMrrNc4A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=h+bIkKAYWp8x+RpL4+a4FvRPhUM0eBQLqanbhRh694U=; b=NPCSWJ3nYlMpFRVF2rXGiAgxk/11Pb0RoAn5dzw0SosejKtqXCsJedIkdj4qscqeZeBAp0VwSoA16ECCjs5LkUvQhhkeolTeNYkAsOtqvtw4hXUl3gUHoOsj9ev8cNGKq9aYEdxvFRtPx7bLorz6haW14u8l/YKAPAu1KakIXnA0DMQr/2qeBdexTRMwY1JQJaDWn4hjHrG/Z8P1ESMv26x88L508AEHE68Rh5mIFLY3PVWJY8gnglNtpv+Qqu/BOM5Oo5I/GJJtxtWrggkH0+GYmi8AE6JoG01+luOxpWHHV+84SyLQO0r9KWkZ4X9fA3ug+QzJvcr/TvFw1/VvfA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h+bIkKAYWp8x+RpL4+a4FvRPhUM0eBQLqanbhRh694U=; b=EdAx2oUBZ94BFrOPZZhVMJ5XsEsYSHudisBQSpEUiRXi4XlQ7bxfTRiVn/kTD1KaMUIObaBhPalifeF+KFD06DybsARYP5rsEZsAuwZvyAIBlrgCaMzQ9SjASXo61TwDu+3vkulHiGrrZgDFzCE+2Bp+FuEWWJmkxzR2mKK3+Xo= Received: from MW3PR11MB4747.namprd11.prod.outlook.com (2603:10b6:303:2f::11) by MWHPR11MB1662.namprd11.prod.outlook.com (2603:10b6:301:e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4649.14; Mon, 1 Nov 2021 20:43:15 +0000 Received: from MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::7cc4:11e3:2f09:f658]) by MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::7cc4:11e3:2f09:f658%3]) with mapi id 15.20.4649.019; Mon, 1 Nov 2021 20:43:15 +0000 From: "Oram, Isaac W" To: "devel@edk2.groups.io" , "mikuback@linux.microsoft.com" CC: "Agyeman, Prince" , "Chiu, Chasel" , "Kethi Reddy, Deepika" , "Dong, Eric" , "Luo, Heng" , Jeremy Soller , "Esakkithevar, Kathappan" , Liming Gao , "Desimone, Nathaniel L" , "Chaganty, Rangasai V" , Benjamin Doron Subject: Re: [edk2-devel] [PATCH v6 00/52] Consolidate SpiFlashCommonLib instances Thread-Topic: [edk2-devel] [PATCH v6 00/52] Consolidate SpiFlashCommonLib instances Thread-Index: AQHXzDyqnxE0EnAG1UKu4ws+7F8WG6vvIL7w Date: Mon, 1 Nov 2021 20:43:14 +0000 Message-ID: References: <20211028204326.645-1-mikuback@linux.microsoft.com> In-Reply-To: <20211028204326.645-1-mikuback@linux.microsoft.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 66ad1824-c93f-4173-f398-08d99d783a56 x-ms-traffictypediagnostic: MWHPR11MB1662: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: X76sh90NEYUQwB/TqR61Kre0iJXspKu5WXi14Xf+p8PR1jvkO756ww5+ZIbAGZWg+S/GiWrzddllW+h3c+8R85z6myBhwm+ce/CkMtmk6fb2x2mbrsRSDvUxcC6ZZ6ct5PdgYHZJFvtsjHQAVs2BEpT5xO2wbCMU8VJbhscuMicw5O3rjI6J//p2D4QPuYiYiuW2f+uGGe3HGnSRDUs7vMjlYMJjZ2cJe164e0OA2HKNysg5GV1vJ6FoW5A7kdFmQHEP6LDZtyep19ZgfTsXA75imMjhpnXuc6iEfjkv8bM997+bB2qftNEPtgyFef5xLCo7DROjubOoTfnoXtisyYPkhqbSvSe35ajtjG1PZYih0Qg/o0VAZRd1oF74uB3TYRzQQVwiEWLwdzrcmwJoV4fW/H4nUEuBK+vY8fLydEMe2L/kiKNbKNGUOL/dqJOWncH+ioTgVfPd+uc4J3y8HTMVEyp7Ss4RaZRFgHFSCtok7WRkSYN4sIJPkp///Dwt52YqETyqGouKF4bY/F+7LLDO9Qw+WJRDW9wl5vw811l9zycrOu4mOV6+/ISenaIWPBM578twFlyxAlSzhz9bL5iK2wzxdAhG3X7h6VgSxyjrfj7lwwbuqlpGlsfJk716AvF3RJ6dvIKum2srmg5N3IdADZv3nwKxe70x8o2+fR3/GrQYkTsmbHgUk4S7s81+RcjWG5+j/291GsdkZ8TD8un00jhCKgy1XJ87Z/qQIxRXx6fUxpaBgjpdCGSBeDMK6v0EY7m3Mc5oOnyherENszFspjB/gcbuCTLvt8pxs8PhgiFXfKlmjfelFcJ0C1smVUrlIp89deTKfnWuYmBPXg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4747.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(122000001)(38070700005)(966005)(6506007)(5660300002)(53546011)(4326008)(26005)(30864003)(19627235002)(86362001)(38100700002)(186003)(76116006)(508600001)(55016002)(52536014)(71200400001)(83380400001)(2906002)(66946007)(9686003)(8936002)(66556008)(7696005)(316002)(33656002)(66446008)(64756008)(66476007)(54906003)(110136005)(8676002)(82960400001)(579004)(559001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xs3UEyU6S6fkTIi0Xx0vMBjkdZE4MnvpZ6pxdRCwWwk2AkzNBUwkNA2FHpAZ?= =?us-ascii?Q?SxESglyMCYcECVt+2MeIYz2i8p3DW2bx1gNQXCEPrufJeKFaKTPDGJ40eCN1?= =?us-ascii?Q?deJvyrkRO3thuaLvQEWoZGdcD5N1HQOFJW33hlMBo4UjeY7W1tgPUgb71vWB?= =?us-ascii?Q?xfrggsXGHrwrFsfQjpcUV5b++wqITdLHjeBio/f4tWy5oZYjXcNOt9WXwboc?= =?us-ascii?Q?iQeCHpcXIHs/JlCbAUcW2r9MOEop7r6PbQE07Z3USOG28qSCYhOWt6EoFuR+?= =?us-ascii?Q?gErAa554NrbLYc8VHMrRqfH61qZ+FXxzF/9n41YAVa9eJ0miaQ5oIEOPuqPi?= =?us-ascii?Q?0rL/gdqmLsJg54ck1DfiStUY2o/m5IdvIvbUPgPIsj+vVDn5hbfCGBzW2bat?= =?us-ascii?Q?8UTcjXw2DtZn3ErGYR0u36pwaRls2bNrTgLz3te7yfLzjrrftwErAP3e5b//?= =?us-ascii?Q?3+S1xsED+1klzCTDQBvNHmpWpK/1xJmtGF7arsQz/rUffWFDxv3lUht4l5to?= =?us-ascii?Q?XjEDMCUnzre3WF8rTsZ+GBxiLxukGWKKHNuWUlILusNdORNsO109cke5W7Cl?= =?us-ascii?Q?ScYHwwoItXtVchWrAGfdrBeQwkZWPP2a0wOZsdDspjBYIttQqWYNzfc5S+nm?= =?us-ascii?Q?vBOIgTsISlfLNGyovUGsEj/AdUD+VgNBBVdKrMIpKAo5qFaeC7wfEyslgws4?= =?us-ascii?Q?i9vEMWLc+HsIYT8RwPbRQ4g87L6Fdg1AocyKp8U9DrztywNglVSDx/OGWtXv?= =?us-ascii?Q?pG5g0uvAwdxR7JhA++fuQqiWC/ry4JmCvDLWTSZgdP4+9gyQ1i/xWy2V6RW8?= =?us-ascii?Q?Xh7YYqT/i5RjITixfnUp/MshvOk2vl0qe4iCSZ6xypOaH1FQPXO0+jjp2piz?= =?us-ascii?Q?aNvLRjQfV2o5S6MkajEgEs7Jehw5g4GWC2P79dFxiiRvuqSOf3TEBaV/TXcr?= =?us-ascii?Q?iuL53o64Oi6BH77I8onuRXy2vubmkXAYHLYdX3OchkwD7fpqcqNtry36wyTM?= =?us-ascii?Q?aNzZftBFesIZXaSbiDFVAxG+/7ErFQJ9xUDjTwgEOZuW85rjbLaKf7KYwPLa?= =?us-ascii?Q?m6smpygIWBwDXhbJ0fkpdyRy4I5KfmAKQBwx84us2iDd96ZB4nD/EZNlFRDI?= =?us-ascii?Q?z8EPs5WD1VS2Sgf+YRDWD/B39h/kdXee539g0dz98mr9syFcTnhR06pbLo9v?= =?us-ascii?Q?/RXmS1NpWvAqN+YVWShC1yhNIyd018spt+5X0ySYc6uHU/u/ppwvAILi/dWU?= =?us-ascii?Q?QaLMb8jUHwUO+r8wiEvIrhiW8flsTwJPZui0vfFUonc/5B+KF/9Ox7W+L546?= =?us-ascii?Q?FAHyuWVqipkvw4pMuPdJOiAg50Bry59yQjY1LSZGLiwcuJAkgwQxpL86vS44?= =?us-ascii?Q?kLxjUPpIBXPj9eicWGPXHbYLwZKxJDEthZkaYE1lGGe3M5KFV4/x4Z5LEt3k?= =?us-ascii?Q?1/Pqu9RKvsOtDrgcI0fVPnXpVcrYyFVOHHKyx/KrFDg9l7KcOslh9TrY4VAw?= =?us-ascii?Q?Y2y3za7iQW3uTe7cemSAxx8lrfvkNL8anisYrES14PqxbEFyDgmaODjKkF2s?= =?us-ascii?Q?akt0GTsjf/pzbSCzPfbSsF+5o9sOriDuJTQYH9ycM1GnFJQv2QmMf57ujrZo?= =?us-ascii?Q?t0cSI0atN6f9ih4Rlss8BDo=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4747.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 66ad1824-c93f-4173-f398-08d99d783a56 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2021 20:43:14.8406 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AAsw512EjnPU8T/9Cpc5BYi9cNyM+gV79FBSkA9WFZzBkAKYIbpcyJCo9ywZKXQubHRSRR5VA/6MREab9hFBVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1662 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Series Reviewed-by: Isaac Oram These PCD already exist: gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaBaseAddress|0xFF800000|UINT32|0= x10000001 gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize|0x00800000|UINT32|0x100000= 02 gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeBase|0xFFE60000|UINT32|0= x30000004 gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeSize|0x000A0000|UINT32|0= x30000005 gMinPlatformPkgTokenSpaceGuid.PcdFlashFvMicrocodeOffset|0x00660000|UINT32= |0x30000006 gMinPlatformPkgTokenSpaceGuid.PcdMicrocodeOffsetInFv|0x90|UINT32|0x300000= 07 As well as more duplication in UefiCpuPkg and other locations. I would lik= e us to use the MinPlatformPkg versions. I will talk to Sai to see about r= emoving the restriction on IntelSiliconPkg using those. Patch 10: mPlatformDefaultBaseAddress is initialized but not used. But I = already have the patches to clean that up, so I wouldn't incorporate that i= n this series. More an FYI for later changes. Regards, Isaac -----Original Message----- From: devel@edk2.groups.io On Behalf Of Michael Kuba= cki Sent: Thursday, October 28, 2021 1:43 PM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Chiu, Chasel ; Kethi Reddy, Deepika ; Dong, Eric= ; Luo, Heng ; Jeremy Soller ; Esakkithevar, Kathappan ; Liming Gao ; Desimone, Nathaniel L ; Chaganty, Rangasai V = ; Benjamin Doron Subject: [edk2-devel] [PATCH v6 00/52] Consolidate SpiFlashCommonLib instan= ces From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D3307 SpiFlashCommonLib is duplicated in multiple places across the MinPlatform d= esign in edk2-platforms. I'm planning to build some additional functionalit= y on top of SpiFlashCommonLib and, ideally, this duplication will be consol= idated into a single instance usable across all current library consumers. This patch series focuses on consolidating the various SpiFlashCommonLib in= stances as agreed upon in https://edk2.groups.io/g/devel/message/71701. Read the BZ for more general background around this series. I only have an UpXtreme board on hand so maintainers/reviewers of other boa= rd packages should test these changes on those boards. V6 changes: - Changed the name of the new SPI PPI and SPI Protocol to "PCH_SPI2_PPI" and "PCH_SPI2_PROTOCOL" to differentiate the interfaces from prior definitions. The previous PPI and Protocol interfaces are available in IntelSiliconPkg. - Corresponding PPI and Protocol GUIDs are updated. - Included changes for the "AspireVn7Dash572G" that was added after the V5 patch series was sent. - Rebased the patch series for changes that have happened since the V5 patch series to resolve merge conflicts. V5 changes: - Added build support for PurleyOpenBoardPkg and WhitleyOpenBoardPkg (added to edk2-platforms during the lifetime of this patch series). - Updated KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash to use the new SPI PPI interface that identifies SPI flash regions by GUID. - Added new Reviewed-by replies that came in to existing patches during v4. V4 changes: - Assigned new GUID values to the PCH SPI PPI and Protocols to differentiate from previous instances. This was done because the interface changed to identify SPI flash regions by GUID. V3 changes: - Added support to IntelSiliconPkg to identify flash regions by GUID as requested in v2 review feedback. V2 changes: - Rebased patch series on current edk2-platforms master (32183bdaa91) Note: Previous patch series only received a couple review comments after be= ing on the mailing list for over 2 months. Please be respectful of contribu= tors time and efforts and review in a timely manner. Cc: Agyeman Prince Cc: Chasel Chiu Cc: Deepika Kethi Reddy Cc: Eric Dong Cc: Heng Luo Cc: Jeremy Soller Cc: Kathappan Esakkithevar Cc: Liming Gao Cc: Nate DeSimone Cc: Rangasai V Chaganty Cc: Benjamin Doron Signed-off-by: Michael Kubacki Michael Kubacki (52): CometlakeOpenBoardPkg: Remove redundant IntelSiliconPkg.dec entry WhiskeylakeOpenBoardPkg: Remove redundant IntelSiliconPkg.dec entry CometlakeOpenBoardPkg/PeiPolicyUpdateLib: Add missing GUID to INF IntelSiliconPkg: Add BIOS area base address and size PCDs IntelSiliconPkg: Add microcode FV PCDs IntelSiliconPkg: Add PCH SPI PPI IntelSiliconPkg: Add PCH SPI Protocol IntelSiliconPkg: Add SpiFlashCommonLib IntelSiliconPkg: Add SmmSpiFlashCommonLib IntelSiliconPkg: Add MM SPI FVB services CometlakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs KabylakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs SimicsOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs TigerlakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs WhiskeylakeOpenBoardPkg: Use IntelSiliconPkg BIOS area and ucode PCDs CoffeelakeSiliconPkg: Use IntelSiliconPkg BIOS area and ucode PCDs KabylakeSiliconPkg: Use IntelSiliconPkg BIOS area and ucode PCDs SimicsIch10Pkg: Use IntelSiliconPkg BIOS area and ucode PCDs TigerlakeSiliconPkg: Use IntelSiliconPkg BIOS area and ucode PCDs CometlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib KabylakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib SimicsOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib TigerlakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib WhiskeylakeOpenBoardPkg: Update SpiFvbService & SpiFlashCommonLib PurleyOpenBoardPkg: Use IntelSiliconPkg SpiFvbServiceSmm WhitleyOpenBoardPkg: UseIntelSiliconPkg SpiFvbServiceSmm MinPlatformPkg: Remove SpiFvbService modules CoffeelakeSiliconPkg: Remove SmmSpiFlashCommonLib KabylakeSiliconPkg: Remove SmmSpiFlashCommonLib SimicsIch10Pkg: Remove SmmSpiFlashCommonLib TigerlakeOpenBoardPkg: Remove SmmSpiFlashCommonLib MinPlatformPkg: Remove SpiFlashCommonLibNull PurleyOpenBoardPkg: Add SpiFlashCommonLib.h KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Add IntelSiliconPkg.dec CoffeelakeSiliconPkg: Remove PCH SPI PPI and Protocol from package KabylakeSiliconPkg: Remove PCH SPI PPI and Protocol from package SimicsIch10Pkg: Remove PCH SPI SMM Protocol from package TigerlakeSiliconPkg: Remove PCH SPI PPI and Protocol from package IntelSiliconPkg: Add flash region GUIDs IntelSiliconPkg: Identify flash regions by GUID CoffeelakeSiliconPkg/BasePchSpiCommonLib: Identify flash regions by GUID CoffeelakeSiliconPkg: Update for SPI2 PPI and Protocol CometlakeOpenBoardPkg: Remove unnecessary gPchSpiPpiGuid reference KabylakeSiliconPkg: Identify flash regions by GUID KabylakeSiliconPkg: Update for SPI2 PPI and Protocol KabylakeOpenBoardPkg/PeiSerialPortLibSpiFlash: Update for new SPI PPI API KabylakeOpenBoardPkg/KabylakeRvp3: Add PeiSerialPortlibSpiFlash to build SimicsIch10Pkg/BasePchSpiCommonLib: Identify flash regions by GUID SimicsIch10Pkg/PchSpiSmm: Update for SPI2 Protocol TigerlakeSiliconPkg/BasePchSpiCommonLib: Identify flash regions by GUID TigerlakeSiliconPkg/SpiSmm: Update for SPI2 Protocol WhiskeylakeOpenBoardPkg: Update for SPI2 PPI Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash/PeiSe= rialPortLibSpiFlash.c = | 46 +-- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiSpiLib/PchSpi.c = = | 10 +- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/BasePchSpiCommonLib= /SpiCommon.c = | 192 +++++++++---- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiFla= shCommon.c = | 196 ------------- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiFla= shCommonSmmLib.c = | 54 ---- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Spi/Smm/PchSpi.c = = | 10 +- {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/FvbInfo.c = | 0 {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/SpiFvbServiceCommon.c = | 4 +- {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/SpiFvbServiceMm.c = | 8 +- {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/SpiFvbServiceStandaloneMm.c = | 0 {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/SpiFvbServiceTraditionalMm.c = | 0 Platform/Intel/TigerlakeOpenBoardPkg/Library/SmmSpiFlashCommonLib/SpiFlash= CommonSmmLib.c =3D> Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommon= Lib/SmmSpiFlashCommonLib.c | 16 +- {Platform/Intel/TigerlakeOpenBoardPkg =3D> Silicon/Intel/IntelSiliconPkg}/= Library/SmmSpiFlashCommonLib/SpiFlashCommon.c = | 33 ++- {Platform/Intel/MinPlatformPkg/Flash =3D> Silicon/Intel/IntelSiliconPkg}/L= ibrary/SpiFlashCommonLibNull/SpiFlashCommonLibNull.c = | 12 +- Silicon/Intel/KabylakeSiliconPkg/Hsti/Dxe/SecureMemoryMapConfiguration.c = = | 108 ++++++- Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.c = = | 10 +- Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiFlash= Common.c = | 196 ------------- Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiFlash= CommonSmmLib.c = | 54 ---- Silicon/Intel/KabylakeSiliconPkg/Pch/LibraryPrivate/BasePchSpiCommonLib/Sp= iCommon.c = | 188 +++++++++---- Silicon/Intel/KabylakeSiliconPkg/Pch/Spi/Smm/PchSpi.c = = | 8 +- Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonLib/SpiFlashCommon.c= = | 194 ------------- Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonLib/SpiFlashCommonSm= mLib.c = | 54 ---- Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/SpiCommon.= c = | 189 +++++++++---- Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.c = = | 8 +- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/LibraryPrivate/BaseSpiCommon= Lib/SpiCommon.c = | 224 +++++++++++---- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/Spi.c = = | 10 +- Platform/Intel/CometlakeOpenBoardPkg/BiosInfo/BiosInfo.inf = = | 4 +- Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/Include/Fdf/FlashMapInc= lude.fdf = | 4 +- Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc = = | 7 +- Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.fdf = = | 38 +-- Platform/Intel/CometlakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLib/Pei= PolicyUpdateLib.inf = | 3 +- Platform/Intel/CometlakeOpenBoardPkg/Policy/PolicyInitDxe/PolicyInitDxe.in= f = | 4 +- Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Include/Fdf/FlashMap= Include.fdf = | 4 +- Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg.dsc = = | 7 +- Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/OpenBoardPkg.fdf = = | 40 +-- Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/PeiSi= liconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf = | 4 +- Platform/Intel/KabylakeOpenBoardPkg/BiosInfo/BiosInfo.inf = = | 4 +- Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Include/Fdf/FlashMapInclude= .fdf = | 4 +- Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc = = | 7 +- Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.fdf = = | 40 +-- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Include/Fdf/FlashMapInclu= de.fdf = | 4 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc = = | 9 +- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.fdf = = | 40 +-- Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/PeiSilicon= PolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf = | 4 +- Platform/Intel/KabylakeOpenBoardPkg/Library/PeiSerialPortLibSpiFlash/PeiSe= rialPortLibSpiFlash.inf = | 4 +- Platform/Intel/MinPlatformPkg/Include/Library/SpiFlashCommonLib.h = = | 98 ------- Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec = = | 2 - Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc = = | 6 - Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/OpenBoardPkg.dsc = = | 2 +- Platform/Intel/PurleyOpenBoardPkg/BoardMtOlympus/OpenBoardPkg.fdf = = | 2 +- Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/OpenBoardPkg.dsc = = | 4 +- Platform/Intel/PurleyOpenBoardPkg/BoardTiogaPass/OpenBoardPkg.fdf = = | 5 +- Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc = = | 6 +- Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf = = | 2 +- Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf.inc = = | 8 +- Platform/Intel/TigerlakeOpenBoardPkg/BiosInfo/BiosInfo.inf = = | 8 +- Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/Include/Fdf/FlashMapInc= lude.fdf = | 4 +- Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc = = | 7 +- Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.fdf = = | 40 +-- Platform/Intel/WhiskeylakeOpenBoardPkg/BiosInfo/BiosInfo.inf = = | 4 +- Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/Library/PeiPolicyUpdateLib/P= eiPolicyUpdateLib.inf = | 3 +- Platform/Intel/WhiskeylakeOpenBoardPkg/Policy/PolicyInitDxe/PolicyInitDxe.= inf = | 4 +- Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/Fdf/FlashMapInclud= e.fdf = | 4 +- Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Library/BoardInitLib/PeiMu= ltiBoardInitPreMemLib.inf = | 2 +- Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc = = | 7 +- Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.fdf = = | 38 +-- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/Include/Fdf/FlashMa= pInclude.fdf = | 4 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc = = | 7 +- Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.fdf = = | 38 +-- {Silicon/Intel/SimicsIch10Pkg =3D> Platform/Intel/WhitleyOpenBoardPkg}/Inc= lude/Library/SpiFlashCommonLib.h = | 2 +- Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc = = | 2 +- Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.fdf = = | 5 +- Silicon/Intel/CoffeelakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPolic= yLib.inf = | 4 +- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Private/Library/PchSpiCommo= nLib.h = | 60 ++-- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/Protocol/Spi.h = = | 295 -------------------- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.inf = = | 3 +- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/Private/BasePchSpiCommonLib= /BasePchSpiCommonLib.inf = | 13 + Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SmmSpi= FlashCommonLib.inf = | 51 ---- Silicon/Intel/CoffeelakeSiliconPkg/Pch/Spi/Smm/PchSpiSmm.inf = = | 3 +- Silicon/Intel/CoffeelakeSiliconPkg/SiPkg.dec = = | 8 - {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/SpiFvbServiceCommon.h = | 0 {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/SpiFvbServiceMm.h = | 0 {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/SpiFvbServiceSmm.inf = | 6 +- {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}= /Flash/SpiFvbService/SpiFvbServiceStandaloneMm.inf = | 6 +- Silicon/Intel/IntelSiliconPkg/Include/Guid/FlashRegion.h = = | 45 +++ Silicon/Intel/{CoffeelakeSiliconPkg/Pch =3D> IntelSiliconPkg}/Include/Libr= ary/SpiFlashCommonLib.h = | 2 +- Silicon/Intel/{CoffeelakeSiliconPkg/Pch =3D> IntelSiliconPkg}/Include/Ppi/= Spi.h = | 4 +- Silicon/Intel/IntelSiliconPkg/Include/Ppi/Spi2.h = = | 31 ++ Silicon/Intel/{TigerlakeSiliconPkg =3D> IntelSiliconPkg}/Include/Protocol/= Spi.h = | 0 Silicon/Intel/{SimicsIch10Pkg/Include/Protocol/Spi.h =3D> IntelSiliconPkg/= Include/Protocol/Spi2.h} = | 106 ++++--- Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dec = = | 45 +++ Silicon/Intel/IntelSiliconPkg/IntelSiliconPkg.dsc = = | 17 ++ {Platform/Intel/TigerlakeOpenBoardPkg =3D> Silicon/Intel/IntelSiliconPkg}/= Library/SmmSpiFlashCommonLib/SmmSpiFlashCommonLib.inf = | 26 +- {Platform/Intel/MinPlatformPkg/Flash =3D> Silicon/Intel/IntelSiliconPkg}/L= ibrary/SpiFlashCommonLibNull/SpiFlashCommonLibNull.inf = | 3 +- Silicon/Intel/KabylakeSiliconPkg/Cpu/Library/PeiCpuPolicyLib/PeiCpuPolicyL= ib.inf = | 4 +- Silicon/Intel/KabylakeSiliconPkg/Hsti/Dxe/HstiSiliconDxe.h = = | 2 +- Silicon/Intel/KabylakeSiliconPkg/Hsti/Dxe/HstiSiliconDxe.inf = = | 12 +- Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Library/SpiFlashCommonLib.h = = | 98 ------- Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Ppi/Spi.h = = | 26 -- Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Protocol/Spi.h = = | 293 ------------------- Silicon/Intel/KabylakeSiliconPkg/Pch/IncludePrivate/Library/PchSpiCommonLi= b.h = | 68 ++--- Silicon/Intel/KabylakeSiliconPkg/Pch/Library/PeiSpiLib/PeiSpiLib.inf = = | 3 +- Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SmmSpiFl= ashCommonLib.inf = | 53 ---- Silicon/Intel/KabylakeSiliconPkg/Pch/LibraryPrivate/BasePchSpiCommonLib/Ba= sePchSpiCommonLib.inf = | 11 + Silicon/Intel/KabylakeSiliconPkg/Pch/Spi/Smm/PchSpi.h = = | 2 +- Silicon/Intel/KabylakeSiliconPkg/Pch/Spi/Smm/PchSpiSmm.inf = = | 3 +- Silicon/Intel/KabylakeSiliconPkg/SiPkg.dec = = | 13 +- Silicon/Intel/SimicsIch10Pkg/Ich10Pkg.dec = = | 11 - Silicon/Intel/SimicsIch10Pkg/IncludePrivate/Library/PchSpiCommonLib.h = = | 68 ++--- Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonLib/SmmSpiFlashCommo= nLib.inf = | 50 ---- Silicon/Intel/SimicsIch10Pkg/LibraryPrivate/BasePchSpiCommonLib/BasePchSpi= CommonLib.inf = | 16 +- Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpi.h = = | 2 +- Silicon/Intel/SimicsIch10Pkg/Spi/Smm/PchSpiSmm.inf = = | 3 +- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/IncludePrivate/Library/SpiCo= mmonLib.h = | 60 ++-- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/LibraryPrivate/BaseSpiCommon= Lib/BaseSpiCommonLib.inf = | 19 +- Silicon/Intel/TigerlakeSiliconPkg/IpBlock/Spi/Smm/SpiSmm.inf = = | 3 +- Silicon/Intel/TigerlakeSiliconPkg/Pch/PchInit/Dxe/PchInitDxeTgl.inf = = | 1 + Silicon/Intel/TigerlakeSiliconPkg/SiPkg.dec = = | 8 - 118 files changed, 1450 insertions(+), 2476 deletions(-) delete mode 1006= 44 Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFlashCommonLib/SpiF= lashCommon.c delete mode 100644 Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFl= ashCommonLib/SpiFlashCommonSmmLib.c rename {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/F= eature}/Flash/SpiFvbService/FvbInfo.c (100%) rename {Platform/Intel/MinPla= tformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/Sp= iFvbServiceCommon.c (96%) rename {Platform/Intel/MinPlatformPkg =3D> Silic= on/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServiceMm.c (94= %) rename {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPk= g/Feature}/Flash/SpiFvbService/SpiFvbServiceStandaloneMm.c (100%) rename {= Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}/F= lash/SpiFvbService/SpiFvbServiceTraditionalMm.c (100%) rename Platform/Int= el/TigerlakeOpenBoardPkg/Library/SmmSpiFlashCommonLib/SpiFlashCommonSmmLib.= c =3D> Silicon/Intel/IntelSiliconPkg/Library/SmmSpiFlashCommonLib/SmmSpiFla= shCommonLib.c (75%) rename {Platform/Intel/TigerlakeOpenBoardPkg =3D> Sili= con/Intel/IntelSiliconPkg}/Library/SmmSpiFlashCommonLib/SpiFlashCommon.c (8= 4%) rename {Platform/Intel/MinPlatformPkg/Flash =3D> Silicon/Intel/IntelSi= liconPkg}/Library/SpiFlashCommonLibNull/SpiFlashCommonLibNull.c (83%) dele= te mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlashComm= onLib/SpiFlashCommon.c delete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlas= hCommonLib/SpiFlashCommonSmmLib.c delete mode 100644 Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonL= ib/SpiFlashCommon.c delete mode 100644 Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonL= ib/SpiFlashCommonSmmLib.c delete mode 100644 Platform/Intel/MinPlatformPkg/Include/Library/SpiFlashC= ommonLib.h rename {Silicon/Intel/SimicsIch10Pkg =3D> Platform/Intel/WhitleyOpenBoardP= kg}/Include/Library/SpiFlashCommonLib.h (96%) delete mode 100644 Silicon/I= ntel/CoffeelakeSiliconPkg/Pch/Include/Protocol/Spi.h delete mode 100644 Silicon/Intel/CoffeelakeSiliconPkg/Pch/Library/SmmSpiFl= ashCommonLib/SmmSpiFlashCommonLib.inf rename {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/F= eature}/Flash/SpiFvbService/SpiFvbServiceCommon.h (100%) rename {Platform/= Intel/MinPlatformPkg =3D> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiF= vbService/SpiFvbServiceMm.h (100%) rename {Platform/Intel/MinPlatformPkg = =3D> Silicon/Intel/IntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServi= ceSmm.inf (88%) rename {Platform/Intel/MinPlatformPkg =3D> Silicon/Intel/I= ntelSiliconPkg/Feature}/Flash/SpiFvbService/SpiFvbServiceStandaloneMm.inf (= 88%) create mode 100644 Silicon/Intel/IntelSiliconPkg/Include/Guid/FlashRe= gion.h rename Silicon/Intel/{CoffeelakeSiliconPkg/Pch =3D> IntelSiliconPkg}/Inclu= de/Library/SpiFlashCommonLib.h (96%) rename Silicon/Intel/{CoffeelakeSilic= onPkg/Pch =3D> IntelSiliconPkg}/Include/Ppi/Spi.h (85%) create mode 100644= Silicon/Intel/IntelSiliconPkg/Include/Ppi/Spi2.h rename Silicon/Intel/{TigerlakeSiliconPkg =3D> IntelSiliconPkg}/Include/Pr= otocol/Spi.h (100%) rename Silicon/Intel/{SimicsIch10Pkg/Include/Protocol/= Spi.h =3D> IntelSiliconPkg/Include/Protocol/Spi2.h} (76%) rename {Platform= /Intel/TigerlakeOpenBoardPkg =3D> Silicon/Intel/IntelSiliconPkg}/Library/Sm= mSpiFlashCommonLib/SmmSpiFlashCommonLib.inf (65%) rename {Platform/Intel/M= inPlatformPkg/Flash =3D> Silicon/Intel/IntelSiliconPkg}/Library/SpiFlashCom= monLibNull/SpiFlashCommonLibNull.inf (91%) delete mode 100644 Silicon/Inte= l/KabylakeSiliconPkg/Pch/Include/Library/SpiFlashCommonLib.h delete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Ppi/Spi.h delete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Include/Protocol/S= pi.h delete mode 100644 Silicon/Intel/KabylakeSiliconPkg/Pch/Library/SmmSpiFlas= hCommonLib/SmmSpiFlashCommonLib.inf delete mode 100644 Silicon/Intel/SimicsIch10Pkg/Library/SmmSpiFlashCommonL= ib/SmmSpiFlashCommonLib.inf -- 2.28.0.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82819): https://edk2.groups.io/g/devel/message/82819 Mute This Topic: https://groups.io/mt/86662265/1492418 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [isaac.w.oram@intel.com] -=3D-=3D-=3D-=3D-=3D-=3D