From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web09.1520.1642123745315231122 for ; Thu, 13 Jan 2022 17:29:05 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=KD1MLQi4; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642123745; x=1673659745; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=x6rmu0eZ2Sv+uUFJjCToavKqaPgmF5vfMR3jPPPMhJY=; b=KD1MLQi4RtIulph4xOd1ZpPf0YoX2EVm9p234nLWqIJEwNsNsSw33ETh eFteRZbM2oCTtNUGtiG7Js1WJvDJX6TWcj3O1lYeALbxJN60vTriRqPFG ell5wGKcDhy4COrXt0pvY5IYeLQF5YH6rW/uon/I58MpqG9i7SxXj1h+I uhruye6aKE5r361RoVqrk9yGoyV6QHcho9UHkSVlKX4/SOu1cWidcehmw kiiCLDrpNHRERYyPUkywse9az2wekHvcNWV+cyxUiWJct3DExrmtTbWoL rC+xasuP9sS69a14uDM3NKaKksCfy8w9oLoACpE7utS4+hK/UktBtlIhJ g==; X-IronPort-AV: E=McAfee;i="6200,9189,10226"; a="244113985" X-IronPort-AV: E=Sophos;i="5.88,287,1635231600"; d="scan'208";a="244113985" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2022 17:29:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,287,1635231600"; d="scan'208";a="475576404" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga006.jf.intel.com with ESMTP; 13 Jan 2022 17:29:04 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Thu, 13 Jan 2022 17:29:03 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Thu, 13 Jan 2022 17:29:03 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.43) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 13 Jan 2022 17:29:03 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=X+PSzpAtL68/OA77rMEYq7dnwAAS9FSZNhrTAQ0idfpTeC1U+mezbb+ZtArBUkYH6qZpLt1yj+MdQk3Fhrc4UJPlKzUCPGcEFwYxYUv7OHi3PrLPosaFgExJRS4pNkHOFCKHUHqAw2Jecs4JDHSl82c1wq4nENo6/2MPGtnVUrQkQdBYzr4kIctn30QBQ5dI/Sh/YE8BEdXsdj1PZgmqvmP/G8pJytpYw2dU3I89wZJntY/Fsl55fZ81DNY8d8sgCB8Lg0qdU11272cC0gs865+fcd855CWPjxyBsv02he0OblhRb2QagjYq12trO7woOw2bTS+YaEit3GDPdE7eIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cRaMzELhxDYn1BkSIbSpJnsXfcS6lIOREGpNNprc71E=; b=Kz8WwgDm8BQfHw7apTocAe5C4p75GBW6GBx+H38ffYUOZKSlDIlhSaICgbXVy0aL7opUXDKWD4z0B2t6Y7WU9CcGd1oIOCTxJ6Jxe+e4SvZ0tCRdQXNLqFdbwHi59PqAFOgBqO6g/EoM2z5WIvwFMNHagJ04jZ1zTm2nSzSR8YmB3rTbh2FbCqMZWeQxoksfVuG+eVVXevRHhhuIhja1pED4qdKRNpH19QNlGpFY65Ok6glsbki8BAuioeRUyA9M+wHCbOusNzer6+TCayiQMQ4Uc2iXAwmcIkgChgDkQEzBDZFRTufEqGAk/G//2Kjv9Cu1JbR/s+CEh7l21+Au3Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW3PR11MB4747.namprd11.prod.outlook.com (2603:10b6:303:2f::11) by CY4PR1101MB2103.namprd11.prod.outlook.com (2603:10b6:910:17::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.11; Fri, 14 Jan 2022 01:29:02 +0000 Received: from MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::9c36:57de:e967:55a3]) by MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::9c36:57de:e967:55a3%6]) with mapi id 15.20.4888.011; Fri, 14 Jan 2022 01:29:02 +0000 From: "Oram, Isaac W" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chiu, Chasel" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/Include: Remove duplicate file Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/Include: Remove duplicate file Thread-Index: AQHYBnMg2QRDJ0abHU6EYA8V5NTy26xgRMiAgAF6btA= Date: Fri, 14 Jan 2022 01:29:02 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2ac56def-69de-4e14-8379-08d9d6fd3f4e x-ms-traffictypediagnostic: CY4PR1101MB2103:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: XTJEjVIrlAQVKTwSQR2JisvzFXWOggwNxITsHL/FlEn2BB3+iBfMEvS0/Iq+EZaQsrio1wYcG2naTNWyJn2ZVIG3vj4wfADb9HF6cZHwvdz7ULgfgFn7hYYWv6XLweTju95Nie6TphsDyt4KIZmQhv4buT6hJN+n4AIfuxoS7kiQwYv0ygY7lX4AHbYaZXmJo709hOpZNxTHTfM6nHalMhBE/KNFK4BFX/KbHGyE5IPRyAJ3OEvZ0G2tbRZr5QV2hlLphpJuPJ7diC5wK0xpQYwC5FxghmAIA9zU00Zb+Xrly19omQcc2PeFrph1+899qxbmJSALH44dscVy0h0UoKfJAhtauk6hAJWBztm8L8ZZUtDLfg86UoR/pYF+76pL8uCxPztk32OCk/ZHxNEEwKIt3r02muH86ZtuKwT3dU9gJGPVtCMxSl0MbHlpK7umMxhCGlN9pIjAx9ls6413kON9JqxRnxzrMBEnULlrpGUFJMbhHfuTZECyOFdmkbC2DFlJHLMCOoj4fn/R0UJmgbL0C5XT6VA8SVRk1KqTFcIiJz+5pwPlKvjwFyIZerVlgU0nxT6Zn5si9aois30ZzyVKqF0i4hqoYroSaPzMvP3wJRQnTFcTGw9Cd/hAxI9RHA9Bq6KyC2IjVWIWb3bC1lJNKk5k7YIPwV6LJ4K4YQxcANhqTd6LlT+oKZVRypv5JlJFQqlmTpG5cbwORmqBnA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4747.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(107886003)(33656002)(71200400001)(110136005)(508600001)(66446008)(122000001)(186003)(38100700002)(2906002)(66946007)(86362001)(9686003)(5660300002)(76116006)(52536014)(53546011)(26005)(82960400001)(7696005)(55016003)(8676002)(316002)(66476007)(8936002)(4326008)(38070700005)(83380400001)(66556008)(64756008)(6506007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?OvY+U7BcMy8/0hqob7qr6Wu46BwaxNDHYAr98r5jdV5mDsferGi9Sd71NbKt?= =?us-ascii?Q?ahfAJtXbc6StD3lKnvdt0/li/7NHqIehZBh6GhCgb57i6XiLsnGgu3TI3UYX?= =?us-ascii?Q?4c3ZSJ6cnYr23koaMnWslVNyEY69Fnhiy0AJ7uRajIDRBNBVxF7el0yokLOM?= =?us-ascii?Q?Dw155wP9MUqsGbfy3O2JCkyhMltbBj/J608nZ4N87O7d2Mi/YnsWpPXaqn48?= =?us-ascii?Q?SQhkV7VbT7Df4yjFhe09DwJNSrefTdURdrw94wB2XTdQRrgTacEUMBRlsoZt?= =?us-ascii?Q?bWtD0cR6m5AOrCPyL07BUF9bza93rkZdXM5E/QGxyIYM4d4/Tsc1oNhH5Nwu?= =?us-ascii?Q?oQwM392cV/j0TRgygNwSnOZ8ZzV+yTlkQx/Rg0DVlDqD/FRY1CKFTxWb9GcU?= =?us-ascii?Q?G6TRADHYK+X/LPH2kB8alV7uM00+Y4pENS0aP8aiVbwvmaLXFUYcf76aNhLD?= =?us-ascii?Q?EY0OGXw6SfvWTxNouyz72Xj94+MafqFWTx5Iisc+ZcR+6jNd2Tb9MU67utgM?= =?us-ascii?Q?JoD0uJ47V4K83OiodQXJpDiG8SkSUOYYG3flPEw5/i5Py0EhTZKP49qNvUj8?= =?us-ascii?Q?SXVeqFeu++AJTNzN/wZew7g9FCQ/u0ceYu0HlLA407j+KUGO2BboaHgSSJav?= =?us-ascii?Q?vQUYV353PcLTGaO+i3VUTjEaLMNvZ6Mu2s1gMnmp4Tywii5kdPh0CMX5J/Xq?= =?us-ascii?Q?cNWYSHvCWMnRcSPn7nqToYJSHB7o5Tkda6RL7TMdsUGOI5rnoluqcp25YKwU?= =?us-ascii?Q?j8SUQ6DolnP8dnVB3Y0mQiu1Zmgy4WXmjLdVi27G2D0y/DjjjXGdSpgJjqik?= =?us-ascii?Q?Wp34BFa8HKxcm3NGL6KQdyRoqZo2RP84/Ii7hMNIzjtnoJYCQUYNwCAi69uf?= =?us-ascii?Q?sUOmcm14OiX4peKn+xmuA9LeATu8NTYyZLdyAAOx4hAo61ho2jUkD90OWfOz?= =?us-ascii?Q?WJ0ddKXlrGF7w3MwimnvAdSvEQ5tM4Srpkj8VrfyN2qDnVSkgXzVKg51P6bS?= =?us-ascii?Q?eFja/PxybzyuqD2AdgWLXNyhRW9mcT0blnVgyw6MY5bPu+Py6EJjsnZmFJSl?= =?us-ascii?Q?e+2lHGDwsl4XpTWmL/cWhXYg3F1i23t5l5OT1p6HREl9VuMK+X7BfB5EQwQH?= =?us-ascii?Q?3AWMnjZ1veUBxhhFVb34ZCsXoW8l0SARgXGurbxieME7/l/4+0NdoTF5Zwmn?= =?us-ascii?Q?yFvWJKQ6x1L196bHl/6gWaA0PbFvlJb4hfE4tTBOymED8CV4yDG6hmUZyX8t?= =?us-ascii?Q?j5EJQjBpqnqRm0McyyNWkpaCZ+BgdvKWO9oinpY4WbUmGmn++1nmvviKbG92?= =?us-ascii?Q?nRBIyOtNCdOkbpoJjDLKWyR+BVwhOfntWKh23KoP716wdpzOtk9i+1n33iwf?= =?us-ascii?Q?QEHOJhcJyOAg53pfq1Su0CGy9STObiNHcUIjBCmLarAkahPajdhX8c1YLmC3?= =?us-ascii?Q?9kk1tqE9rciKB9xE9rZrnp2NOEm6r12TbilVVf2M5cetvES9OQEzVKNqTLNI?= =?us-ascii?Q?YIHOgLOSgUhgmhNQ6KKNM+xo+iaWcJ8TwiQhg/gCCt14KYLtxR4GAlfHm6Sx?= =?us-ascii?Q?7Nx0Eg6X4IRWx8fKfJtNvUs3EyiXM7fswrNrE4vRGml9hieyLszxb6H1O1uU?= =?us-ascii?Q?XVfWFO3PMuCLL+5Tpiah+RU=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4747.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2ac56def-69de-4e14-8379-08d9d6fd3f4e X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jan 2022 01:29:02.5877 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nsNhw3ghZEAOg/WIpfXEd85CH4J7KYc7vk9mbds/Y+l0i+M/sljkwmdBUZDxaBvUQzNU6l84+a9cLBtJj2Ri3A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2103 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed as 60bb320b9e..73d1067db3 -----Original Message----- From: Desimone, Nathaniel L =20 Sent: Wednesday, January 12, 2022 6:54 PM To: Oram, Isaac W ; devel@edk2.groups.io Cc: Chiu, Chasel Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg= /Include: Remove duplicate file Reviewed-by: Nate DeSimone > -----Original Message----- > From: Oram, Isaac W > Sent: Monday, January 10, 2022 2:41 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Desimone, Nathaniel L=20 > ; Chiu, Chasel > Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] > WhitleyOpenBoardPkg/Include: Remove duplicate file >=20 > Switch to using the IntelSiliconPkg version of the file as both were iden= tical. >=20 > Cc: Nate DeSimone > Cc: Chasel Chiu >=20 > Signed-off-by: Isaac Oram > --- >=20 > Platform/Intel/WhitleyOpenBoardPkg/Include/Library/SpiFlashCommonLib.h > | 98 -------------------- >=20 > Platform/Intel/WhitleyOpenBoardPkg/Library/SmmSpiFlashCommonLib/Sm > mSpiFlashCommonLib.inf | 1 + > 2 files changed, 1 insertion(+), 98 deletions(-) >=20 > diff --git > a/Platform/Intel/WhitleyOpenBoardPkg/Include/Library/SpiFlashCommonLi > b.h > b/Platform/Intel/WhitleyOpenBoardPkg/Include/Library/SpiFlashCommonLi > b.h > deleted file mode 100644 > index ef62ba238d..0000000000 > --- > a/Platform/Intel/WhitleyOpenBoardPkg/Include/Library/SpiFlashCommonLi > b.h > +++ /dev/null > @@ -1,98 +0,0 @@ > -/** @file > - The header file includes the common header files, defines > - internal structure and functions used by SpiFlashCommonLib. > - > - Copyright (c) 2019 Intel Corporation. All rights reserved.
> - SPDX-License-Identifier: BSD-2-Clause-Patent > - > -**/ > - > -#ifndef __SPI_FLASH_COMMON_LIB_H__ > -#define __SPI_FLASH_COMMON_LIB_H__ > - > -#include > -#include > -#include > -#include > -#include > -#include -#include=20 > -#include=20 > > - > -#define SECTOR_SIZE_4KB 0x1000 // Common 4kBytes sector size > -/** > - Enable block protection on the Serial Flash device. > - > - @retval EFI_SUCCESS Opertion is successful. > - @retval EFI_DEVICE_ERROR If there is any device errors. > - > -**/ > -EFI_STATUS > -EFIAPI > -SpiFlashLock ( > - VOID > - ); > - > -/** > - Read NumBytes bytes of data from the address specified by > - PAddress into Buffer. > - > - @param[in] Address The starting physical address of the rea= d. > - @param[in,out] NumBytes On input, the number of bytes to read. O= n > output, the number > - of bytes actually read. > - @param[out] Buffer The destination data buffer for the read= . > - > - @retval EFI_SUCCESS Opertion is successful. > - @retval EFI_DEVICE_ERROR If there is any device errors. > - > -**/ > -EFI_STATUS > -EFIAPI > -SpiFlashRead ( > - IN UINTN Address, > - IN OUT UINT32 *NumBytes, > - OUT UINT8 *Buffer > - ); > - > -/** > - Write NumBytes bytes of data from Buffer to the address specified=20 > by > - PAddresss. > - > - @param[in] Address The starting physical address of the w= rite. > - @param[in,out] NumBytes On input, the number of bytes to write= . On > output, > - the actual number of bytes written. > - @param[in] Buffer The source data buffer for the write. > - > - @retval EFI_SUCCESS Opertion is successful. > - @retval EFI_DEVICE_ERROR If there is any device errors. > - > -**/ > -EFI_STATUS > -EFIAPI > -SpiFlashWrite ( > - IN UINTN Address, > - IN OUT UINT32 *NumBytes, > - IN UINT8 *Buffer > - ); > - > -/** > - Erase the block starting at Address. > - > - @param[in] Address The starting physical address of the block= to be > erased. > - This library assume that caller garantee t= hat the PAddress > - is at the starting address of this block. > - @param[in] NumBytes On input, the number of bytes of the logic= al > block to be erased. > - On output, the actual number of bytes eras= ed. > - > - @retval EFI_SUCCESS. Opertion is successful. > - @retval EFI_DEVICE_ERROR If there is any device errors. > - > -**/ > -EFI_STATUS > -EFIAPI > -SpiFlashBlockErase ( > - IN UINTN Address, > - IN UINTN *NumBytes > - ); > - > -#endif > diff --git > a/Platform/Intel/WhitleyOpenBoardPkg/Library/SmmSpiFlashCommonLib/S > mmSpiFlashCommonLib.inf > b/Platform/Intel/WhitleyOpenBoardPkg/Library/SmmSpiFlashCommonLib/S > mmSpiFlashCommonLib.inf > index a5bcb5e2f2..b1e0896c7c 100644 > --- > a/Platform/Intel/WhitleyOpenBoardPkg/Library/SmmSpiFlashCommonLib/S > mmSpiFlashCommonLib.inf > +++ > b/Platform/Intel/WhitleyOpenBoardPkg/Library/SmmSpiFlashCommonLib/S > m > +++ mSpiFlashCommonLib.inf > @@ -33,6 +33,7 @@ >=20 > [Packages] > MdePkg/MdePkg.dec > + IntelSiliconPkg/IntelSiliconPkg.dec > WhitleySiliconPkg/WhitleySiliconPkg.dec > WhitleySiliconPkg/CpRcPkg.dec > WhitleyOpenBoardPkg/PlatformPkg.dec > -- > 2.27.0.windows.1