From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web08.2498.1634253496554523640 for ; Thu, 14 Oct 2021 16:18:16 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=Sy2owPGP; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: isaac.w.oram@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10137"; a="226583072" X-IronPort-AV: E=Sophos;i="5.85,374,1624345200"; d="scan'208";a="226583072" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2021 16:17:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,374,1624345200"; d="scan'208";a="481473015" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga007.jf.intel.com with ESMTP; 14 Oct 2021 16:17:42 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 14 Oct 2021 16:17:41 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 14 Oct 2021 16:17:41 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.103) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 14 Oct 2021 16:17:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RLWGmTMboDtugdzD0dWXQGRMirtgSnTAjKcSkq8KMJwIk4Eban6KA+XavUZEfo3mwqoLqa2kpTP8gVJ3Ijzw5MhKr4ITwvPc+x8eXluu07ayKk0qGkZgOXGVIbQgfWXtBBvXO0MfgO734MOl02T6afCROA4750px5pB6bog/IxP6e/l/qJVs1fi6svFpQ6EHrcVFwEpewNM0pXcfGtFmeEXQc1FNARPVmHgeyaT4jrvgsNUQ6yl+ntEZ9KCU8lW5Gz4wJhg+mcFXFB2iUyVUpSfZ7G1tgyQEaU5TbgqFSsnx7dn5fUqh+prjQ2mGLCSwPcf/98EILv9x6tjIlUECsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yuGb/NRDqIvZRAL43MoBr0B86kKcjqarx2+aexDkUa0=; b=L3qITy3uZvwYvucQc48MvKvEBmChhumn9s7xcWR42dKnKPgRa4nHKWHfVp4FtFXUAgmnYGBfhASGh0PhO0sBQ1BCPjqMVTEmlDWWcspzlfnZpYgnNXe6/klYBv3HPTznj9bTcHLISYAWo+0NpZoL15glDfY3td6q0h37OKJrGZjH5cVTmhE3Zzg6KLEYg1D1QKD2RwWHqTuLYumvbJc/YjsA1qlhTimElRcsP1c1t4i48KXbQvuMjl9fzVv9zvkGV6fQDfrsjTguF7tkxpW26w7aPTdcWAAB5KJPjfeWIeVy9+5GflW77xgfNhFn2YrG2IpuDP46LJ3djJ94dEu39A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yuGb/NRDqIvZRAL43MoBr0B86kKcjqarx2+aexDkUa0=; b=Sy2owPGPtDPg8xop0fh3x1oZnx+3u6uh/wjZHfrds3/LcDqqMiaa1YOV+7uKFakFsDRW49JWW/MV+28xqd305POF1chdI4tmjMsAlZdUg7GdqtarWO/Fwci0obn7+/m3fhXteBHxmLbs0n7bptCGVaVM2OTirYWo2Xt+dmNGjhE= Received: from MW3PR11MB4747.namprd11.prod.outlook.com (2603:10b6:303:2f::11) by MWHPR11MB1406.namprd11.prod.outlook.com (2603:10b6:300:23::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.24; Thu, 14 Oct 2021 23:17:39 +0000 Received: from MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::7cc4:11e3:2f09:f658]) by MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::7cc4:11e3:2f09:f658%3]) with mapi id 15.20.4587.030; Thu, 14 Oct 2021 23:17:40 +0000 From: "Oram, Isaac W" To: "KARPAGAVINAYAGAM, MANICKAVASAKAM" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Felixp@ami.com" , "DOPPALAPUDI, HARIKRISHNA" , "Jha, Manish" , "Bobroff, Zachary" , "KARPAGAVINAYAGAM, MANICKAVASAKAM" Subject: Re: [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro Thread-Topic: [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro Thread-Index: AQHXwUsMCqCDcWhKXkiGXWyyBQH7RavTIBNg Date: Thu, 14 Oct 2021 23:17:39 +0000 Message-ID: References: <20211014222952.1651-1-manickavasakamk@ami.com> In-Reply-To: <20211014222952.1651-1-manickavasakamk@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action authentication-results: ami.com; dkim=none (message not signed) header.d=none;ami.com; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7de27408-8fdd-4ef4-af2d-08d98f68d156 x-ms-traffictypediagnostic: MWHPR11MB1406: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: Dn1t+sls7N4yM4E/Ts643RNO1OMzk1DWAisswU2OrtflQidzfdtuViyAG2NBWtPD5q4ptVHY98fD514QhUaXWFO5tvWbw6Ur+bbgDBjkTL0Qlp6eilrLepqpgHKvCYYkhnNxO7pveN1HpTUzmvbdZEVYpgEKAOJQqhN8bUGOjFkWZA9K1X81GM4ZxsZ4pBuJ9clQDxhX7tjEUr8h6n3abctVRwyHdwQ7Kv9yFKV8wDBJaF02a6P29ER+7Sg7DH4ERANc+fNpHs1B7lX2CZaSHCa+YLrSxrYQDkbCAp999nxtFudbWNcjOIdeTEkZJjRmv1ydZGNqm0oElH3FzgseRaa1KjnJyMp8VqdnZsODyjDlJuQLWSjTciBe8MFhuCGhTr/n3HwTOrjl9aDGKI5X4zpcaiGMHQfAp8u8xxCtqZ3T8yT7bNtMtggRmf3JTnirl2xKT3Nyq8KJoLkDSpK5vIwEDT8cJHzoW8bRM/O820nwof91TgdFG51Cu19VrF+E9z1xaccGCs2UIzUuUl4lAYWLqq7lqlL0TbOH8OJs1vRsFl3RKGQJKSM8rZ1GAFe5SIZZDrDYwqN0uxh20JA4GUjjoE2swGWyCRTkKv3+DwZyheq9W+c25rrTM+4nGOQrdJm7j8x5U4I4kAa+WUWorj3wlhvRMMn+xD13LsqsAgD3PmVxhCRX1hdhYXSu1L7b3e4w1NGWDUmLsry36FOAQQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4747.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(7696005)(66446008)(55016002)(71200400001)(186003)(53546011)(33656002)(2906002)(508600001)(40140700001)(316002)(64756008)(66946007)(6506007)(66476007)(82960400001)(9686003)(66556008)(26005)(5660300002)(8936002)(38100700002)(38070700005)(76116006)(4326008)(110136005)(8676002)(83380400001)(86362001)(122000001)(52536014)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?j5qL+JeLjhIQkt5TVx8zU9EZAUkmdAYBrl7ZND2/kM0tH3G/HRieBnT6Er1E?= =?us-ascii?Q?Ra4k8kntrTraXN6CcmFAHnuH0Uynvyru4WC5u95ovdqCiBZapBZv8l6NfJoj?= =?us-ascii?Q?lv0+ZZnXR/AhVG18NvpIlZB9XDN7tx0QXGn9s8YS5GKnMQVTt4bBAC8j4k5H?= =?us-ascii?Q?G8xvaCVmhLv45H0K+8ru4uFjzSqTOp7ikNuwtSlQZzOiOInnnLd96imAAPVO?= =?us-ascii?Q?XOOG5qRjtIWxHmOencn+Dy//FB83UnYVNrIH4M7hJkMCJjvHQ8m2rBOa1KPh?= =?us-ascii?Q?SYSwgVnuyTxXa+i7oEKuMadzdDoUXU5sFveCJliQGTbTO1EJN/TBf/oVeIwL?= =?us-ascii?Q?GC84QGrLgKZVgkHyFXXsnmmVykZFMyw5n4se6OquYIqtqUJnjSGS/qAmFiQI?= =?us-ascii?Q?2gD0pdVznA06BAEeGOrPSed0KvwnSbiSoZW4S5YFU5D0VCKJ8QJFFGUnYGy7?= =?us-ascii?Q?5/VSO5OciHGMfIGXyN+c9k2B08D5bXCx2WdULzKgPTDPtlR+kKLg4glmSmoV?= =?us-ascii?Q?t1vNBhW/aGn3FM8ETc+MgBsB27tcet1A2ncDujVRiNbBwsPYNPWKNv8XVP5v?= =?us-ascii?Q?qZc/GYNkK9pwiGuzNEP9l4pGziaivXZnywZg8VPzkhOOdPGsYfwTZusuztym?= =?us-ascii?Q?Jqzt/xBmz06qeOVU9/54mYmyBGxjiJrDROgBPta5qZjRQ06iyFkiLSge2kDW?= =?us-ascii?Q?ku+9K7viih5JZSsZ6Q7qBORT7k3rbfRzdenV0SkxV27XokegVqLHKBww5r5T?= =?us-ascii?Q?5ttPffH/LdtyH4zg/l2b91VsGW8hbpO91SCTiO9mK28y5bo8ZtoLG4L8H84u?= =?us-ascii?Q?MK/Gc4QOcVeB2M6L0p5cU2ozjGD2GIEVFo9yQnutyvzCw3CsUnU10ltvIWN/?= =?us-ascii?Q?LFQ5BqL8RIAOwDs8cEtm3A8SF+tyhEFQruR49HkMk5RX9JAt9mWKyGn+bvtO?= =?us-ascii?Q?5lTYNvtrn9wFTB40MTTd+1z5qM/jNay/BgadFkUxdAyZHTHWvk8UmUWkNg2r?= =?us-ascii?Q?U2tWK85KvHVt8LoYq2lvZeO7Z5pYnELLtyoB/oOhFIgRTvPy2h17YyJSEori?= =?us-ascii?Q?EC4rBFGG111589b46Epw30gTAUOHn9xbATqh3z4VWK0hvWAswGXXcSOqyq9C?= =?us-ascii?Q?d1VSVrJtAq0oH1xrMsNSEyWtqedOPjjXq1Jj5IBRoi9B9+53A3a98kDoZRy/?= =?us-ascii?Q?VYy0N3kzCewV2KF0QDBPGmw8GW2zX0T4Wq92lQ1HI3/uDQASHSzpaoVCKGZV?= =?us-ascii?Q?okNeCE0+tCAHlsNKg70y8Jw9cNOj4s14kLPdaw60fEy2+OKHxmSwyqfXuteZ?= =?us-ascii?Q?CQqtZT1dUgGcnURhJYTfjCQ4?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4747.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7de27408-8fdd-4ef4-af2d-08d98f68d156 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Oct 2021 23:17:39.9652 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iyg02+lqHLdVuq4uxyS/IXU3LEoxp1cJN0IuiV69WiOOxvotSSumWq7n8gShOTXmY9la94l9aBSnHEQvtqzkRQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1406 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Isaac Oram -----Original Message----- From: manickavasakam karpagavinayagam =20 Sent: Thursday, October 14, 2021 3:30 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Felixp@ami.com; DOPPALAPUDI, HARIKRISHNA ; Jha, Manish ; Bobroff, Zachary ; KARPAGAVINAYAGAM, MANICKAVASAKAM Subject: [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot = issue & using proper ASSERT macro Fix to resolve the OS boot issue when booting on WilsonCitySMT board. ASSERT_EFI_ERROR(StatusParameter) needs to be passed with Error Status code= and not with TRUE or FALSE. Replaced ASSERT_EFI_ERROR with ASSERT. Signed-off-by: Manickavasakam Karpagavinayagam --- Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c | 12 += ++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInit= Dxe.c b/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c index d8274fa7ad..212103f483 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c +++ b/Platform/Intel/WhitleyOpenBoardPkg/Uba/BoardInit/Dxe/BoardInitDxe.c @@ -68,6 +68,16 @@ BoardInitDxeDriverEntry ( ASSERT_EFI_ERROR (Status); break; =20 + case TypeWilsonCitySMT: + Status =3D gBS->InstallProtocolInterface( + &Handle, + &gEfiPlatformTypeWilsonCitySMTProtocolGuid, + EFI_NATIVE_INTERFACE, + NULL + ); + ASSERT_EFI_ERROR(Status); + break; + case TypeCooperCityRP: Status =3D gBS->InstallProtocolInterface ( &Handle, @@ -80,7 +90,7 @@ BoardInitDxeDriverEntry ( =20 default: // CAN'T GO TO HERE. - ASSERT_EFI_ERROR (FALSE); + ASSERT (FALSE); } =20 return Status; --=20 2.25.0.windows.1 Please consider the environment before printing this email. The information contained in this message may be confidential and proprieta= ry to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephon= e at 770-246-8600, and then delete or destroy all copies of the transmissio= n.