* [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/PlatformHooksLib: Fix eSPI serial debug
@ 2021-09-22 21:34 Oram, Isaac W
2021-10-15 0:56 ` Nate DeSimone
0 siblings, 1 reply; 3+ messages in thread
From: Oram, Isaac W @ 2021-09-22 21:34 UTC (permalink / raw)
To: devel; +Cc: Chasel Chiu, Nate DeSimone
Fix issue with missing debug messages on ESPI_ENABLE configuration.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
---
Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/PlatformHooks.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/PlatformHooks.c b/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/PlatformHooks.c
index fa695358bf..8a93f41678 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/PlatformHooks.c
+++ b/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/PlatformHooks.c
@@ -116,6 +116,13 @@ IsAspeedPresent (
IoWrite8 (ASPEED2500_SIO_INDEX_PORT, REG_LOGICAL_DEVICE);
IoWrite8 (ASPEED2500_SIO_DATA_PORT, ASPEED2500_SIO_UART1);
if (IoRead8 (ASPEED2500_SIO_DATA_PORT) == ASPEED2500_SIO_UART1) {
+ //
+ // In ESPI mode, assume this SIO logic device always present.
+ //
+#ifdef ESPI_ENABLE
+ DeviceID = 0;
+ PresenceStatus = TRUE;
+#else
//
//right now, maybe it is ASPEED. to detect the device ID.
//
@@ -143,6 +150,7 @@ IsAspeedPresent (
if ((DeviceID & 0xff0000ff) == 0x04000003) {
PresenceStatus = TRUE;
}
+#endif
}
IoWrite8 (ASPEED2500_SIO_INDEX_PORT, ASPEED2500_SIO_LOCK);
return PresenceStatus;
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/PlatformHooksLib: Fix eSPI serial debug
2021-09-22 21:34 Oram, Isaac W
@ 2021-10-15 0:56 ` Nate DeSimone
0 siblings, 0 replies; 3+ messages in thread
From: Nate DeSimone @ 2021-10-15 0:56 UTC (permalink / raw)
To: Oram, Isaac W, devel@edk2.groups.io; +Cc: Chiu, Chasel
Reviewed-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> -----Original Message-----
> From: Oram, Isaac W <isaac.w.oram@intel.com>
> Sent: Wednesday, September 22, 2021 2:35 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> <nathaniel.l.desimone@intel.com>
> Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1]
> WhitleyOpenBoardPkg/PlatformHooksLib: Fix eSPI serial debug
>
> Fix issue with missing debug messages on ESPI_ENABLE configuration.
>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
> ---
>
> Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/PlatformHo
> oks.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git
> a/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/Platform
> Hooks.c
> b/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/Platform
> Hooks.c
> index fa695358bf..8a93f41678 100644
> ---
> a/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/Platform
> Hooks.c
> +++
> b/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/Platform
> Hooks.c
> @@ -116,6 +116,13 @@ IsAspeedPresent (
> IoWrite8 (ASPEED2500_SIO_INDEX_PORT, REG_LOGICAL_DEVICE);
> IoWrite8 (ASPEED2500_SIO_DATA_PORT, ASPEED2500_SIO_UART1);
> if (IoRead8 (ASPEED2500_SIO_DATA_PORT) == ASPEED2500_SIO_UART1) {
> + //
> + // In ESPI mode, assume this SIO logic device always present.
> + //
> +#ifdef ESPI_ENABLE
> + DeviceID = 0;
> + PresenceStatus = TRUE;
> +#else
> //
> //right now, maybe it is ASPEED. to detect the device ID.
> //
> @@ -143,6 +150,7 @@ IsAspeedPresent (
> if ((DeviceID & 0xff0000ff) == 0x04000003) {
> PresenceStatus = TRUE;
> }
> +#endif
> }
> IoWrite8 (ASPEED2500_SIO_INDEX_PORT, ASPEED2500_SIO_LOCK);
> return PresenceStatus;
> --
> 2.27.0.windows.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/PlatformHooksLib: Fix eSPI serial debug
[not found] <16A7427D66FD8B66.15876@groups.io>
@ 2021-10-15 1:13 ` Oram, Isaac W
0 siblings, 0 replies; 3+ messages in thread
From: Oram, Isaac W @ 2021-10-15 1:13 UTC (permalink / raw)
To: devel@edk2.groups.io, Oram, Isaac W; +Cc: Chiu, Chasel, Desimone, Nathaniel L
Pushed as 8194edc4af71799f163fe9735d0059dd90079ecc
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Oram, Isaac W
Sent: Wednesday, September 22, 2021 2:35 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/PlatformHooksLib: Fix eSPI serial debug
Fix issue with missing debug messages on ESPI_ENABLE configuration.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
---
Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/PlatformHooks.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/PlatformHooks.c b/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/PlatformHooks.c
index fa695358bf..8a93f41678 100644
--- a/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/PlatformHooks.c
+++ b/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/PlatformHooks.c
@@ -116,6 +116,13 @@ IsAspeedPresent (
IoWrite8 (ASPEED2500_SIO_INDEX_PORT, REG_LOGICAL_DEVICE);
IoWrite8 (ASPEED2500_SIO_DATA_PORT, ASPEED2500_SIO_UART1);
if (IoRead8 (ASPEED2500_SIO_DATA_PORT) == ASPEED2500_SIO_UART1) {
+ //
+ // In ESPI mode, assume this SIO logic device always present.
+ //
+#ifdef ESPI_ENABLE
+ DeviceID = 0;
+ PresenceStatus = TRUE;
+#else
//
//right now, maybe it is ASPEED. to detect the device ID.
//
@@ -143,6 +150,7 @@ IsAspeedPresent (
if ((DeviceID & 0xff0000ff) == 0x04000003) {
PresenceStatus = TRUE;
}
+#endif
}
IoWrite8 (ASPEED2500_SIO_INDEX_PORT, ASPEED2500_SIO_LOCK);
return PresenceStatus;
--
2.27.0.windows.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-15 1:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <16A7427D66FD8B66.15876@groups.io>
2021-10-15 1:13 ` [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/PlatformHooksLib: Fix eSPI serial debug Oram, Isaac W
2021-09-22 21:34 Oram, Isaac W
2021-10-15 0:56 ` Nate DeSimone
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox