From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.3503.1634260398305955394 for ; Thu, 14 Oct 2021 18:13:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=CsLoAEu3; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: isaac.w.oram@intel.com) X-IronPort-AV: E=McAfee;i="6200,9189,10137"; a="314022749" X-IronPort-AV: E=Sophos;i="5.85,374,1624345200"; d="scan'208";a="314022749" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Oct 2021 18:13:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,374,1624345200"; d="scan'208";a="564120427" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by FMSMGA003.fm.intel.com with ESMTP; 14 Oct 2021 18:13:13 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 14 Oct 2021 18:13:12 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 14 Oct 2021 18:13:12 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 14 Oct 2021 18:13:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=coZef4qICsWgNIiohQ/N818VDEXAgS6Ra3Fh77uHo+/Sw7gMqIrKfEVwQaO1Zy/UTuvPqiCpBkhKCd0Bf7e0iee7+7GsKp0MDMujwIGmTKRkuPnX8nFTsNlZRjARj9uziWJKha0868GRMWdIVcfZl1KwcGJU/NOmtEHafQ3Fvmf/UwDyvOuJ1H1aumRjuk0HYPQIPT5p1QSlpkdXxXflnTqN4kgh8BY+hZH8Q9HKx36+Gxv4YH2eARBpQub6JPm5IHCH6MnReEeUNpUObQyC9Z3cmnYOCxJO1hNDdXaDHCmkjicWUAhrndBYRxHy6+YVYfCGsSjQk3xYUZEjQxyNxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yR0ONZq6Xamk8MAEU8XB4Up2VSmUsTUCn87Lxn1mgEc=; b=AouMktAdogChnid0KuiWsxRQKzhBZYWTZNDDWQuZEBwndedDrZ8LP0GiB/wgd8R0QTgdOv6XySdUGa2DAhXvs0lmY23J5M4Fkq3jgvQ1dzM1+RhpfhtHwYX30srCeilJNYVmmoIFFNFOI8kwhF55XhJ5PFJnSQRdOK97m3dVhoJm1ufW6nCriVFUqXf0NgnvdpIWR6VeiAascKdIPVyH5zAw+FWKWTy3breJlmkA0fQXJmXumbGOp5594flnfX/RWzv2AiK2ievJI0bs7RPFKsL+EVqfOHgd2UOmvxeJ6wSvV020M/Forh7SdHSdGngPswmlKf/wfdERlu1T27C7Ig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yR0ONZq6Xamk8MAEU8XB4Up2VSmUsTUCn87Lxn1mgEc=; b=CsLoAEu3atsB9XJ/3mbAAjtDwTp+NOBgjhvhp3VFUOn15PKiG99l1vQKYXkW5dthKNk8eKCV7+z5xhzzx0A692Q8t1gtFnPHu/zcK1kSZhf3Gf5Kv2LTf5/ssLM3ZBLwPh+7Useo58XyX6aS3YR5kVfftvg3cVpYxjJOzi+z2TE= Received: from MW3PR11MB4747.namprd11.prod.outlook.com (2603:10b6:303:2f::11) by MWHPR11MB1517.namprd11.prod.outlook.com (2603:10b6:301:e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.22; Fri, 15 Oct 2021 01:13:11 +0000 Received: from MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::7cc4:11e3:2f09:f658]) by MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::7cc4:11e3:2f09:f658%3]) with mapi id 15.20.4587.030; Fri, 15 Oct 2021 01:13:11 +0000 From: "Oram, Isaac W" To: "devel@edk2.groups.io" , "Oram, Isaac W" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/PlatformHooksLib: Fix eSPI serial debug Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/PlatformHooksLib: Fix eSPI serial debug Thread-Index: AQHXr/m1mTIVbBTXhEGK6kg/VoF3QavTY2eg Date: Fri, 15 Oct 2021 01:13:11 +0000 Message-ID: References: <16A7427D66FD8B66.15876@groups.io> In-Reply-To: <16A7427D66FD8B66.15876@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4488201a-7401-43d9-a80d-08d98f78f4e7 x-ms-traffictypediagnostic: MWHPR11MB1517: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2449; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FeXsiddabowE6RazjyboR1INX8OLDDyhX3VHKyhytFVxYuoyBEpkwIYYrIuQrm0bwCT4+DIDsMI0YQJNgPUOOx0BnqBRRs29CNTOFGKbykFZzusMO7NAbgOjs0jfl5vvKTbrWPohkS/SF2plNC9iPryW3VSIwQVKDWlzq+v/o4QhQxz9+0QmXpj9wsH2k5xy6auKLELgcDrLntVjfszwHN9Ts5MMBd2RRBuk05CLBEJcJEo+Ksn/Hvtmh9Wkf+ioC0IHHsthu+Jp+sND0ITil3go7YVd950nEtSdgfaPlMVffKQHdpSXG3u/JTZUheQ8ye2vKs41bHu6JgKAFyv9wHhDlr7Ff4IhYsa/r5XWhTvWFG0oZEcXciAyPu7VJ8KjVMBSvF6QegcIgyoxARjAZ6Kimzkh1I9EjNvBLhD2y4ipN8bQXYRbB7U28Fa9dMYBm8cxOqV0bFE8tJBvzbWopPWrXGW42HBWSWZrGZM5Ftg8Zx6Nm4axb1Dh7P8w2Y8LSns0Nge3IZa8Fe1uokkHpUwRez53RtXNW5uodcR+70pO/LvY+K0QLfpSHkSwVh5KaXUtJvTI8xxTFwgo9jfvN8ta+2S7TIXtAPoCITZFQbo+LH0O4z9P3Nb7+1ZwNGTJk1cZmJUwTP+OFO38FsZhVxw0wgGhXPQsGNx+NVJ0zs46u7Mk2c8FsU4TwuKrMWIMn3NK/qfNwuQ2XDBIQGQO2sP15R0N/1s/K0oxThqZ26GeVDxBRSS7ZO85RMO1sPxIQ2qAEUOzxKN9gJ/KXZPj+uXBXp723PsBnBxZFnDU3gCrnmUq5K0doDy9CY084wikaFhv9dBqyMtjKFD2hj1LXg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4747.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(7696005)(54906003)(55016002)(9686003)(316002)(508600001)(71200400001)(5660300002)(110136005)(76116006)(86362001)(966005)(107886003)(82960400001)(8936002)(8676002)(38100700002)(2906002)(66476007)(6506007)(64756008)(66946007)(122000001)(52536014)(186003)(83380400001)(4326008)(53546011)(38070700005)(26005)(33656002)(66556008)(66446008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?YEguBNcrNuh1AJzEbmLjWEQ3eQKOaha6rEBew99op/+VgCKb6DyDTp10be1e?= =?us-ascii?Q?8bvqGuXP809gLbm+3kv7NNJKu72kguqZ8dHJyvHhS6kkW73pARlrBXSSZslD?= =?us-ascii?Q?cfNkY+oG63RGcw5/HdaA2qJzGNImIhkZ50yce7lSQT+Kx3hkt9QydEWKO3lH?= =?us-ascii?Q?wuMq3ddjBV+Y8o/yiYnfMyAamo2rIFBiW6PHuCqR8kO2lERaqSjsmIgvIoSc?= =?us-ascii?Q?e97kaqBvmbeee1llhfL6g8wQK17uoW/GJu9GF7qvrFTLdMG0FiNG1kLUzjMW?= =?us-ascii?Q?94W5Pq7f/0LHGwQd5KznQZgRTMpkQloNllGKpTqPHgbp/VqHH8TbczAd91kQ?= =?us-ascii?Q?a5Yb1k16xHlXh1/TFvQfAhwTVgiLhxIRNA3s77Gm81cDWFmZsAGnYK31h68G?= =?us-ascii?Q?M4PLa7Z8Xy33f7B7khvsq7IpYh6Zxa9rRpsksWPKkshTjEZqbIf7v8j+IgCf?= =?us-ascii?Q?pyIsLoG5VUQALKigWuYkq5sgjDpVKzj3OmZ5xyvcoH6y20tCF+atDngSukQo?= =?us-ascii?Q?YMST+B+T0TkxbK+8kmHvl7ofQQ83blhNsty/l46C1F0cODUPsQpkfsYutggP?= =?us-ascii?Q?b8Fhf2rjt6Un9fR1yinrddJTyXDpOLV3WTvMF7aJK+TKx46rlIJvuvxejgwC?= =?us-ascii?Q?2TvhjxRFiM+302w1MtM7KP/MhXVjeqj0bnlFHPjskOZZt6P7szI05AWOu05e?= =?us-ascii?Q?J5DN58q1EV7e0P0TSfGnxAlEP/O7SdjXPHgLhDWdL8C2VaDZ51Fb+33VOpxk?= =?us-ascii?Q?gJwu1mWppYVxukHV2lWZXW4C+FTI5RZ8/pWVHzYU8mGUNz+3SEGHw4QO2XyL?= =?us-ascii?Q?vZFRU5vupAOLMsNbWOr4uNNKLnTZLx1kfwPv8wPkj25i3II+eQD/MvsNmTAS?= =?us-ascii?Q?NIx7DklSUD5ZogqzZaCgaCbPfgItiiQo4HyDp3Xob4r6UDPBcIwElio5v/NV?= =?us-ascii?Q?F9JTdXUWPeh4SEK4BNjTmTgolxcfCUypMW+lFUsF5yA2b70B8xY1mixaPY6y?= =?us-ascii?Q?w/Q0q8KPwoliY8b6OAMMWsXtCM06lwIlbsc8qeV+se3qk0/F0n3MNGWK0dT0?= =?us-ascii?Q?PfzCAJS8S+SJZY1p5my5rWsmZ4H7Zrpqz5Q7GS+m154KFhROcuo6Oq5gPgVS?= =?us-ascii?Q?NGTJySK0igtg8bfCAvCxUoAINrhUmp9NweIekjXk4YO0U1Fphipm3ZR15EcZ?= =?us-ascii?Q?nxwrn54Xafo9XHtA9AZ1lU7JDZRAoXFJDJLBszvcx/9JZdD1tHG02G5FKfuI?= =?us-ascii?Q?psSfsZa8+bGA5l2AzJAJLgFJ31hxNVLqYudMqh3LRfb4SxwzYSePocRezNd0?= =?us-ascii?Q?ZMcHsSP5V0/E3QuWOsVjXpvQ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4747.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4488201a-7401-43d9-a80d-08d98f78f4e7 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Oct 2021 01:13:11.6947 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: rrp/4vBXoGuvw4I/CqgIslDESRY4+tKZLVpXmMGyRSoe2g2qNyrDNaUIg7G1ykVHNzX3yPku+KzapKggBzPAIA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1517 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed as 8194edc4af71799f163fe9735d0059dd90079ecc -----Original Message----- From: devel@edk2.groups.io On Behalf Of Oram, Isaac = W Sent: Wednesday, September 22, 2021 2:35 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/Pla= tformHooksLib: Fix eSPI serial debug Fix issue with missing debug messages on ESPI_ENABLE configuration. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Isaac Oram --- Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/PlatformHooks.= c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/Pl= atformHooks.c b/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib= /PlatformHooks.c index fa695358bf..8a93f41678 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/PlatformH= ooks.c +++ b/Platform/Intel/WhitleyOpenBoardPkg/Library/PlatformHooksLib/PlatformH= ooks.c @@ -116,6 +116,13 @@ IsAspeedPresent ( IoWrite8 (ASPEED2500_SIO_INDEX_PORT, REG_LOGICAL_DEVICE); IoWrite8 (ASPEED2500_SIO_DATA_PORT, ASPEED2500_SIO_UART1); if (IoRead8 (ASPEED2500_SIO_DATA_PORT) =3D=3D ASPEED2500_SIO_UART1) { + // + // In ESPI mode, assume this SIO logic device always present. + // +#ifdef ESPI_ENABLE + DeviceID =3D 0; + PresenceStatus =3D TRUE; +#else // //right now, maybe it is ASPEED. to detect the device ID. // @@ -143,6 +150,7 @@ IsAspeedPresent ( if ((DeviceID & 0xff0000ff) =3D=3D 0x04000003) { PresenceStatus =3D TRUE; } +#endif } IoWrite8 (ASPEED2500_SIO_INDEX_PORT, ASPEED2500_SIO_LOCK); return PresenceStatus; --=20 2.27.0.windows.1