From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web09.4141.1642043726255292861 for ; Wed, 12 Jan 2022 19:15:26 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=K2i/OiHt; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642043726; x=1673579726; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=RbukWXuIXMIs12vH0hFODgtz5y6DGEzIFnE7Mlz7tg0=; b=K2i/OiHtcrq9NPPRLmlTU880M0dudUMrXeCk4G3WIKZP0vDYuRZ8Yvw1 S3JuSLObrOBbGS2vrmWtqNrjsF7E1LMXXIyiDqk7UbsVjvR3XX9KmC8ju ueJx0yAQtRu0E/fjMQB6otdh+piiqjiFJ0yRb7kDrwR8KiU+bhaEK/yAW ORkgnFfBD2kZxIOgAemnfPzf3q0e43z333jUDuvsCLFl8QY1YfAYMELWe xNQxsKbgIq0xn71mZcSRi47D20fCWyFEtszT3bGAGSfKQTCmop7YwQv+T s3wsKr5lV7GlnvuZ9wHP+T1v7yjIGn4RQ07gZzZhw+7hqg+rVSYJzKGIP g==; X-IronPort-AV: E=McAfee;i="6200,9189,10225"; a="242733790" X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="242733790" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jan 2022 19:15:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,284,1635231600"; d="scan'208";a="473072788" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga003.jf.intel.com with ESMTP; 12 Jan 2022 19:15:25 -0800 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 19:15:25 -0800 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 12 Jan 2022 19:15:24 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 12 Jan 2022 19:15:24 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 12 Jan 2022 19:15:11 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=g55KjEvpvz7MqYN+5LD4uEaoTXRebKIMugBYhnfkeZMLAtxCeKQusWNnCepD00l1yh9BgdpKXJQ48LL12yne9XcJtb5qMCkF6bCnuOU3Ts552aqs8lzwS0sUFbrSM1uziTv7PIne2YKrvYPuiiCHa9xk6wGaurOnTQ8crv66aZx5Vr1ioqwIvRDpTyzsqGeHf/ym5IWQ0T5c84Kcxh/AuWLBEUN3ojBAgVCM43BVCpAdK25VR0Ztj7jCO9DYfRmY2sAWd5l2B5nLsCubt7FA4bWBLz0udYhDDJQ6kP5FCwzwKc38mBOXGgC4qduHSg6SoRoO6Hgl4PRleIpM6ni01A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9wK3gD5nimUFoLQU+bn0qclZ6oYCNmeqhgrKZsW/sdU=; b=fPQtVnAM7KkLOp6YG88u9W1FiAVRacNkgLuq+T1dM7iD4crW+HPsN45VUunObW3Illde9Bomo1r8iWmHy2FVVroMlo1BgkgEPAD/KChIdt5BXxds5oXbQ1zg8laRIwcQFBD7dWUZ/JdXBDCXjou6QqPFZifp7OmljSphiXkwAsZ7PAGzgJNDAfMjYLt8FcJde1kbUBju8iDFWbwLEG1yPIuXFZk1Klmo295MBkpCtz9fW+nxZFCJbYTiX7kloIvdVp7q+L5emOjt3bX1mss4tNW89b2rSVjtP8etEryQtij77qr5Vl7T92VyvkGLCau/lKeIgRXKmGBj/iVp4Y3TFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW3PR11MB4747.namprd11.prod.outlook.com (2603:10b6:303:2f::11) by MWHPR1101MB2125.namprd11.prod.outlook.com (2603:10b6:301:4d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.11; Thu, 13 Jan 2022 03:15:08 +0000 Received: from MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::9c36:57de:e967:55a3]) by MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::9c36:57de:e967:55a3%8]) with mapi id 15.20.4867.012; Thu, 13 Jan 2022 03:15:08 +0000 From: "Oram, Isaac W" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Gao, Liming" , "Dong, Eric" , "Tan, Ming" , "Chiu, Chasel" , "Bi, Dandan" , "Shindo, Miki" , "Abbas, Mohamed" , "KARPAGAVINAYAGAM, MANICKAVASAKAM" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 00/27] Improve feature build consistency Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 00/27] Improve feature build consistency Thread-Index: AQHYB1sIMGzNCJneh0a95awIoByCO6xgQPqAgAAEZ4A= Date: Thu, 13 Jan 2022 03:15:08 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 897e4219-df0d-472b-a47c-08d9d642e76a x-ms-traffictypediagnostic: MWHPR1101MB2125:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: q1fZFn3fK9xQ/C2HvA16WEmK/2j07joeKcjs5VIR1tDw3hvMIc4PTGosHd4qjWx9H0xcvkgwo45URcqL15Sgnl6lwohtTQ39djo0Lv2+CnoTEKhminpARSTf9lFu8A+3KUciytJClyXZY/rCRrsC74K9KVSuPOKLTM2219Jr4qkRtkhP+0d2b4ew2JTg68v2QRE4rz9yep8ur9DyObb24aO+1ZbX7iipR/EzDutFie4SXK3jRquEH5mW5RgGC4hxmJW2XTRNrYcwpsOe27O1xscDpP8iBEnAO/rkmwNxpFt+IwPBkIWYOQjvyHVV0t6dr4NJ9Ylevjl713PVXDgUG+VPn4HAKpivTYwK11v9B7zWIz8HYWRFdV878S8u18XlKm3asrsDvrQ1mPu52HJGyaJFX7qnJodrL/oMX5fypW8ccOgEVQ42o3N2glkTx9FjszrzK4anls6ZIgZC+jODSoHufU8fqK0Pr1qIRicqjZcazqmuEyPPO1ozqdWVojwUqcC/YrUTpC6bTUA6PJIars43WM/ZBhTX+fEbuSfTBm3V4Pg1OuhoQtf88pAnrRwN/+uO1u7236zeXHdzg/QqONGC1S7bpBYrpZdBKNo6AkJz4+qEyVoTO+5jHNsytlPIIheYmavybanVy7qXVckaJySVBwEaV8XYZmohUapTvB9qE21dccyYpNQuptdzSUwcMsaPwKfvpBrNgOoyUskYBQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4747.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(76116006)(54906003)(9686003)(122000001)(64756008)(66446008)(66476007)(8936002)(19627235002)(33656002)(66946007)(82960400001)(38100700002)(186003)(71200400001)(38070700005)(2906002)(83380400001)(66556008)(52536014)(30864003)(26005)(8676002)(6506007)(55016003)(5660300002)(508600001)(53546011)(110136005)(4326008)(316002)(86362001)(7696005)(579004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1d2x4xrP918ZEF6TZFIKWTcB7YizgaIkd5VVhVYCkS+glMG/lZQsrd6rqJqs?= =?us-ascii?Q?VoB81idSrbzaWROF6xNWy/ZuBvJxXJ2jYhiJSx1eGDvo/K/M8w6D8rMgDjA8?= =?us-ascii?Q?0TTFJiu1g/T/QX7bcNBBSLgJ40tZ2YPQWIAG2o5MkpSVUAIrPOI0NrCheDIt?= =?us-ascii?Q?W6GQGI54Y8gcZxeC8q6GODoCVx1AHhdq7upzSvaqbdseZND1uaY3B91j8Glu?= =?us-ascii?Q?CsoAzFWud91RtWtXUUV2RPAZ6HfegeGCiTZt99FlRt3SZn6j6XPIN0udGcqV?= =?us-ascii?Q?uOpcpDw7XwiV0ShKzKotexBWb0XexwL6DIdshJTLNfltvm4wjChA5eBZlwiE?= =?us-ascii?Q?PbqZ92Gwq9isZfT86dgDK4IjAszt0RYgzZBKpscjMgdfgRcnYuQAGkgeRfOF?= =?us-ascii?Q?rKSQYKakHnQCeyJw3PesxNrjE47d7BGMUytXQVcI/eq8joyQ3u3/2kGitQ40?= =?us-ascii?Q?A8fwvlQXey8xR4kVGIy5tu96g5jFyJsQXD84LRfFX328XGPCsx9n4d0wwjr0?= =?us-ascii?Q?+park9YJTxJ09rPn62oSdfXwzxuGYortRVvzYuZvT9QQ46LRT34ScfJRnm+1?= =?us-ascii?Q?mqN+gN0MRuCUmzb0OTvmSJNijEAYWRvZzOWJE67Q2mfydj4zH5QhrreXe8Fz?= =?us-ascii?Q?1ehpZnW+TdR0Pg7GElVn+f/KHffKofimYNLpf5IFi9eB3DoLfxrpjbBhqAu5?= =?us-ascii?Q?baBQypn0kzK4H+E8n1l92SLWXKL72fLkKeDfrUCptvyuAkyYhWrZGYcIHv9m?= =?us-ascii?Q?WbByWyJobHLuyhBwO+qVvRq5AfMino07JQxK95sWW6oebdpq5wZyM0Hk5zp7?= =?us-ascii?Q?MDh/XJOVp4iJ+Z/V2C8vmYOHgVg6IYUm3JXQ3/GdK/F0wqGOq64yd97QIeLf?= =?us-ascii?Q?Dn2fKoKZhBhPsTCi9KFkQrkQsjXcCEcf+52BG1zx7qXIWLbgZlrTCv+MiUlL?= =?us-ascii?Q?wzEClGJXXFhydI2KO064Dcr9P9wqPPvolRPRx5CX3RbunvJgjE/TG6VBq6o1?= =?us-ascii?Q?BuQgYYdZGO3JqkCPWjrz/1Kz1TiMyQOumTrdNgadxlCxHWbWJ+5VNcwAys3R?= =?us-ascii?Q?BtZQkCYF6VXS+FK5cx92AkGBizeIjeWWqGVS6d9ctBOm5COh39iawHwQilDo?= =?us-ascii?Q?IVqKa6lghbswotV8Jz855tR8NovwMVROLCln2Qv8YU/xEnapxtaQXSZb0Oau?= =?us-ascii?Q?65+OGC58JpdSc+CvtBfzQqDYjQ01+8tk0qoW4xWodRPAnCZtuAJucfvDYOWP?= =?us-ascii?Q?LX5DNNXOnttW7mOGOw3Z/KYsFXLW+S94LR5upV2sPwkKi0CcvKo8l0DEv9jO?= =?us-ascii?Q?aGDnZLb4XikomY5GelZ0i9rvA1k4dgO7ozneGOVQ7/i0FkiYbZqHkdvSqEAK?= =?us-ascii?Q?SGat/U44kUXrmW3ft/YF0aRbDv/tadV0uw2zQNzgDISWAUXVMRh8aHs9uy3W?= =?us-ascii?Q?MIxr7AhEzGkkebmaC/3a54i7O9X1Cv7WpFji6vtDMWbqDeZR+pO/8NNoPtV6?= =?us-ascii?Q?4I7diCX5yh4r3yvTL5qIOVl6Hysdh0m6L73JOBa6ClkuG5MdWwiHdUrxfi6w?= =?us-ascii?Q?g4lv89I98oo7h6eFZBlhz/pyzGD67s+yj7Vxt72V95IqAVfl6DW2uiddqZNs?= =?us-ascii?Q?7fSCgO8yvuSithB0qBqSAPI=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4747.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 897e4219-df0d-472b-a47c-08d9d642e76a X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2022 03:15:08.6785 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: W1FBHQSbyp2BTptsD4kYL+0xgWIL+j/4v+rtlnJxpBfhZus/qgB0BOPIq9e2eUcCtaUy0osD3wUwZD0D/GXEqg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2125 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Nate. Comments in line. Regards, Isaac -----Original Message----- From: Desimone, Nathaniel L =20 Sent: Wednesday, January 12, 2022 6:47 PM To: Oram, Isaac W ; devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Gao, Liming ; Dong, Eric ; Tan, Ming ; Chiu, Chasel ; Bi, Dandan ; Shindo, Miki ; Abbas, Mohamed ; KARPAGAVINAYAGAM, MANICKAVASAKAM Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 00/27] Improve feature b= uild consistency Hi Issac, Thank you for doing this cleanup work. I have some comments for you. I have= provided a summary of my feedback below: PATCH 01/27 * Features/Intel/Debugging/BeepDebugFeaturePkg/Include/BeepDebugFeature.dsc Line 69: [Components.IA32] should be changed to [Components.$(PEI_ARCH)] Li= ne 83: [Components.X64] should be changed to [Components.$(DXE_ARCH)] Note: These comments can also be addressed by restoring the @todo comment s= tating that these changes still need to be done (which you deleted.) [Isaac] $(DXE_ARCH) and $(PEI_ARCH) are not fully functional. It appears t= hat they are fine in DSC files, even when inside an include. But they are = not fine inside an include in an FDF file. The PreMemory.fdf and PostMemor= y.fdf do not work when I try to introduce this change. =20 As these are not required, ToDo are against coding style and are bad for co= mprehensibility, I would prefer to not add such useless comments back in. = Comments should improve the comprehensibility of code and should not distra= ct from understanding the code. PATCH 18/27 * Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dsc Line 33: [PcdsFeatureFlag.X64] should be changed to [PcdsFeatureFlag.$(DXE_= ARCH)] Note: This comment can also be addressed by adding a @todo comment stating = that this change still needs to be done. [Isaac] See prior response. PATCH 19/27 * Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc Line 35: Typo here. Usb3DebugPortParamLibo should be Usb3DebugPortParamLib. [Isaac] Good catch. I guess we don't catch that class of error if the libr= ary class is not used. * Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dsc Line 40: Did you test compilation for the Usb3DebugFeaturePkg? I've general= ly run into issues when a components sections does not specify a machine ar= chitecture through some sort of means. [Isaac] There is no code consuming these libraries. I verified build of 32= and 64 bit modes as well as part of AdvancedFeaturePkg build and a board p= ackage build. I believe that library classes can be specified by module type and the buil= d tool builds the right mode for the consuming driver on demand. Basically= , there is no value to specifying architecture for a library. This does not work with components however. If you leave the architecture = unspecified, you get an error when including the component in an FDF as the= build does not know how to resolve. PATCH 26/27 Since FvAdvanced is post-memory and not covered by the boot guard IBB, I su= spect we should probably also support optional signing of that FV. [Isaac] I do not know how to act on that suggestion. That seems out of sco= pe for this change. I restricted my changes to be functionally compatible = as I do not have hardware to test these changes other than minimally. Thanks, Nate -----Original Message----- From: Oram, Isaac W Sent: Tuesday, January 11, 2022 6:20 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chaganty, Rangasai V ; Gao, Liming ; Dong, Eric <= eric.dong@intel.com>; Tan, Ming ; Desimone, Nathaniel L= ; Chiu, Chasel ; Bi= , Dandan ; Shindo, Miki ; Abbas= , Mohamed ; KARPAGAVINAYAGAM, MANICKAVASAKAM Subject: [edk2-devel][edk2-platforms][PATCH V1 00/27] Improve feature build= consistency This series addresses inconsistencies in feature implementation and use. So= me inconsistencies are just conventions of the feature design/template/conv= ention. Some are inconsistency with feature design intent that negatively = affect the usability of the features and the amount of work required from b= oard porting engineers. Some features were missing feature enable flags. Some features had non-functional standalone builds. Many features were implemented to include common core build content in thei= r feature include files. Updated some of the Readme content. Added AdvancedFeaturePkg.fdf to build all feature content to support verify= ing no build time issues between features. Removed duplicate and unused content from build files. Modified the TemplateFeaturePkg to use the common MinPlatform include conte= nt. Removed all instances where features were relative to Features/Intel and ma= de them relative to the package roots. This does mean PACKAGES_PATH may need to be extended for all the feature do= mains. Debugging, PowerManagement, etc. However, it should enable packaging tools to function properly as the relat= ive paths violate spec. Use of the common MinPlatformPkg build includes does increase the build tim= e for each individual feature in standalone build modes. It does not negati= vely impact board or AdvancedFeaturePkg builds as the common content is onl= y built once. Part of MinPlatform arch intent is to reduce cognitive comple= xity, so the simpler build is more valuable than fast build time. Cc: Sai Chaganty Cc: Liming Gao Cc: Eric Dong Cc: Ming Tan Cc: Nate DeSimone Cc: Chasel Chiu Cc: Dandan Bi Cc: Miki Shindo Cc: Mohamed Abbas Cc: Manickavasakam Karpagavinayagam Signed-off-by: Isaac Oram Isaac Oram (27): BeepDebugFeaturePkg: Use MinPlatformPkg build include files BeepDebugFeaturePkg: Fix all relative package paths AcpiDebugFeaturePkg: Fix all relative package paths IpmiFeaturePkg: Fix all relative package paths IpmiFeaturePkg: Fix build errors S3FeaturePkg: Fix all relative package paths S3FeaturePkg: Use MinPlatformPkg build include files SmbiosFeaturePkg: Fix all relative package paths SmbiosFeaturePkg: Use MinPlatformPkg build include files UserAuthFeaturePkg: Fix all relative package paths UserAuthFeaturePkg: Use MinPlatformPkg build include files VirtualKeyboardFeaturePkg: Fix all relative package paths VirtualKeyboardFeaturePkg: Use MinPlatformPkg build include files VirtualKeyboardFeaturePkg: Add feature enable PCD NetworkFeaturePkg: Use MinPlatformPkg build include files LogoFeaturePkg: Use MinPlatformPkg build include files PostCodeDebugFeaturePkg: Complete as an advanced feature AcpiDebugFeaturePkg: Use MinPlatformPkg build include files Usb3DebugFeaturePkg: Align with feature design guidelines SpcrFeaturePkg: Use MinPlatform build include files TemplateFeaturePkg: Use MinPlatform build include files AdvancedFeaturePkg: Fix all relative package paths AdvancedFeaturePkg: Add missing features MinPlatformPkg/Build: Add an include file for the common SPI FV info WhitleyOpenBoardPkg/Build: Use common SPI FV Header include AdvancedFeaturePkg/Build: Add FDF to create FV for all features WhitleyOpenBoardPkg/Build: Enable Features/Intel features Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc = | 67 +++++- Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.fdf = | 49 +++++ Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeatures.dsc = | 49 +++-- Features/Intel/AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc = | 64 +++++- Features/Intel/AdvancedFeaturePkg/Include/PostMemory.fdf = | 49 +++-- Features/Intel/AdvancedFeaturePkg/Include/PreMemory.fdf = | 49 +++-- Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugDxe.= inf | 2 +- Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugDxeSmm/AcpiDebugSmm.= inf | 2 +- Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dec = | 2 +- Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dsc = | 21 ++ Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/AcpiDebugFeature.dsc = | 74 +------ Features/Intel/Debugging/AcpiDebugFeaturePkg/Include/PostMemory.fdf = | 4 +- Features/Intel/Debugging/BeepDebugFeaturePkg/BeepDebugFeaturePkg.dec = | 7 +- Features/Intel/Debugging/BeepDebugFeaturePkg/BeepDebugFeaturePkg.dsc = | 28 +++ Features/Intel/Debugging/BeepDebugFeaturePkg/Include/BeepDebugFeature.dsc = | 222 ++++++------------- Features/Intel/Debugging/BeepDebugFeaturePkg/Include/Library/BeepLib.h = | 6 +- Features/Intel/Debugging/BeepDebugFeaturePkg/Include/PostMemory.fdf = | 14 ++ Features/Intel/Debugging/BeepDebugFeaturePkg/Include/PreMemory.fdf = | 13 ++ Features/Intel/Debugging/BeepDebugFeaturePkg/Library/BeepStatusCodeHandler= Lib/PeiBeepStatusCodeHandlerLib.inf | 5 +- Features/Intel/Debugging/BeepDebugFeaturePkg/Library/BeepStatusCodeHandler= Lib/RuntimeDxeBeepStatusCodeHandlerLib.inf | 3 - Features/Intel/Debugging/BeepDebugFeaturePkg/Library/BeepStatusCodeHandler= Lib/SmmBeepStatusCodeHandlerLib.inf | 3 - Features/Intel/Debugging/BeepDebugFeaturePkg/Readme.md = | 91 +++++--- Features/Intel/Debugging/PostCodeDebugFeaturePkg/Include/PostCodeDebugFeat= ure.dsc | 231 +++++--------------- Features/Intel/Debugging/PostCodeDebugFeaturePkg/Include/PostMemory.fdf = | 14 ++ Features/Intel/Debugging/PostCodeDebugFeaturePkg/Include/PreMemory.fdf = | 13 ++ Features/Intel/Debugging/PostCodeDebugFeaturePkg/Library/PostCodeStatusCod= eHandlerLib/PeiPostCodeStatusCodeHandlerLib.inf | 2 +- Features/Intel/Debugging/PostCodeDebugFeaturePkg/PostCodeDebugFeaturePkg.d= ec | 11 + Features/Intel/Debugging/PostCodeDebugFeaturePkg/PostCodeDebugFeaturePkg.d= sc | 30 +++ Features/Intel/Debugging/PostCodeDebugFeaturePkg/Readme.md = | 31 ++- Features/Intel/Debugging/Usb3DebugFeaturePkg/Include/Usb3DebugFeature.dsc = | 131 ++--------- Features/Intel/Debugging/Usb3DebugFeaturePkg/Readme.md = | 50 +++-- Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dec = | 14 +- Features/Intel/Debugging/Usb3DebugFeaturePkg/Usb3DebugFeaturePkg.dsc = | 18 ++ Features/Intel/Network/NetworkFeaturePkg/Include/NetworkFeature.dsc = | 89 +------- Features/Intel/Network/NetworkFeaturePkg/NetworkFeaturePkg.dsc = | 18 ++ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcAcpi/BmcAcpi.inf = | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/BmcElog/BmcElog.inf = | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Frb/FrbDxe.inf = | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Frb/FrbPei.inf = | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/GenericI= pmi.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Pei/PeiGener= icIpmi.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Smm/SmmGener= icIpmi.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/IpmiFeature.dsc = | 90 ++------ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PostMemory.fdf = | 16 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Include/PreMemory.fdf = | 6 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFeaturePkg.dsc = | 18 ++ Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiFru/IpmiFru.inf = | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/DxeIpmiInit.inf= | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/IpmiInit/PeiIpmiInit.inf= | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLib/Ipmi= BaseLib.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLibNull/= IpmiBaseLibNull.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiCommandLib/I= pmiCommandLib.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiPlatformHook= LibNull/IpmiPlatformHookLibNull.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/PeiIpmiBaseLib/P= eiIpmiBaseLib.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/SmmIpmiBaseLib/S= mmIpmiBaseLib.inf | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/OsWdt/OsWdt.inf = | 2 +- Features/Intel/OutOfBandManagement/IpmiFeaturePkg/SolStatus/SolStatus.inf = | 2 +- Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Library/SpcrDevi= ceLib.h | 2 +- Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PostMemory.fdf = | 13 ++ Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PreMemory.fdf = | 11 + Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc = | 62 ------ Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Readme.md = | 12 +- Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.dec = | 6 + Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.dsc = | 18 ++ Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.fdf = | 2 +- Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc = | 74 +------ Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc = | 18 ++ Features/Intel/PowerManagement/S3FeaturePkg/S3Pei/S3Pei.inf = | 2 +- Features/Intel/Readme.md = | 49 +++-- Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/PostMemory.fdf = | 2 +- Features/Intel/SystemInformation/SmbiosFeaturePkg/Include/SmbiosFeature.ds= c | 54 +---- Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosBasicDxe/SmbiosBas= icDxe.inf | 2 +- Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dec = | 10 +- Features/Intel/SystemInformation/SmbiosFeaturePkg/SmbiosFeaturePkg.dsc = | 18 ++ Features/Intel/TemplateFeaturePkg/Include/TemplateFeature.dsc = | 2 +- Features/Intel/TemplateFeaturePkg/TemplateFeaturePkg.dsc = | 18 ++ Features/Intel/UserInterface/LogoFeaturePkg/Include/LogoFeature.dsc = | 69 +----- Features/Intel/UserInterface/LogoFeaturePkg/LogoFeaturePkg.dec = | 2 - Features/Intel/UserInterface/LogoFeaturePkg/LogoFeaturePkg.dsc = | 38 +++- Features/Intel/UserInterface/UserAuthFeaturePkg/Include/PostMemory.fdf = | 6 +- Features/Intel/UserInterface/UserAuthFeaturePkg/Include/UserAuthFeature.ds= c | 92 +------- Features/Intel/UserInterface/UserAuthFeaturePkg/Library/PlatformPasswordLi= bNull/PlatformPasswordLibNull.inf | 2 +- Features/Intel/UserInterface/UserAuthFeaturePkg/Library/UserPasswordLib/Us= erPasswordLib.inf | 2 +- Features/Intel/UserInterface/UserAuthFeaturePkg/Library/UserPasswordUiLib/= UserPasswordUiLib.inf | 2 +- Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthFeaturePkg.dsc = | 18 ++ Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm/U= serAuthentication2Dxe.inf | 2 +- Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm/U= serAuthenticationDxe.inf | 2 +- Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDxeSmm/U= serAuthenticationSmm.inf | 2 +- Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Include/PostMemory.= fdf | 2 +- Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Include/VirtualKeyb= oardFeature.dsc | 64 +----- Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardFeat= urePkg.dec | 7 +- Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboardFeat= urePkg.dsc | 18 ++ Platform/Intel/{WhitleyOpenBoardPkg =3D> MinPlatformPkg}/Include/Fdf/Commo= nSpiFvHeaderInfo.fdf | 2 +- Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/PlatformPkg.fdf = | 48 ++-- Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc = | 44 ++++ Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.fdf = | 54 ++--- 96 files changed, 1159 insertions(+), 1334 deletions(-) create mode 10064= 4 Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.fdf create mode 100644 Features/Intel/Debugging/BeepDebugFeaturePkg/Include/Po= stMemory.fdf create mode 100644 Features/Intel/Debugging/BeepDebugFeaturePkg/Include/Pr= eMemory.fdf create mode 100644 Features/Intel/Debugging/PostCodeDebugFeaturePkg/Includ= e/PostMemory.fdf create mode 100644 Features/Intel/Debugging/PostCodeDebugFeaturePkg/Includ= e/PreMemory.fdf create mode 100644 Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Inclu= de/PostMemory.fdf create mode 100644 Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Inclu= de/PreMemory.fdf rename Platform/Intel/{WhitleyOpenBoardPkg =3D> MinPlatformPkg}/Include/Fd= f/CommonSpiFvHeaderInfo.fdf (88%) -- 2.27.0.windows.1