From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com []) by mx.groups.io with SMTP id smtpd.web09.250.1623449718527367366 for ; Fri, 11 Jun 2021 15:15:21 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=ul3EfNr7; spf=fail (domain: intel.com, ip: , mailfrom: isaac.w.oram@intel.com) IronPort-SDR: 76ju71xDtDg0fhW93HayKo9Zi7kz+S+c7dhYZFTKjhMbYZPOxPAkzS/xwJssFmjcqhJE/dOYzZ dj2z+3PDGqKw== X-IronPort-AV: E=McAfee;i="6200,9189,10012"; a="185995836" X-IronPort-AV: E=Sophos;i="5.83,267,1616482800"; d="scan'208";a="185995836" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2021 15:15:21 -0700 IronPort-SDR: l7k1ukXJnBCddEVjL4egROOig7viGLMwnbtlyu665JkLGHB9Q77eslcVZy9sAG9osxX5Pf8ypz Ndun+YFB4j9Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,267,1616482800"; d="scan'208";a="486738811" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga002.fm.intel.com with ESMTP; 11 Jun 2021 15:15:20 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Fri, 11 Jun 2021 15:15:20 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Fri, 11 Jun 2021 15:15:19 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Fri, 11 Jun 2021 15:15:19 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Fri, 11 Jun 2021 15:15:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=avbROjaCHpCc6Nbv28fRjVoFVx6YkxGJyUobXzcVSqjbWO1gdqEti4Khhnk9w+D5W+21InfC8DqF5IYJV4+vIOy3bL0U9cgCFvHIF7eTJOjdJXm8i2rGAK3AKsPyQRbD2j8hhVtp3TPaz/I7FBT3ilrKky1aGvn8k0MCoLSB1ryxizfyywcRtUKbmuU+BLXoO1qt4ibviptE+Rdn74P7TMXY+8lCXuMQnYc+xDuOntnCIuaYt5gnHu5t4aGw1mKRrE0qrMxSMAMJ+QJY2DlpIGVaDIYK9ncYMoWy1lQLVKJSfOx+F1agbBhPbxFSZmJhYzQR8vZXUoJRrdQwXiMR9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HpwIA7SOIShbZeLj5/M5G0GU8F+EgQ8qVsQUGcglooA=; b=MZsG6CoE62EVatLgvbaUc9Aidhh0/1STY8In9Ah65QkVYpotDDfpNtKl3tk0UamJhyqps0rMh0du8m0ewF7DwGiwGoytfzPbFT0KB50k8qVcAIUyOPllfQPP44BLQhYA8coHd3dDq21SZz7EzZeqREHmurFayP42eoZLPiKWlTBucUlLGNdDpN9w3kAPN/oXFxjTu8TK43GnagEG7Wl2NTcfXMLoxSaOoNj4DBMd8KIxxMWTdAXCl2VmGJcHFfNisQJV/591hZm2JVOmerysE1IeZqA2DDUCyuE+HhGWn2niC/6scWgY6xGI35WbA/CakFVCXexuWuELOKlbDeMRcg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HpwIA7SOIShbZeLj5/M5G0GU8F+EgQ8qVsQUGcglooA=; b=ul3EfNr7MNU3Ysh+l9WR6NF7sPAgVI6cKaWmAqsuYtIkp0fQaIn1u453/5QKinPbMBXXEpD6BnWwNgVnb9MQIU2IKC3ahTvzujnq1VIB6Lyessp5QAfDtklocAJgLy8+UrR0aR6dQ9swuInYs+NMQN/gRXs+y9Si42lBg+2zRJs= Received: from MW3PR11MB4747.namprd11.prod.outlook.com (2603:10b6:303:2f::11) by MW3PR11MB4649.namprd11.prod.outlook.com (2603:10b6:303:5b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.21; Fri, 11 Jun 2021 22:15:18 +0000 Received: from MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::4cc2:7196:5a55:629e]) by MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::4cc2:7196:5a55:629e%3]) with mapi id 15.20.4219.024; Fri, 11 Jun 2021 22:15:18 +0000 From: "Oram, Isaac W" To: "KARPAGAVINAYAGAM, MANICKAVASAKAM" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Felixp@ami.com" , "DOPPALAPUDI, HARIKRISHNA" , "Jha, Manish" , "Bobroff, Zachary" , "KARPAGAVINAYAGAM, MANICKAVASAKAM" , "gaoliming@byosoft.com.cn" Subject: Re: [edk2-platforms][PATCH] IpmiFeaturePkg : Rename IPMI Macro and Structure Defintions Thread-Topic: [edk2-platforms][PATCH] IpmiFeaturePkg : Rename IPMI Macro and Structure Defintions Thread-Index: AQHXXwwQobhPtnLGuEGsjg86MMCApqsPX4jw Date: Fri, 11 Jun 2021 22:15:17 +0000 Message-ID: References: <20210611215217.8938-1-manickavasakamk@ami.com> In-Reply-To: <20210611215217.8938-1-manickavasakamk@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action authentication-results: ami.com; dkim=none (message not signed) header.d=none;ami.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [134.134.136.211] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 58b52823-abd0-4706-ae03-08d92d26653c x-ms-traffictypediagnostic: MW3PR11MB4649: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: dmBZk7jYmMD2XNAHL0eBwJz/rgY8fRnbUJ2WeEQNiImRpRTk6j17YKmpeFB3gLUa/JzRonhVhEegf87cxr2nZgu0iXDW/i2Fc7Nt88saGebs2uKYyxHCA+I2JB3bbLfx5bYvhXam19jvNLUycCAtx1NEg649HR+e+MoH5Cu9JkrJ64itaAqk7hWeadaVmiuwOjlnBqvqCDcPtzIDqaoANb3FIBgUYQaopksOf74k6EikfubmVitzerVxcrRxLHlsVZNzI7FXlEXyGNxouLRXCYZWC0ZHv/otcyTg+RIUOAaolrmCOAsfeT1quXzeoNaV69QXp8VOLtTml4elOMtfFQPuY2zAq+96vBGyKE0p22z+3HX2jTov9qvG+fcfrsmllp9sqLz0JkuFltTPWA7xaV8AJTmlIMcbiUukbcZHvJbwU23k8F4D2bTBIBgOCgUN0NVdM09eNyQLcI/1/S3ntrDA/z2M5OdxYhjZ3JIRqv7sHglb8MSqpoon3X3PJnVkkr8tKMBzcMsAzPvLeYihkLZQmw+n1RaxyeBtSmnr7LOGVvaV9WS+D/Qyw9MBNyzMAEWV+vyPT+Eciuz4mgoyjNtTwHZ+gAN0XDd0vOeHVoQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4747.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(39860400002)(366004)(376002)(136003)(396003)(5660300002)(66476007)(6506007)(53546011)(9686003)(8676002)(4326008)(7696005)(8936002)(26005)(33656002)(52536014)(316002)(110136005)(76116006)(86362001)(71200400001)(122000001)(66556008)(66946007)(38100700002)(55016002)(54906003)(83380400001)(186003)(64756008)(478600001)(2906002)(66446008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?mOhTZtjE73xUTYM+QWkDF7xlIrfRR/EJLU5AgRh0l3am965loXBRT3u23mJh?= =?us-ascii?Q?/rbLWJ+vh3G6Vxr9/r3hlh/bwKAvnmpOlvKMr6Py6vPcgh/yh4TorYoHk/DT?= =?us-ascii?Q?UCU7bn8esbZWj5L3+k2DfNVBAUI4O8MbBcZBm240PtJImYszhf9K2iT9O0m2?= =?us-ascii?Q?xw2fQZA9dC9Y0wnWIzcWycLfbZxDbbGPNoQlB2iybyOnEoHkfevGBPsynpiN?= =?us-ascii?Q?7jnd23xEUjLMFDrMHn0pleq62TjwkbNI+z48/1oMHdaotdUXJaFiQvdyXLZx?= =?us-ascii?Q?k8/l2wT0o9MN+cBN7a6JoHRD2AQt2g0uG3xCZMa4r8MjSkJxnYRHjsbNN/8H?= =?us-ascii?Q?43Kg0ZNHLsKsydNUUZbK/fD4fY2ETmY1TXD9mtDHMq67VV2tHi9RVZnRSvoi?= =?us-ascii?Q?aSbXxJ0iT1OPqzkOix9YV7prHnpg1FUg7tqLvkAtStpZxAEzrK7U95dniCAx?= =?us-ascii?Q?ZFdr45se4GzQnlRLrn9NP1RUYVXivd51YHXD++PG1WNSzxchoUgzEIZRAsdU?= =?us-ascii?Q?qjmtNAuImh+osFjEGCVFFpthVlOnJGP/qC8fdtvIGtfOVqmTDEW040eZ/Xqu?= =?us-ascii?Q?nk0LFnKvicRA0nXxF+4cWNS2jj8MqhteqbLOjHs4i2Pa2AN66xuWIIQ2lHkJ?= =?us-ascii?Q?0hIf3gJcBKALXeDYbmHrVwSNFcM5vmHfolJviPk6mNVFBQihMMR50TLUFOQq?= =?us-ascii?Q?YuFBtAlGcuKjxv6k22RcuA/BYMNXade11+qIhKlQicF2abkQB57p/aqk7+k4?= =?us-ascii?Q?lD5LA0wCn0WiwRba1RtLdd1lw+844gVvWwjhdDWlnNBHw2JxFCZ/fTTWTLXN?= =?us-ascii?Q?HGJq9HtCxImcirhZIiVsG2ze+/b4vfRY+fpJv2wAsFTvRFBSvNpn3bMJOXHZ?= =?us-ascii?Q?c0gMXYOLYth2st+uv8svgbSyxepsGN9dXirZ0YAffeGn9POIOJKqNXk++qlK?= =?us-ascii?Q?t3BH4b0R2wpTT7NCX9AgyzcgzDZKh1fgAtjjD1BsIvxRJNQXzGs1mxNaNTk7?= =?us-ascii?Q?GpCGU6zTdWdxZ806Ho7+WtZIXGUm2YbQazI5/et5cd9tLFqewJ6T+qrIzgvU?= =?us-ascii?Q?IC9F95ynTSf8GEFwVWweRBAjHqa523KjdDp4sMj6UXu1MIg4Niy4PmDAXUW1?= =?us-ascii?Q?5CJZjzbsWbHL6g/1OEMLBLk91q4xMfffdr95ZE1TZ9q/xhQ+qVTgIQKe0XIX?= =?us-ascii?Q?CmqfGBqr78pO/iVM9Vy632Bs+RYSRE8P9UlgKmedNZJvASjfM1x0+vJ5UFzc?= =?us-ascii?Q?ipmUOvTJbNnCY/CMByUV0A98aoUtY2NUw1Dhl3tosLYpn1XeaqnG/rKMIwJk?= =?us-ascii?Q?rn2qJI7bIOIiwK7JyvhByt6G?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4747.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58b52823-abd0-4706-ae03-08d92d26653c X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jun 2021 22:15:17.9242 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: iA2F8jvGmsOlld8OUPesP1psc5Jafg4ZNQc5H6YkZv/BURMogJv1qB8PSJ5XIgcUjcBS4kISdTTA9HM5bBpC0Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4649 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Isaac Oram -----Original Message----- From: manickavasakam karpagavinayagam =20 Sent: Friday, June 11, 2021 2:52 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Felixp@ami.com; DOPPALAPUDI, HARIKRISHNA ; Jha, Manish ; Bobroff, Zachary ; KARPAGAVINAYAGAM, MANICKAVASAKAM ; gaolimi= ng@byosoft.com.cn Subject: [edk2-platforms][PATCH] IpmiFeaturePkg : Rename IPMI Macro and Str= ucture Defintions Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB, EFI_FIRMWARE_GET_BMC_EXECUTION_C= ONTEXT EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_G= ET_BMC_EXECUTION_CONTEXT IPMI_BMC_IN_FORCED_UPDATE_MODE --- .../IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Dxe/IpmiInit.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericI= pmi/Dxe/IpmiInit.c index 1e0c132508..d788b48867 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/Ipm= iInit.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/Ipm= iInit.c @@ -242,7 +242,7 @@ Returns: EFI_STATUS Status; UINT32 DataSize; SM_CTRL_INFO *pBmcInfo; - EFI_IPMI_MSG_GET_BMC_EXEC_RSP *pBmcExecContext; + IPMI_MSG_GET_BMC_EXEC_RSP *pBmcExecContext; UINT32 Retries; #ifdef FAST_VIDEO_SUPPORT EFI_VIDEOPRINT_PROTOCOL *VideoPrintProtocol; @@ -301,14 +301,14 @@ Returns: Status =3D IpmiSendCommand ( &IpmiInstance->IpmiTransport, IPMI_NETFN_FIRMWARE, 0, - EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT, + IPMI_GET_BMC_EXECUTION_CONTEXT, NULL, 0, IpmiInstance->TempData, &DataSize ); =20 - pBmcExecContext =3D (EFI_IPMI_MSG_GET_BMC_EXEC_RSP*)&IpmiInstance->Tem= pData[0]; + pBmcExecContext =3D (IPMI_MSG_GET_BMC_EXEC_RSP*)&IpmiInstance->TempDat= a[0]; DEBUG ((DEBUG_INFO, "[IPMI] Operational status of BMC: 0x%x\n", pBmcEx= ecContext->CurrentExecutionContext)); - if ((pBmcExecContext->CurrentExecutionContext =3D=3D EFI_FIRMWARE_BMC_= IN_FORCED_UPDATE_MODE) && + if ((pBmcExecContext->CurrentExecutionContext =3D=3D IPMI_BMC_IN_FORCE= D_UPDATE_MODE) && !EFI_ERROR (Status)) { DEBUG ((DEBUG_ERROR, "[IPMI] BMC in Forced Update mode, skip waiting= for BMC_READY.\n")); IpmiInstance->BmcStatus =3D BMC_UPDATE_IN_PROGRESS; --=20 2.25.0.windows.1 Please consider the environment before printing this email. The information contained in this message may be confidential and proprieta= ry to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephon= e at 770-246-8600, and then delete or destroy all copies of the transmissio= n.