Re: [edk2-platforms][PATCH] IpmiFeaturePkg : Rename IPMI Macro and Structure Defintions

Re: [edk2-platforms][PATCH] IpmiFeaturePkg : Rename IPMI Macro and Structure Defintions

[Oram, Isaac W]

Reviewed-by: Isaac Oram <isaac.w.oram@intel.com>

-----Original Message-----
From: manickavasakam karpagavinayagam <manickavasakamk@ami.com> 
Sent: Friday, June 11, 2021 2:52 PM
To: devel@edk2.groups.io
Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Felixp@ami.com; DOPPALAPUDI, HARIKRISHNA <harikrishnad@ami.com>; Jha, Manish <manishj@ami.com>; Bobroff, Zachary <zacharyb@ami.com>; KARPAGAVINAYAGAM, MANICKAVASAKAM <manickavasakamk@ami.com>; gaoliming@byosoft.com.cn
Subject: [edk2-platforms][PATCH] IpmiFeaturePkg : Rename IPMI Macro and Structure Defintions

Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB, EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT
EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT
IPMI_BMC_IN_FORCED_UPDATE_MODE
---
 .../IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c             | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c
index 1e0c132508..d788b48867 100644
--- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c
+++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/IpmiInit.c
@@ -242,7 +242,7 @@ Returns:
   EFI_STATUS                      Status;

   UINT32                          DataSize;

   SM_CTRL_INFO                    *pBmcInfo;

-  EFI_IPMI_MSG_GET_BMC_EXEC_RSP   *pBmcExecContext;

+  IPMI_MSG_GET_BMC_EXEC_RSP       *pBmcExecContext;

   UINT32                          Retries;

 #ifdef FAST_VIDEO_SUPPORT

   EFI_VIDEOPRINT_PROTOCOL         *VideoPrintProtocol;

@@ -301,14 +301,14 @@ Returns:
     Status = IpmiSendCommand (

                &IpmiInstance->IpmiTransport,

                IPMI_NETFN_FIRMWARE, 0,

-               EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT,

+               IPMI_GET_BMC_EXECUTION_CONTEXT,

                NULL, 0,

                IpmiInstance->TempData, &DataSize

                );

 

-    pBmcExecContext = (EFI_IPMI_MSG_GET_BMC_EXEC_RSP*)&IpmiInstance->TempData[0];

+    pBmcExecContext = (IPMI_MSG_GET_BMC_EXEC_RSP*)&IpmiInstance->TempData[0];

     DEBUG ((DEBUG_INFO, "[IPMI] Operational status of BMC: 0x%x\n", pBmcExecContext->CurrentExecutionContext));

-    if ((pBmcExecContext->CurrentExecutionContext == EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE) &&

+    if ((pBmcExecContext->CurrentExecutionContext == IPMI_BMC_IN_FORCED_UPDATE_MODE) &&

         !EFI_ERROR (Status)) {

       DEBUG ((DEBUG_ERROR, "[IPMI] BMC in Forced Update mode, skip waiting for BMC_READY.\n"));

       IpmiInstance->BmcStatus = BMC_UPDATE_IN_PROGRESS;

-- 
2.25.0.windows.1


Please consider the environment before printing this email.

The information contained in this message may be confidential and proprietary to American Megatrends (AMI).  This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited.  Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.