From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web12.443.1642554664519668993 for ; Tue, 18 Jan 2022 17:11:05 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=GHYtSFVs; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642554664; x=1674090664; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=W8qCDgZP/NWhmU8WfD3t0PWXeOineo10aKkGjFK4grg=; b=GHYtSFVs9ONtlFFJdzRH4GBi9TF0NiUe/1sCyHUFBY2UvPdyu29PjCDb sSNg5wlUtzzQ7KdfUGYzGbczCwfshu3sBmrY7eQ6oxNZDGamCNjCyZJTR KAKubCSxQktIycKejZWIG4OyDbGy1vMtKXbFSDTCt7iK6rxgS0QHR58DR N1e49K51We6KTeNOe0o1z69iDMrztzcwFwI4rH2AcaJzeSTop4UhqFFFk dWy47rVVJzSwtpNx7id0GW+mturf0FhHzDzbPOzhcZncAL4v91VchX4GG m14kf1DhJKGq48ORuU3rDj4evx9bDlzIXqPPUULn30wf1maFavya1y8S/ Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="232316103" X-IronPort-AV: E=Sophos;i="5.88,298,1635231600"; d="scan'208";a="232316103" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2022 17:11:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,298,1635231600"; d="scan'208";a="693596911" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga005.jf.intel.com with ESMTP; 18 Jan 2022 17:11:03 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 18 Jan 2022 17:11:02 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 18 Jan 2022 17:11:02 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 18 Jan 2022 17:11:02 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=apml547Vq/c4bNUGwWiiJf3YUtbxryBT5Uk/qffC3+ephGtknfN+5ybMypHlVuZILwRavM2KpJutgjLpCCVd31zfnOAPWVg0h34OqbSUNPzfqduW39dD2Wv6QUFKB7wLmiWIvHnIRFymz2ddbt5PKUOiohkWQl/e0TKQC7mFw5MMB+NbwN8Kp59Z+AyIkXlGdnmggElXs59nljLouEP9mrop9o4bG2yAJZl8XGWWCIVpMEQ5MGHZ4+7ONNEQHF+HX8CnmKvfoxNwCCRPRCetFXCUKMePEUnLQEkUJH1KPXTriBBSzqAYdB+fBDN7ED+Pz61X8khWP9lCQ5HyKwUs0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WFvi7VOilIIeobDHGwb5AhJA+4OItaop++cn+L5zzOg=; b=ZHUNuRpuVdZI3i20vy8Yv6X6T2Ymc6skH0cOs6g5R/Af/QEFJ7yVsRx5dSNyc9h2nrbRfzK6PvQS6IKsKZ5yV/z8NrlxOhmurF8UmqhzUBnmmfsZIXVGTHruWRAVRfujYAIO85/dxQqpDStem3C7JGNvPDhjahCIgj4KW2jyLdhbgr6FDMsUs7PWdTeRcHw3uC8yajommzq2OJhtEE8VqfWSlW9gPF1NXV1lW4jNlDVQiGIC9r3u5YeJxuVH7ToxqZ2MNg8jFJJq/9CKjYOFNTU4HF3jMHEi5auRbFZhuBLuhLY4CBY4PEA2bZWJy9obvW5dgmboXwjmbxyjglxZTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW3PR11MB4747.namprd11.prod.outlook.com (2603:10b6:303:2f::11) by BYAPR11MB2663.namprd11.prod.outlook.com (2603:10b6:a02:ca::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.7; Wed, 19 Jan 2022 01:11:00 +0000 Received: from MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::9c36:57de:e967:55a3]) by MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::9c36:57de:e967:55a3%6]) with mapi id 15.20.4888.014; Wed, 19 Jan 2022 01:11:00 +0000 From: "Oram, Isaac W" To: "Chaganty, Rangasai V" , "devel@edk2.groups.io" CC: "Gao, Liming" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 06/27] S3FeaturePkg: Fix all relative package paths Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 06/27] S3FeaturePkg: Fix all relative package paths Thread-Index: AQHYB1sHfweefX5aekSJvzeG0C+686xh/f4AgAeVKaA= Date: Wed, 19 Jan 2022 01:11:00 +0000 Message-ID: References: <29902af26459b43d30e4b70244e3742813113f1e.1641953242.git.isaac.w.oram@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 88cdb4ab-d4e1-4c64-b165-08d9dae88e66 x-ms-traffictypediagnostic: BYAPR11MB2663:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PPOZKyqnu9f5TbVFc9TS3//4jOSQf2LQzUR/IQv2VfM943tJPEHIbf8GVmrsjKq/qMfeEGBeWLBDMsT1qjyHv7C/ABJBkTnhQpQF1Mjje+WlMAKuq6c4uSmg+6sj3ijeT/td8hwqSC7/Kd2rSQLmt1osQbLCkDfoGuMfMhHohqEOCCRA8nzMyNNwN+Z9N9N1xLJeVzoqsn5gr0H/kjgjslH7wM37i1nACMFRweIqReZoXllL9Gw7y49ykQnI0uyAID6astwgNrvF74d1bYZEwO/1Geh08Vs+M6XNZlZ8lHlFbGbXeTc/hKk2Ps/fsvGRZa69sPWO7W2qYfjWHXSM+1dcoBqscd+HOASiyIsYkLQ+ZBkB2fT7p9OaMTof1DlZYMP1cHFl/nt0q8j9h1lawDoKTf7EMsj8l8EIHwtFAKliVjgDfD5LwIorERj12nMlbuZyMdtTe3p/cTXlPi8ehW9qPZz2q/FxAiBSsoPMa+ZGfzfG6z/pU7aOq4pysZozGQBwcUn84dmMXEtvG75P1tWB0wL3UL8+esDS5PkCuyNAoEI11KKdl2KJ5i+ZxAsgQJLFC4iOWcpdyv5rXlzVxBsH10Fvii/kqVS3m+NQco513fQR3oDawuSkZln0tmxuYtZSml6SHjZu1u4gXor1EDWlQ4XpFJ8VZK3zLafhPpZMtHzBStTMl6Yb84oRB4Bq+lCoSr9Qy8xLPuntgJtTuA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4747.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(53546011)(6506007)(9686003)(86362001)(82960400001)(110136005)(8936002)(71200400001)(316002)(4326008)(508600001)(2906002)(7696005)(5660300002)(38100700002)(122000001)(186003)(66556008)(64756008)(66446008)(66476007)(26005)(76116006)(33656002)(19627235002)(66946007)(8676002)(55016003)(83380400001)(52536014)(38070700005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4Aau/jcy49oDBxcq2pe6aFWLZR5rjXl9dHuRSZU2YnjM5JIThjEiUeS7Xozv?= =?us-ascii?Q?S+fVc4FyIxwwtZrst236vUVlToyiXTCnuCrQUYlcI6o86D+pEGAPpVPsF15O?= =?us-ascii?Q?kTE7B0DrOwjtsx4vPKcK5bXMAXBb41VuBr/OyzFUsl2okxFvKRTyPlFDf9qN?= =?us-ascii?Q?Whc3yBia11Zl0pjpW/Nmokr+WuW39FYiJ2ITF9UwzTR4N29fvxPBhbIhdMFI?= =?us-ascii?Q?YYJ0fKk0S4dvxGvb9MAFlOj8zO+aLwcO1HJZKzUar2k1Px11tvHMS+v5wsOX?= =?us-ascii?Q?s9RUhQKqg5fL9JDuwd2I10+jTukKw3RIqG6bOCYUp54Uv5R/RpY2ylBU8DNg?= =?us-ascii?Q?SxkY8u/c0W9WK3OcnRElh0UPSJ6bGbeSrlayL/Hoi8q7UAK0fXLjFlXJqWiT?= =?us-ascii?Q?QF4y47FFt/G0v8JK85pNyPSMWZG4Fwj4cbCSqyr/NwGXePd8I3CkOt/YKUuD?= =?us-ascii?Q?HlU6Yf0E0JKHx9gUEPt37y/JazB+vo6WL5wNBB7Yg08zXhb6VQGNSphhg8nR?= =?us-ascii?Q?ZMXOaJH86xUc+PsVsE75JI0gfWK+0y34jPz5yw622jKGuzvJN3Tn3ZHXL8GK?= =?us-ascii?Q?lYbZbKOvj0aut/U2I+niOlCDCiDBfK+QyxbMgyF618dnhozUCPqryUlQkTJY?= =?us-ascii?Q?F2ismo41G0xsnv1zfJYnt6WHkLDt2YjOkorG3zjI+HVhBq/LUxUrpEnThNw0?= =?us-ascii?Q?UMMUFWeLUL2iw2ecuzFH1CXUkiOebhei11V462Jz0MPFzJldGgrSZIc4PEwf?= =?us-ascii?Q?o8nM7ZsOPTC9DWsoMM7YB5JIBIbzO3J6UgI2AHUBe1GnOPKfg5XC9Y3BE3k6?= =?us-ascii?Q?tWl3Gr/QoSxjHTE2Ue2h+znMU2LsbRQaobHsCbGdlZ8xFBusiEaUvMBNWEHi?= =?us-ascii?Q?/qjm6PvsC/PK16LfBJd/FCeCCXsL9s5QpTaUMcv43sW2PWJLRSF/PbcWzKan?= =?us-ascii?Q?f3hKT8XI7XvWL0vFwB4MT9zwL+mIbAY1Yxc0W7A2kBvEINa3wDUdr9Yzxm1s?= =?us-ascii?Q?pbEzChcf+bGiFgJiAV+SOKwXoyUOKr65DMrculJ6bmw//Wiox6rorqqv5nWs?= =?us-ascii?Q?HdsGqA6jGHEHzqvIEUpPXYi2bYdk0FIKvdhGZaTrzF7KcX8kw3DFraT/da9Q?= =?us-ascii?Q?7TxCwjYx8nZdyXK6oFIZEu+xW0wIGd0dvMwfZ1cgZRsTSQ5hnaU8Rpiavn+l?= =?us-ascii?Q?Y7sEqmnQ3xiECXD2sBsPZYBeXAt342KxdrhaBufQ6AKbS7odn7ffGRN7Tzjj?= =?us-ascii?Q?g3+Pw1T1X0R2Z7NY9i+goEGjb+Jx3T8gm0buWIrph+3cbcMTq22S/IsQL8pL?= =?us-ascii?Q?hrCDGk/hRyeve1uBpenV2z1+hZf45Eo1e55oJsT9LlBnNN+dNtSgC0XQYXGA?= =?us-ascii?Q?EkY2U6o9ocVPviifUGK03d6DN/PjCT4hpsmGOgtx3mdjSbYfG2EzoOsYg++0?= =?us-ascii?Q?ENJ5HJUwSbYgAK5Fx74ti2hNqOkl+BVl/7HwFgj5+raK18uyBw08n02lxUOi?= =?us-ascii?Q?1iBhT3LirndFf22NQQM3fNV04HG9TlM14I2b2ngXqiHd+U0wImedWXfCEJtl?= =?us-ascii?Q?Pqk/Yv6TAn7RIHf2UUVAfNiZEYUpUMPst8s1D8Loj0WP3i5UbtkLDMl4Ofue?= =?us-ascii?Q?n0BW2KSxKBf0Xr4JD+VcCIU=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4747.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88cdb4ab-d4e1-4c64-b165-08d9dae88e66 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jan 2022 01:11:00.5217 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZouDdGdCj9XqC1oE7SWInJcMjmDSWSK7eGGtNj67TQQrNuZ9qNHfww1D3w9Li5uUvIlTDyi4PgYGJR1Ednsxsg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR11MB2663 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed as af5a7863ff..a16d6344dc -----Original Message----- From: Chaganty, Rangasai V =20 Sent: Thursday, January 13, 2022 9:20 PM To: Oram, Isaac W ; devel@edk2.groups.io Cc: Gao, Liming Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 06/27] S3FeaturePkg: Fix= all relative package paths Reviewed-by: Sai Chaganty -----Original Message----- From: Oram, Isaac W =20 Sent: Tuesday, January 11, 2022 6:20 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-devel][edk2-platforms][PATCH V1 06/27] S3FeaturePkg: Fix all= relative package paths Packages should be at the root of a PACKAGES_PATH entry. At some point, paths were relative to edk2-platforms/Features/Intel which w= as functional, but interferes with the proper functioning of packaging tool= s. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Isaac Oram --- Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.fdf | 2 +- = Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc | 2 +- Features/Intel/PowerManagement/S3FeaturePkg/S3Pei/S3Pei.inf | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.= fdf b/Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.fdf index 3cd5cd9628..34caf3dacc 100644 --- a/Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.fdf +++ b/Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.fdf @@ -7,4 +7,4 @@ # ## =20 - INF PowerManagement/S3FeaturePkg/S3Pei/S3Pei.inf + INF S3FeaturePkg/S3Pei/S3Pei.inf diff --git a/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.= dsc b/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc index 312870981e..f94bd2b431 100644 --- a/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc +++ b/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc @@ -91,7 +91,7 @@ # in the package build. =20 # Add components here that should be included in the package build. - PowerManagement/S3FeaturePkg/S3Pei/S3Pei.inf + S3FeaturePkg/S3Pei/S3Pei.inf =20 # # Feature DXE Components diff --git a/Features/Intel/PowerManagement/S3FeaturePkg/S3Pei/S3Pei.inf b/= Features/Intel/PowerManagement/S3FeaturePkg/S3Pei/S3Pei.inf index 46fbb62a46..e485eac952 100644 --- a/Features/Intel/PowerManagement/S3FeaturePkg/S3Pei/S3Pei.inf +++ b/Features/Intel/PowerManagement/S3FeaturePkg/S3Pei/S3Pei.inf @@ -23,7 +23,7 @@ [Packages] MdePkg/MdePkg.dec IntelSiliconPkg/IntelSiliconPkg.dec - PowerManagement/S3FeaturePkg/S3FeaturePkg.dec + S3FeaturePkg/S3FeaturePkg.dec =20 [Sources] S3Pei.c -- 2.27.0.windows.1