From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web08.2059.1623370359569497983 for ; Thu, 10 Jun 2021 17:12:39 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=q+u0mg7m; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: isaac.w.oram@intel.com) IronPort-SDR: ccyV+L3H3ARDCE0tN4Z57coHMYP+vFZz9PyXcIK5/fAgmYKJgNmVKp59Ja/GNxIjQimS1L+OTO ohRrWUxYQksQ== X-IronPort-AV: E=McAfee;i="6200,9189,10011"; a="205393787" X-IronPort-AV: E=Sophos;i="5.83,264,1616482800"; d="scan'208";a="205393787" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Jun 2021 17:12:35 -0700 IronPort-SDR: 6MomcpwKB30CA45yi8KTuNLfISCTN5tA3SjDaa0fvOZT8RP2fiGxyJHxaKRmMvWLlmH4y/INn5 7ZUXBYdU8oiQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,264,1616482800"; d="scan'208";a="470451752" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga004.fm.intel.com with ESMTP; 10 Jun 2021 17:12:35 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Thu, 10 Jun 2021 17:12:34 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Thu, 10 Jun 2021 17:12:34 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Thu, 10 Jun 2021 17:12:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DpDYm0x+H3Z6+gndqlbhNl6qdnrkldPcaYbgz5OWnw3TtNXbKGyRewBhv+IeHeV1EVvyB3UrxFHCkz80+ayHe/eKhhqc8+sDPgcv8zqnkZfGFhy/XqdLFJ+FqfuANCVZeyCr9aivfiko7Ew6lRhcGiPKUEgQNWMliMFp6tBm0Wen5Ipi6SCtlJoHkfXAi/i/eSXKVSqtWjuSbzO/v3jQZ5BtirAQCmwiFcL3ECi75u/00fzkKe03itKLy/z7hY6iy3a2TsWsiTgkVc9i05py8V7nrFHWMtLKUzgLgO1Xg3t25190yO/uWfwTBnRsuOq5aVbksdqzzO4gbyttZJ64jw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M11mSbJBEf1wtFk++LYzNxrgPpwlIofHG2VRbHobvYY=; b=GAWlmrPkg2pYH3U+v8yS7csYvvym3G0CKEMpNASo8Um60k9a7kcntA2sJss1skNk9Hs2Df+HgxIhrcXsJfRes3TKsQna8K91HDu/WToE6ZhaX6q3H/fziQHTlB+jkNXCQKhCbwYotM9CxMtG0q4HFsFMjWNXP9N1rBBFhqO2meuvI30bWHDDmOv/sZG2fgSEx3ce04MMoErGTPbNE8zSviB44hL6HOVmgSj5JHJuoiaRGA//eDrF0naAWxNM8A/gwLlDP4l+viEFlubEBG9Sz6p2g42dLaXrl3vVoaQ8umAub8LmY3iohOezEbr7WQNak+Xu0DfDWQgxlErCZbpw8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=M11mSbJBEf1wtFk++LYzNxrgPpwlIofHG2VRbHobvYY=; b=q+u0mg7mSew6b8+ksvFxsxj9ph3iac2KSwqf43zUMNrKFdQDjlUHpHYU312MLVRjPZSmmuXLHcgKoT3QhlDyHv4O4sjGVTluo91wjMDoG2ZEnI14EncHV6BUjHtjGyawt8YLADhV2FS5+pxXlDhJTMPfpG95T4nJvFhbxYTVozs= Received: from MW3PR11MB4747.namprd11.prod.outlook.com (2603:10b6:303:2f::11) by CO1PR11MB4980.namprd11.prod.outlook.com (2603:10b6:303:98::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4219.22; Fri, 11 Jun 2021 00:12:33 +0000 Received: from MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::bb:85ac:3e3d:11fa]) by MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::bb:85ac:3e3d:11fa%3]) with mapi id 15.20.4195.032; Fri, 11 Jun 2021 00:12:33 +0000 From: "Oram, Isaac W" To: "KARPAGAVINAYAGAM, MANICKAVASAKAM" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Felixp@ami.com" , "DOPPALAPUDI, HARIKRISHNA" , "Jha, Manish" , "Bobroff, Zachary" Subject: Re: [edk2][PATCH] MdePkg : Add IPMI Macro and Structure Defintions to resolve the IPMI build error Thread-Topic: [edk2][PATCH] MdePkg : Add IPMI Macro and Structure Defintions to resolve the IPMI build error Thread-Index: AQHXXlIsW/Dyi2lE6UucfpwHjQUZ7qsN7Iqg Date: Fri, 11 Jun 2021 00:12:33 +0000 Message-ID: References: <20210610234121.7409-1-manickavasakamk@ami.com> In-Reply-To: <20210610234121.7409-1-manickavasakamk@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action authentication-results: ami.com; dkim=none (message not signed) header.d=none;ami.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [73.67.210.78] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 8ce562e9-b657-4032-10ec-08d92c6d9c3d x-ms-traffictypediagnostic: CO1PR11MB4980: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2RBOIHy2N/Ua+S5wNJQxa7m70NIIkwRafD5z7z0Ue/urg1i+NMD3iUrUTJov+Ih5JJZFjYdcL4k3Ib614MTESPWr6Y3tb/WKLJG4ysRq3HRkAPhFVEWpIi4MrnYZDnoDaAv9jvW7vWWuFV0CJvaHxWb/GDSaCjsUiPCOTTe2WG2/OAVw4eEm7dD8Sob6rDz3SdvmLUk+5EB7zk+UhLom8SNBR/re8TAPMUeMUqfnTZbFGFtS5SYqE2J10lhHt66JyGQZiN+adEzHYlMnit5V5PrASLoDFfNUIyE9xot51OiILk+r9FjOn4ElzfP6BXPtjN67C0BNh54KfPOjbphV2RpBotiYniO4G8evUT4hmIHkyFFQ5edSvseS66jwNtlFH1u/87ouQWL/Zi+e/YM5yRZCiwxStUj9DvevQyKtLPb/ce4ORGR33lcVF4tjBdMTepJWtZyAh7T8M8GC8xHxToQEoCZgB4zzS5V+pvACFr0RyrfHZlpDNHlGRQnAolr2QG7IloKNHlBba8Vi7j0q3TvgU+PF8N+evS6qF15dj55bjL8cSWgiMxg7pLGhQAutxgYTcmwHUOAzu0lYduE3qoKqimMkfo7zf/1k0DylejY= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4747.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(39860400002)(346002)(396003)(376002)(366004)(5660300002)(83380400001)(8936002)(76116006)(86362001)(110136005)(54906003)(7696005)(33656002)(186003)(122000001)(26005)(52536014)(9686003)(55016002)(53546011)(8676002)(71200400001)(4326008)(66946007)(64756008)(6506007)(2906002)(66446008)(38100700002)(66556008)(316002)(66476007)(478600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?5srMe1bWP51FRnXgpKlrRblU5dS5F33QWEoAeOnmyjTUekUKrCLW6200DALn?= =?us-ascii?Q?CmuVK2XzwjOj/oig/dhVKaScWdTUt4pQBi92gVOGBjWc35IG9PdxNIPrauYc?= =?us-ascii?Q?U9/+OJ+LnhDoxkBXjZxzYq3x4SctW/C2eHZd+Z57tvONjpO9fwS3tl6fufgC?= =?us-ascii?Q?KvD4gX6hE4F1MkW4svsyN13zG3MgG4FB1KkApEeaGqabxds+chnJAF45s7t4?= =?us-ascii?Q?yOWQOaXz5EhCoH3Eeh1Il9uNQYWBa5YfUiEhvgLhnSjP45IW8DsLUjCudmg8?= =?us-ascii?Q?YbjlHj2mhcJ5kbI4Vyr/lKFQ3U8FWeBDoOV5nh/2Tuc6/CBzfmg9YpVWMMGz?= =?us-ascii?Q?qsu4u0EQ2t4K5F/CJjYi9u/CpEKIlVXvBiJ5ZTqO3A2PQODZJQArl62Vzs32?= =?us-ascii?Q?G079BkH59buWdHYrHAfWZhnLn5gz1uMTlQlbPKDFyLMEixEJCQB0+zD7V7s8?= =?us-ascii?Q?GQYqpfw5cCDnR1BLDrWpQIn7rWmUNnmg5Q97YfO9tIkLX7fs++7nqsOV/97/?= =?us-ascii?Q?SVCskCuHr6k2mb9v1vRlct1LcAgBlgNKJVgdsD2MAnIlTdgosQbcOXoLWM+t?= =?us-ascii?Q?WRWC54BBEKmg25SL6/rg9qJjoBQTvOYZ2RUyFWUqkMXgoob2ZQUbmIXn04kJ?= =?us-ascii?Q?pMh+u4fnbNP3xTJ/6DW9zcwF3qfAhxpOJYPtSSOuBWQ+Zn3eM4EU7UNz98jN?= =?us-ascii?Q?eNfD0V1xfXacc0wycJCB3B4QYfoPe0lMfKaw8zRDVJp/TASCrAISAHUylgLt?= =?us-ascii?Q?KHMXuAjP13fXUkn65yakFI1Xtz07wZ3Zma0P4serNs2h3MsBS/U7Mfh8VFjW?= =?us-ascii?Q?Dp56I1Dbw7CiKJcFru2CdjMUbvNQTuRt4fORlkZGwVpNQlEmjJvpySQDYNi7?= =?us-ascii?Q?xI7+nAOMeqfJ9CdXwrWq9eU93iRypyaiEUyJ7vQ0Sz9wUmAtAKDoJMrCYb1A?= =?us-ascii?Q?5vs+T4OOiNffU1mfYsm5kLQZDU9ol/yiVAAotShIh0L9G88IGATzSNYWwgR3?= =?us-ascii?Q?/whP4fVrH0U9ZvbpD2MrsVtvxnwZ/XQN5U9dScXykZkpHb9vImBm+p9pkN+2?= =?us-ascii?Q?4RmEd2Wv10NKBXMK9koXbZFFJm9Bj0FZ5qqjHXzC3APJQod7R5kO54wIxSoa?= =?us-ascii?Q?BaTa8ZS1yX6yHYacAgX7gp/jRWmTki8kreSgNnRD+6Ms2r7XM7SB3i5hWn+S?= =?us-ascii?Q?nXkepx7MfnnrCAh7vOFC04z8ATRTOmooQevzWLaaqonVFrLQqzAqjOJHW9sS?= =?us-ascii?Q?w5gZpl8hgHTrscYEsUTdVgNb9BT50oXNcQumvwK76wl7w+Upov/lhghzr5ZH?= =?us-ascii?Q?Ctc=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4747.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8ce562e9-b657-4032-10ec-08d92c6d9c3d X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jun 2021 00:12:33.1770 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YD2wnrhBshS+o7A/p97IOQR9fGU+zvleVRpXVUTW4BjGa6DAV5fpvvMSPQnGpSE9t/p0JWga7o1gHIvJfej6gA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB4980 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Please comment the following commenting per normal style /*-------------------------------------------------------------------------= --------------- Definitions for Get BMC Execution Context ---------------------------------------------------------------------------= -------------*/ Which would correctly be: // // Definitions for Get BMC Execution Context // Please don't use EFI_ or Efi prefix for items that are not part of UEFI own= ed specifications. Please correct: EFI_IPMI_MSG_GET_BMC_EXEC_RSP EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT EFI_FIRMWARE_BMC_IN_FULL_RUNTIME EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE =20 and any uses. Thanks, Isaac -----Original Message----- From: manickavasakam karpagavinayagam =20 Sent: Thursday, June 10, 2021 4:41 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Felixp@ami.com; DOPPALAPUDI, HARIKRISHNA ; Jha, Manish ; Bobroff, Zachary Subject: [edk2][PATCH] MdePkg : Add IPMI Macro and Structure Defintions to = resolve the IPMI build error Build error reported for missing structures IPMI_SET_BOOT_OPTIONS_RESPONSE, EFI_IPMI_MSG_GET_BMC_EXEC_RSP and macros EFI_FIRMWARE_GET_BMC_EXECUTION_CON= TEXT EFI_FIRMWARE_BMC_IN_FULL_RUNTIME/EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE when using edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg --- MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h | 4 ++++ MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h | 19 +++++++++++++++++= ++ 2 files changed, 23 insertions(+) diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h b/MdePkg/In= clude/IndustryStandard/IpmiNetFnChassis.h index 79db55523d..d7cdd3a865 100644 --- a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h @@ -186,6 +186,10 @@ typedef struct { UINT8 ParameterData[0]; } IPMI_SET_BOOT_OPTIONS_REQUEST; =20 +typedef struct { + UINT8 CompletionCode:8; +} IPMI_SET_BOOT_OPTIONS_RESPONSE; + // // Definitions for Get System Boot options command // diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h b/MdePkg/I= nclude/IndustryStandard/IpmiNetFnFirmware.h index 2d892dbd5a..1c692cc792 100644 --- a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h @@ -17,4 +17,23 @@ // All Firmware commands and their structure definitions to follow here // =20 +/*------------------------------------------------------------------------= ---------------- + Definitions for Get BMC Execution Context +--------------------------------------------------------------------------= --------------*/ +#define EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT 0x23 + +// +// Constants and Structure definitions for "Get Device ID" command to fol= low here +// +typedef struct { + UINT8 CurrentExecutionContext; + UINT8 PartitionPointer; +} EFI_IPMI_MSG_GET_BMC_EXEC_RSP; + +// +// Current Execution Context responses +// +#define EFI_FIRMWARE_BMC_IN_FULL_RUNTIME 0x10 +#define EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE 0x11 + #endif --=20 2.25.0.windows.1 Please consider the environment before printing this email. The information contained in this message may be confidential and proprieta= ry to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephon= e at 770-246-8600, and then delete or destroy all copies of the transmissio= n.