From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web12.3336.1651527228559586696 for ; Mon, 02 May 2022 14:33:48 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=MDY3ZROs; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651527228; x=1683063228; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=il2cVykZ/u0+cYc4Krou9WpvWT7+n2UX+6AMf+FEbH4=; b=MDY3ZROs/tcgaYV1c5CjKZlUDb6DMp23bN/lFHjA2nFo8p/3S8ZtksLO s3kn6LlzY+j++dLLxlLjDs3CCCOCzMd313lxedNFdqTJQi6fr7sVLkhNR alHTR0v8PjqcswoSdi1amBiwPQqYWqAD/lGUzqGPkQoCkXZRzbJGScCC+ 3NsVfIvv6Bd4Fyr98Ucjwd/CKtIP9DwQRqvIPmx8DhIbEBh8kAzXWykcn omo4/t+hbKZV3K1OO+AeFU4WLEvlepWgwbW/eZt6xyZ8xEGpi3/yjXaMJ Bdb+i0tt545gE7+bXr0xv8BctemvIQO5WSoBsb23wS24XV6RaXH9cqPOI w==; X-IronPort-AV: E=McAfee;i="6400,9594,10335"; a="247243103" X-IronPort-AV: E=Sophos;i="5.91,193,1647327600"; d="scan'208";a="247243103" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 May 2022 14:33:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,193,1647327600"; d="scan'208";a="663706742" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga002.fm.intel.com with ESMTP; 02 May 2022 14:33:47 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 2 May 2022 14:33:47 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Mon, 2 May 2022 14:33:46 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Mon, 2 May 2022 14:33:46 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.175) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Mon, 2 May 2022 14:33:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XO86/toFpA/iyCK32K/mnIf4rz8RVgJAq5bJvlAb95r1l+aLwKCxDoCpQPSJgzRaJcfy3G/r8eP9N2m4XGm7f5JDDQqOIJw9uPUlugM5t6eH84yAGu/+TGrLmpTxt0mSjCZxDX/iCcn9N8icqq4HLS59g0qPddBwtDWg+BYaB/5USZSU+0NQmNsvMfwV5XPqpYx4atwAUbCzMMcTr+P6/r/Yu7V81xicKRp+S7mpo8pe9HEXnuMoQXYU5cStMXavxxIr2Fn/78QuDHdMAIO676RnWhnF3e9Jqqr1rH59iG9OGGVi3A+jxcfa0TtdvGNzf/UdfxC1TDbV7L4RN3FvFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=el9ax9wg6PWGK3XkG5xdmnv6YvZWvdcxl5emXnAHJWs=; b=TXudYodG25AArM4HkLcU+arV4vjA0gqOSXDh4ngngHXcKKCZB7jFqYyR+b93fbr4vmtnjczlZVFqS4tWCIP5MOf2k8KZpQkJGmZrHKSaWlGTvlRCgFALGJ0gtOcBcC9J6B6vWxCIbY8fduh1OOv3KiaYQ2ToduoewoQDQNAt9QmJMyep0EYsyu2CbhKe0bfktjYOH3Cv8BU12uS3M2NQjgcCNRqz3b9ezaWNZJSHEU6aaZoLMOxkEeZvZzmwC7L80fLNwvxyJVkCnUQUfys0GlxISeNfYn6yvWffUCYD+7sWVxZhreFwhPQEiyF9j/hmbw0C/oPolexPYGwx7tU9hQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW3PR11MB4747.namprd11.prod.outlook.com (2603:10b6:303:2f::11) by DM4PR11MB6020.namprd11.prod.outlook.com (2603:10b6:8:61::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.13; Mon, 2 May 2022 21:33:16 +0000 Received: from MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::50f6:afc6:f825:35ea]) by MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::50f6:afc6:f825:35ea%7]) with mapi id 15.20.5206.024; Mon, 2 May 2022 21:33:15 +0000 From: "Oram, Isaac W" To: "Desimone, Nathaniel L" , "devel@edk2.groups.io" CC: "Chiu, Chasel" Subject: Re: [PATCH 1/1] WhitleyOpenBoardPkg/Build: Fix GCC build issues Thread-Topic: [PATCH 1/1] WhitleyOpenBoardPkg/Build: Fix GCC build issues Thread-Index: AQHYXArxTBIgK8Ppc0GJbpTZJxuX7K0MFU5AgAAK+6A= Date: Mon, 2 May 2022 21:33:15 +0000 Message-ID: References: <20220429205124.1530-1-isaac.w.oram@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.401.20 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 05f08b5b-aa33-483c-4641-08da2c835e36 x-ms-traffictypediagnostic: DM4PR11MB6020:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: q+wvhVPvKUWkB+oTu/8te9Lx+cPEPnwuFWdOSptOhxgU4q1IjhOMwh6Zzl5mcsdw4FyVacUL1Q2n7vIteBrtOhguHK8p4p941YQsmlF8HBnB+mmipxzqOxZUne1138ZlAryDQyqc5m51i2MFKWty4Moa5bwjNXVZ6eMaIgywGr98UVAmCGPMjHQvBZEWpd/GtnvE+FLS5KOIHqD92Ne6E2xs11j3i8WBZwqKrtYImapLVZPJh48wbiFxJh3K+dxGWgrWCz1HA+k2YCE564WYfz09zgZQZw8YIeMqIyZIEFHfznRPPgKBImwZrFtN1kWHb7AvdOHknOxn2H3V1iqJVtRP04kU2GYTXivFpsNDgjzO2TY0JElfHIMJrmDCZiE/sicCXBmayjSuQ/w3d2OX+3WlfH6Mf7jkJOqjjVIwAS94FusGiySAS6ml5ussiUstLAfOB9KYduKbxl86Kdxe8+uo8sMxe/gDuUuYUWH258jwjhTWr9nijLqL+4URGaBoZ0LZqf0/STVppfAnt5SdGbsKj63AVl8HbnFfSK73RYyylxLiJgfrv1bUeRzEdKQ3fSX9hYopLPUe2R8wby/0EYv8kYh0Jl7Gj6Axf6W1T8aBrd42nN3gnWVgyNZacsbhA7ptEgnNcVNacTXd2Eo2c9pukichuJ0afyvZ3xQFUTDyWhVtKYFxARLD4Vg77dHX1P7xpEtiXjDeeW6AOY44yg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4747.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(66476007)(7696005)(66556008)(53546011)(26005)(76116006)(66946007)(6506007)(110136005)(71200400001)(9686003)(107886003)(316002)(508600001)(86362001)(82960400001)(186003)(83380400001)(66446008)(38070700005)(122000001)(38100700002)(64756008)(2906002)(55016003)(52536014)(33656002)(5660300002)(8936002)(4326008)(8676002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VcZoiHq7jGLJlK78lpZFTYimTSzX5nlN3gl7Dz4FHg1fbqmAu54qfD8j2/UQ?= =?us-ascii?Q?1PORm8oXr1N6ZvyoeuyyWDcjq+43j1GamOZ2bd4ioRb7qM8aJq4oHxm51GH/?= =?us-ascii?Q?RwAjPK/G6Jjf0eDrcq+dzbX13Bfp6wBo7RIvFqAyypfpOW4vdwema+ONTsJT?= =?us-ascii?Q?tuDuFm9g6DUy1t0rLt1OM456Ow0pNNuE9wVxS5dsk5nTQAEYYrmseSb0o57J?= =?us-ascii?Q?X1QWBK0vD/H9gwT0nS0rK7mTr8M9VRGVi2pNj6K+QYS0XBWTlIsX1xdMe+os?= =?us-ascii?Q?ux++pQOXHxNAbWPYTh8UetgB9pToZORDq67QRiz7m5YRcT5sNRMUq5ye6Jk2?= =?us-ascii?Q?RbCUPl6Q20snEjn0EbW8qwo+dhm5pXYxhjIf9I5VYE3+uz0v6M0+JYeYDTpH?= =?us-ascii?Q?eU6HUi0YmJKPS6UmirXer5Fb38yevhDlPC7ppbxB1ilV5PriLEH1hDtYpO7g?= =?us-ascii?Q?WpKza96UPyR164oebiciYSzVRGYeET93p3nJubJN+H29MaofUnTeUyrpDEMX?= =?us-ascii?Q?LZaq3Gf82/FiHKJ35bnSV/2lkN7S5eCl3JO6gX4xRGSZrBDAcNQ0KwMsvaMc?= =?us-ascii?Q?MPQjRhuN3S0pLYdLn020CDHM6m7hrx+TtBTYLyN1+o4F1ASF6/Z0UrmAG6yN?= =?us-ascii?Q?LrvrmWx+c/qDyvvORoCjxp3WOgXRyHTYrGMCsr2ldVzucILQrTgYZu2DU8gO?= =?us-ascii?Q?vg7WzgxWCA1HtRrnkRca+UJZixf2tm34tWZBPVXMKSKxpgC/vZQo06PicY+Y?= =?us-ascii?Q?FrvOgQEw0BAtw9UtaSQm6ctqgzMgmsZDaLYi7kgEXGJDXqG2Bwty0M0nUEB2?= =?us-ascii?Q?qMZ78gBPtM2HwKrYp9Rv33Tc8I8QSiTwXkWcvx5DxZOplFuH6k1ByxqkwKHc?= =?us-ascii?Q?rItr3ewQcVHGYY1MKYcnD8o2vSjRgrhR1VcRHcySkZK/Ov2My6hNLl0Sa9VU?= =?us-ascii?Q?6Y4enIDkZRmtJIPDt4GRlWsvNyTrD0n+Mfb1tiC6xYGBTUQbFG1K73iU8XyV?= =?us-ascii?Q?KGabiho37MooEiD+pOOAs0JGVKLCLH5/+tOv4+e43xwZdMEQptR4bH5QxsJO?= =?us-ascii?Q?EwZb4RxX13y69N3kkAOE09g/kBDyjXdfLDA98lv+Xtkr916TnpB6SboWYiV1?= =?us-ascii?Q?yGv8QnfiH7iiTay75F280PxlDHRfp2e17b9Fd0mp1T//p++fzdAaJoW92tKU?= =?us-ascii?Q?DtPVJoywxO4rIR7ZIMWuquss0MvQZtL44WXcYz0g6BjdpDMssU1OAZ7AH/8R?= =?us-ascii?Q?5PdbNIbO7RSZDObYlXqD1O85ou+a+T4k/bdI3E5E35UIkMD87+uxo22Wkuc+?= =?us-ascii?Q?/H2yPD/cqcdCrO+uqcz4vZgicOmkcptIm1yRHgNg8I2kaMj2W/lHWn+H7lrC?= =?us-ascii?Q?KhvSWqm9nGGwRlgruX2X5Nhirn6JjBNApwX1Svx/LcK7UkzzcQaXhEVL+wRB?= =?us-ascii?Q?AWt9smyYq8bOyCXUXrvplwa1r/tXQ0JnZN+mUoalH2e8OSjbTGF0ZCVlKT3w?= =?us-ascii?Q?1AL792n36MB+vwkHexZO0W/Kix/uC4XBdUetsuAeqHBU9mQbYSge6O1rN94l?= =?us-ascii?Q?QFtcEaAGWQBgJHL9DyriFxcHNb7IBkMtQlEQAPw9QlMvTsISz1wJZ+LG7SK2?= =?us-ascii?Q?Ol8TWABQdIGcT+sEkyxUPY/Po1QOrallMSNiikoiydygacdBY2SBvZ48zfOW?= =?us-ascii?Q?TZ/ZHI5WOLZcFERKQnbfvlZpni4LZ54YwqFVUS6vywbm5+UtFlgcCMw3bQ/U?= =?us-ascii?Q?SpqNRqJPvQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4747.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 05f08b5b-aa33-483c-4641-08da2c835e36 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 May 2022 21:33:15.8830 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mMUbApcP8YeB3EPguY/CIkxE+ukIutxFaX1z7zr4pHDtF4ksHdmLYgznHMk5ZQe6rHp0SRz5lgW2lzJ+ejCxoA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6020 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed as 38855c561f..6b05b8acd6 -----Original Message----- From: Desimone, Nathaniel L =20 Sent: Monday, May 2, 2022 1:54 PM To: Oram, Isaac W ; devel@edk2.groups.io Cc: Chiu, Chasel Subject: RE: [PATCH 1/1] WhitleyOpenBoardPkg/Build: Fix GCC build issues Reviewed-by: Nate DeSimone -----Original Message----- From: Oram, Isaac W Sent: Friday, April 29, 2022 1:51 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Chiu, Chasel Subject: [PATCH 1/1] WhitleyOpenBoardPkg/Build: Fix GCC build issues Fix build warning in PlatformInfo.c. Fix script invocation issues in build_board.py for AML content build in Wil= sonCityRvp and JunctionCity. Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Isaac Oram --- .../WhitleyOpenBoardPkg/JunctionCity/build_board.py | 11 ++++++++--- .../Platform/Pei/PlatformInfo/PlatformInfo.c | 4 ++-- .../WhitleyOpenBoardPkg/WilsonCityRvp/build_board.py | 11 ++++++++--- 3 files changed, 18 insertions(+), 8 deletions(-) diff --git a/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/build_board.py= b/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/build_board.py index 72d0c5089a..ccf7a8c55a 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/build_board.py +++ b/Platform/Intel/WhitleyOpenBoardPkg/JunctionCity/build_board.py @@ -62,7 +62,8 @@ def pre_build_ex(config, functions): =20 execute_script =3D functions.get("execute_script") =20 - command =3D ["build", "-D", "MAX_SOCKET=3D" + config["MAX_SOCKET"]] + # AML offset arch is X64, not sure if it matters. + command =3D ["build", "-a", "X64", "-t", config["TOOL_CHAIN_TAG"],=20 + "-D", "MAX_SOCKET=3D" + config["MAX_SOCKET"]] =20 if config["EXT_BUILD_FLAGS"] and config["EXT_BUILD_FLAGS"] !=3D "": ext_build_flags =3D config["EXT_BUILD_FLAGS"].split(" ") @@ -79,7 = +80,11 @@ def pre_build_ex(config, functions): command.append(os.path.join(config["WORKSPACE"], "PreBuildReport.txt")= ) command.append("--log=3D" + os.path.join(config["WORKSPACE"], "PreBuil= d.log")) =20 - _, _, _, code =3D execute_script(command, config) + shell =3D True + if os.name =3D=3D "posix": # linux + shell =3D False + + _, _, _, code =3D execute_script(command, config, shell=3Dshell) if code !=3D 0: print(" ".join(command)) print("Error re-generating PlatformOffset header files") @@ -109,7= +114,7 @@ def pre_build_ex(config, functions): os.path.join(config["BUILD_X64"], aml_offsets_split[0], aml= _offsets_split[1], aml_offsets_split[1], "OUTPUT", os.path.dirname(relative= _dsdt_file_path), dsdt_file_root_ext[0] + ".offset.h")] =20 # execute the command - _, _, _, code =3D execute_script(command, config) + _, _, _, code =3D execute_script(command, config, shell=3Dshell) if code !=3D 0: print(" ".join(command)) print("Error re-generating PlatformOffset header files") diff --gi= t a/Platform/Intel/WhitleyOpenBoardPkg/Platform/Pei/PlatformInfo/PlatformIn= fo.c b/Platform/Intel/WhitleyOpenBoardPkg/Platform/Pei/PlatformInfo/Platfor= mInfo.c index 0065819d83..439ce357f1 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/Platform/Pei/PlatformInfo/Platform= Info.c +++ b/Platform/Intel/WhitleyOpenBoardPkg/Platform/Pei/PlatformInfo/Platf +++ ormInfo.c @@ -413,8 +413,8 @@ PdrGetPlatformInfo ( return Status; } =20 - if ((PlatformInfoHob->BoardId >=3D TypePlatformMin) && (PlatformInfoHob-= >BoardId <=3D TypePlatformMax) || - (PlatformInfoHob->BoardId >=3D TypePlatformVendorMin) && (PlatformIn= foHob->BoardId <=3D TypePlatformVendorMax)) { + if (((PlatformInfoHob->BoardId >=3D TypePlatformMin) && (PlatformInfoHob= ->BoardId <=3D TypePlatformMax)) || + ((PlatformInfoHob->BoardId >=3D TypePlatformVendorMin) &&=20 + (PlatformInfoHob->BoardId <=3D TypePlatformVendorMax))) { // // Valid Platform Identified // diff --git a/Platform/Intel/WhitleyOpenBoardPkg/WilsonCityRvp/build_board.p= y b/Platform/Intel/WhitleyOpenBoardPkg/WilsonCityRvp/build_board.py index 5f625f5f92..e2d32d3e13 100644 --- a/Platform/Intel/WhitleyOpenBoardPkg/WilsonCityRvp/build_board.py +++ b/Platform/Intel/WhitleyOpenBoardPkg/WilsonCityRvp/build_board.py @@ -60,7 +60,8 @@ def pre_build_ex(config, functions): =20 execute_script =3D functions.get("execute_script") =20 - command =3D ["build", "-D", "MAX_SOCKET=3D" + config["MAX_SOCKET"]] + # AML offset arch is X64, not sure if it matters. + command =3D ["build", "-a", "X64", "-t", config["TOOL_CHAIN_TAG"],=20 + "-D", "MAX_SOCKET=3D" + config["MAX_SOCKET"]] =20 if config["EXT_BUILD_FLAGS"] and config["EXT_BUILD_FLAGS"] !=3D "": ext_build_flags =3D config["EXT_BUILD_FLAGS"].split(" ") @@ -77,7 = +78,11 @@ def pre_build_ex(config, functions): command.append(os.path.join(config["WORKSPACE"], "PreBuildReport.txt")= ) command.append("--log=3D" + os.path.join(config["WORKSPACE"], "PreBuil= d.log")) =20 - _, _, _, code =3D execute_script(command, config) + shell =3D True + if os.name =3D=3D "posix": # linux + shell =3D False + + _, _, _, code =3D execute_script(command, config, shell=3Dshell) if code !=3D 0: print(" ".join(command)) print("Error re-generating PlatformOffset header files") @@ -107,7= +112,7 @@ def pre_build_ex(config, functions): os.path.join(config["BUILD_X64"], aml_offsets_split[0], aml= _offsets_split[1], aml_offsets_split[1], "OUTPUT", os.path.dirname(relative= _dsdt_file_path), dsdt_file_root_ext[0] + ".offset.h")] =20 # execute the command - _, _, _, code =3D execute_script(command, config) + _, _, _, code =3D execute_script(command, config, shell=3Dshell) if code !=3D 0: print(" ".join(command)) print("Error re-generating PlatformOffset header files") -- 2.27.0.windows.1