From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web12.5442.1644283963147800111 for ; Mon, 07 Feb 2022 17:32:43 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=MAJ/typz; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644283963; x=1675819963; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=Xg2R/LsScSXJ8wsZ75totTRq41oQfNBjA+dqEveWVXk=; b=MAJ/typzp21RLPl3n0ZC/9dOe/swRkf/NNw8l8ud8Q2J10p6Rcc7Qh/5 WouinFXOzg9S7yJaHEdviovOT/GhZClvBeBvTbWk0+jxSQqACiTdt0PpS QS+4uOBp37Nry6UqWUbOJe8oK2amYn7LQsBhS7CaTkAFG7RdfFTWbphtJ p32I0S/Jl9pBdPm2h8/lQ4V62XwZ9OZr6T/LnfXsQ1PnL55wRgZVHsdB8 w4jKu0bfSjFsucfJwmpEwTrHOjCAPkLcm5OtXvIfkQRNF14XI8jeUNGMK NqK+QWRcaBlvp1mWEt1ggbu5Ne4VkG3M5x1vDCUN1UkuNdwtJalltKgov Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10251"; a="309590821" X-IronPort-AV: E=Sophos;i="5.88,351,1635231600"; d="scan'208";a="309590821" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Feb 2022 17:32:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,351,1635231600"; d="scan'208";a="585026806" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga008.fm.intel.com with ESMTP; 07 Feb 2022 17:32:41 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 7 Feb 2022 17:32:41 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 7 Feb 2022 17:32:40 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 7 Feb 2022 17:32:40 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.109) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 7 Feb 2022 17:32:40 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R92API60wIzeRjfO3p/F8rA5DwmQWWM83kzmpF1zdRi4ToWayvdcqkRlNO0P7Pk1XrCoQYgifLSUv8VThyYzJGTclHZQdeKZ2V0btctxD3mi3GPITBFCRBHoPjB6oihaz1zyOYlLCmcDq525I3Tl3jYr0Z0Dt8QwqjqhuJSsR9yCmBhV7M7wF1Zxd+rVF1/6CSXvsj6l+etL8VRagf7Nd7yQovTUau0Ee5viW0sQmZbjYLt2vUb8gQgd+PImUHgmky5byY1yrWSh1/QrOOESpGP2GRhlbgwzBq9OB/PLh5w8PYNdotk7eNVc+3vkYl9DUJWxETp4dQ9ky3t1EWaC7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=M4+JG1WXRYFI5Gosmf/osuZUrpY0pg2kh7NQ93MPwDE=; b=DiWkRjuDuxAw/Z4Cpxys7gci9ApFA/SMSQrMJCVIg5DGS5ubKy0T3RfHtLhDKYe1U7bWZK9NeoENgScolLjg3fZkSGj6HrNCZ7ztPf8ixPWff/xNkDYvK46YpUOb6yI9aIWKNbUJ0tSMNOySMLAO7o7+mNmhVyxC0tcFXA55M2YLNjoQgGGbnUqCFE3DvAVOT2P6zNBNDQnldLoQbPk2CpTN6QAPuZUc/UdKAGEf8rlICF0lYaUtmwB1wbabeR9pBjXKVS1zzN1kmNs9q+kp76/neDZAACF3sg+wVhi6/Dd1H/CtlHBaMLupW2sNY/G0ftlKUc/4hsRMjx/MEspMvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from MW3PR11MB4747.namprd11.prod.outlook.com (2603:10b6:303:2f::11) by BN6PR11MB4129.namprd11.prod.outlook.com (2603:10b6:405:83::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.12; Tue, 8 Feb 2022 01:32:38 +0000 Received: from MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::9c36:57de:e967:55a3]) by MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::9c36:57de:e967:55a3%8]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022 01:32:38 +0000 From: "Oram, Isaac W" To: "Chiu, Chasel" , "Zhang, Xiaoqiang" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" Subject: Re: [PATCH v1] MinPlatformPkg: Install memory relating PPIs Thread-Topic: [PATCH v1] MinPlatformPkg: Install memory relating PPIs Thread-Index: AQHYG/pgSqpP+fg8b02qfve6ebpIxKyHzMcAgAD64GA= Date: Tue, 8 Feb 2022 01:32:38 +0000 Message-ID: References: <20220207081109.1094-1-xiaoqiang.zhang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4e79048c-f856-4727-c31c-08d9eaa2e45b x-ms-traffictypediagnostic: BN6PR11MB4129:EE_ x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5516; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pDer6z/qQ9QxCOTiorJyOcVkzq3pKa8ylljDEh9Gl4gSZpVth5MtFf1a5L+uIuBROx/jYN1GuNLmcyC/2ixfjw7yLOR+nsT1TeDdEI1SigfVpeWmGcws5NuolaUXcJtUwAaMWw8wHlywsYoHBkVNrVENbV5FozpFjt+ayUaDHqB6nVq20tzvJ4BorR6n4tvmPNY5pHGJYbdZg0DyjOpgQru6oF1WJAzUoCVO4kAf7yV6S132lFnLXxoU7lKja34d9XTiQXcM9ngv1OPFxaOtz3HzlHm5OBX6quXmE0mP2RU2WGypUsID0OVOOhkWFgvVMQ6bY3ziioQizctTY3Rz0G0H9ARpT1JmXPwpYNOrgPDlZF60Bwa+6tw0auJp8bNmmKH1o7dAzsILF1Fx34S2X1h/mUmHEdyG4TIT87Y8LEcruDA2qoJXVttSfMAGWRt4eS3b+JAcPjGqcjzQGT49jqI0+B1oJkRR++wpKjroaS01XTLFFG2iPwHC7Ls4u8UtYkJUIFAVDl0sMP6tGOy4O6Zgk+MEqHxUQ0BB1jm3AuuRIqdlAFlSanQt8fveUzqFf+UvSQQVz0MlELFzGvbCBZ2lCVk50nu/w56WVqHV1wFVQMI5wQkSLiGRLq5TcJzkTucw5tVlVemFrn6IkdzxTGB4pD9/4f5rT24VwZQuNY9ZlNZyR6l7MeFQwY4aG++x7kO4K/tLjq9I8QlmxG7GXpLiqIlZBoVF1bRcnRdnLbW6IdORPzX3UKossWvBz3fs+xC/3wAjiiY/FMC+379lx3dK0JwKB22T23fFE5gkyNA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4747.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230001)(366004)(38070700005)(26005)(33656002)(186003)(966005)(4326008)(2906002)(8676002)(8936002)(64756008)(55016003)(66446008)(66556008)(66946007)(83380400001)(66476007)(86362001)(76116006)(110136005)(71200400001)(9686003)(19627235002)(82960400001)(7696005)(6506007)(53546011)(38100700002)(52536014)(107886003)(122000001)(5660300002)(316002)(508600001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?DIh9zR5OqPnP07q1PaEBpBhB4LJ+6GCTUg+vlf3iO065o9mcR0gmqvZeggix?= =?us-ascii?Q?363jKd/4QAGPaTFRDEDmxOueauT/rM6qTaU35376gclQojjgMqsz656QKske?= =?us-ascii?Q?hMSracRmuE9mr/lSGzpUi2iOV+lFsfrEBmLLVuQHCunLqxKP7WHfEcqCZ6kD?= =?us-ascii?Q?5xKsQnlgcph5vmwDw/40XPbGDsL3IKnpy1VOd2tPfqOUd+0Ij8d2A3FgM7vs?= =?us-ascii?Q?BVFgorPYxeGm8r/0++T779SOS1z8q0Cfvnezf6McPuRbqvWj+ETvI9r+WI85?= =?us-ascii?Q?AopJNmHWBPwJllRqsNyH81CjJ03hv9TtwfOtuEE8wthspZjoKcxJkodnGsWZ?= =?us-ascii?Q?GHyJJhUQ2Q7ax/5pUfB82HtGi5/bM+0m28ss9Jh5H+1TKofh47Unwn4xewJo?= =?us-ascii?Q?sUZvcrPyqoi8p6r1JS+0z4NBjsSRgFQ9+j+/EF+1w0Q1ql5eYBa/kMRfyg88?= =?us-ascii?Q?MXAXtPpyCPDNlKoL1aALl5zWMVIvGK4NiOGLgrW7MSyop0gZJnV/zG1Ivo7K?= =?us-ascii?Q?96MRGRd0c8ivhy4xsgrrW4vw4IpH7+KnfKs3Bah31/SRTkJF5vMViioJaTTS?= =?us-ascii?Q?BwTSiLplxIL6wMpoNTzVA6hkhrshKJBsh6beRw9Qya2eIaRYEYISEyf+Nd0P?= =?us-ascii?Q?jltu0mO7jKa7U2+K1SeL3wRgIQ/B4UnIj3hDE/dQO/qEApPl0C3bvYbdPHOC?= =?us-ascii?Q?F0pnJkNas4x22WzzHaO1FnCyMZnwinZZXYg3oqYz8nLnQG+rLpwvCJchIWUP?= =?us-ascii?Q?uFsIs4WBBA6LO+CousAs2xLcSg3I6qAk7ylOwY5moAUrBoyGlXa0xeQk+TDQ?= =?us-ascii?Q?WeRvl3U5rfoIdsDRocI6kySHb1OCJB289VX40OFkZvRWfg6a8MOv2RZwY516?= =?us-ascii?Q?Sxglxu98ce3+UbdlSy4C3BksucQMHly157gHVFKaxqGJxZMdCs+5o6iFgvTb?= =?us-ascii?Q?omL4Ooip0dbvbbmKcKi6kDD647Sk9ibqwc47pfawWsahlJw1NFcdzpJ7eNPb?= =?us-ascii?Q?Hx78bxnveeuVGl9BfIfi/LVw4TqJEUS4r0HU7BmRPZ5d0QwQyVr37nwJ7Pqt?= =?us-ascii?Q?Cit1O6oQOTuPPcwx0FUOUey7TQD6OHcP4aZJ3ou8Wed94l7Jv8qHWlbmxR9y?= =?us-ascii?Q?3Cr0JV2rYAuBzm1STmYCwfGtNT+OTKXSlcGI+qRPgXoMoDSy6WHX48TZCILF?= =?us-ascii?Q?ht5IiGEsCwszUptEa8zDfj5oHKtlXGu6dx+qxstKoeh5QtoKtwBkF+FgANLW?= =?us-ascii?Q?lw9obex5kg/bINd/9IZSdXHdApI7UlYYsNjSzOoKVSE1g8/DDjao4OcQAKLF?= =?us-ascii?Q?bMyIocn/67On1EiO/48qCnvErOJKclNEPfjbyZg85YtH0aw94Mue4ieVIRGl?= =?us-ascii?Q?YCkb+o4DQIgyxOATIrPy83Kg7o3SRJtmYG+4UF7YsK0YQ5PBckKSSGfkmK7p?= =?us-ascii?Q?uyrP5A9kE/J0G1fbL6x7qdkcpz6BAFtFicYTjcd5kNSD+18GfFqJsl8seOwr?= =?us-ascii?Q?69DI+Lp0gm4DqjALV1yyBIfD2jvvIOCn5x7BosIYp6oboZ1eRYKUA9uNdWi0?= =?us-ascii?Q?ROe4wXrjeaARaKwDR/EZBh2BrkRPrX3Rt03AAFAtuvnvL6TqDOhYWMVFpbSj?= =?us-ascii?Q?OX71CFXtsVCHMiwI8r1LTM8=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4747.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4e79048c-f856-4727-c31c-08d9eaa2e45b X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Feb 2022 01:32:38.5206 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: NWNkY8BUn0vvNs2RyQL5IitJ+wOdwo+FWMEsSgruJTnX9c55qwkNgDucqOXzsGgLTUL/X9RpxWd3oOkIQZWHIg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR11MB4129 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable This has uncovered another issue that we should fix so that this isn't nece= ssary. Since UEFI native code is all about binary interoperability, there should b= e no difference between native mode and FSP dispatch mode. FV are FV, PPI = are PPI, etc. These two PCD should mean the exact same thing and this shou= ldn't be necessary. We will look at moving all the board logic use out of edk2 and into MinPlat= formPkg and board packages. Regards, Isaac -----Original Message----- From: Chiu, Chasel =20 Sent: Monday, February 7, 2022 1:09 AM To: Zhang, Xiaoqiang ; devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Oram, Isaac W <= isaac.w.oram@intel.com> Subject: RE: [PATCH v1] MinPlatformPkg: Install memory relating PPIs Thanks Xiaoqiang!=20 Reviewed-by: Chasel Chiu > -----Original Message----- > From: Zhang, Xiaoqiang > Sent: Monday, February 7, 2022 4:11 PM > To: devel@edk2.groups.io > Cc: Zhang, Xiaoqiang ; Chiu, Chasel=20 > ; Desimone, Nathaniel L=20 > ; Oram, Isaac W=20 > > Subject: [PATCH v1] MinPlatformPkg: Install memory relating PPIs >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3824 >=20 > Install memory relating PPIs for EDKII native build and FSP dispatch=20 > mode >=20 > Signed-off-by: Xiaoqiang Zhang > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Isaac Oram > --- >=20 > Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPr= eMe > m.c | 5 ++++- >=20 > Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformIni > tPreMe > m.inf | 2 ++ > 2 files changed, 6 insertions(+), 1 deletion(-) >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformI > nitPre > Mem.c > b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformI > nitPre > Mem.c > index 6519fdd042..d8c96b52f4 100644 > --- > a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformI > nitPre > Mem.c > +++ > b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformI > nitPre > Mem.c > @@ -481,7 +481,10 @@ PlatformInitPreMem ( >=20 > BuildMemoryTypeInformation (); >=20 > - if (!PcdGetBool(PcdFspWrapperBootMode)) { > + if ((!PcdGetBool (PcdFspWrapperBootMode)) || (PcdGet8 > (PcdFspModeSelection) =3D=3D 0)) { > + // > + // Install memory relating PPIs for EDKII native build and FSP dispa= tch mode > + // > Status =3D PeiServicesInstallPpi (mMemPpiList); > ASSERT_EFI_ERROR (Status); > } > diff --git > a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformI > nitPre > Mem.inf > b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformI > nitPre > Mem.inf > index fb997838ef..86d8246f02 100644 > --- > a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformI > nitPre > Mem.inf > +++ > b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformI > nitPre > Mem.inf > @@ -34,11 +34,13 @@ > MdeModulePkg/MdeModulePkg.dec > MdePkg/MdePkg.dec > IntelSiliconPkg/IntelSiliconPkg.dec > + IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec >=20 > [Pcd] > gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode ## > CONSUMES > gMinPlatformPkgTokenSpaceGuid.PcdStopAfterDebugInit ## CONSUM= ES > gMinPlatformPkgTokenSpaceGuid.PcdStopAfterMemInit ## CONSUM= ES > + gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelection ## > CONSUMES >=20 > [FixedPcd] > gMinPlatformPkgTokenSpaceGuid.PcdPlatformEfiAcpiReclaimMemorySize =20 > ## CONSUMES > -- > 2.32.0.windows.1