From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web09.250.1623449718527367366 for ; Fri, 11 Jun 2021 15:15:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=XsBbmwIq; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: isaac.w.oram@intel.com) IronPort-SDR: yP3jHq5Xvj0DV8nTKiywk6N5KaoWp/Ax0yU3BTtmfJ96Mnj2Q54yCqpqzU9GkX5TZf5wXrhYnJ TwBYTsHbCc4g== X-IronPort-AV: E=McAfee;i="6200,9189,10012"; a="185995825" X-IronPort-AV: E=Sophos;i="5.83,267,1616482800"; d="scan'208";a="185995825" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2021 15:15:17 -0700 IronPort-SDR: FziY1r8GfKSIifL9kocSeoUY4sbsb7nE7rciQcMmg4FGNP19l0CMPIctfXUVu/pFi26YEB0cmy /TQy+N8aokYw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,267,1616482800"; d="scan'208";a="414577314" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by fmsmga007.fm.intel.com with ESMTP; 11 Jun 2021 15:15:17 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Fri, 11 Jun 2021 15:15:16 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4 via Frontend Transport; Fri, 11 Jun 2021 15:15:16 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.4; Fri, 11 Jun 2021 15:15:13 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=B/NgQ0iblVCvkeR03IrvBv6yITvOl5YstKtfOE/5exIb/QqHS9E+qcOq9SqH4m2hcwKAZBi7tmboGmD5GAIHZKcqMfyr/j7jdMz0UniVbVDHiMZbUEOODAldt3hzLfxZZZmzAG0T1A6WlpS36/Qf+evWvTHH5dw5qn0HRFQ7pAepzZZffp1jmVBKBo71o/0d5wUi/KwQQ8z3WOl/W+4IW2G15EsyQdsW3H1Ri2vad3VLUMooOrtUswOM+uJkAKkIuf9b1AS8KpEuM9MeEyK4bSbKTSptvHY5aWtfKXy0yxywCQkKWbFn7ulGPfg8fLWYkJ3U/QRRNaRQZ7TICPjbEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xA3iFt6biMxNtG0N+svL8PmiQ8Yw51KTJbf6yzdufVc=; b=Wrc+ybuvPiMznyou6IIC4mjAWOy0uES3aB4svDQd8QyqwlHIy6CtjttRKZwFMNnbTMsMpeGZJLOttgge5rjm1k8pZmhaqE59wsOKTuR6ToHIzPC3YydBo3vbqN02+OF1dyFu10yJhvTFU0p+SnDRszgtje7lQchAs58PcqAvNHBohggrxuqUZrHJhbIfr5IXk7J7A2lIWvHeos5vwiabl9p+qn95y5Mj0VkNyIIS7jPVqmV3la4OS/HiWRGOipJTw3CwV4AG+cpNx+qNsU8N10Opy4c9kJDzdwZc6QZ4Kd0hURRnbrzzkYDniLniGJzzLL17qMDE3tQLBb22tVKAEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xA3iFt6biMxNtG0N+svL8PmiQ8Yw51KTJbf6yzdufVc=; b=XsBbmwIqzaP7+JJTzHdATnWnVYzm/sSW3wP4aw+apzf6fnZpEFdzbS8BlY51hkKYl0+08PsP2JxarqyNA+QHLgbRNuMbrxF5BBABBrgdv9BZUkKA+Lt+hePgxiy0APgpUJLoXiATwwANC/xIsXFSB4U4ATwIwIwca4lG4zgTRZg= Received: from MW3PR11MB4747.namprd11.prod.outlook.com (2603:10b6:303:2f::11) by MW3PR11MB4649.namprd11.prod.outlook.com (2603:10b6:303:5b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4195.21; Fri, 11 Jun 2021 22:15:07 +0000 Received: from MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::4cc2:7196:5a55:629e]) by MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::4cc2:7196:5a55:629e%3]) with mapi id 15.20.4219.024; Fri, 11 Jun 2021 22:15:07 +0000 From: "Oram, Isaac W" To: "KARPAGAVINAYAGAM, MANICKAVASAKAM" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Felixp@ami.com" , "DOPPALAPUDI, HARIKRISHNA" , "Jha, Manish" , "Bobroff, Zachary" , "KARPAGAVINAYAGAM, MANICKAVASAKAM" , "gaoliming@byosoft.com.cn" Subject: Re: [edk2][PATCH V1] MdePkg : Add IPMI Macro and Structure Defintions to resolve the IPMI build error Thread-Topic: [edk2][PATCH V1] MdePkg : Add IPMI Macro and Structure Defintions to resolve the IPMI build error Thread-Index: AQHXXwvZ+lLGhVP8NkafCUo9zBRcAKsPYENg Date: Fri, 11 Jun 2021 22:15:07 +0000 Message-ID: References: <20210611215004.8873-1-manickavasakamk@ami.com> In-Reply-To: <20210611215004.8873-1-manickavasakamk@ami.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action authentication-results: ami.com; dkim=none (message not signed) header.d=none;ami.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [134.134.136.211] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 28ef9759-b2cc-48a3-12da-08d92d265eff x-ms-traffictypediagnostic: MW3PR11MB4649: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:983; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: mB7G/z74WJ32JXjQADXKUWwOcbWbGhGca+wT8X3x6AOqaBzGMXm1AVF8VyQmEMJ6WE97qqNWX+tVri1Cc3oJ2RtVmmKT+ufrQzOKspRli+ZNwyzHHlD2FDMvJoK4b/fG/zWk0SYSFlvEcL0x1D/gtXuisnHYtvDeH8szxqtSNr/jAtEDX9SzoZDENbrh5BOom3zN66GKh/AW4rYE/jZus3IoWoYNSV+xxWA3sPrAV30RaFvvurhI5JOWib6NbWVZ6HcfMZLUxxTCJsRA4aEFOE+rRJWgjGI3dt8DkK5e3hSGdrLH60bZDudPTW17G3oTjqdSxR2FcVKt9vTy6W3TNgd2/r8AtOil9JAY0ukAEeieysGRg6Z45r+yIREBLoMKIuvKYvlyjnnVaODpF5VECLFxZC3OdKDSNmK4DNSvM3Nuzh7yLqY8HT467agGr/4t8al0tpdUBn3vx6TMb4wJ0IvHkgU2+fsI69os1KpUA2Ij2ZQn+86jPMnrDXV2lZnKHahs0slsQsRsVib3pDw/sJrauegA5bZMSeJDdS0b0DQ3zY3zGNmBsqvJGloO0clfe3CXCblepaCnrszqYH6yXuWSF3k4ep8xrckbTpaV5Iw= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4747.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(346002)(39860400002)(366004)(376002)(136003)(396003)(5660300002)(66476007)(6506007)(53546011)(9686003)(8676002)(4326008)(7696005)(8936002)(26005)(33656002)(52536014)(316002)(110136005)(76116006)(86362001)(71200400001)(122000001)(66556008)(66946007)(38100700002)(55016002)(54906003)(83380400001)(186003)(64756008)(478600001)(2906002)(66446008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?iSW7cJQJh2W9iCkkeaLcDpQOYexW/GoZxuu8SRgvuokklS0DdlfF4zcXyeBR?= =?us-ascii?Q?a4MWxUHG/UhOvAC3gy6pWO3H9OZgyE5tVaG+suWg+z9ZG/c6wRsABsusmOs/?= =?us-ascii?Q?wzw58uHJH0hxBZPtuNw5q/t5mCKJ/7dK+N5mh6bi4b7aKWd+jy1bXo5Auw1f?= =?us-ascii?Q?kua9FlIhIyBKFearJDkUAaIq06Uc8k4gwSUxEdAOmCGWirII98Xw4QylFx6L?= =?us-ascii?Q?/Kzn0uPItEx1LQc97VdpQmPNBdaKWHzs4ArypIl1JKvtLtzh6EEl3P8Fj1Tt?= =?us-ascii?Q?B0KizUo0/V05kO4rLwzxNU4Q2xaImpaDR54ENI386rJLtDBu8gRhlGs2Nkn8?= =?us-ascii?Q?VoN0N17ZmqqrEfkruCXB1Sr6SRcV9t9ViYZ6SJiOO4ldIiw7v6aZz9AyYmtd?= =?us-ascii?Q?HxGZUSEniGmLftaij/GbAaTZZtxLmvmGPLxiaZLOikGSlrElJhNy2dtSUNkX?= =?us-ascii?Q?8aBhzEuzL/01fLSA55e2e4nkWKuDX891lHHIfuzinz0rZy4d4I+jRg9TbhEU?= =?us-ascii?Q?1AvVAyVqOOyjfTsHGv5QyfCtDHB1lW3jXBg388P/1FbJH9S5sMbUIIM5FuY8?= =?us-ascii?Q?sGU12IkuJyJDb5RWo5GIY40++54Y6En3llouoa511q+BvVelOR+GXaUsZ6vi?= =?us-ascii?Q?PNhax691WwKv0xYVwVcSatfDRdZiPEvaa2ddara3VZABJtrGQ9rqxpho63q6?= =?us-ascii?Q?83SBKHJo7M6GFVQJFr0LJtbTK+vBCTxg2uN5n8Q8n08YxetYSjOsd25Qxnh2?= =?us-ascii?Q?IfL8JwKqIIYOJ3sUt6Jx+lMravQ72LwTuXvhLCfyV1NSXBvnlFFZM15o7eKr?= =?us-ascii?Q?lfzBsLga5wXgLqFsxDLWFWHFIBBXrJTwT+c4irKP2++jJ/rtca2GGocl3AOB?= =?us-ascii?Q?ffL0frLdSW6Ha3O+dCdYtpBJf5HCBprhdBo88BvvT7m6PVJxRDrF4dK5QCYl?= =?us-ascii?Q?N6ihAVcCLatldRyy+ujS15kaLXINGyn33LWDpDEgGDuyO9SAYkre1blr911Z?= =?us-ascii?Q?ymdr8B43j7G0JHx9ZqtMBDO1/eWD8612gwHNY37euKwvW6LQZh0RHq57hHgh?= =?us-ascii?Q?Sa4YTPW2hJ0g3reld7UwA6VviT7AAHXzIdtKzxGd8QSG9E/AsRTcOD4qeCnZ?= =?us-ascii?Q?+xLSCNbakPuLYKsd21HMrG1xjzcIvc0kfz6xHAY1teYrVRJu7jol2K/ykHAf?= =?us-ascii?Q?+IDz7nEmDJMnTBoSsFHlF7CoL2ZKsQHnZ3zPtEcU3FDJ0chQBou9aHtqBFxb?= =?us-ascii?Q?cQYfiuBMQjZsbP2NgsBsZfQvb7o+lxEnFeA8Q11CbqK2TZiyfQlOEoWL3XtL?= =?us-ascii?Q?2oD9fEYfsxsAxQyHa0X5JUdZ?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4747.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28ef9759-b2cc-48a3-12da-08d92d265eff X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jun 2021 22:15:07.4203 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4Ra5nE88MjXoRL3W4mRLeH4F6cDUlm/iWS/hccx3CS16jj5o1s0IyJOezOIVnROB36lCTgXkNxNNi5Jq8nLdAw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4649 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Isaac Oram -----Original Message----- From: manickavasakam karpagavinayagam =20 Sent: Friday, June 11, 2021 2:50 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Felixp@ami.com; DOPPALAPUDI, HARIKRISHNA ; Jha, Manish ; Bobroff, Zachary ; KARPAGAVINAYAGAM, MANICKAVASAKAM ; gaolimi= ng@byosoft.com.cn Subject: [edk2][PATCH V1] MdePkg : Add IPMI Macro and Structure Defintions = to resolve the IPMI build error Build error reported for missing structures IPMI_SET_BOOT_OPTIONS_RESPONSE,= EFI_IPMI_MSG_GET_BMC_EXEC_RSP and macros EFI_FIRMWARE_GET_BMC_EXECUTION_CO= NTEXT EFI_FIRMWARE_BMC_IN_FULL_RUNTIME/EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE when using edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg MdePkg : Rename IPMI Macro and Structure Defintions Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB, EFI_FIRMWARE_GET_BMC_EXECUTION_C= ONTEXT EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_G= ET_BMC_EXECUTION_CONTEXT IPMI_BMC_IN_FORCED_UPDATE_MODE --- Notes: V1 : - Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB, EFI_FIRMWARE_GET_BMC_EXECU= TION_CONTEXT - EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to IPMI_MSG_GET_BMC_EXEC_RSPB,= IPMI_GET_BMC_EXECUTION_CONTEXT - IPMI_BMC_IN_FORCED_UPDATE_MODE 0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch | 61 +++++= +++++++++++++++ MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h | 4 ++ MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h | 18 +++++= + 3 files changed, 83 insertions(+) diff --git a/0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patc= h b/0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch new file mode 100644 index 0000000000..16d149e2d8 --- /dev/null +++ b/0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch @@ -0,0 +1,61 @@ +From c5e221cfe5d815883f39b71667b6e8f644a27390 Mon Sep 17 00:00:00 2001 +From: manickavasakam karpagavinayagam +Date: Thu, 10 Jun 2021 14:59:22 -0400 +Subject: [edk2][PATCH] MdePkg : Add IPMI Macro and Structure Defintions=20 +to resolve the IPMI build error + +Build error reported for missing structures=20 +IPMI_SET_BOOT_OPTIONS_RESPONSE, EFI_IPMI_MSG_GET_BMC_EXEC_RSP and=20 +macros EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT +EFI_FIRMWARE_BMC_IN_FULL_RUNTIME/EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE +when using=20 +edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg +--- + MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h | 4 ++++ =20 +MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h | 19=20 ++++++++++++++++++++ + 2 files changed, 23 insertions(+) + +diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h=20 +b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h +index 79db55523d..d7cdd3a865 100644 +--- a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h ++++ b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h +@@ -186,6 +186,10 @@ typedef struct { + UINT8 ParameterData[0]; + } IPMI_SET_BOOT_OPTIONS_REQUEST; +=20 ++typedef struct { ++ UINT8 CompletionCode:8; ++} IPMI_SET_BOOT_OPTIONS_RESPONSE; ++ + // + // Definitions for Get System Boot options command // diff --git=20 +a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h=20 +b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h +index 2d892dbd5a..1c692cc792 100644 +--- a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h ++++ b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h +@@ -17,4 +17,23 @@ + // All Firmware commands and their structure definitions to follow=20 +here // +=20 ++/*-----------------------------------------------------------------------= ----------------- ++ Definitions for Get BMC Execution Context=20 ++---------------------------------------------------------------------- ++------------------*/ #define EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT =20 ++0x23 ++ ++// ++// Constants and Structure definitions for "Get Device ID" command to=20 ++follow here // typedef struct { ++ UINT8 CurrentExecutionContext; ++ UINT8 PartitionPointer; ++} EFI_IPMI_MSG_GET_BMC_EXEC_RSP; ++ ++// ++// Current Execution Context responses // ++#define EFI_FIRMWARE_BMC_IN_FULL_RUNTIME 0x10 ++#define EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE 0x11 ++ + #endif +-- +2.25.0.windows.1 + diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h b/MdePkg/In= clude/IndustryStandard/IpmiNetFnChassis.h index 79db55523d..d7cdd3a865 100644 --- a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h @@ -186,6 +186,10 @@ typedef struct { UINT8 ParameterData[0]; } IPMI_SET_BOOT= _OPTIONS_REQUEST; +typedef struct {+ UINT8 CompletionCode:8;+} IPMI_SET_= BOOT_OPTIONS_RESPONSE;+ // // Definitions for Get System Boot options comm= and //diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h b/Md= ePkg/Include/IndustryStandard/IpmiNetFnFirmware.h index 2d892dbd5a..c4cbe2349b 100644 --- a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h @@ -17,4 +17,22 @@ // All Firmware commands and their structure definitions to follow here //= +// ----------------------------------------------------------------------= ------------------+// Definitions for Get BMC Execution Context+// -----= ---------------------------------------------------------------------------= --------+#define IPMI_GET_BMC_EXECUTION_CONTEXT 0x23++//+// Constants and= Structure definitions for "Get Device ID" command to follow here+//+typede= f struct {+ UINT8 CurrentExecutionContext;+ UINT8 PartitionPointer;+}= IPMI_MSG_GET_BMC_EXEC_RSP;++//+// Current Execution Context responses+//+#= define IPMI_BMC_IN_FORCED_UPDATE_MODE 0x11+ #endif--=20 2.25.0.windows.1 Please consider the environment before printing this email. The information contained in this message may be confidential and proprieta= ry to American Megatrends (AMI). This communication is intended to be read= only by the individual or entity to whom it is addressed or by their desig= nee. If the reader of this message is not the intended recipient, you are o= n notice that any distribution of this message, in any form, is strictly pr= ohibited. Please promptly notify the sender by reply e-mail or by telephon= e at 770-246-8600, and then delete or destroy all copies of the transmissio= n.