From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web10.1264.1642620418904468823 for ; Wed, 19 Jan 2022 11:26:59 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=BoX0ZH2J; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642620418; x=1674156418; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=3qw12Fi1kvo1g0wR/r3b2U9FfPocY8fJnOAlOOgE71M=; b=BoX0ZH2Jo6SCuev7PHVdUOyuwLgHYsbvJSv1+9ezZ001mqVnVopFKn0C jMzRUiLRwBGwQtNRNKynrrUVBPD4oML4fT+WIaH7Mi0XGvbxCh3ztYZ0E cxYwGLCPUNE6T5ooMR185QSJ4Ax8TzB2YfwHts7aVrgTLSwcKBySDbDqH A+otD6+SUImMC6RCsXVALbEv0xSvEnz3RB75s86esuUxMl+HlJwKD250P l6oOgghrVq5qFbquT76yIYgKzc9DC8Jz46PWdQWtHGuA4TbMfHHwGtcUu Vs4FkFMYQp5Mm5yMsgLHaFeJmVDkf0obdefKk9xETacr2nkQkRQ8ry5LF g==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="269561380" X-IronPort-AV: E=Sophos;i="5.88,300,1635231600"; d="scan'208";a="269561380" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Jan 2022 11:10:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,300,1635231600"; d="scan'208";a="530738319" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga007.fm.intel.com with ESMTP; 19 Jan 2022 11:10:01 -0800 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Wed, 19 Jan 2022 11:10:01 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Wed, 19 Jan 2022 11:10:01 -0800 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (104.47.51.41) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Wed, 19 Jan 2022 11:10:00 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N6FWNo8xkd06p3Cr9FTew9J1D4vVHi6QdJsAzIFBDNTgJL9m/ZJSn5VBp7L6rinCFpt28gnOKAq1WFJNqRQmWxukZ3EOXtPYsksXh8crjx32MU64o05YwrCoDcxmePOKMMxwHpXvGaDJObInXqjxBE+TWOLbvgByNL0+aUl3qyk9x1H8J6hRxTC38oPEXeFhvvQXoz2kGSN/HyHKRdaPWLxdmHH6Fg2jBavoHmiNs0HC0+k3RCtjtgqtHZx3IrUF1JMGZjBVm6qMAqA6H4GiMo6LADFoaUZ8643lNp9wTAlNTJASTCRy/34q31H1LgzjDuae6r7dDJGgYOw3k5k5Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1SjuiLc3sFLoW6OTVe8JwkDwgw6IQK+i99ln9epQ27w=; b=lwjDU2rdBU2FZ+7tdVayuRcYA7CaXfCvSnYF4fih0x2tm4Bm7bgKBc1T8lZa2LcYW1KhfV3H9+uLrq+q9zLQwtTj74RJYGHv9mSun02WTKja7xWB5r3iyQtr+Y9epH0jQabPUprsj2cPqRe7t07igpeB9h14gX0cMfHyDAYXMBc7cuy+63gbHJ5LBuw9cnCjQ0tl9AQLDsfkLiyTmIRjzpy/Wy9LR3O50EfR2bnnpQL63ssqhnXsdpjy3HpAANIHJ5wmFRP3f7TisBSjFWDy0or2IpFei07QnrONRxBHX4YjiGTt2QACZvVgrXH9ZOPGj03CM/NuIncbUW1ia5w6xw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Received: from MW3PR11MB4747.namprd11.prod.outlook.com (2603:10b6:303:2f::11) by SA0PR11MB4639.namprd11.prod.outlook.com (2603:10b6:806:70::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.11; Wed, 19 Jan 2022 19:09:58 +0000 Received: from MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::9c36:57de:e967:55a3]) by MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::9c36:57de:e967:55a3%6]) with mapi id 15.20.4888.014; Wed, 19 Jan 2022 19:09:58 +0000 From: "Oram, Isaac W" To: "Chaganty, Rangasai V" , "devel@edk2.groups.io" CC: "Gao, Liming" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 20/27] SpcrFeaturePkg: Use MinPlatform build include files Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 20/27] SpcrFeaturePkg: Use MinPlatform build include files Thread-Index: AQHYB1sJ/SjldNPL7UGwWZT4olYObaxiDB8AgAi1Y4A= Date: Wed, 19 Jan 2022 19:09:58 +0000 Message-ID: References: <9fe41786a6142a31b8724632f37eab047e3d9deb.1641953242.git.isaac.w.oram@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e1c0f2ef-6805-4f7a-e6b8-08d9db7f495c x-ms-traffictypediagnostic: SA0PR11MB4639:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4714; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: nBvJh338RWIpdG083peB0u+RDtF8Ktd7dDCJPb/1o9JG2WPnfC/rVxGuWMiEb/kQhKQzAye3+PDew+jqnAgrC4EXs78SwUWti87W2vIukNVJpb1QxD5gwMroSPc4H1+t0EuA3jGKoe/zgW/JSDSoEBwZ3O3fJhFXkLyBvXJzjECEpgKZBkEsAb5VeuauMP/8v9H7DF90ae94BZgqsOO5mUAQz0FynHsFIqyb1A6nXp2MUcJZBeK/g9Ze2/O3btHF81BCvPEbkxGiaSRFUfIdh9pvdbi1+cMFu+IbbZqrk7wxWhHh8JHYn1ZMzUOq5FKypWRE3eOiT4GXkZYjVrpxIV5myEDtwbRBc4HvH+9VckaOza2V9bekUJcgJKegsyrm7AkMBUX0WRvBXlTGDlK5MhawIA1WY/KrjIjnswnA9fI/0/UcPQs2lFY595Skc69WySmtXma86yM6bT5bt8F8//qJmFP8LpUDUFfrwfJv7sWuoQYn++s2b97rL4ApuFv72cOHpQGEWFdSBzGH7c/NdOAMT/rNpBQpUwdazuCxIds680ffXNsERV7ZgVWV18CeAnq4ZbUpf/+YZAiW5LURZrTB9XcOTr9bDbtijXrAAzYbNlxecsn8aC8SaPVAorpD15CnpfpKVymZCiTbChRaj8CEnLgqy2lrmeJkclonwgHFov6vcE+m5n7kMuwnji08lclhCNwCNNg8yBC61J2JmpMtwOQYm74Tgs1zekKGK/oIc5r9u4cR+E6uvbX09L5MqmTSGvlUJWC0DBNSStkyHXZFICy5+0e7Frj6yrgW5W4= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4747.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(9686003)(83380400001)(186003)(110136005)(33656002)(8676002)(4326008)(316002)(76116006)(7696005)(66946007)(53546011)(66446008)(86362001)(64756008)(6506007)(82960400001)(66476007)(38100700002)(38070700005)(71200400001)(508600001)(8936002)(52536014)(122000001)(30864003)(55016003)(2906002)(966005)(26005)(5660300002)(66556008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?NT/u4Mru3GpfhuSwZVI/VlfL99Zkd8LjEbNAfdIK9XmKH0iQQ7OTyxc9xaqZ?= =?us-ascii?Q?Lv14C9QaMEhU0hCj1M+cCppT20E+qnWjnDL6RLnuxOnEgM23IbslGDWH2Tyg?= =?us-ascii?Q?r8zTnDUQfZ4CWaXaFP5dsphyecDmM2Vs8C8t8yfp9S/oyuVBDj4LZ2MZu/J1?= =?us-ascii?Q?xPJsH1qft4QW6Xavk+FNyL5zqydKbXIM+IkLm2JUBRue225LPXYfOq11W3oG?= =?us-ascii?Q?u2szHaCtSkmZ/b+5X1duwjZhcXEO7vBI5euUdQ6xvpp0P5JbMjYKS+blGZ/8?= =?us-ascii?Q?5vV33QmaSwuVj8r6+95lRUnG56aJtvSLfgJzAsrUrcFXQ/HG9LF1TFqgSIg7?= =?us-ascii?Q?1MvYy1bPpXzUndpEQ7QD9QRILvjjOCjO4+tBOncJ/BzTYmbkP6v4FKsAg64k?= =?us-ascii?Q?thWhZqlJfjEU667udzaDbavnclwB7WIKqoOh05IWOsZAeXJkTBYWtae5bjuO?= =?us-ascii?Q?4DCMrVvePGVnhlP0i6bOV41stE0aIYXqu2fzkOZpSjYSZEHvlkk3qI47o+PV?= =?us-ascii?Q?RAQKhrXCTjFL2QPf/2+OsVGzLlpIQ1E0AAMZIOpwLw5YB29Hb8CABuK+YWYd?= =?us-ascii?Q?f6Kxp0g2glfQidHmASEaWBOBb5eMgjLbEHXifEg7PTm4NT+SV7kVlNmm4CHm?= =?us-ascii?Q?qWf1IaEXRc38rvEhvO/tjyxp1yhz04JNoydDLoPzgpvzTYbWp1wGy+fOhhQ7?= =?us-ascii?Q?AYsAbCbpOht1xGk8pMPfjDREiwGPx1Z01XB+Yx+ywDdQRjImzGPJ7Y/LWx8y?= =?us-ascii?Q?zAu8R+ppsDMFCAUIiCYeKJWT1oIP4wQxQZLqaAudWHgDUvhaGAGHasgUvYmz?= =?us-ascii?Q?PD+CkIeUKGCTmMe0zD1DODpfbMVdaowDxfIM3pzsEKS9LsqsBUtpicq+6JXT?= =?us-ascii?Q?DUXWqapVsONesSZyXp6qhrCsU1hTw28+l/vpZcXeRwTNVrSOtfRV94UXRBdn?= =?us-ascii?Q?VwCiXHQ3W5dIlgLTQuIBaFu/2EkR28WhFgZt0YX5Qyu8tBPw5AZGNM3GG+w+?= =?us-ascii?Q?62CAWIzDOzOGZuvRV5Gl9T0TeA+ac3w/8lmJgod5kI8mMaa1GQjKVCGPnQpR?= =?us-ascii?Q?lhz0K0D3hN4ypIyKUMlhTLJG3UINc/veLuMgo57VBrXCS5k6Jq3TwfbzFIbW?= =?us-ascii?Q?WVYNmCRmlSaD/PvgKgfTREzUHB5YqQHHa/cwnFTlyjWDXu9Pr5WG+Sl4kClT?= =?us-ascii?Q?KD4U9FWYSFg37SQcW+mWpz3NNFuhircNbsyRY+giLqRXOOn/lSDsNSjjIq1Z?= =?us-ascii?Q?9/iQsHLgnzd/f5ejiei1z7PvjcXhg+ZAzFD3nJaI7NQ6tzRDoU6SZydxR0qv?= =?us-ascii?Q?Yo6q1cJlU/nzk/3IUWxdJWl6I2ZUABP9xL0iHwYYeuPxB4I9jqXLaBoi0T/d?= =?us-ascii?Q?ZGlXVwhFHyN2dJu/vNLOMD1Ah+kWFsMa8iWA8s0WFlATtvF3trKF2SJoCR/5?= =?us-ascii?Q?0kZypC3rH1QpktmMAR8GdiUg9b//92jCGJVuKOlD/JdiWBXASUT5nEyoQc5C?= =?us-ascii?Q?Z45T8zOop+zOh0TrXM35ZpmtM0UumxnnwW6PgdQ5JGfkdN9wcOpauVJ1sZ1u?= =?us-ascii?Q?96BWP9GCoT6+N6NGJegXyCXa4i7FdlkoaMBdG/IIrwIjsuHOlbFuKr786jmb?= =?us-ascii?Q?6wZqz2kKsIO+tLfTBqOqlP8=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4747.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e1c0f2ef-6805-4f7a-e6b8-08d9db7f495c X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jan 2022 19:09:58.6853 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: qZtg5uLD/rT2v06ECRVoJCIAU2cWkMWgZZ8lzPs4TQnC8z7+nZFTCZ05gdg5sEkw6OzEl/EWT3ISmib+NPjwsg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4639 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed as d0919cab63..2082072cc8 -----Original Message----- From: Chaganty, Rangasai V =20 Sent: Thursday, January 13, 2022 10:10 PM To: Oram, Isaac W ; devel@edk2.groups.io Cc: Gao, Liming Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 20/27] SpcrFeaturePkg: U= se MinPlatform build include files Reviewed-by: Sai Chaganty -----Original Message----- From: Oram, Isaac W Sent: Tuesday, January 11, 2022 6:20 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-devel][edk2-platforms][PATCH V1 20/27] SpcrFeaturePkg: Use M= inPlatform build include files Also added feature enable flag Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Isaac Oram --- Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Library/SpcrDevi= ceLib.h | 2 +- Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PostMemory.fdf = | 13 ++++ Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PreMemory.fdf = | 11 ++++ Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature.dsc = | 62 -------------------- Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Readme.md = | 12 ++-- Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.dec = | 6 ++ Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.dsc = | 18 ++++++ 7 files changed, 55 insertions(+), 69 deletions(-) diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Libr= ary/SpcrDeviceLib.h b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Inc= lude/Library/SpcrDeviceLib.h index 947813815e..2e50270ee6 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Library/Spc= rDeviceLib.h +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Library/ +++ SpcrDeviceLib.h @@ -12,7 +12,7 @@ =20 /** Get a Serial Port device used for SPCR. - The caller should call FreePool() to free the memory if return value is = not NULL. + The caller should call FreePool () to free the memory if return value is= not NULL. =20 @retval NULL Can not get device. @retval Others A serial port device path. diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Post= Memory.fdf b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Post= Memory.fdf new file mode 100644 index 0000000000..f963f567c2 --- /dev/null +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PostMemo +++ ry.fdf @@ -0,0 +1,13 @@ +## @file +# FDF file for post-memory SpcrFeature advanced feature. +# +# This file is intended to be included into another package so=20 +advanced features # can be conditionally included in the flash image=20 +by enabling the respective # feature via its FeaturePCD. +# +# Copyright (C) 2022 Intel Corporation. +# +# SPDX-License-Identifier: BSD-2-Clause-Patent ## + +INF SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpiDxe.inf diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PreM= emory.fdf b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PreMe= mory.fdf new file mode 100644 index 0000000000..3c461e7fbc --- /dev/null +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/PreMemor +++ y.fdf @@ -0,0 +1,11 @@ +## @file +# FDF file for pre-memory SpcrFeature advanced feature. +# +# This file is intended to be included into another package so=20 +advanced features # can be conditionally included in the flash image=20 +by enabling the respective # feature via its FeaturePCD. +# +# Copyright (C) 2022 Intel Corporation. +# +# SPDX-License-Identifier: BSD-2-Clause-Patent ## diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Spcr= Feature.dsc b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/Spc= rFeature.dsc index c51e552df5..b06ddf4fe6 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeature= .dsc +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Include/SpcrFeat +++ ure.dsc @@ -25,40 +25,9 @@ !error "DXE_ARCH must be specified to build this feature!" !endif =20 -##########################################################################= ###### -# -# Library Class section - list of all Library Classes needed by this featu= re. -# -##########################################################################= ###### - -!include MdePkg/MdeLibs.dsc.inc - [LibraryClasses] - ####################################### - # Edk2 Packages - ####################################### - BaseLib|MdePkg/Library/BaseLib/BaseLib.inf - BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRepStr.inf - DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf - UefiDriverEntryPoint|MdePkg/Library/UefiDriverEntryPoint/UefiDriverEntry= Point.inf - UefiLib|MdePkg/Library/UefiLib/UefiLib.inf - PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf - PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf - UefiBootServicesTableLib|MdePkg/Library/UefiBootServicesTableLib/UefiBoo= tServicesTableLib.inf - DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf - UefiRuntimeServicesTableLib|MdePkg/Library/UefiRuntimeServicesTableLib/U= efiRuntimeServicesTableLib.inf - - ####################################### - # SpcrFeaturePkg Packages - ####################################### SpcrDeviceLib|SpcrFeaturePkg/Library/SpcrDeviceLibNull/SpcrDeviceLibNull= .inf =20 -[LibraryClasses.common.DXE_DRIVER] - ####################################### - # Edk2 Packages - ####################################### - MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAll= ocationLib.inf - ##########################################################################= ###### # # Component section - list of all components that need built for this feat= ure. @@ -74,38 +43,7 @@ # ##########################################################################= ###### =20 -# -# Feature DXE Components -# - # @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzi= lla.tianocore.org/show_bug.cgi?id=3D2308 # is completed. [Components.X64] - ##################################### - # Spcr Feature Package - ##################################### - - # Add library instances here that are not included in package components= and should be tested - # in the package build. - - # Add components here that should be included in the package build. SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpiDxe.inf - #{ -# -# SpcrDeviceLib|SpcrFeaturePkg/Library/SpcrDeviceLibNull/SpcrDeviceLi= bNull.inf -# } - -##########################################################################= ######################### -# -# BuildOptions Section - Define the module specific tool chain flags that = should be used as -# the default flags for a module. These flags are a= ppended to any -# standard flags that are defined by the build proc= ess. They can be -# applied for any modules or only those modules wit= h the specific -# module style (EDK or EDKII) specified in [Compone= nts] section. -# -# For advanced features, it is recommended to enabl= e [BuildOptions] in -# the applicable INF file so it does not affect the= whole board package -# build when this DSC file is active. -# -##########################################################################= ######################### -[BuildOptions] diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Readme.md b/= Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Readme.md index 0a5d48876d..66138ee0f6 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Readme.md +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Readme.md @@ -22,10 +22,10 @@ Platform can implement its own library to select the se= rial port device. * SpcrDeviceLibNull =20 ## SpcrAcpiDxe -The main driver of convert the serial port device info to ACPI table. -It will call the function GetSpcrDevice() in the library SpcrDeviceLib to = get the serial port device path. +The main driver of convert the serial port device info into an ACPI table. +It will call the function GetSpcrDevice () in the library SpcrDeviceLib to= get the serial port device path. If the serial port device path is not NULL, then use gEfiPciIoProtocolGuid= to get the PCI info, and use the gEfiSerialIoProtocolGuid to get the seria= l port info, such as the baud rate etc. -If the serial port device is PCI device 00:16:03 (AMT serial over lan PCI = device), then will set the BaseAddress. +If the serial port device is PCI device 00:16:03 (AMT serial over LAN PCI = device), then will set the BaseAddress. At last fill the ACPI table as Windows required. =20 ## SpcrDeviceLibNull @@ -37,19 +37,19 @@ Fill the serial port device info used for SPCR to ACPI = table. =20 ## Configuration There is not special configuration. -But the platform maybe implemente its own SpcrDeviceLib. +But the platform may implement its own SpcrDeviceLib. =20 ## Data Flows GetSpcrDevice() -> serial port device path -> get PCI info and serial port= info -> ACPI table. =20 ## Control Flows -GetSpcrDevice() in SpcrDeviceLib -> SpcrAcpiDxe. +GetSpcrDevice () in SpcrDeviceLib -> SpcrAcpiDxe. =20 ## Build Flows There is not special build flow. =20 ## Test Point Results -* Check the output ACPI table. +There are not test points implemented. =20 ## Functional Exit Criteria * Check the output ACPI table. diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeatureP= kg.dec b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.d= ec index 03776abf06..b084fad892 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.dec +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.d +++ ec @@ -21,6 +21,12 @@ [Includes] Include =20 +[Guids] + gSpcrFeaturePkgTokenSpaceGuid =3D { 0xe978c988, 0xeeba, 0x4671, { 0xb8,= =20 +0x0d, 0xcc, 0x8b, 0x89, 0xb5, 0xd1, 0xef }} + +[PcdsFeatureFlag] + =20 +gSpcrFeaturePkgTokenSpaceGuid.PcdSpcrFeatureEnable|FALSE|BOOLEAN|0x0000 +0001 + [LibraryClasses] ## @libraryclass Provides an API for get SPCR device. # diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeatureP= kg.dsc b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.d= sc index 82d2d3ac73..2ee874a58e 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.dsc +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/SpcrFeaturePkg.d +++ sc @@ -24,6 +24,24 @@ PEI_ARCH =3D IA32 DXE_ARCH =3D X64 =20 +[Packages] + MinPlatformPkg/MinPlatformPkg.dec + +[PcdsFeatureFlag] + # + # PCD needed for MinPlatform build includes + # + gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable = |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable = |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |FALSE + +# +# Include common libraries +# +!include MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc +!include MinPlatformPkg/Include/Dsc/CorePeiLib.dsc +!include MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc + # # This package always builds the feature. # -- 2.27.0.windows.1