From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.622.1642555607983712521 for ; Tue, 18 Jan 2022 17:26:49 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=mktCNC5v; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: isaac.w.oram@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1642555608; x=1674091608; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=03ema4oa3FeAYv7LSL8GbTtk8IPCF1CrAXBJ6pHlp98=; b=mktCNC5vQal3bTNnKssEeD5oCdSYFaAWnwWc62EmTKk7rXvUetjJIYOb 0BKF61wJUH8t10nalEhvaaEIkXw4Q3kYogyb3sPuqTzjP81yuSOrQJtD8 Ns6s7xGxGadJrNV/NTiUjSOtncYSuoKIlmLs+N4zFBeXwlGozhnrRJThm 56pxVwziIt9vjPe2OdDt8D7xEpTovTwNSG+iJ32Lu6hNP+JxTDvRTSwtJ Cl+N60JCRXYWAEhGtU6zFzkW/EpCvIbS+Pv+EGA8r/E1UEo4GaXk+JEt2 Pp41xn7xGcB1dyQGvuXLG1pLJrMUdCDD9w4HoN/Nlnc8i/fB9LdxQfS7f g==; X-IronPort-AV: E=McAfee;i="6200,9189,10231"; a="244750972" X-IronPort-AV: E=Sophos;i="5.88,298,1635231600"; d="scan'208";a="244750972" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jan 2022 17:26:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,298,1635231600"; d="scan'208";a="492859853" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga002.jf.intel.com with ESMTP; 18 Jan 2022 17:26:46 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 18 Jan 2022 17:26:46 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 18 Jan 2022 17:26:46 -0800 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 18 Jan 2022 17:26:45 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mkD9QgxajcfWP4Il1Raf9g4hyv+k8oHiPmKRG2HDvW4K22QUsb/1tJ2FdUDEDhEfiTVN4fyETkcNk0016EsVPmI+WlyHXgNqK2RcYLCFkIh4fwOrBvMhT+nxYnGdjYsiLaPn6m9eLEuoqGKj6I6QW+7mXH+CQhdHd/k0FW5uGj9VByp8zcDfhyFdjEWx9E3RhGi/zBxG5PLHaGbpg/XUimZ1ullKnCOjVrHiJPaQuURoeIkifAxQ/YiESa7NEfn3txbbGe+ate2at1CwOdKFkDtMcz6e5hkGVMSgCbDiP85S3VyJCdqEfCrQi1b9Wl7NsrT0+42LZsQJlZbR1PmcMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NE0XT4YKFwl8+VqG+Zrqp59H2ZgwbtrnjGk1kHi3tYQ=; b=Wjm+c4CCSICPlGoPRAhg3MMVm1ZbkdHJsB/FD27JC3MwGQ3B01wh6NOZb7WVoQP4PGm05ylhAVJ3tTXEM+oRBL7I95x58TL7j4S96Zg+YS1iHtcoxHyjrqgnACN7jmnpyZwlFLaOdpTzbCQHCO3kL0lBZmmIXVmr16307NJhVM937xJRAt+rbhI/mt41KRNclGNsAqB0NJgyXE2/49Y8rKGxgEX6iZS66+3wRyFhQCb4SCZNzmwkjnLKt6SkktFc2zuR69xcE5nY9mgJsT/Wa6mea1VIcVCw/sN4tMQ2/+mLtzWCWmWhuZhLUn1fUUzCb/6U3dfV+uZgF6i/SR8eAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW3PR11MB4747.namprd11.prod.outlook.com (2603:10b6:303:2f::11) by MWHPR11MB1776.namprd11.prod.outlook.com (2603:10b6:300:110::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4888.12; Wed, 19 Jan 2022 01:26:44 +0000 Received: from MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::9c36:57de:e967:55a3]) by MW3PR11MB4747.namprd11.prod.outlook.com ([fe80::9c36:57de:e967:55a3%6]) with mapi id 15.20.4888.014; Wed, 19 Jan 2022 01:26:44 +0000 From: "Oram, Isaac W" To: "Chaganty, Rangasai V" , "devel@edk2.groups.io" CC: "Gao, Liming" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 07/27] S3FeaturePkg: Use MinPlatformPkg build include files Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 07/27] S3FeaturePkg: Use MinPlatformPkg build include files Thread-Index: AQHYB1sHKv/qj55LDUa78E9wHyMSPaxiAMoAgAeXqvA= Date: Wed, 19 Jan 2022 01:26:44 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.6.200.16 dlp-reaction: no-action authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a2c0a4cb-371b-4828-63d2-08d9daeac0d4 x-ms-traffictypediagnostic: MWHPR11MB1776:EE_ x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8273; x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rK4EokVU46SJdgaolo15fk20UUBoH/G+kJD/VfLCOyKTSGWpbmOkn5RlmVaO6ar33X+PQRy7oY9Zay2kw/VPblSaX5QUczvZCsp2jAh15MmvTHrC4Tupha7NXQ4TnqujwUy/8zGHC6zHjl7MFzkUpvQXxmjsEIAk3WKrvVKxMrF2O3ZgpWrBhRfC/XqAmBEizc1WEob0ScPSHq05wlBidyQELNsFT1bIUxEtYSjoc/Q6Q1UJyhdhO/vLVdBUkehCmfFcstVcNKL4MLO6UHu2BAQkS3MmcQwXrGF8sa0X4QvvZDxRBD8bJ/X7xTAL34Ei36mr2z0gnvFho79EBpUN4hupk40JB18jzl+hR6u3yIDU6771r+ze0pzh+l6A7ViAhc0XnywUNjGAkbAY4AwA85LSblc8LYh7Xuno/d/z0WNX2R5UWV18w7qbhUXmo+V0uU/gpkihCExkQ0s7kRh7t2Y2ld3uRqil5gQrvsn4GW2zFY2fgXyTDEYRTbvQQqy0NUic1Ckp9sV2jIv+MveXwOf3j+045hXl05idyDht/9EwFlSfblvsXt7sOOiTv2YI96Uj1Fr1uoSqNbYR+5llRMtFi0rspxua0KnQu/3rD5ogf9oFpDKgn4HWNwNN2O/1FFSN8Rhoh598RC+a1v1E7s6Ts0hRSUNIDW8cbmDS/CE0CHBDiccYZmgX1jLn0HfS/reM19bjMCtIGyCXpgd76a1IbqIEcyi1cA1Oyan2XFoTizCcVHiHowSDriV0zvv0NBo5UiLjhYJHyFztLPlRPcRDQQlJxlkgm2ha8j/eIzQ= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4747.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(66446008)(4326008)(82960400001)(26005)(9686003)(76116006)(2906002)(71200400001)(316002)(966005)(6506007)(7696005)(33656002)(38070700005)(110136005)(5660300002)(19627235002)(122000001)(52536014)(83380400001)(86362001)(66946007)(66476007)(66556008)(53546011)(64756008)(38100700002)(8676002)(8936002)(186003)(55016003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?W3E/7gtdWsW1Rdzy2rGx7ZstthcVqXe9iY2gq0CzCm4R0Uw70YrfWmvSqUNI?= =?us-ascii?Q?IvDVswUAYXKSyPbt/DH77IweBGCumBN+GTz7HcofmwYePmnnmaKZOraOhcfB?= =?us-ascii?Q?I3N8aJ5PG7q4iVcgUWzAmKk4AOb328f73V3Q/DRVOxgb1qA6V8brslk0KbYB?= =?us-ascii?Q?PBlzOcx7rLb4KuHYNIJEgZAj8flGEonjd8AssuG5wJea8ZidCfvQUwKH5TBV?= =?us-ascii?Q?uHIwK1jBWJjI1BuU6xlpi4vAWsQvJfMPtgu7xLVTcd5RaScZEHTJ+zbKANAs?= =?us-ascii?Q?DvmNkPD51Rs564BSspD8wKd7mmMceVwGmz5o7H3kg6dXQnhMIPJJOtypvIde?= =?us-ascii?Q?3FN93ry1eKETiG9a2nJAs2GyQPF6jvJXTwognwEZMR2McsoF98jWJ1CO/sp3?= =?us-ascii?Q?bAnGw038hu2bML9cDELpLRx4jsoC9UxLvXOnDhhZ4Wf2nkw1ZUaZsmJP6leQ?= =?us-ascii?Q?VINU6q28XSUCqVak/vU5CevJVXnPOPVpqtzIHC/vHnnO35aLK8XkhNgYTEmA?= =?us-ascii?Q?n6chLDfSmTrK5sK387sW+BJDe38WmlGuK52OrG1YP3mGe0aH33Y0fYEXeJRM?= =?us-ascii?Q?4EI4aydJ8kUAcnkoHraHnPmz/Bu3waVGeCbMvW2uTC7hLLaZ9UPOHzrPjSc8?= =?us-ascii?Q?F2TzVn2iJaHSkJWtqO4SX1dqdt15ZTc+Po18ffTtiXxiuixi1T7hUeuOnFz0?= =?us-ascii?Q?kjNITDJDqtEwlWpl7gSeichOK7iBGGWccGCkI9VndEYLQ0uobUqBf20gVMGA?= =?us-ascii?Q?DFfwPFmiNT7CmwPyjtl2UeW5BTC6GrdPGl3ArT4Ucq5KOdXzXUUv0Qmr/KNW?= =?us-ascii?Q?8peuMK8hJvp+5j+epksY7TfeDzTGv363Ew6Wo/9J/QUaxWe00XQKsvlydF69?= =?us-ascii?Q?3u5uRxEsdJ2sIFhozmj37N41iUvjMbdrInhdQGJplL2gNIrKFxEyaaOgIUqo?= =?us-ascii?Q?C3iuhhJZuMRkocIoC74Z60Bj05DwH76SESjbG261bN/9DW0iSlXYZ4FLWlPn?= =?us-ascii?Q?iEUSlPdZnDyLKywgwa91Lz32renFNTBeeCJkxoumNiWuVsOuLHSv5oInNCxn?= =?us-ascii?Q?ui220X6UYRAwaJbUycfIK3YThKIXKys/IHA37QWD0IbrwzFF0kFIOKT5pSu9?= =?us-ascii?Q?SHXPF9V3m79uF6bCAIlR93dkxmtxsgDIl7Ys5MtHEmcf0wjDT6VgfStPgQhY?= =?us-ascii?Q?5s7k6TAZiYNoJi8RL7nFeWJOKQFUJPz9WAL63o4LQpYYsdTbHOZ5sABy4h1h?= =?us-ascii?Q?KMewyzobkQXWbDll6OA/jkSBH0rc4njoFryVsrcprezbSDIM8qz3/5u/OQTB?= =?us-ascii?Q?qDJjDLVxah6CPSXQTutjf4qGdtT9iC3nrAjAqOCzyMI9pwiCk56qmnJZXM8s?= =?us-ascii?Q?dtnQ01rUuoBEQDmRZBeeqaE1wG/N3wZBG4kexFZI89xTuqjPiU1qifAgatwM?= =?us-ascii?Q?2Qcquoc1P4P4g20KrtmFBrX96sZCHs5nBz+pmlxMu1exLzhHNzj+p3m1Aqw7?= =?us-ascii?Q?z4XHYVYY/b3+OBNPMtUZ3c9cNnz5rxEGQMEC60znuB7qRVseEQH5xKxSqUlK?= =?us-ascii?Q?KjhfjiO6ZAnvFcNicxQmwlyeS1F1AS76fYQreX5/T2tINJA5E0PuHnOiFL+t?= =?us-ascii?Q?BZ+6L+cIvFnNdJRPAX1TALA=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR11MB4747.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a2c0a4cb-371b-4828-63d2-08d9daeac0d4 X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jan 2022 01:26:44.1514 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7TDJ/RTB0fGEJXhuNiMNlV3F63l1uvCgEY2Zq6zbEvVyna/qoiv1F5gtcQRV5OPSCXynF+XBZkWU323GszUmzw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1776 Return-Path: isaac.w.oram@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed as a16d6344dc..d1864efa5b -----Original Message----- From: Chaganty, Rangasai V =20 Sent: Thursday, January 13, 2022 9:30 PM To: Oram, Isaac W ; devel@edk2.groups.io Cc: Gao, Liming Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 07/27] S3FeaturePkg: Use= MinPlatformPkg build include files Reviewed-by: Sai Chaganty -----Original Message----- From: Oram, Isaac W =20 Sent: Tuesday, January 11, 2022 6:20 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chaganty, Rangasai V ; Gao, Liming Subject: [edk2-devel][edk2-platforms][PATCH V1 07/27] S3FeaturePkg: Use Min= PlatformPkg build include files Use the MinPlatformPkg common core build files to build libraries needed by= this feature. Cc: Sai Chaganty Cc: Liming Gao Signed-off-by: Isaac Oram --- Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.fdf | 2 +- = Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc | 72 ++-= ----------------- Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc | 18 +++= ++ 3 files changed, 26 insertions(+), 66 deletions(-) diff --git a/Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.= fdf b/Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.fdf index 34caf3dacc..fdd16a4e03 100644 --- a/Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.fdf +++ b/Features/Intel/PowerManagement/S3FeaturePkg/Include/PreMemory.fdf @@ -7,4 +7,4 @@ # ## =20 - INF S3FeaturePkg/S3Pei/S3Pei.inf +INF S3FeaturePkg/S3Pei/S3Pei.inf diff --git a/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.= dsc b/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc index f94bd2b431..cc34e78507 100644 --- a/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc +++ b/Features/Intel/PowerManagement/S3FeaturePkg/Include/S3Feature.dsc @@ -18,12 +18,12 @@ # ##########################################################################= ###### [Defines] -!ifndef $(PEI_ARCH) - !error "PEI_ARCH must be specified to build this feature!" -!endif -!ifndef $(DXE_ARCH) - !error "DXE_ARCH must be specified to build this feature!" -!endif + !ifndef $(PEI_ARCH) + !error "PEI_ARCH must be specified to build this feature!" + !endif + !ifndef $(DXE_ARCH) + !error "DXE_ARCH must be specified to build this feature!" + !endif =20 ##########################################################################= ###### # @@ -31,34 +31,7 @@ # ##########################################################################= ###### =20 -!include MdePkg/MdeLibs.dsc.inc - -[LibraryClasses] - ####################################### - # Edk2 Packages - ####################################### - BaseLib|MdePkg/Library/BaseLib/BaseLib.inf - BaseMemoryLib|MdePkg/Library/BaseMemoryLibRepStr/BaseMemoryLibRepStr.inf - DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf - IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf - PciCf8Lib|MdePkg/Library/BasePciCf8Lib/BasePciCf8Lib.inf - PciLib|MdePkg/Library/BasePciLibCf8/BasePciLibCf8.inf - PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci.i= nf - -[LibraryClasses.common.PEI_CORE,LibraryClasses.common.PEIM] - ####################################### - # Edk2 Packages - ####################################### - HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf - MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAlloc= ationLib.inf - PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf - PeimEntryPoint|MdePkg/Library/PeimEntryPoint/PeimEntryPoint.inf - PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf - PeiServicesTablePointerLib|MdePkg/Library/PeiServicesTablePointerLibIdt/= PeiServicesTablePointerLibIdt.inf - - ####################################### - # Silicon Initialization Package - ####################################### +[LibraryClasses.common.PEIM] SmmAccessLib|IntelSiliconPkg/Feature/SmmAccess/Library/PeiSmmAccessLib/P= eiSmmAccessLib.inf =20 ##########################################################################= ###### @@ -92,34 +65,3 @@ =20 # Add components here that should be included in the package build. S3FeaturePkg/S3Pei/S3Pei.inf - -# -# Feature DXE Components -# - -# @todo: Change below line to [Components.$(DXE_ARCH)] after https://bugzi= lla.tianocore.org/show_bug.cgi?id=3D2308 -# is completed. -[Components.X64] - ##################################### - # S3 Feature Package - ##################################### - - # Add library instances here that are not included in package components= and should be tested - # in the package build. - - # Add components here that should be included in the package build. - -##########################################################################= ######################### -# -# BuildOptions Section - Define the module specific tool chain flags that = should be used as -# the default flags for a module. These flags are a= ppended to any -# standard flags that are defined by the build proc= ess. They can be -# applied for any modules or only those modules wit= h the specific -# module style (EDK or EDKII) specified in [Compone= nts] section. -# -# For advanced features, it is recommended to enabl= e [BuildOptions] in -# the applicable INF file so it does not affect the= whole board package -# build when this DSC file is active. -# -##########################################################################= ######################### -[BuildOptions] diff --git a/Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc b= /Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc index 28ee49d429..e16a1f8d00 100644 --- a/Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc +++ b/Features/Intel/PowerManagement/S3FeaturePkg/S3FeaturePkg.dsc @@ -24,6 +24,24 @@ PEI_ARCH =3D IA32 DXE_ARCH =3D X64 =20 +[Packages] + MinPlatformPkg/MinPlatformPkg.dec + +[PcdsFeatureFlag] + # + # PCD needed for MinPlatform build includes + # + gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable = |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable = |FALSE + gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable = |FALSE + +# +# Include common libraries +# +!include MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc +!include MinPlatformPkg/Include/Dsc/CorePeiLib.dsc +!include MinPlatformPkg/Include/Dsc/CoreDxeLib.dsc + # # This package always builds the feature. # -- 2.27.0.windows.1