From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.2242.1587751426811797131 for ; Fri, 24 Apr 2020 11:03:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@intel.onmicrosoft.com header.s=selector2-intel-onmicrosoft-com header.b=wtu9sMgG; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: jaben.carsey@intel.com) IronPort-SDR: vSXlGTqQ3N69pAXdb8Al5CGC2jgisHRB0OpOmBsFv2AQSwxyW5NfYF9+cdl1PgZDZOIuT4XIke udy8Yz7LdhCw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2020 11:03:30 -0700 IronPort-SDR: rzU7q2GR9nmNB3iemLAKdomaHOnvDMN31nYt8juGxZ82hQjCyw6ktMU+3g0S7XCkdxAAcWFvBe L5u6wZznCn2A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,313,1583222400"; d="scan'208";a="291662816" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga002.fm.intel.com with ESMTP; 24 Apr 2020 11:03:28 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 24 Apr 2020 11:02:51 -0700 Received: from fmsmsx605.amr.corp.intel.com (10.18.126.85) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 24 Apr 2020 11:02:51 -0700 Received: from FMSEDG001.ED.cps.intel.com (10.1.192.133) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 24 Apr 2020 11:02:51 -0700 Received: from NAM02-CY1-obe.outbound.protection.outlook.com (104.47.37.58) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 24 Apr 2020 11:02:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KUd8T0nX2wWdy2hD86pwxzg2tE7JzUXFadcBOh82DxB1BWoNtoacG3KIq1WVJYKmdreVzop9Cf/aH+1COLrGBuJzQnfGUP68KzGovlXN1K+OkciRMQDWbW84XaZKseYW2nQtZZw79ckv+rdRvbIIKo1/clL+wX8Ylj83OMN6hvAD8H6CftG5hZ+/Hj8SsTy4Idz+XDJeJiyrM9zAaJSIWNLnhQCbxCDyWHmQs8upvV8DLu4Xi0WghYqnoEbxFN9Y9l5C7SftcgGkoTtEF1XGMR4ifP1hGqD5AohpI/YbaIKEO0eeqCq7hzyEa8rXBOzBTXRvErOujcwQROED3Etwdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qYqP2YRxsEf/z7wT6HLk/E+2gQDAKupwM90+BbVyJOw=; b=ZUjHaALXaAqvjXtqxNRmt684/WeM/8zBue2SwHCOj+plJiU9K3/wRYZqLq5DxU4py9xWO2jUyPNGJFsomB6JuhUOxie9am/Ght5l9jnhZz1EE2tcLuQeKJtO48YvUndE+U0GSGO2M3+kNhdrd83pPqTNvfZqRNjzveI5M6Q732S+ZC60UNwBeNOVme3L2T+YWeaP1QsWmGEMUcQTypy8QqhVWqoynWVnth0CB2jqtY7am+lh/ZL1ig7Jj3veB4HSzeFr3s7T8/nnKgQjfGMm7kxJ9Bs/Q9SfntrUD5M0MOgUObgbkKZEMZYi+OLQd3PUaT+XzAsUXddmVouWIOdbqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qYqP2YRxsEf/z7wT6HLk/E+2gQDAKupwM90+BbVyJOw=; b=wtu9sMgGHfkgRwKF3+a9ZFotcZod1rRNUVQMIhCkA8Scic0kw97xepzzTp17r9QEByPIkaa6vl85YntXJiom8KkJiSMDdTpgzyp9y/yIc4Lupi26uLodlDCyJm2uAkcOOOGFaJ2gaMimd4FIaVCbVOLdysTTHX32G07EChJfS+4= Received: from MW3PR11MB4748.namprd11.prod.outlook.com (2603:10b6:303:2e::9) by MW3PR11MB4713.namprd11.prod.outlook.com (2603:10b6:303:2f::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2937.22; Fri, 24 Apr 2020 18:02:43 +0000 Received: from MW3PR11MB4748.namprd11.prod.outlook.com ([fe80::acdc:dd12:cb50:1951]) by MW3PR11MB4748.namprd11.prod.outlook.com ([fe80::acdc:dd12:cb50:1951%5]) with mapi id 15.20.2921.033; Fri, 24 Apr 2020 18:02:43 +0000 From: "Carsey, Jaben" To: "devel@edk2.groups.io" , "nikita.leshchenko@oracle.com" CC: "liran.alon@oracle.com" , "aaron.young@oracle.com" , "Justen, Jordan L" , Laszlo Ersek , Ard Biesheuvel Subject: Re: [edk2-devel] [PATCH v5 03/12] OvmfPkg/MptScsiDxe: Report name of driver Thread-Topic: [edk2-devel] [PATCH v5 03/12] OvmfPkg/MptScsiDxe: Report name of driver Thread-Index: AQHWGmHy09dfbEihEUy7b5BO/2RBKaiIj6eQ Date: Fri, 24 Apr 2020 18:02:43 +0000 Message-ID: References: <20200424175927.41210-1-nikita.leshchenko@oracle.com> <20200424175927.41210-4-nikita.leshchenko@oracle.com> In-Reply-To: <20200424175927.41210-4-nikita.leshchenko@oracle.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.2.0.6 dlp-product: dlpe-windows authentication-results: spf=none (sender IP is ) smtp.mailfrom=jaben.carsey@intel.com; x-originating-ip: [134.134.136.201] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 68bcbb49-41d6-4bbd-ec49-08d7e879afbc x-ms-traffictypediagnostic: MW3PR11MB4713: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2512; x-forefront-prvs: 03838E948C x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR11MB4748.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:(136003)(366004)(396003)(346002)(39860400002)(376002)(966005)(8936002)(5660300002)(478600001)(316002)(26005)(19627235002)(110136005)(8676002)(81156014)(55016002)(9686003)(186003)(7696005)(71200400001)(54906003)(53546011)(33656002)(6506007)(86362001)(4326008)(66946007)(76116006)(66556008)(2906002)(64756008)(66446008)(66476007)(52536014);DIR:OUT;SFP:1102; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yaAaw6TCaIqaFCnXpqeiaXR22L2M7IG2k1y+bVYiNZlQ5i1MG/x+4F1/CcD+IqwbUclfFgV0c1CLXIVAqGwClDk8ny3qeL91DGnMFU3OsieIjEzv4scmqg1krcLv7eHDlYYszV9fswCFS0FxEfsKwWBeNBz6DzmWxG/s0JPcQj7fNM3UmdX7RWAgCJf8ticJvgvtLwfIethC8C2tdjsWgcVNkQxFzTnqlqaCnvq1U6GLqeTZKxND/ywaBUL7/zcCluOKt0K0tjUK3epRor3Z8P7TxgzUEzt3ISx2qMtOaI1nNZ5U4Ry1Y9rYkYmNtGknnqTScQPCyymh0zOXax4fH0IddFRMvxerdiwvdx9nJq0DNFegOwiis2OQ+lR7KFghkBE3zTMTNfqL+9xfXZTo5hGz/sBKiW4UTNEbOVFV1QsItBpEauL0qpkL2Z8GFGwQ9NfcuxmpuBUoIouorW0RITL5iZoeBfey6QdcnWK0mTq5iQGkL5FG+XnPaufHnW6fzgNsdXumMgVMr2V9bPvsFQ== x-ms-exchange-antispam-messagedata: hKTEVOpClIomECCGJiZYgv0c9w4ZEUWz1E7GlxOcVrUv66938KTxsvrdhhTfQQ2xnTpksESbdP6Zr5P3DMeBo6oSUIkJXtuk2/GuRUJkX3u6ydwKSBSGZRjhhCf90lTgvOXgdE0mmG98lIV4CDVjKQ== MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 68bcbb49-41d6-4bbd-ec49-08d7e879afbc X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Apr 2020 18:02:43.1353 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: L0KCAdZiDQdlbU1gnkmRyDW0bMs3HBpko9MhjvhHP4nWTF/GWJQ1iEgD3SbHnnzoZrUNPZBEgjLxj9iD+y9oNQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR11MB4713 Return-Path: jaben.carsey@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I don't remember reviewing this previously (not recently at least), maybe t= he RB should be CC? One comment inline below. > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Nikita > Leshenko > Sent: Friday, April 24, 2020 10:59 AM > To: devel@edk2.groups.io > Cc: Nikita Leshenko ; > liran.alon@oracle.com; aaron.young@oracle.com; Justen, Jordan L > ; Laszlo Ersek ; Ard > Biesheuvel ; Carsey, Jaben > > Subject: [edk2-devel] [PATCH v5 03/12] OvmfPkg/MptScsiDxe: Report name > of driver >=20 > Install Component Name protocols to have a nice display name for the dri= ver > in places such as UEFI shell. >=20 > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2390 > Signed-off-by: Nikita Leshenko > Reviewed-by: Laszlo Ersek > Reviewed-by: Jaben Carsey > Reviewed-by: Liran Alon > --- > OvmfPkg/MptScsiDxe/MptScsi.c | 61 > ++++++++++++++++++++++++++++++++++-- > 1 file changed, 59 insertions(+), 2 deletions(-) >=20 > diff --git a/OvmfPkg/MptScsiDxe/MptScsi.c b/OvmfPkg/MptScsiDxe/MptScsi.c > index 581d3909b84d..64949a809022 100644 > --- a/OvmfPkg/MptScsiDxe/MptScsi.c > +++ b/OvmfPkg/MptScsiDxe/MptScsi.c > @@ -69,6 +69,63 @@ EFI_DRIVER_BINDING_PROTOCOL > mMptScsiDriverBinding =3D { > NULL, // DriverBindingHandle, filled as well }; >=20 > +// > +// Component Name > +// > + > +STATIC > +EFI_UNICODE_STRING_TABLE mDriverNameTable[] =3D { > + { "eng;en", L"LSI Fusion MPT SCSI Driver" }, > + { NULL, NULL } > +}; > + > +STATIC > +EFI_COMPONENT_NAME_PROTOCOL mComponentName; > + > +EFI_STATUS > +EFIAPI > +MptScsiGetDriverName ( > + IN EFI_COMPONENT_NAME_PROTOCOL *This, > + IN CHAR8 *Language, > + OUT CHAR16 **DriverName > + ) > +{ > + return LookupUnicodeString2 ( > + Language, > + This->SupportedLanguages, > + mDriverNameTable, > + DriverName, > + (BOOLEAN)(This =3D=3D &mComponentName) // Iso639Language > + ); > +} > + > +EFI_STATUS > +EFIAPI > +MptScsiGetDeviceName ( > + IN EFI_COMPONENT_NAME_PROTOCOL *This, > + IN EFI_HANDLE DeviceHandle, > + IN EFI_HANDLE ChildHandle, > + IN CHAR8 *Language, > + OUT CHAR16 **ControllerName > + ) > +{ > + return EFI_UNSUPPORTED; > +} > + > +STATIC > +EFI_COMPONENT_NAME_PROTOCOL mComponentName =3D { > + &MptScsiGetDriverName, > + &MptScsiGetDeviceName, > + "eng" // SupportedLanguages, ISO 639-2 language codes }; > + > +STATIC > +EFI_COMPONENT_NAME2_PROTOCOL mComponentName2 =3D { > + (EFI_COMPONENT_NAME2_GET_DRIVER_NAME) > &MptScsiGetDriverName, > + (EFI_COMPONENT_NAME2_GET_CONTROLLER_NAME) > &MptScsiGetDeviceName, > + "en" // SupportedLanguages, RFC 4646 language codes }; I think that the }; needs to be outside of the comment for both of these s= tructures. > + > // > // Entry Point > // > @@ -85,7 +142,7 @@ MptScsiEntryPoint ( > SystemTable, > &mMptScsiDriverBinding, > ImageHandle, // The handle to install onto > - NULL, // TODO Component name > - NULL // TODO Component name > + &mComponentName, > + &mComponentName2 > ); > } > -- > 2.20.1 >=20 >=20 >=20