From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (NAM04-BN8-obe.outbound.protection.outlook.com [40.107.100.45]) by mx.groups.io with SMTP id smtpd.web11.70504.1673561884862932225 for ; Thu, 12 Jan 2023 14:18:05 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=TGmyJoei; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.100.45, mailfrom: kuei-hung.lin@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Jb4Yv33xu/D87WoP8qncjtQYQDdQ/xLqA710b1ixl6JJmz3en5Qzbui7b3m+SLOyhkpeGgoCozX/Tb/VBF5V8pfpM/xNOMqw3Y34Q8cFOf4ciryyQcC5+SqKclbo+ZazAPGv0xDvtzxKCmX7eVXTwNCsdCkkPwWqwuyZrW9dv1SVJAyAazm+x36A9xGKrtESUlyvsYrphtAptH44cNWDb/eMcGoxhH0cw7mL3gu2vRmQu0VrS7PY0nYOVJf6ik86hdb4tNduJz6Jvb1mTBYq9t0dn3VhK2dWZKPGB+r+JEL2eq26vwFgBi8RmSJP2tUQ2gyFd4Zb1euXAkhBeiV9Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vP0RTXZzYnXX+OmZpMVrcZResDirWDslq1+LTl3w+rE=; b=MjJcujkDrlxXAuW2X158oCvKO8mUK7SbRbDlXDkc9ZxYswaZuPsqUwHYAfWHnQtdM6Fw8ax4sPdvV10FwUO13Ohnv8yw7Z8p/YwvKkdd2J37UvBTtY8l+6kAqKzWFl2tNJR6O4Sgxq8W524n0bNJ8a3uNHGum0+VpEnfQKSfweNdiuDZvwhT+QGYcjcjzE4fTBjvMXuZ4Rm5Ws5fJUbLW/57jA5ZvhzS6VvU8/tpWJSKYKI/XpaqzWJC9kHsTjIPeV1YqLCXywow7Cwc+vQqCZcSTVmEQfpimV6eP2qeMej1tXIuqyNr8VYgzwy5Q/BKLg6wTbqkJRRM5H0S/zRZUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vP0RTXZzYnXX+OmZpMVrcZResDirWDslq1+LTl3w+rE=; b=TGmyJoeiucCvl+Q1VFZ4maO9rjqE+PnZ5kYjU20/Wpe/cTrMzFpKqYL+oW39kD9JUOMR3tcfFf+BfGy61Ni7MX+ltTOY5fzvfuu1ZSlpULnqzfg2tVe6/NOvdz+cmN6bQmBT95lOz4Y3iNmlv1zwy9UJUnUf2bk4EaBKWOOYgg8= Received: from MW3PR12MB4425.namprd12.prod.outlook.com (2603:10b6:303:5e::21) by DS7PR12MB6333.namprd12.prod.outlook.com (2603:10b6:8:96::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.18; Thu, 12 Jan 2023 22:18:02 +0000 Received: from MW3PR12MB4425.namprd12.prod.outlook.com ([fe80::1289:643d:a26a:9118]) by MW3PR12MB4425.namprd12.prod.outlook.com ([fe80::1289:643d:a26a:9118%6]) with mapi id 15.20.5986.018; Thu, 12 Jan 2023 22:18:02 +0000 From: "Lin, Kuei-Hung (Timothy)" To: "He, Jiangang" , "Chang, Abner" , "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Bi, Dandan" , "Gao, Liming" , "Kirkendall, Garrett" Subject: Re: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing source file to Brotli library Thread-Topic: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing source file to Brotli library Thread-Index: AQHZJkP0ez06IqtD6EWknFffBlQE0q6a5zQAgAAK7eOAAAFJkIAAZOs2 Date: Thu, 12 Jan 2023 22:18:01 +0000 Message-ID: References: <20230112050822.1940-1-abner.chang@amd.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=True;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-01-12T22:18:00.873Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW3PR12MB4425:EE_|DS7PR12MB6333:EE_ x-ms-office365-filtering-correlation-id: a481df01-335b-4115-0f36-08daf4eade91 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: muGiQd8iSW7sYpxdlOf0L73OBKgpDGiyuaWZQThGgx0PByytgoLNGR7Mi0xMTmXFfon+kCrJ1FnyS5EWWEJznXDWPRN+vPGcJ5Mtl4haHMA9epG9UAQN9gdATsYQNzUHLqmVL5DepiD1bU3hUWaAg/++iVbefApX/DeeSIJpBUwsQIB3Y1WILLQY+gSReR5dyGIM4dOP0MJ/xXPL+JLLraWOG/Jf0bhSl+7fquwD2/egoCjkg3D/VU+b40fM1tysih3PTLb0EIJOmBETPYA1SstL0L1tDJJ5WJ2nclaU9rvLRYOd1hovH/0zzy+baCvB3sqVAD+CqfyLFHNqS1loRVqaVFpsIYdvXUHHH8Yt9/UYRP1t3N2d+jyGQPe43EdO5os2Mzlo/cAhpc41CptVU77G8BbY5J3i/hrqCtxgYT+/wnHTwT1Gqb6SbksQOjCkLtH7FOwq10Jnqhy8/EXYIOi2DGfvIEHQptf/96jCKgj5eJijoejAKkxj/b4E6YXalSsQ21UKrzriL8HA/+FOv+Q3pAxQOU3d2bkKgJX1ITqSZykP7KuO65lPCLTbAyyXvSg9FlybPbgdkQ30ybkJsnojjGk7kt454Gr2aHyAqIDyki+yQTWQgsrwERlGup4SbHcTAsoWpGog6cubE6oXWdN7FQExdszlEtmgSYCPKbmwbWpXT12WvKUBEJxTYrBVXxlrHVMw3r+AjdxeFmFYk+iusXW6vK/90gAO7GF4f1XLbfm3hNL110eVu7fX6mMBt+gcmYIwQk16pJYAIhCOmA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW3PR12MB4425.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(136003)(376002)(396003)(346002)(366004)(39860400002)(451199015)(33656002)(110136005)(45080400002)(54906003)(316002)(52536014)(41300700001)(6506007)(83380400001)(166002)(76116006)(66556008)(66476007)(4326008)(8676002)(9686003)(64756008)(66446008)(66946007)(91956017)(71200400001)(38070700005)(966005)(86362001)(478600001)(38100700002)(122000001)(7696005)(53546011)(55016003)(26005)(186003)(66899015)(5660300002)(8936002)(2906002)(19627405001);DIR:OUT;SFP:1101; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?4RCXIEjylnT9z6O4bDZXNb2dKqjCZiX5ObxV6bOMADfF1Mpm/T4ci3h4ZW?= =?iso-8859-1?Q?sU++Nkicteqg90aLflrCkE1eBfPekoR0OAdI/9lh/lJvDTiXDR2cK9j+l6?= =?iso-8859-1?Q?iica5Hqm0iH6FBNThDcNGqZ1gSMcjQRxs7OL9yDQQiuZ+a59QR5lj2vipg?= =?iso-8859-1?Q?tEWLU7ajrtwyVOqNSYTBuDuwzNhAAP6TgDY5PrX0EyF8EnPELT3IM8wqYU?= =?iso-8859-1?Q?Ot6Upa3djcsQoIrvQBD7mGFQEzYQ9TIDWroGvWnZa45k1lKOGQ71PxIzSZ?= =?iso-8859-1?Q?4+++RRyySLd/xCCp29/snSnpJRUKJeINNP/q1f+rbYasOZ6snwFeXPZT7f?= =?iso-8859-1?Q?4JsxPwDjYGRIdEOKVGMzGxcQK2PDCtI14+49EKHvuczOLvN8ZXd1iO/lEN?= =?iso-8859-1?Q?YByyVFNRfoWw06mJyxg16kMgwGywfS4ypRnucGibrlwO5QEyyWfxjtvbov?= =?iso-8859-1?Q?1UQKGFY7DjZais4a7ZYQpORjmj8vvdTaFgHwk+hE4sUD8bXNA357Na/2MQ?= =?iso-8859-1?Q?N+3Je+Ekl0iRUE9NzX+IAa8FvumS3Gz4T26/AWQgyjFiF/7sgTQhJFR/Sv?= =?iso-8859-1?Q?hp24GjKfu9GAYul1CJ3sgzA72JRNe7OiZagcpz2H4tyobayQY2PKa1kdOw?= =?iso-8859-1?Q?dHP+QVgeSbFy5nOYf10AQKvKMQlvn7Ld/RYgRGI/jPxiLcFmS4VzqeHgF8?= =?iso-8859-1?Q?KHygOAYmGdRfcHTa/cj+rm+PaP6dhQWwA8mmkJgWrOCr2B6q1LYTb472FJ?= =?iso-8859-1?Q?RTuxyNrzR0WMPzvTa5SkCqJA5Nmg/+17CKmKhDoJskfTKdfeXRFKpZWf2B?= =?iso-8859-1?Q?8H+eR2zZ2CJyVy9oa3ozyGeb7DeaTnkc4erptrqJpoV0jU1li3qQC5Zthw?= =?iso-8859-1?Q?KThNROdANflxWa2TlVOHN3Lsv6ruzJPNitYFuEkAUCHDt4KFwUXn7rSZiq?= =?iso-8859-1?Q?eWMPKYbT8tFS1QD6wsax8yA1N+BXaQaZXK1WU7uAPZ+bTHAYyfXFBdLP5A?= =?iso-8859-1?Q?R+Sx1ImG23kDfySPaKnzJzEq7kptA7Tg3kj3cvKv0QnYxIjFenI39C28I/?= =?iso-8859-1?Q?1UcPpM8cdoE6Hp0g4fLaqgBAU9QKee0A8ZjORPTttKBtXso+8e4doEytKf?= =?iso-8859-1?Q?P+OZ/bT2gE8O8Wmb7tUApqDIZTbSI++r31F6e2GpnfM3+PbBA28VZfS6Rb?= =?iso-8859-1?Q?LBt4oiJiyuGpen28Kdmql2/5ve+eKmmZkcG6E5Q6XTT/vaUau3yrEXbU7E?= =?iso-8859-1?Q?1s4C5v1wmxu7oKtQM8BWGxjzyosU2zEB6c9X2+SF+VWswxIZlzN6DatGh+?= =?iso-8859-1?Q?18SfnwpWARfkOrePM9CLOx/HTvSGRoakBzmw9NKd/zBm3TwbNuSZ4eTBzj?= =?iso-8859-1?Q?kgWz3Gk70qKKCplnTmw0MZoU2QK/KsCP2EPcBdNQVpKWO5+V8sMadstXjw?= =?iso-8859-1?Q?kRO/bA7NJYjyzgA34OlrFHXFTcjojgwDcHjY8l8gcrVrC626gX1HWx+zkF?= =?iso-8859-1?Q?p0jQTQMeC+3CX+r8jH67ic6C/pgOcDgGm6i23wiybxPeF372P7WQna2n0c?= =?iso-8859-1?Q?5/JulDls5yK3M3ztz1v4UQsqgX7NgKIAjvnTzP/xXBXJHH83WMc7pwHhSa?= =?iso-8859-1?Q?BCUslqrTzMTeo=3D?= MIME-Version: 1.0 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4425.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a481df01-335b-4115-0f36-08daf4eade91 X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Jan 2023 22:18:01.9607 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VLKSfqhCNOazgE/PGgHTi3VYLh+0vvu5h8lbnb5qfQlTzdzN+r3XWi7EO4ukrQEjVqmhkhDDDIN0Ycxa7soI/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB6333 Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MW3PR12MB44252C5199CC6676F57614A8B3FD9MW3PR12MB4425namp_" --_000_MW3PR12MB44252C5199CC6676F57614A8B3FD9MW3PR12MB4425namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable [AMD Official Use Only - General] This patch tried to fix following build failure when linking the Brotli dec= ompress lib. Steps to replicate the issue: 1 - Attach a NULL lib to DxeIpl.inf in any project's .DSC, say OvmfPkgX64.d= sc MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf { NULL|MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecom= pressLib.inf } 2 - Follow the EDKII'2 package build steps to build that project. Build.py = would compliains with following errors. ... /home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustomDecompressLib= /brotli/c/dec/decode.c:879: undefined reference to `_kBrotliPrefixCodeRange= s' /usr/bin/ld: /home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustom= DecompressLib/brotli/c/dec/decode.c:1193: undefined reference to `_kBrotliC= ontextLookupTable' /usr/bin/ld: /tmp/ccKzzHN0.ltrans0.ltrans.o: in function `DecodeCommandBloc= kSwitch': ... /usr/bin/ld: /tmp/ccKzzHN0.ltrans0.ltrans.o: in function `BrotliUefiDecompr= ess': /home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustomDecompressLib= /brotli/c/dec/decode.c:898: undefined reference to `_kBrotliPrefixCodeRange= s' /usr/bin/ld: /home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustom= DecompressLib/brotli/c/dec/decode.c:1193: undefined reference to `_kBrotliC= ontextLookupTable' -- Timothy ________________________________ From: He, Jiangang Sent: Thursday, January 12, 2023 8:08 AM To: Chang, Abner ; Kinney, Michael D ; devel@edk2.groups.io ; Lin, Kuei-Hung (T= imothy) Cc: Bi, Dandan ; Gao, Liming ; Kirkendall, Garrett ; Kinney, Michael D Subject: RE: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing s= ource file to Brotli library [AMD Official Use Only - General] Timothy will answer the question. From: Chang, Abner Sent: Thursday, January 12, 2023 10:05 AM To: Kinney, Michael D ; devel@edk2.groups.io Cc: Bi, Dandan ; Gao, Liming ; Kirkendall, Garrett ; Kinney, Michael D ; He, Jiangang Subject: Re: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing s= ource file to Brotli library [AMD Official Use Only - General] Hi Mike, CC Jiangang, he can give the clear answer. Thanks Abner Get Outlook for Android ________________________________ From: Kinney, Michael D > Sent: Thursday, January 12, 2023 11:23:48 PM To: devel@edk2.groups.io >; Chang, Abner > Cc: Bi, Dandan >; Gao, Limi= ng >; Kirkendall,= Garrett >; K= inney, Michael D > Subject: RE: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing s= ource file to Brotli library Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Hi Abner, What was the failure before this change? This looks like something that would always break the build of source files= were missing. Mike > -----Original Message----- > From: devel@edk2.groups.io > On Behalf Of Chang, Abner via groups.io > Sent: Wednesday, January 11, 2023 9:08 PM > To: devel@edk2.groups.io > Cc: Bi, Dandan >; Gao, Li= ming >; Garrett K= irkendall >; > Abner Chang > > Subject: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing sou= rce file to Brotli library > > From: Abner Chang > > > Add missing source files to Brotli library INF. > > Signed-off-by: Jiangang He > > Cc: Dandan Bi > > Cc: Liming Gao = > > Cc: Garrett Kirkendall > > Cc: Abner Chang > > --- > .../BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomD= ecompressLib.inf > b/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLi= b.inf > index 525e92408d6..244c2e35023 100644 > --- a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompre= ssLib.inf > +++ b/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompre= ssLib.inf > @@ -5,6 +5,7 @@ > # Brotli was released on the website https://github.com/google/brotli. > # > # Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved. > +# Copyright (C) 2023 Advanced Micro Devices, Inc. All rights reserved.<= BR> > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > @@ -41,6 +42,10 @@ > # Wrapper header files end # > brotli/c/common/dictionary.c > brotli/c/common/transform.c > + brotli/c/common/context.c > + brotli/c/common/platform.c > + brotli/c/common/constants.c > + brotli/c/common/shared_dictionary.c > brotli/c/dec/bit_reader.c > brotli/c/dec/decode.c > brotli/c/dec/huffman.c > -- > 2.37.1.windows.1 > > > >=20 > --_000_MW3PR12MB44252C5199CC6676F57614A8B3FD9MW3PR12MB4425namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable

[AMD Official Use Only - General]


This patch tried to fix following build failure when li= nking the Brotli decompress lib.

Steps to replicate the issue:
1 - Attach a NULL lib to DxeIpl.inf in a= ny project's .DSC, say OvmfPkgX64.dsc
  MdeModulePkg/Core/DxeIplPeim/DxeIpl.i= nf {
    <LibraryClasses>
      NUL= L|MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.= inf
  }
2 - Follow the= EDKII'2 package build steps to build that project. Build.py would compliai= ns with following errors.
...
/home/edk2/edk2-stable20= 2211/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/c/dec/decode.c:8= 79: undefined reference to `_kBrotliPrefixCodeRanges'
/usr/bin/ld: /home/edk2/edk2-stable2022= 11/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/c/dec/decode.c:119= 3: undefined reference to `_kBrotliContextLookupTable'
/usr/bin/ld: /tmp/ccKzzHN0.ltrans0.ltra= ns.o: in function `DecodeCommandBlockSwitch':
...
/usr/bin/ld: /tmp/ccKzzHN0.ltrans0.ltra= ns.o: in function `BrotliUefiDecompress':
/home/edk2/edk2-stable20= 2211/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli/c/dec/decode.c:8= 98: undefined reference to `_kBrotliPrefixCodeRanges'
/usr/bin/l= d: /home/edk2/edk2-stable202211/MdeModulePkg/Library/BrotliCustomDecompress= Lib/brotli/c/dec/decode.c:1193: undefined reference to `_kBrotliContextLook= upTable'

--
Timothy




From: He, Jiangang <Ji= angang.He@amd.com>
Sent: Thursday, January 12, 2023 8:08 AM
To: Chang, Abner <Abner.Chang@amd.com>; Kinney, Michael D <= michael.d.kinney@intel.com>; devel@edk2.groups.io <devel@edk2.groups.= io>; Lin, Kuei-Hung (Timothy) <Kuei-Hung.Lin@amd.com>
Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <gaolimin= g@byosoft.com.cn>; Kirkendall, Garrett <Garrett.Kirkendall@amd.com>= ;; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: RE: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add mi= ssing source file to Brotli library
 

[AMD Official Use Only - General]


Timothy will answer the question.<= /span>

 

From: Chang, Abner <Abner.Chang@amd.com>
Sent: Thursday, January 12, 2023 10:05 AM
To: Kinney, Michael D <michael.d.kinney@intel.com>; devel@edk2= .groups.io
Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, Liming <gaolimin= g@byosoft.com.cn>; Kirkendall, Garrett <Garrett.Kirkendall@amd.com>= ;; Kinney, Michael D <michael.d.kinney@intel.com>; He, Jiangang <J= iangang.He@amd.com>
Subject: Re: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add mi= ssing source file to Brotli library

 

[AMD Official Use Only - General]<= /span>

 

Hi Mike, 

CC Jiangang, he can give the clear = answer.

 

Thanks

Abner 

 

From: Kinney, Michael D <michael.d.kinney@intel.co= m>
Sent: Thursday, January 12, 2023 11:23:48 PM
To: devel@edk2.groups.io <devel@edk2.groups.io>;= Chang, Abner <Abner.Chang@amd.com>
Cc: Bi, Dandan <dandan.bi@intel.com>; Gao= , Liming <gaoliming@byosoft.com.cn>; Kirkendall, Garrett <Garrett.Kirkendall@amd.com<= /a>>; Kinney, Michael D <michael.d.kinney@inte= l.com>
Subject: RE: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add mi= ssing source file to Brotli library

 

Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding.


Hi Abner,

What was the failure before this change?

This looks like something that would always break the build of source files= were missing.

Mike

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> = On Behalf Of Chang, Abner via groups.io
> Sent: Wednesday, January 11, 2023 9:08 PM
> To: devel@edk2.groups.io
> Cc: Bi, Dandan <dandan.bi@intel.com>; Gao, L= iming <gaoliming@byosoft.com.cn>; Garrett Kirkendall <garrett.kirkendall@amd.com>;
> Abner Chang <abner.chang@amd.com>
> Subject: [edk2-devel] [PATCH V2] MdeModulePkg/Decompress: Add missing = source file to Brotli library
>
> From: Abner Chang <abner.chang@amd.com>
>
> Add missing source files to Brotli library INF.
>
> Signed-off-by: Jiangang He <jiangang.he@amd.com= >
> Cc: Dandan Bi <dandan.bi@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn&g= t;
> Cc: Garrett Kirkendall <garrett.kirkendall@a= md.com>
> Cc: Abner Chang <abner.chang@amd.com>
> ---
>  .../BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf = ; | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCust= omDecompressLib.inf
> b/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompres= sLib.inf
> index 525e92408d6..244c2e35023 100644
> --- a/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecom= pressLib.inf
> +++ b/MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecom= pressLib.inf
> @@ -5,6 +5,7 @@
>  #  Brotli was released on the website https://github.com/google/brotli.
>  #
>  #  Copyright (c) 2017 - 2020, Intel Corporation. All rights= reserved.<BR>
> +#  Copyright (C) 2023 Advanced Micro Devices, Inc. All rights re= served.<BR>
>  #
>  #  SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -41,6 +42,10 @@
>    # Wrapper header files end #
>    brotli/c/common/dictionary.c
>    brotli/c/common/transform.c
> +  brotli/c/common/context.c
> +  brotli/c/common/platform.c
> +  brotli/c/common/constants.c
> +  brotli/c/common/shared_dictionary.c
>    brotli/c/dec/bit_reader.c
>    brotli/c/dec/decode.c
>    brotli/c/dec/huffman.c
> --
> 2.37.1.windows.1
>
>
>
>
>

--_000_MW3PR12MB44252C5199CC6676F57614A8B3FD9MW3PR12MB4425namp_--