From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.38789.1673475033089657975 for ; Wed, 11 Jan 2023 14:10:33 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=RdI3E3GK; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: rangasai.v.chaganty@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673475033; x=1705011033; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=IB8ScGFRf66GZyqEvHr+37YtE64Dcm9JYrD2u33Iokk=; b=RdI3E3GK+Yt5kGFFFYjzLYsCD81XPlALKeSzV57MUq9pPROqi7q3Tlbl 6aUzim0BrNxwZTElFzWK9EurW030QTbNqLtDonScEqfdyNiQa8JSDwsmS EqpjX9WmgBXeXQTt5C7TPV+LE/oHaw+tHhmsKmsgpNdFx5mDmw588VApu GWGD6pPgewnjc+MUawqBeS1u5Ep3nh1vacK4r8Vv0VYRbP/9s3vGl2HiS ZQXz2gbaTc5AAG7dlChm7NUfJx4uTwwxDGPS5ev7Q5OlX9QQ6mOSP284q ZrXYsIKYXBKAvNQlb93qeEzzyApkzryGtdVAiweXAbjd7cdRqA5qAP0Wh A==; X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="325564669" X-IronPort-AV: E=Sophos;i="5.96,318,1665471600"; d="scan'208";a="325564669" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jan 2023 14:10:32 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10586"; a="659538522" X-IronPort-AV: E=Sophos;i="5.96,318,1665471600"; d="scan'208";a="659538522" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 11 Jan 2023 14:10:31 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 11 Jan 2023 14:10:31 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Wed, 11 Jan 2023 14:10:30 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Wed, 11 Jan 2023 14:10:30 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Wed, 11 Jan 2023 14:10:28 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=J07gAkboys3BYSMW+v64KaBeKZWBLo0vusSlhzednLHZ3LteeQfwbiFW4lh8XV+T6CZTgDauIAArmwdnk/tOrcRW5wAdAZLKDsIkCodGPJ/aJ+dGscX4WZGOfNQk+qeb/9rfrTUHb4KmJUXh61v8U5uzwRvqS4vpHsDbzSQkwiGZJRWxy6grR2UltJ58GWNsWKpWaHsdepAMVZsFo+CjSMHMNNVoVMc9Au+eO4EIX66o8lOOCUuhKSMDFAab6OspNqbHQtWS1XQjuCuPcjL9quubbQkU39XLzqUxXhJBpw8ueYvYC1HcAcy2MZVJVVCMTMPdVZPlFcmNwxGuN/gybw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2/BM1LAlXNL+oFk+y6TNvvwnUiF3DExzWPq+VwiYCgA=; b=WQfwu0wsOJgUiUIiXM1DvkA/vwjGTiV5yMQVRplPmAwIzX+05Dm3D45sHDyqvqNRpVneCjzFByyUKJB6vK9usURlwbrfecnuyv/bohbUmK2n8Kt00FlHZAyoakkgIXKhGFhNhldLzmKiaA8I/E2uSssxxFplZBlw1+ynkYgGvlSMfUVCJNIByq2NpuS4pUDxBzHHV6ZuKi+NAC4qey8eximpmGUP6NdH7Eu6vSkKTNum/vYoL+eJXiSaUXuAnZz52ts6gtvkAA0hsI+mtsH/XNv4rNfk5wgttkuWNnyXYQqxKTZMYczuqdXcSn2Y0yqEmEDCcaD+FyYzTxl21JUbNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MW4PR11MB5776.namprd11.prod.outlook.com (2603:10b6:303:183::9) by CH0PR11MB5217.namprd11.prod.outlook.com (2603:10b6:610:e0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.13; Wed, 11 Jan 2023 22:10:25 +0000 Received: from MW4PR11MB5776.namprd11.prod.outlook.com ([fe80::5218:39d3:2ec:3c40]) by MW4PR11MB5776.namprd11.prod.outlook.com ([fe80::5218:39d3:2ec:3c40%7]) with mapi id 15.20.5986.018; Wed, 11 Jan 2023 22:10:25 +0000 From: "Chaganty, Rangasai V" To: "Oram, Isaac W" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Gao, Liming" , "Dong, Eric" , "Bi, Dandan" Subject: Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] Features/Intel: Prepare for edk2-platforms CI Thread-Topic: [edk2-devel][edk2-platforms][PATCH V1 1/1] Features/Intel: Prepare for edk2-platforms CI Thread-Index: AQHZJIdEJpGKNSkaBU+cIjHmYnYFca6ZyeTQ Date: Wed, 11 Jan 2023 22:10:25 +0000 Message-ID: References: <113a2e2caf5f3d6ae2f223478b7440c834a6cdc5.1673309073.git.isaac.w.oram@intel.com> In-Reply-To: <113a2e2caf5f3d6ae2f223478b7440c834a6cdc5.1673309073.git.isaac.w.oram@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MW4PR11MB5776:EE_|CH0PR11MB5217:EE_ x-ms-office365-filtering-correlation-id: 20fb4585-5d9e-457c-8794-08daf420a3e1 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 2xd/7cges1bEybE6aQcv/bXV+AaaH5BNmnAXOf+96NstssWBBsRLKFeeFaWmmVD2nnUX3HqNZa+F9pK6wlFJz4mT/D6SYqlLNP7YRgTKe6722TMzIH4rfHb1ec+C6rEz+RLsgUtg8LPPLPVPq0plmPnietBpdFZw0W6th7DTiyoohtk+6Klw32BG0G6BZ8SywB8ZsIld3S3C349ujF1ZBXDhR38xAjZqMnN6zbz2P+utIbUz7AYtmLjcW/AQglo4quc6MPBvB9L9+AKGGF9CslIMdaYt3qbAJqLnKX76LOyq5OzFN2do/2jck3UMc7HiwyxojF7/CCwNpuhl98Rqs3G8ZptFIxrXB0q2ArcKCyIZySaXJT5vCvF47yQp8oKBtkZ/CG8lTZCVQb4Iex36NxyisZ0gTrTbyOtGETQjL9LMurMVAzRmMix4k5iZbD0tqOE4k2WK4/bfZgj4i2wCuqPJG9HdptABbFRY/0aw7N7YTu2wevPU2hd0aXMUN4/4CLfoyzTARx8DeZGVVCX8ZPpVJxfglqhVi3qELNaMynsWqNqKV5HGze3LVv0scydD2ks1lapXA6jQf9UDzHFTV/tBVqIAqki1+BubLbKKdyFwHf1rN8YsOqx9pSUVVjc0gQxRJE5lzqcRGxB1EwRlPGtU6GgJrmFNmYziR2u+w2Hj5acBqpxIvg89/q8puiHbedsxTrUwoZpwBWZv4SKrgXoLR9WQIsnMBfWysOAenvE6N38lfcvQ85oVipSd4ZmDI63ECK0lIvOjIkV/P+gjxg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MW4PR11MB5776.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(366004)(39860400002)(136003)(396003)(346002)(451199015)(9686003)(82960400001)(478600001)(33656002)(966005)(38070700005)(41300700001)(38100700002)(71200400001)(86362001)(316002)(110136005)(54906003)(19627235002)(55016003)(66556008)(66946007)(26005)(186003)(7696005)(66476007)(76116006)(4326008)(66446008)(64756008)(5660300002)(53546011)(107886003)(6506007)(2906002)(30864003)(83380400001)(8676002)(52536014)(8936002)(122000001)(579004);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?n/MTW0Y37MmIPmRCbSSIO5pvtcJpS3rw90gDIcUOnsgSKtY8gSafkUqhggr8?= =?us-ascii?Q?UQb7E7/nu7y8xo66RnNoeYxtIbYrwYpnpGfYuqKY82DKwUhxS5efjwjFHXwU?= =?us-ascii?Q?pHthNJ4weDAiTDVBa/89DfuykaCrIxjY1JbotiSoGnekfUkTdHBoqn/2FaYC?= =?us-ascii?Q?wIVQpvLRS789Bl74H/yM15d8ijS0EfJQfWmw45Q2X7GFBpJLk4RjJEyJNV95?= =?us-ascii?Q?7S3Xan0UtEWElY9YRkU3RWcBfcWvHyjiTaTZO1wXXFVu5aMXSFZiEfseffnY?= =?us-ascii?Q?nnfWOEzNFTg8KIsl6MSOK7J2U1jps2shn3Gri5o0C3DFdmsCgJ0WqMufBVSk?= =?us-ascii?Q?fl4++qnVWE0GYHYaVtpcEFzspRcft0niGUtSxPsfYv0mhZm1CsUjr18lWWjn?= =?us-ascii?Q?PtNiPFQeQXEpMVibMD5Sn90ufpP1BEncMzL466uBgzkdSotIbXMxpjybONrI?= =?us-ascii?Q?rfDnPg7DxOzFK0j0+uKrUf3BVNvz4UtLhDvRPP3iVJhqyNORqz9eZpCKk1BR?= =?us-ascii?Q?BqeMlAFDGDrw3CMt93+y0v3uLPBDS59Y16m/qRttKT8dk2JOSFWRrlM3MMTR?= =?us-ascii?Q?TCOdLBQZjH2x4zz14+v9IHoUPurGdX8uT4EbL3E+rDkgg/LKjpVnId11kbdj?= =?us-ascii?Q?/LPWWBciD1ihUmC7BqAbEfjzw8eGgswM22jNgO+NjfxZAHjz6wu8m1qW1yUZ?= =?us-ascii?Q?KP9Gy6A53KJ3VWMbMe5LXPJpvyhEjGJf+0SK26ZjuZJ1lep7gKZdjP2BZayX?= =?us-ascii?Q?Izq6/gNBN6YmargEt7Vcuqljy8xAeES34xNc8iE4LNBifyyrKuR7bbnb03bL?= =?us-ascii?Q?TKLhLE8aNYpYrTlurOjsuvzH7k0qBrclow34oAgY2Ny0G0hYQJMuMARo66c3?= =?us-ascii?Q?g6tNT5EIxwOerHmLWeq817ujAH8CeYoyAMKujbkcCBbT1AbUw7iVMmKxSBxj?= =?us-ascii?Q?KQ07J4zscW10DZefZ9p413nOBcPNb+UrsGkQ4aXi2dbNxJOTh9DCqRqNfwv8?= =?us-ascii?Q?8LrVYeIcsvKZYYKn5wOrqgazERwC3udRzZAcpRnAjmzIr12IthD++GoMDmsA?= =?us-ascii?Q?aPwz6tOxtkbbgSsgEjzUR8ZFQFUTr6y1Ksc2xKRApBLuGKqkWc7FdiHwtuwZ?= =?us-ascii?Q?LrZRaxR8MjjcUnAsxBOqoBGvKNts9OSKf/MuuzIB48b+Kxhlk634fkvWUsOI?= =?us-ascii?Q?hLpcVDzWzaFER/cLZvZ987Z9ExYvurgof/TALVhhUuXRzF6jvM8ueCPhv+0k?= =?us-ascii?Q?YGFyVj19fWkJKkDSajGrIkdqle0BXyTnSnmlU02yo6l9FW+7jgGe+RhcSGEX?= =?us-ascii?Q?ARa3Z8iGh3+SPFmjPEz2mjm1puiLCWmFTj6hQ/7cYz8Run0wIdPfk6AIRIaU?= =?us-ascii?Q?Z+zi16jayeIAYYEcyI5FcmgPCzN80joljpTBFGKPDXsI2Rv0Ybhous2UA/9e?= =?us-ascii?Q?RL8HK5eKLb/DTfOSmLeJ8CLrIrNYpAD5eJJH9jvWRiZqaqnR2ULflbbrtII0?= =?us-ascii?Q?0OvGbKp5NOcIMljxQJUwMSD8ygQQ7z92FHefTN/4LDn9tsGdxKqvCjiltSBo?= =?us-ascii?Q?cSJUmDrMl0TMDddAhpF/1tTgrmsPtVDKYIZaACdX7kyjPwNrcj0sJo/MaiEp?= =?us-ascii?Q?QQ=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20fb4585-5d9e-457c-8794-08daf420a3e1 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2023 22:10:25.1787 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: TL2tcf5qlLRsp3PLEsszAGOD8A2tw6YNcI9WddUAXeq7qqEqcsw2apD3ypGF0xsU8y8NMx5TiPfYB3tG5r52qzwI2opg5w52+l4TEiOWUK8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5217 Return-Path: rangasai.v.chaganty@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Sai Chaganty -----Original Message----- From: Oram, Isaac W =20 Sent: Monday, January 09, 2023 4:05 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Chaganty, Rangasai V ; Desimone, Nathaniel L ; Gao, Liming ; Dong, Eric ; Bi, Dandan Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] Features/Intel: Prepare= for edk2-platforms CI Fix some build issues with GCC5 targets Add a Readme.md for AdvancedFeaturePkg Add VS2019, CLANGPDB, and GCC5 build targets to Readme.md for each feature Cc: Sai Chaganty Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Cc: Dandan Bi Signed-off-by: Isaac Oram --- .../AdvancedFeaturePkg/AdvancedFeaturePkg.dsc | 6 ++- Features/Intel/AdvancedFeaturePkg/Readme.md | 38 +++++++++++++++++++ .../AcpiDebugFeaturePkg.dsc | 3 ++ .../Debugging/AcpiDebugFeaturePkg/Readme.md | 9 ++--- .../Debugging/BeepDebugFeaturePkg/Readme.md | 6 +++ .../PostCodeDebugFeaturePkg/Readme.md | 5 ++- .../Debugging/Usb3DebugFeaturePkg/Readme.md | 9 ++--- .../Intel/Network/NetworkFeaturePkg/Readme.md | 9 ++--- .../AsfFeaturePkg/Readme.md | 5 ++- .../GenericIpmi/Common/IpmiHooks.c | 2 + .../GenericIpmi/Common/IpmiHooks.h | 2 + .../GenericIpmi/Dxe/GenericIpmi.c | 2 +- .../Library/IpmiBaseLib/IpmiBaseLib.c | 2 +- .../IpmiFeaturePkg/Readme.md | 9 ++--- .../SpcrFeaturePkg/Readme.md | 5 ++- .../Library/PcdInitLib/PcdInitLib.c | 2 +- .../PowerManagement/S3FeaturePkg/Readme.md | 9 ++--- .../SmbiosFeaturePkg/Readme.md | 9 ++--- Features/Intel/TemplateFeaturePkg/Readme.md | 9 ++++- .../UserInterface/LogoFeaturePkg/Readme.md | 6 ++- .../UserAuthFeaturePkg/Readme.md | 9 ++--- .../VirtualKeyboardFeaturePkg/Readme.md | 5 ++- .../VirtualKeyboardFeaturePkg.dsc | 4 ++ 23 files changed, 119 insertions(+), 46 deletions(-) create mode 100644 F= eatures/Intel/AdvancedFeaturePkg/Readme.md diff --git a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc b/Fea= tures/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc index 18929589c5..226d41522d 100644 --- a/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc +++ b/Features/Intel/AdvancedFeaturePkg/AdvancedFeaturePkg.dsc @@ -25,7 +25,7 @@ DSC_SPECIFICATION =3D 0x00010005 OUTPUT_DIRECTORY =3D Build/AdvancedFeaturePkg SUPPORTED_ARCHITECTURES =3D IA32|X64 - BUILD_TARGETS =3D DEBUG|RELEASE + BUILD_TARGETS =3D DEBUG|RELEASE|NOOPT SKUID_IDENTIFIER =3D DEFAULT PEI_ARCH =3D IA32 DXE_ARCH =3D X64 @@ -95,6 +95,10 @@ [PcdsFixedAtBuild] gUsb3DebugFeaturePkgTokenSpaceGuid.PcdUsb3DebugPortLibInstance|1 =20 +[PcdsDynamicExDefault.X64] + gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow + gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow + # # MinPlatform common include for required feature PCD # These PCD must be= set before the core include files, CoreCommonLib, diff --git a/Features/In= tel/AdvancedFeaturePkg/Readme.md b/Features/Intel/AdvancedFeaturePkg/Readme= .md new file mode 100644 index 0000000000..ba50560328 --- /dev/null +++ b/Features/Intel/AdvancedFeaturePkg/Readme.md @@ -0,0 +1,38 @@ +# Overview +Build all advanced features for testing build and integration. + +Please refer to individual feature packages for details on intended uses. + +# High-Level Theory of Operation +Enable all features and build a reasonable default configuration. This is= not expected to produce binaries that are directly usable in a product as = features may require board or silicon specific configuration and libraries. + +## Firmware Volumes +Produces: +* FvAdvancedPreMemory +* FvAdvancedUncompressed +* FvAdvanced + +## Build +Supported build targets +* VS2019 +* CLANGPDB +* GCC5 + +## Windows Example: +With current working directory at O:\ + +git clone https://github.com/tianocore/edk2.git + +git clone https://github.com/tianocore/edk2-platforms.git + +set workspace=3DO:\ + +set EDK_TOOLS_PATH=3DO:\Edk2\BaseTools + +set=20 +packages_path=3DO:\edk2;O:\edk2-non-osi;O:\edk2-platforms\Platform\Intel; +O:\edk2-platforms\Silicon\Intel;O:\edk2-platforms\Platform\Qemu;O:\edk2 +-platforms\Silicon\Qemu;O:\edk2-platforms\Features\Intel;O:\edk2-platfo +rms\Features\Intel\Debugging;O:\edk2-platforms\Features\Intel\Network;O +:\edk2-platforms\Features\Intel\OutOfBandManagement;O:\edk2-platforms\F +eatures\Intel\PowerManagement;O:\edk2-platforms\Features\Intel\SystemIn +formation;O:\edk2-platforms\Features\Intel\UserInterface + +cd \edk2 + +edksetup.bat Rebuild + +build -a IA32 -a X64 -t CLANGPDB -b NOOPT -p=20 +AdvancedFeaturePkg\AdvancedFeaturePkg.dsc diff --git a/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeatureP= kg.dsc b/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.d= sc index 306d8bce16..ffe8c427ff 100644 --- a/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.dsc +++ b/Features/Intel/Debugging/AcpiDebugFeaturePkg/AcpiDebugFeaturePkg.d +++ sc @@ -34,6 +34,9 @@ # !include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc =20 +[PcdsFeatureFlag.X64] + gAcpiDebugFeaturePkgTokenSpaceGuid.PcdUseSmmVersion = |FALSE + # # Include common libraries # diff --git a/Features/Intel/Debugging/AcpiDebugFeaturePkg/Readme.md b/Featu= res/Intel/Debugging/AcpiDebugFeaturePkg/Readme.md index 9868d6d816..b6cb054efa 100644 --- a/Features/Intel/Debugging/AcpiDebugFeaturePkg/Readme.md +++ b/Features/Intel/Debugging/AcpiDebugFeaturePkg/Readme.md @@ -91,11 +91,10 @@ Architecturally defined data structures and flows for t= he feature. Key control flows for the feature. =20 ## Build Flows -*_TODO_* -Any special build flows should be described in this section. - -This is particularly useful for features that use custom build tools or re= quire non-standard tool configuration. If the -standard flow in the feature= package template is used, this section may be empty. +Supported build targets +* VS2019 +* CLANGPDB +* GCC5 =20 ## Test Point Results *_TODO_* diff --git a/Features/Intel/Debugging/BeepDebugFeaturePkg/Readme.md b/Featu= res/Intel/Debugging/BeepDebugFeaturePkg/Readme.md index 6626c9b764..143699dbb3 100644 --- a/Features/Intel/Debugging/BeepDebugFeaturePkg/Readme.md +++ b/Features/Intel/Debugging/BeepDebugFeaturePkg/Readme.md @@ -120,11 +120,17 @@ Status Code (ReportStatusCode) -> Beep Value (GetBeep= ValueFromStatusCode). ReportStatusCode () -> BeepStatusCodeReportWorker () -> GetBeepValueFromSt= atusCode () -> Beep () =20 ## Build Flows +Supported build targets +* VS2019 +* CLANGPDB +* GCC5 + Standalone build * build -a IA32 -a X64 -p Debugging\BeepDebugFeaturePkg\BeepDebugFeaturePk= g.dsc =20 AdvanceFeaturePkg build * build -a IA32 -a X64 -p AdvancedFeaturePkg/AdvancedFeaturePkg.dsc + ## Test Point Results None =20 diff --git a/Features/Intel/Debugging/PostCodeDebugFeaturePkg/Readme.md b/F= eatures/Intel/Debugging/PostCodeDebugFeaturePkg/Readme.md index 3fc52f1c00..d0d8d36fd7 100644 --- a/Features/Intel/Debugging/PostCodeDebugFeaturePkg/Readme.md +++ b/Features/Intel/Debugging/PostCodeDebugFeaturePkg/Readme.md @@ -111,7 +111,10 @@ Status Code (ReportStatusCode) -> Post Code (GetPostCo= deFromStatusCode). ReportStatusCode () -> PostCodeStatusCodeReportWorker () -> GetPostCodeFro= mStatusCode () -> PostCode () =20 ## Build Flows -There are not special build flows. +Supported build targets +* VS2019 +* CLANGPDB +* GCC5 =20 ## Test Point Results There are no test points defined. diff --git a/Features/Intel/Debugging/Usb3DebugFeaturePkg/Readme.md b/Featu= res/Intel/Debugging/Usb3DebugFeaturePkg/Readme.md index c8afcf9fd2..740bfb6db0 100644 --- a/Features/Intel/Debugging/Usb3DebugFeaturePkg/Readme.md +++ b/Features/Intel/Debugging/Usb3DebugFeaturePkg/Readme.md @@ -72,11 +72,10 @@ Architecturally defined data structures and flows for t= he feature. Key control flows for the feature. =20 ## Build Flows -*_TODO_* -Any special build flows should be described in this section. - -This is particularly useful for features that use custom build tools or re= quire non-standard tool configuration. If the -standard flow in the feature= package template is used, this section may be empty. +Supported build targets +* VS2019 +* CLANGPDB +* GCC5 =20 ## Test Point Results No test points implemented diff --git a/Features/Intel/Network/NetworkFeaturePkg/Readme.md b/Features/= Intel/Network/NetworkFeaturePkg/Readme.md index af59fc427a..e953bbcbda 100644 --- a/Features/Intel/Network/NetworkFeaturePkg/Readme.md +++ b/Features/Intel/Network/NetworkFeaturePkg/Readme.md @@ -69,11 +69,10 @@ Architecturally defined data structures and flows for t= he feature. Key control flows for the feature. =20 ## Build Flows -*_TODO_* -Any special build flows should be described in this section. - -This is particularly useful for features that use custom build tools or re= quire non-standard tool configuration. If the -standard flow in the feature= package template is used, this section may be empty. +Supported build targets +* VS2019 +* CLANGPDB +* GCC5 =20 ## Test Point Results *_TODO_* diff --git a/Features/Intel/OutOfBandManagement/AsfFeaturePkg/Readme.md b/F= eatures/Intel/OutOfBandManagement/AsfFeaturePkg/Readme.md index f18b1bfb07..35f5fc202d 100644 --- a/Features/Intel/OutOfBandManagement/AsfFeaturePkg/Readme.md +++ b/Features/Intel/OutOfBandManagement/AsfFeaturePkg/Readme.md @@ -44,7 +44,10 @@ AsfPushEvent() -> through SmBus -> NIC -> Remote managem= ent consoles N/A now. =20 ## Build Flows -There is not special build flow. +Supported build targets +* VS2019 +* CLANGPDB +* GCC5 =20 ## Test Point Results There are not test points implemented. diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Common/IpmiHooks.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Gene= ricIpmi/Common/IpmiHooks.c index 86ff7c0fdf..b2788e5a4c 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Common/= IpmiHooks.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Comm +++ on/IpmiHooks.c @@ -9,6 +9,7 @@ #include "IpmiHooks.h" =20 EFI_STATUS +EFIAPI IpmiSendCommand ( IN IPMI_TRANSPORT *This, IN UINT8 NetFunction, @@ -64,6 +65,7 @@ Returns: } // IpmiSendCommand() =20 EFI_STATUS +EFIAPI IpmiGetBmcStatus ( IN IPMI_TRANSPORT *This, OUT BMC_STATUS *BmcStatus, diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Common/IpmiHooks.h b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Gene= ricIpmi/Common/IpmiHooks.h index 083c9e70b0..823cc08c61 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Common/= IpmiHooks.h +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Comm +++ on/IpmiHooks.h @@ -15,6 +15,7 @@ // Internal(hook) function list // EFI_STATUS +EFIAPI IpmiSendCommand ( IN IPMI_TRANSPORT *This, IN UINT8 NetFunction, @@ -54,6 +55,7 @@ Returns: ; =20 EFI_STATUS +EFIAPI IpmiGetBmcStatus ( IN IPMI_TRANSPORT *This, OUT BMC_STATUS *BmcStatus, diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/= Dxe/GenericIpmi.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Gener= icIpmi/Dxe/GenericIpmi.c index 957a9c8e6e..d973db3680 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/Gen= ericIpmi.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/GenericIpmi/Dxe/ +++ GenericIpmi.c @@ -28,6 +28,7 @@ @retval EFI_UNSUPPORTED IPMI is not available. **/ EFI_STATUS +EFIAPI LocateIpmiInterface ( IN EFI_HANDLE ImageHandle, IN EFI_SYSTEM_TABLE *SystemTable @@ -43,4 +44,3 @@ LocateIpmiInterface ( =20 return Status; } // LocateIpmiInterface() - diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/Ipmi= BaseLib/IpmiBaseLib.c b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/L= ibrary/IpmiBaseLib/IpmiBaseLib.c index 6b2e0a9e1e..5df9d861c6 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBaseLib= /IpmiBaseLib.c +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Library/IpmiBase +++ Lib/IpmiBaseLib.c @@ -132,6 +132,7 @@ IpmiSubmitCommand ( =20 **/ EFI_STATUS +EFIAPI IpmiGetBmcStatus ( OUT BMC_STATUS *BmcStatus, OUT SM_COM_ADDRESS *ComAddress @@ -152,4 +153,3 @@ IpmiGetBmcStatus ( ); return Status; } - diff --git a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Readme.md b/= Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Readme.md index d383150e3f..7551fcc64f 100644 --- a/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Readme.md +++ b/Features/Intel/OutOfBandManagement/IpmiFeaturePkg/Readme.md @@ -58,11 +58,10 @@ Architecturally defined data structures and flows for t= he feature. Key control flows for the feature. =20 ## Build Flows -*_TODO_* -Any special build flows should be described in this section. - -This is particularly useful for features that use custom build tools or re= quire non-standard tool configuration. If the -standard flow in the feature= package template is used, this section may be empty. +Supported build targets +* VS2019 +* CLANGPDB +* GCC5 =20 ## Test Point Results *_TODO_* diff --git a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Readme.md b/= Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Readme.md index 66138ee0f6..173fb3e491 100644 --- a/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Readme.md +++ b/Features/Intel/OutOfBandManagement/SpcrFeaturePkg/Readme.md @@ -46,7 +46,10 @@ GetSpcrDevice() -> serial port device path -> get PCI in= fo and serial port info GetSpcrDevice () in SpcrDeviceLib -> SpcrAcpiDxe. =20 ## Build Flows -There is not special build flow. +Supported build targets +* VS2019 +* CLANGPDB +* GCC5 =20 ## Test Point Results There are not test points implemented. diff --git a/Features/Intel/PlatformPayloadFeaturePkg/Library/PcdInitLib/Pc= dInitLib.c b/Features/Intel/PlatformPayloadFeaturePkg/Library/PcdInitLib/Pc= dInitLib.c index 4ea89582f3..e3d305d01f 100644 --- a/Features/Intel/PlatformPayloadFeaturePkg/Library/PcdInitLib/PcdInitLi= b.c +++ b/Features/Intel/PlatformPayloadFeaturePkg/Library/PcdInitLib/PcdIni +++ tLib.c @@ -21,6 +21,7 @@ =20 **/ EFI_STATUS +EFIAPI PcdInitConstructor ( VOID ) @@ -86,4 +87,3 @@ PcdInitConstructor ( =20 return EFI_SUCCESS; } - diff --git a/Features/Intel/PowerManagement/S3FeaturePkg/Readme.md b/Featur= es/Intel/PowerManagement/S3FeaturePkg/Readme.md index 95ce2ddc15..8f96d29ce1 100644 --- a/Features/Intel/PowerManagement/S3FeaturePkg/Readme.md +++ b/Features/Intel/PowerManagement/S3FeaturePkg/Readme.md @@ -63,11 +63,10 @@ Architecturally defined data structures and flows for t= he feature. Key control flows for the feature. =20 ## Build Flows -*_TODO_* -Any special build flows should be described in this section. - -This is particularly useful for features that use custom build tools or re= quire non-standard tool configuration. If the -standard flow in the feature= package template is used, this section may be empty. +Supported build targets +* VS2019 +* CLANGPDB +* GCC5 =20 ## Test Point Results *_TODO_* diff --git a/Features/Intel/SystemInformation/SmbiosFeaturePkg/Readme.md b/= Features/Intel/SystemInformation/SmbiosFeaturePkg/Readme.md index 6ecca8af4b..46d1744414 100644 --- a/Features/Intel/SystemInformation/SmbiosFeaturePkg/Readme.md +++ b/Features/Intel/SystemInformation/SmbiosFeaturePkg/Readme.md @@ -65,11 +65,10 @@ Architecturally defined data structures and flows for t= he feature. Key control flows for the feature. =20 ## Build Flows -*_TODO_* -Any special build flows should be described in this section. - -This is particularly useful for features that use custom build tools or re= quire non-standard tool configuration. If the -standard flow in the feature= package template is used, this section may be empty. +Supported build targets +* VS2019 +* CLANGPDB +* GCC5 =20 ## Test Point Results *_TODO_* diff --git a/Features/Intel/TemplateFeaturePkg/Readme.md b/Features/Intel/T= emplateFeaturePkg/Readme.md index fc77340684..a777eccc29 100644 --- a/Features/Intel/TemplateFeaturePkg/Readme.md +++ b/Features/Intel/TemplateFeaturePkg/Readme.md @@ -45,11 +45,18 @@ Architecturally defined data structures and flows for t= he feature. Key control flows for the feature. =20 ## Build Flows -Any special build flows should be described in this section. +Standard and special build flows should be described in this section. =20 This is particularly useful for features that use custom build tools or re= quire non-standard tool configuration. If the standard flow in the feature= package template is used, this section may be empty. =20 +Example: + +Supported build targets +* VS2019 +* CLANGPDB +* GCC5 + ## Test Point Results The test(s) that can verify porting is complete for the feature. =20 diff --git a/Features/Intel/UserInterface/LogoFeaturePkg/Readme.md b/Featur= es/Intel/UserInterface/LogoFeaturePkg/Readme.md index bf1a61ba95..33f2ffe410 100644 --- a/Features/Intel/UserInterface/LogoFeaturePkg/Readme.md +++ b/Features/Intel/UserInterface/LogoFeaturePkg/Readme.md @@ -78,8 +78,10 @@ Architecturally defined data structures and flows for th= e feature. Consumer gets image from the logo driver via EDKII_PLATFORM_LOGO_PROTOCOL. =20 ## Build Flows - -No any special build flows is needed. +Supported build targets +* VS2019 +* CLANGPDB +* GCC5 =20 ## Test Point Results =20 diff --git a/Features/Intel/UserInterface/UserAuthFeaturePkg/Readme.md b/Fe= atures/Intel/UserInterface/UserAuthFeaturePkg/Readme.md index b236d2ad30..a5c1d3cb96 100644 --- a/Features/Intel/UserInterface/UserAuthFeaturePkg/Readme.md +++ b/Features/Intel/UserInterface/UserAuthFeaturePkg/Readme.md @@ -59,11 +59,10 @@ Architecturally defined data structures and flows for t= he feature. Key control flows for the feature. =20 ## Build Flows -*_TODO_* -Any special build flows should be described in this section. - -This is particularly useful for features that use custom build tools or re= quire non-standard tool configuration. If the -standard flow in the feature= package template is used, this section may be empty. +Supported build targets +* VS2019 +* CLANGPDB +* GCC5 =20 ## Test Point Results *_TODO_* diff --git a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Readme.= md b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Readme.md index ae7f778748..5e750cd923 100644 --- a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Readme.md +++ b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Readme.md @@ -43,7 +43,10 @@ User touch the touch panel -> absolute pointer and statu= s -> virtual keyboard ev This driver use AbsolutePointer protocol to get t= he info of user input, and use GraphicsOutput protocol to show the picture. =20 ## Build Flows -There is not special build flow. +Supported build targets +* VS2019 +* CLANGPDB +* GCC5 =20 ## Test Point Results Test this driver in a device with touch panel and the BIOS support touch p= anel driver. diff --git a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/Virtual= KeyboardFeaturePkg.dsc b/Features/Intel/UserInterface/VirtualKeyboardFeatur= ePkg/VirtualKeyboardFeaturePkg.dsc index d13bd673d3..a025cc755d 100644 --- a/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyboar= dFeaturePkg.dsc +++ b/Features/Intel/UserInterface/VirtualKeyboardFeaturePkg/VirtualKeyb +++ oardFeaturePkg.dsc @@ -34,6 +34,10 @@ # !include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc =20 +[PcdsDynamicExDefault.X64] + gEfiMdeModulePkgTokenSpaceGuid.PcdConOutRow + gEfiMdeModulePkgTokenSpaceGuid.PcdSetupConOutRow + # # Include common libraries # -- 2.39.0.windows.1